Re: Context regression tests (issue 348760043 by nine.fierce.ball...@gmail.com)

On 2018/05/07 23:07:36, Dan Eble wrote: On 2018/05/07 22:53:29, Dan Eble wrote: > stop relying on duplicating type+ID Carl, I hope that these revisions address your concerns about the tests per se. After reviewing the revised tests, I am in favor of moving back to your original patch,

Re: logging an optional input location

On May 12, 2018, at 16:17, Carl Sorensen wrote: > > Does our code base use the optional second parameter anywhere? If not, maybe > it would be even simpler to eliminate the optional second parameter, and just > call > > warning (_f (. . .), origin); > > and keep all

Re: logging an optional input location

On 5/12/18, 1:49 PM, "lilypond-devel on behalf of Dan Eble" wrote: There’s this repetition in context.cc: if (origin) { origin->warning (_f ("cannot find or create `%s' called

logging an optional input location

There’s this repetition in context.cc: if (origin) { origin->warning (_f ("cannot find or create `%s' called `%s'", ly_symbol2string (n).c_str (), id)); } else { warning (_f ("cannot find or create `%s' called `%s'",

Re: [testlilyissues:issues] Moderation action required

I don't think we should update a release last issued 5 years ago - so no 2.18.3. It also seems that a security problem with no reported problems actually happening in 5 years can be so serious to warrant rushing out a new release? The problem is known, it is published how to exploit the

Re: [testlilyissues:issues] Moderation action required

- Original Message - From: "David Kastrup" To: "Knut Petersen" Cc: "dondelelcaro" ; "lilypond-devel" Sent: Saturday, May 12, 2018 11:27 AM Subject: Re: [testlilyissues:issues]

Re[2]: [testlilyissues:issues] Moderation action required

David Kastrup wrote 12/05/2018 11:27:40 James, they try to fix lilypond 2.18, not 2.20 or master. 2.18 is still insecure. At this point of time we probably really need to decide to release 2.20, come hell and high water, including its current faults. Or pitch out 2.18.3. At the very

Re: [testlilyissues:issues] Moderation action required

Knut Petersen writes: > Am 12.05.2018 um 09:16 schrieb James Lowe: >> Dev team, >> >> Don tacked a patch on the end of an already-fixed issue. > > James, they try to fix lilypond 2.18, not 2.20 or master. > > 2.18 is still insecure. At this point of time we probably

Re: [testlilyissues:issues] Moderation action required

Am 12.05.2018 um 09:16 schrieb James Lowe: Dev team, Don tacked a patch on the end of an already-fixed issue. James, they try to fix lilypond 2.18, not 2.20 or master. 2.18 is still insecure. Knut ___ lilypond-devel mailing list

Re: [testlilyissues:issues] Moderation action required

Don, On Sat, 12 May 2018 09:24:17 +0200, David Kastrup wrote: > "James Lowe" writes: > > > Dev team, > > > > Don tacked a patch on the end of an already-fixed issue. > > > > https://sourceforge.net/p/testlilyissues/issues/5243 > > > > I assume this needs a

Re: [testlilyissues:issues] Moderation action required

"James Lowe" writes: > Dev team, > > Don tacked a patch on the end of an already-fixed issue. > > https://sourceforge.net/p/testlilyissues/issues/5243 > > I assume this needs a new issue? Basically yes, and definitely with an explanation of why the committed fix is not

Re: [testlilyissues:issues] Moderation action required

Dev team, Don tacked a patch on the end of an already-fixed issue. https://sourceforge.net/p/testlilyissues/issues/5243 I assume this needs a new issue? Let me know. James On Fri, 11 May 2018 16:52:11 -, "Don Armstrong" wrote: > The following