Re: Charles Winston's chord-semantics GSOC work (issue 568650043 by carl.d.soren...@gmail.com)

2019-04-02 Thread Carl Sorensen
On 4/2/19, 3:20 PM, "v.villen...@gmail.com" wrote: Hi Carl, I appreciate you taking the time to rework this patch, does it mean you’re intending to shepherd Charles’ work until it gets merged? Yes. In addition to Paul’s comments which you’ve nicely addressed, I had a few

Re: gs version error in latest GUB build

2019-04-02 Thread Valentin Villenave
On 4/2/19, Federico Bruni wrote: > As far as I can see from my installations, gs distributed in > lilypond.org recent installers is version 9.26. Nope: $ wget http://lilypond.org/download/binaries/linux-64/lilypond-2.19.83-1.linux-64.sh $ sh lilypond-2.19.83-1.linux-64.sh --tarball $ tar -tjvf

Charles Winston's chord-semantics GSOC work (issue 568650043 by carl.d.soren...@gmail.com)

2019-04-02 Thread v . villenave
Hi Carl, I appreciate you taking the time to rework this patch, does it mean you’re intending to shepherd Charles’ work until it gets merged? In addition to Paul’s comments which you’ve nicely addressed, I had a few additional ones below, on other aspects of Charles’ approach (and taking into acco

PATCHES - Countdown for April 2nd

2019-04-02 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on April 5th.. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5502 NR: Add many function index entries. - Werner LEMBERG

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2019-04-02 Thread Carl . D . Sorensen
Thanks for figuring this out. I'm now working on make check, and will post a new patch shortly (I hope). The new patch is up at https://codereview.appspot.com/568650043 https://codereview.appspot.com/337870043/ ___ lilypond-devel mailing list

Re: Documentation: no \layout in markup-nested scores (issue 548590043 by v.villen...@gmail.com)

2019-04-02 Thread tdanielsmusic
LGTM Trevor https://codereview.appspot.com/548590043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2019-04-02 Thread Paul Morris
Hi Carl, On 4/2/19 12:14 AM, carl.d.soren...@gmail.com wrote: https://codereview.appspot.com/337870043/diff/40001/input/regression/chord-name-exceptions.ly#newcode29 input/regression/chord-name-exceptions.ly:29: chExceptions = #(append (chordmode->exception-entry chordVar markupVar) chExcepti

Re: gs version error in latest GUB build

2019-04-02 Thread Federico Bruni
Il giorno dom 31 mar 2019 alle 17:22, Valentin Villenave ha scritto: On 3/31/19, Valentin Villenave wrote: I couldn’t reproduce (but then again I’m not running Ubuntu). I also find it odd that only some scores are reported to fail while other’s aren’t. OK, as I suspected *all* score