Re: Data structure for (package) options

On Mon, Jan 27, 2020 at 11:39 PM Urs Liska wrote: > > I didn't have time to really think about much (about LilyPond) the past > week, just enjoyed seeing so much constructive discussion. > [..] I haven't read your messages in detail, but I'd like to throw out one thought to consider: we use GUILE

Re: automated formatting

On Tue, Jan 28, 2020 at 12:18 AM David Kastrup wrote: > > David Kastrup writes: > > > Han-Wen Nienhuys writes: > > > >> On Mon, Jan 27, 2020 at 11:49 AM David Kastrup wrote: > >>> > I want to propose to move to automated formatting for our C++ code. > >>> > > >>> > I put up a .clang-format code

Re: Data structure for (package) options

Am Dienstag, den 28.01.2020, 09:26 +0100 schrieb Han-Wen Nienhuys: > On Mon, Jan 27, 2020 at 11:39 PM Urs Liska > wrote: > > I didn't have time to really think about much (about LilyPond) the > > past > > week, just enjoyed seeing so much constructive discussion. > > [..] > > I haven't read your

Re: Data structure for (package) options

Urs Liska writes: > Am Dienstag, den 28.01.2020, 00:34 +0100 schrieb David Kastrup: >> Urs Liska writes: >> >> So basically there is long-term potential for efficiency to mostly >> become a non-issue. > > I'm sorry, but I don't fully understand what you are trying to tell me > here. Are you say

Re: Looking for help in configuring LilyDev in VirtualBox

Il giorno gio 23 gen 2020 alle 22:11, Federico Bruni ha scritto: I will let you know when v2 is released. Now released:

Re: Data structure for (package) options

Han-Wen Nienhuys writes: > On Mon, Jan 27, 2020 at 11:39 PM Urs Liska wrote: >> >> I didn't have time to really think about much (about LilyPond) the past >> week, just enjoyed seeing so much constructive discussion. >> [..] > > I haven't read your messages in detail, but I'd like to throw out o

Re: Data structure for (package) options

Am 28. Januar 2020 14:48:54 MEZ schrieb David Kastrup : >Han-Wen Nienhuys writes: > >> On Mon, Jan 27, 2020 at 11:39 PM Urs Liska >wrote: >>> >>> I didn't have time to really think about much (about LilyPond) the >past >>> week, just enjoyed seeing so much constructive discussion. >>> [..] >>

Re: Looking for help in configuring LilyDev in VirtualBox

Tuesday, January 28, 2020, 1:38:45 PM, Federico Bruni wrote: > Il giorno gio 23 gen 2020 alle 22:11, Federico Bruni > ha scritto: >> I will let you know when v2 is released. > Now released: > Grazie molto Best regards, Peter

Re: automated formatting

On 1/28/20, 1:50 AM, "lilypond-devel on behalf of Han-Wen Nienhuys" wrote: On Tue, Jan 28, 2020 at 12:18 AM David Kastrup wrote: > > David Kastrup writes: > > > Han-Wen Nienhuys writes: > > > >> On Mon, Jan 27, 2020 at 11:49 AM David Kastrup wrote: > >>> >

Re: Disable C++ exceptions (issue 571430048 by jonas.hahnf...@gmail.com)

Reviewers: lemzwerg, Dan Eble, Message: On 2020/01/27 21:05:27, Dan Eble wrote: > > 1) Drop exception handling around scm_boot_guile > > Doing this at the end of main() is pointless. > > Agreed. (It should have been caught by reference anyway.) > > > 2) Disable exception handling code > > We do

Re: automated formatting

On Jan 28, 2020, at 12:11, Carl Sorensen wrote: >Can you provide me with a presubmit hook that applies fixcc? Can you >guarantee that, if fixcc has run on the code, there will be no further >remarks on code formatting during review? > > I think that it's a really good idea to have pre

Re: automated formatting

Dan Eble writes: > On Jan 28, 2020, at 12:11, Carl Sorensen wrote: >>Can you provide me with a presubmit hook that applies fixcc? Can you >>guarantee that, if fixcc has run on the code, there will be no further >>remarks on code formatting during review? >> >> I think that it's a re

Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by hanw...@gmail.com)

https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh File lily/include/parse-scm.hh (right): https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh#newcode30 lily/include/parse-scm.hh:30: SCM parse_embedded_scheme (Input *i, bool safe, Lily

Re: Disable C++ exceptions (issue 571430048 by jonas.hahnf...@gmail.com)

LGTM I don't think there is any chance of ever using exceptions in LilyPond, because we can't mix them with the GUILE call stack. https://codereview.appspot.com/571430048/

Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by hanw...@gmail.com)

https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh File lily/include/parse-scm.hh (right): https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh#newcode30 lily/include/parse-scm.hh:30: SCM parse_embedded_scheme (Input *i, bool safe, Lily

Re: session macros

On Mon, Jan 27, 2020 at 11:33 AM David Kastrup wrote: > > > > When calling the macro twice, we'll define add-session-variable twice, > > which seems fishy. > > I think you got confused here. A macro is just an ordinary function on > its inside, it only differs in its calling conventions during >

Re: session macros

Han-Wen Nienhuys writes: > On Mon, Jan 27, 2020 at 11:33 AM David Kastrup wrote: >> > >> > When calling the macro twice, we'll define add-session-variable twice, >> > which seems fishy. >> >> I think you got confused here. A macro is just an ordinary function on >> its inside, it only differs i

Re: session macros

Han-Wen Nienhuys writes: > On Mon, Jan 27, 2020 at 11:33 AM David Kastrup wrote: >> > >> > When calling the macro twice, we'll define add-session-variable twice, >> > which seems fishy. >> >> I think you got confused here. A macro is just an ordinary function on >> its inside, it only differs i

Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by hanw...@gmail.com)

On 2020/01/28 22:06:33, hanwenn wrote: > > In general, pointers are preferred in function signatures, so you can see that > the value is mutated in the call site. See also > https://google.github.io/styleguide/cppguide.html#Reference_Arguments OK, they're preferred by one or more people at Google.

Doc: Correct and extend infos about LilyDev setup (issue 561360043 by michael.kaepp...@googlemail.com)

Reviewers: , Message: This patch reflects some changes and small fixed that I contributed to LilyDev and which are now in the new release v2. https://github.com/fedelibre/LilyDev/releases Description: Doc: Correct and extend infos about LilyDev setup * Adjust filenames, setup description etc. t

Re: Doc: Correct and extend infos about LilyDev setup (issue 561360043 by michael.kaepp...@googlemail.com)

Good work. Needs some revision. https://codereview.appspot.com/561360043/diff/547520043/Documentation/contributor/quick-start.itexi File Documentation/contributor/quick-start.itexi (right): https://codereview.appspot.com/561360043/diff/547520043/Documentation/contributor/quick-start.itexi#newco

Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by nine.fierce.ball...@gmail.com)

Reviewers: , Description: https://sourceforge.net/p/testlilyissues/issues/5707/ These tests are failing in master @ 2ccac23c0e9f7528e55dfd8d711420b4bc5d7a43. I assume they have been failing for some time. 1: fix bug in display of \cueDuring and \quoteDuring I'm not at all certain that I've fixe

Re: Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by nine.fierce.ball...@gmail.com)

> 2: treat warnings as errors in display-lily-tests.ly > so that bugs will not be overlooked. I don't think I tested this part properly. I'll come back to it. https://codereview.appspot.com/563430046/

Re: Disable C++ exceptions (issue 571430048 by jonas.hahnf...@gmail.com)

> On 28 Jan 2020, at 23:28, hanw...@gmail.com wrote: > > I don't think there is any chance of ever using exceptions in LilyPond, > because we can't mix them with the GUILE call stack. One can combine C++ and Guile exceptions, by converting back and forth between them. Even though GCC admits th

Re: Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by nine.fierce.ball...@gmail.com)

On 2020/01/29 00:06:14, Dan Eble wrote: Pretty sure that the trigger was commit ed86e71eb0f17e93036142938d8c490a3e2fcbea Author: Valentin Villenave Date: Mon Feb 25 17:24:11 2019 +0100 Use "simple strings" rather than #"hash-prefixed Scheme strings" Now that the user-exposed synt

Re: Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by nine.fierce.ball...@gmail.com)

On 2020/01/29 00:09:44, Dan Eble wrote: > > 2: treat warnings as errors in display-lily-tests.ly > > so that bugs will not be overlooked. > > I don't think I tested this part properly. I'll come back to it. It works. https://codereview.appspot.com/563430046/

Re: Announce end of multi-measure-rest (issue 561310045 by hanw...@gmail.com)

On 2020/01/24 18:40:56, hanwenn wrote: > That's for anoter change. I thought that I should do > https://codereview.appspot.com/553400043/ as a scheme engraver, but maybe it's > more something for OLL ? Whatever - I created https://sourceforge.net/p/testlilyissues/issues/5708/ so it isn't forgotten

Re: Announce end of multi-measure-rest (issue 561310045 by hanw...@gmail.com)

ping? https://codereview.appspot.com/561310045/

Re: Issue 5707: fix bug in display of \cueDuring and \quoteDuring (issue 563430046 by nine.fierce.ball...@gmail.com)

On 2020/01/29 03:08:48, Dan Eble wrote: > change the test, not the display function Oh, I am sorry to have been misleading with my comment: I think your original patch was the right thing to do. I just remarked that what display-lily printed would have also worked as input so this was not really

Re: Announce end of multi-measure-rest (issue 561310045 by hanw...@gmail.com)

Hello, On 29/01/2020 05:59, hanw...@gmail.com wrote: ping? https://codereview.appspot.com/561310045/ There's no need to do this really. That was kind of the point of the countdown method we have. The devs get (essentially) 5 - 7 days to see 2 emails for all issues that need looking at. Whi

PATCHES - Countdown for January 29th

Hello, Here is the current patch countdown list. The next countdown will be on January 31st A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5695 reduce dynamic casting - Dan Eble https://sourceforge.ne

Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by hanw...@gmail.com)

On 2020/01/28 23:38:24, Dan Eble wrote: > On 2020/01/28 22:06:33, hanwenn wrote: > > > > In general, pointers are preferred in function signatures, so you can see that > > the value is mutated in the call site. See also > > https://google.github.io/styleguide/cppguide.html#Reference_Arguments > >

Re: Add a tentative .clang-format for LilyPond. (issue 561340043 by hanw...@gmail.com)

Reviewers: lemzwerg, Message: On 2020/01/27 10:07:20, lemzwerg wrote: > For which clang-format version is this format file? It doesn't work with 7.0.1, > for example. Please add this information to the file. $ clang-format --version clang-format version 9.0.0 (Fedora 9.0.0-1.fc31) can you pinp

Re: Doc: Correct and extend infos about LilyDev setup (issue 561360043 by michael.kaepp...@googlemail.com)

Some more nits. Thanks for working on this! https://codereview.appspot.com/561360043/diff/547520043/Documentation/contributor/quick-start.itexi File Documentation/contributor/quick-start.itexi (right): https://codereview.appspot.com/561360043/diff/547520043/Documentation/contributor/quick-start

Re: Add a tentative .clang-format for LilyPond. (issue 561340043 by hanw...@gmail.com)

> just the overrides The new version works just fine. Shall I still inspect the previous version for problematic statements? The output looks good. BTW, for the sake of Emacs, it would be nice if two spaces after a full dot could be retained in comments. Does such an option exist? https://cod