Re: Drop support for multiple configurations (issue 581630043 by jonas.hahnf...@gmail.com)

2020-02-13 Thread jonas . hahnfeld
Reviewers: lemzwerg, carl.d.sorensen_gmail.com, hanwenn, Message: On 2020/02/12 20:45:31, hanwenn wrote: > https://codereview.appspot.com/581630043/diff/563520043/Documentation/included/compile.itexi > File Documentation/included/compile.itexi (left): > > https://codereview.appspot.com/581630043/

Re: Parse inline scheme using per-expression port (issue 557330043 by hanw...@gmail.com)

2020-02-13 Thread lemzwerg--- via Discussions on LilyPond development
minor nit https://codereview.appspot.com/557330043/diff/565660043/lily/include/overlay-string-port.hh File lily/include/overlay-string-port.hh (right): https://codereview.appspot.com/557330043/diff/565660043/lily/include/overlay-string-port.hh#newcode4 lily/include/overlay-string-port.hh:4: Copy

Issues with 'LANG='

2020-02-13 Thread Werner LEMBERG
It seems that the recent version of 'gettext' (0.21 from Dec. 2019) on MacOS – at least on my Lion box – has changed language handling. In the NEWS file I read * Runtime behaviour: - The interpretation of the language preferences on macOS has been improved, especially in the case whe

bugs.lilypond.org from France

2020-02-13 Thread Han-Wen Nienhuys
We have a DNS entry for bugs.lilypond.org that resolves to 91.224.149.60 It serves a 500 page from a Debian machine. According to https://www.iplocation.net/, this is a machine in the south of France. I think we can delete this, but does anyone know what this refers to? -- Han-Wen Nienhuys - h

Re: bugs.lilypond.org from France

2020-02-13 Thread Jonas Hahnfeld via Discussions on LilyPond development
Am Donnerstag, den 13.02.2020, 10:53 +0100 schrieb Han-Wen Nienhuys: > We have a DNS entry for bugs.lilypond.org that resolves to 91.224.149.60 That IP reverse-resolves to chapters.tetaneutral.net, its web page is http://tetaneutral.net/. In case that rings a bell for someone. Jonas > It serves

German translation

2020-02-13 Thread Lukas-Fabian Moser
Folks, [tl;dr: Whom should I contact for improvement suggestions for the German PO file?] The German PO file contains some translations that seem to suffer from the "false friend"-syndrome, for instance #: convertrules.py:549 msgid "point-and-click argument changed to procedure." msgstr "po

Re: German translation

2020-02-13 Thread Federico Bruni
Il giorno gio 13 feb 2020 alle 11:11, Lukas-Fabian Moser ha scritto: What's the right place to send such suggestions to? If there's going to be a new stable release soon, maybe it would be nice to get some of the more amusing translation gaffes fixed in time. LilyPond has a dedicated mailing

Re: bugs.lilypond.org from France

2020-02-13 Thread Thomas Morley
Am Do., 13. Feb. 2020 um 11:07 Uhr schrieb Jonas Hahnfeld via Discussions on LilyPond development : > > Am Donnerstag, den 13.02.2020, 10:53 +0100 schrieb Han-Wen Nienhuys: > > We have a DNS entry for bugs.lilypond.org that resolves to 91.224.149.60 > > That IP reverse-resolves to chapters.tetaneut

Re: bugs.lilypond.org from France

2020-02-13 Thread Han-Wen Nienhuys
I found a conversation about self-hosted allura mentioning bugs.lilypond.org I'll remove the record. On Thu, Feb 13, 2020 at 11:32 AM Thomas Morley wrote: > Am Do., 13. Feb. 2020 um 11:07 Uhr schrieb Jonas Hahnfeld via > Discussions on LilyPond development : > > > > Am Donnerstag, den 13.02.20

Re: Parse inline scheme using per-expression port (issue 557330043 by hanw...@gmail.com)

2020-02-13 Thread jonas . hahnfeld
https://codereview.appspot.com/557330043/diff/579310044/configure.ac File configure.ac (left): https://codereview.appspot.com/557330043/diff/579310044/configure.ac#oldcode42 configure.ac:42: GUILEv2=no Is this meant to be part of this patch? I'm all in for requiring / defaulting to Guile 2.2 onc

Re: Only print out open type font substitution if there was a change (issue 577390043 by hanw...@gmail.com)

2020-02-13 Thread hanwenn
commit af11dc2109631c3bd2912cee438b60d2799f1a53 Author: Han-Wen Nienhuys Date: Thu Jan 23 22:41:14 2020 +0100 Issue 5682: only print out open type font substitution if there was a change This makes debug output less unwieldy. https://codereview.appspot.com/577390043/

Re: Announce end of multi-measure-rest (issue 561310045 by hanw...@gmail.com)

2020-02-13 Thread hanwenn
commit 1a75cad4c7e79c3630ca9d393152c61786eebd36 Author: Han-Wen Nienhuys Date: Fri Jan 24 17:32:44 2020 +0100 Announce end of multi-measure-rest This will allow certain user-defined engravers to do useful things https://codereview.appspot.com/561310045/

Re: allow overriding of GUILE_AUTO_COMPILE (issue 579270043 by hanw...@gmail.com)

2020-02-13 Thread hanwenn
commit d7509a50fea49609511962a3f2e061a1e2ed819c Author: Han-Wen Nienhuys Date: Wed Jan 29 17:19:27 2020 +0100 Issue 5717: allow overriding of GUILE_AUTO_COMPILE https://codereview.appspot.com/579270043/

Re: lily: fix some type conversion warnings (issue 557190043 by hanw...@gmail.com)

2020-02-13 Thread hanwenn
commit 4d93339b06f97dcec176a47d9db0fc169acccef6 Author: Han-Wen Nienhuys Date: Fri Jan 17 23:42:28 2020 +0100 lily: fix some type conversion warnings https://codereview.appspot.com/557190043/

Re: GUILE2: softcode GC environment tuning (issue 563500045 by hanw...@gmail.com)

2020-02-13 Thread hanwenn
Reviewers: hahnjo, Message: commit 4078b52f67e6e5193e72648a8f1a44e8154636e7 Author: Han-Wen Nienhuys Date: Sat Feb 8 21:04:28 2020 +0100 GUILE2: softcode GC environment tuning Disable multithreaded GC and explain why https://sourceforge.net/p/testlilyissues/issues/5718

Re: Grow heap aggressively during music interpretation (issue 561390043 by hanw...@gmail.com)

2020-02-13 Thread hanwenn
commit a19aed147bf1605b21cbe7b1909ff6cbf519fb64 Author: Han-Wen Nienhuys Date: Sat Feb 8 21:02:12 2020 +0100 GUILE2: Scale GC heap with the number of smobs https://codereview.appspot.com/561390043/

Re: In verbose mode, dump time spent on parsing lily.scm and friends. (issue 573420043 by hanw...@gmail.com)

2020-02-13 Thread hanwenn
commit dc10f1ad59adbc4122416f3fe09a25020a6ff355 Author: Han-Wen Nienhuys Date: Sat Feb 8 09:12:50 2020 +0100 In verbose mode, dump time spent on parsing lily.scm and friends. https://sourceforge.net/p/testlilyissues/issues/5679 http://codereview.appspot.com/573420043 https:/

Re: German translation

2020-02-13 Thread Jürgen Reuter
Hi all, at university, we actually *did* use the term "Fluchtsymbol" as translation for "escape character". Using the English term "escape" in German language is just a (common but unnecessary) anglicism. (But in a text book for one of the courses at university, there also was

Re: Clean up embedded scheme parsing/evaluation. (issue 577410045 by hanw...@gmail.com)

2020-02-13 Thread hanwenn
commit 5a4039b700f3a7447401780c720070d14e2891bd Author: Han-Wen Nienhuys Date: Fri Jan 31 08:24:44 2020 +0100 Clean up embedded scheme parsing/evaluation. Renames and reorders functions to clarify the mechanism. No consequential functional changes. Separates input and

Remove unused ly_hash_scm (issue 569340043 by hanw...@gmail.com)

2020-02-13 Thread dak
Issue title is wrong. Function is ly_scm_hash, not ly_hash_scm. Also its prototype in lily/include/lily-guile.hh should get removed. https://codereview.appspot.com/569340043/

Add a RAII wrapper for extracting FT_Face from PangoFcFont (issue 549560043 by hanw...@gmail.com)

2020-02-13 Thread jonas . hahnfeld
LGTM https://codereview.appspot.com/549560043/

Re: Parse inline scheme using per-expression port (issue 557330043 by hanw...@gmail.com)

2020-02-13 Thread hanwenn
https://codereview.appspot.com/557330043/diff/579310044/configure.ac File configure.ac (left): https://codereview.appspot.com/557330043/diff/579310044/configure.ac#oldcode42 configure.ac:42: GUILEv2=no On 2020/02/13 11:02:59, hahnjo wrote: > Is this meant to be part of this patch? I'm all in for

Re: Make Pango >= 1.36 mandatory. (issue 565660044 by hanw...@gmail.com)

2020-02-13 Thread jonas . hahnfeld
LGTM, thanks for getting rid of the old code! https://codereview.appspot.com/565660044/

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-13 Thread hanwenn
looks OK. Is there a way to exercise this? Maybe with #{ c4'' #} or something? https://codereview.appspot.com/557410043/

Re: Parse inline scheme using per-expression port (issue 557330043 by hanw...@gmail.com)

2020-02-13 Thread jonas . hahnfeld
On 2020/02/13 13:34:59, hanwenn wrote: > [...] > > https://codereview.appspot.com/557330043/diff/579310044/lily/include/overlay-string-port.hh > File lily/include/overlay-string-port.hh (right): > > https://codereview.appspot.com/557330043/diff/579310044/lily/include/overlay-string-port.hh#newcod

lilypond.org now serving HTTPS

2020-02-13 Thread Han-Wen Nienhuys
FYI, lilypond.org is now serving on HTTPS See here https://codereview.appspot.com/559470043/ for background. -- Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-13 Thread dak
On 2020/02/13 13:37:52, hanwenn wrote: > looks OK. > > Is there a way to exercise this? Maybe with #{ c4'' #} or something? Just { c4'' } would do it, but regtesting error messages is pretty icky. Warnings are more straightforward, but I really want an error. https://codereview.appspot.com/5574

Re: Make Pango >= 1.36 mandatory. (issue 565660044 by hanw...@gmail.com)

2020-02-13 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/565660044/

Re: Add a RAII wrapper for extracting FT_Face from PangoFcFont (issue 549560043 by hanw...@gmail.com)

2020-02-13 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/549560043/

Re: Update web infrastructure (issue 559470043 by hanw...@gmail.com)

2020-02-13 Thread lemzwerg--- via Discussions on LilyPond development
LGTM, thanks! https://codereview.appspot.com/559470043/

Re: lilypond.org now serving HTTPS

2020-02-13 Thread Jean-Charles Malahieude
Le 13/02/2020 à 15:10, Han-Wen Nienhuys a écrit : FYI, lilypond.org is now serving on HTTPS See here https://codereview.appspot.com/559470043/ for background. This should be applied on stable/2.20 as well. Cheers, -- Jean-Charles

Testing with docker images available

2020-02-13 Thread Han-Wen Nienhuys
See https://github.com/hanwen/lilypond-ci. Example: $ sh test-git.sh rietveld 557410043 .. (5 minutes later) $ tail test-results/rietveld/557410043/90a4346b/index.txt 100.00 input/regression/accidental-cautionary.log 100.00 input/regression/accidental-broken-tie-spac

Re: RFC: docker for CI

2020-02-13 Thread Han-Wen Nienhuys
On Sat, Feb 8, 2020 at 11:31 PM Janek Warchoł wrote: > In principle, thumbs up. However, I think it's essential that we don't try > to do too much at once; I'd suggest to focus on one most important aspect > first. To do that, I'd like to ask a helper question: what are 2 most > important reasons

PATCHES - Countdown for February 14th

2020-02-13 Thread pkx166h
Hello, Here is the current patch countdown list. The next countdown will be on February 16th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5748 engraver: continue when trying to create non-existe