https://codereview.appspot.com/547980044/diff/548010043/lily/skyline.cc
File lily/skyline.cc (right):
https://codereview.appspot.com/547980044/diff/548010043/lily/skyline.cc#newcode348
lily/skyline.cc:348: result.push_back (buildings->at (0));
at() involves a boundary check that is not necessary
On 2020/04/21 00:43:02, dak wrote:
> On 2020/04/20 23:26:07, Dan Eble wrote:
> > On 2020/04/20 19:36:39, dak wrote:
> > > Polish and extend tools in callback.hh
> >
> > LGTM.
> >
> > I have a hunch that the MFPn_WRAP macros could be turned into
something more
> > typical of C++, but I don't blame
On 2020/04/20 23:26:07, Dan Eble wrote:
> On 2020/04/20 19:36:39, dak wrote:
> > Polish and extend tools in callback.hh
>
> LGTM.
>
> I have a hunch that the MFPn_WRAP macros could be turned into
something more
> typical of C++, but I don't blame you for resting at this point.
Not without a lot
On 2020/04/20 19:36:39, dak wrote:
> Polish and extend tools in callback.hh
LGTM.
I have a hunch that the MFPn_WRAP macros could be turned into something
more typical of C++, but I don't blame you for resting at this point.
https://codereview.appspot.com/551780043/
> It loads its languages from langdefs.py, and therefore outputs the
> following unhelpful warning:
>
> langdefs.py: warning: lilypond-doc gettext domain not found.
>
> I understand 'therefore' as 'expectedly' here.
Well, yes, but it's still annoying. Since I don't see any reason to
have thi
Am Montag, den 20.04.2020, 19:10 +0200 schrieb Francisco Vila:
> El 19/4/20 a las 17:12, Jonas Hahnfeld escribió:
> > IIRC langdefs.py complains that we set LANG=C
> > in the build process.
>
> Contributor manual says in website-build:
>
> %
>
> create-weblinks-itexi.py creates a loa
On 2020/04/20 09:09:22, fedelogy wrote:
> On 2020/04/19 15:04:38, hahnjo wrote:
> > As I'm not doing translations myself, it would be great if somebody
familiar
> > with the process could comment on the faith of
> > scripts/auxiliar/texi-skeleton-update.py: It's not failing, but to
me doesn't
> > l
El 19/4/20 a las 17:12, Jonas Hahnfeld escribió:
IIRC langdefs.py complains that we set LANG=C
in the build process.
Contributor manual says in website-build:
%
create-weblinks-itexi.py creates a load of texi macros (of the order of
1000) similar to:
(...)
It loads its lan
LGTM
https://codereview.appspot.com/555700043/
Reviewers: dak,
Message:
On 2020/04/20 12:05:15, dak wrote:
>
https://codereview.appspot.com/573730044/diff/583810043/input/regression/font-name-add-files.ly
> File input/regression/font-name-add-files.ly (right):
>
>
https://codereview.appspot.com/573730044/diff/583810043/input/regression/font-n
https://codereview.appspot.com/573730044/diff/583810043/input/regression/font-name-add-files.ly
File input/regression/font-name-add-files.ly (right):
https://codereview.appspot.com/573730044/diff/583810043/input/regression/font-name-add-files.ly#newcode25
input/regression/font-name-add-files.ly:
On 4/19/20, David Kastrup wrote:
> However, there are a few
> other problems with that regtest that should likely show with Guile-2
> (sometimes?).
Could you elaborate as to what I need to watch out for? I’ve tested it
successfully with Guile 2.2 here (but history has teached us that
unforeseen s
On 2020/04/19 15:04:38, hahnjo wrote:
> As I'm not doing translations myself, it would be great if somebody
familiar
> with the process could comment on the faith of
> scripts/auxiliar/texi-skeleton-update.py: It's not failing, but to me
doesn't
> look like doing anything helpful either.
I remembe
LGTM, nice cleanup.
https://codereview.appspot.com/549920043/
https://codereview.appspot.com/549920043/diff/553940043/lily/include/lily-lexer.hh
File lily/include/lily-lexer.hh (right):
https://codereview.appspot.com/549920043/diff/553940043/lily/include/lily-lexer.hh#newcode23
lily/include/lily-lexer.hh:23: #include
On 2020/04/20 08:17:05, hahnjo wrote:
https://codereview.appspot.com/549920043/diff/553940043/lily/include/lily-lexer.hh
File lily/include/lily-lexer.hh (right):
https://codereview.appspot.com/549920043/diff/553940043/lily/include/lily-lexer.hh#newcode23
lily/include/lily-lexer.hh:23: #include
Please put C++ includes last. I know t
LGTM
https://codereview.appspot.com/549920043/
Am Sonntag, den 19.04.2020, 23:24 +0200 schrieb David Kastrup:
> Jonas Hahnfeld writes:
> > To avoid this from happening again, can we please have the rule that
> > whoever reverts a commit or backs it out of staging is to provide
> > guidance on what's actually wrong? My feeling is that we could
18 matches
Mail list logo
