LGTM
https://codereview.appspot.com/582010043/
Thank you for your reviewing.
https://codereview.appspot.com/577900043/diff/577910043/Documentation/usage/running.itely
File Documentation/usage/running.itely (right):
https://codereview.appspot.com/577900043/diff/577910043/Documentation/usage/running.itely#newcode652
On 21/04/2020 18:54, Jonas Hahnfeld wrote:
Okay, so let me try to briefly summarize the expressed opinions on the
list so far (correct me if I got something wrong or missed a point):
Han-Wen is in favor of Gerrit; David leans towards GitLab; Federico and
me are in favor of GitLab; Werner is fine
On Apr 23, 2020, at 16:24, Jonas Hahnfeld wrote:
>> I'd prefer file-names and thumbnails, unfolded by clicking.
>>
>> Is this behaviour adjustable?
>
> No, I'm merely linking the uploaded file (GitLab decides to display the
> image inline) and AFAICS there are no options to influence this
>
Il giorno lun 27 apr 2020 alle 22:36, Carl Sorensen
ha scritto:
git checkout $RELEASE_BRANCH
if [ 0 -eq $(git merge-base --is-ancestor $COMMIT_ID HEAD) ]; then
echo "true"; else echo "false"; fi
with $RELEASE_BRANCH being the name of the branch, and $COMMIT_ID
replaced with the commit id
Il giorno mar 28 apr 2020 alle 09:02, Jonas Hahnfeld
ha scritto:
Am Dienstag, den 28.04.2020, 00:27 +0200 schrieb Federico Bruni:
Il giorno mer 22 apr 2020 alle 14:28, Jonas Hahnfeld
ha scritto:
> here we go:
> https://gitlab.com/lilypond-issues/lilypond-trial
>
> To reiterate: This
Hi Jonas,
> Done (hopefully).
Thank you very much; it looks like it worked!
Kevin
Am Dienstag, den 28.04.2020, 18:31 +0100 schrieb Kevin Barry:
> Hi James,
>
> > We do have a process, see:
> > http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers
> >
>
> I have followed this as best I can, but it seems I need to have write
>
Please read my suggested changes carefully and amend, as I've no
knowledge of the subject matter.
https://codereview.appspot.com/577900043/diff/577910043/Documentation/usage/running.itely
File Documentation/usage/running.itely (right):
Hi James,
> We do have a process, see:
> http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers
I have followed this as best I can, but it seems I need to have write
access to the issue tracker before I can send patches. If that is the
case then can
Very nice, thanks!
There are some grammar glitches in the documentation – I hope that a
native English speaker can improve that.
https://codereview.appspot.com/577900043/diff/577910043/Documentation/usage/running.itely
File Documentation/usage/running.itely (right):
Am Dienstag, den 28.04.2020, 15:23 +0100 schrieb Phil Holmes:
> On my machine make website returns:
>
> Traceback (most recent call last):
> File "/media/IntelSSD/lilypond/lilypond-git/scripts/build/website_post.py",
> line 179, in
> lines = open(file).readlines()
> File
On my machine make website returns:
Traceback (most recent call last):
File "/media/IntelSSD/lilypond/lilypond-git/scripts/build/website_post.py",
line 179, in
lines = open(file).readlines()
File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input,
Hello Kevin,
On 27/04/2020 18:07, Kevin Barry wrote:
Hi James,
Thank you for responding.
On Mon, Apr 27, 2020 at 11:09:50AM +0100, James wrote:
Is this patch read for full testing or is it work-in-progress you just want
someone to comment on it?
It's not work in progress no - unless someone
d...@gnu.org writes:
> Interesting. In 2.18 it appears to be used as length-callback in
> TremoloRepeatedMusic. Was that wrong or did something change in
> unfolded_music_length ?
>
> https://codereview.appspot.com/561670043/
I need to focus on repo search techniques. Issue 3745, apparently.
Regarding the "Get rid of unused function ly:lexer-keywords": that one
was added with
commit 1ae6f5710e714f13da1bfbfbd840835316618d1f
Author: Han-Wen Nienhuys
Date: Thu Dec 14 14:10:56 2006 +0100
add ly:lexer-keywords to make keyword extraction easier and exact.
but there appears to be no
Interesting. In 2.18 it appears to be used as length-callback in
TremoloRepeatedMusic. Was that wrong or did something change in
unfolded_music_length ?
https://codereview.appspot.com/561670043/
Hello,
Here is the current patch countdown list. The next countdown will be on
April 30th
A quick synopsis of all patches currently in the review process can be
found here:
http://philholmes.net/lilypond/allura/
***
Push:
5930 Make dblatex an optional dependency - Jonas Hahnfeld
On 2020/04/28 07:20:26, hanwenn wrote:
> On 2020/04/28 06:49:58, hahnjo wrote:
> >
https://codereview.appspot.com/547980044/diff/572060043/lily/skyline.cc
> > File lily/skyline.cc (right):
> >
> >
>
https://codereview.appspot.com/547980044/diff/572060043/lily/skyline.cc#newcode175
> >
On 2020/04/28 06:49:58, hahnjo wrote:
>
https://codereview.appspot.com/547980044/diff/572060043/lily/skyline.cc
> File lily/skyline.cc (right):
>
>
https://codereview.appspot.com/547980044/diff/572060043/lily/skyline.cc#newcode175
> lily/skyline.cc:175: Building front_;
> On 2020/04/27 21:30:18,
https://codereview.appspot.com/547980044/diff/572060043/lily/skyline.cc
File lily/skyline.cc (right):
https://codereview.appspot.com/547980044/diff/572060043/lily/skyline.cc#newcode175
lily/skyline.cc:175: Building front_;
On 2020/04/27 21:30:18, hanwenn wrote:
> On 2020/04/27 07:01:28, hahnjo
Am Dienstag, den 28.04.2020, 00:27 +0200 schrieb Federico Bruni:
> Il giorno mer 22 apr 2020 alle 14:28, Jonas Hahnfeld ha
> scritto:
> > here we go:
> > https://gitlab.com/lilypond-issues/lilypond-trial
> >
> > To reiterate: This is _NOT_ meant for "production" work, just for
> > evaluation.
22 matches
Mail list logo
