Remove ly:lexer-keywords command (issue 559960060 by d...@gnu.org)

LGTM https://codereview.appspot.com/559960060/

Re: Start contributin and Error in startup script: couldn't connect to display ":0"

Hello! Em sex., 1 de mai. de 2020 às 17:35, Federico Bruni escreveu: > For me (on Fedora) these two requirements are enough (to launch gitk or > lily-git): > > https://github.com/fedelibre/LilyDev/tree/master/mkosi#running-graphical-applications-from-the-container I don't know. Arch normally

Re: Fix font-name-add-files.ly on GUILE v2 (issue 567500043 by hanw...@gmail.com)

commit 30c845d383bf2c85b75f2c2be735837e59a224d0 Author: Han-Wen Nienhuys Date: Sat Apr 25 10:49:40 2020 +0200 Fix font-name-add-files.ly on GUILE v2 https://codereview.appspot.com/567500043/

Re: make_draw_bezier_boxes: save work if thickness == 0.0 (issue 551730043 by hanw...@gmail.com)

commit fadb710df7ed135d7712ce50fcdfa83a89753213 Author: Han-Wen Nienhuys Date: Fri Apr 17 20:20:50 2020 +0200 make_draw_bezier_boxes: save work if thickness == 0.0 https://codereview.appspot.com/551730043/

Re: Minor cleanups in stencil-integral.cc (issue 579630043 by hanw...@gmail.com)

https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc#newcode465 lily/stencil-integral.cc:465: // more convoluted, but it's fairly hot path. On

Re: Use vectors rather than lists for skylines. (issue 583750043 by hanw...@gmail.com)

commit eaf40071f56ca2ca337dc7684c0da3f307f070bd Author: Han-Wen Nienhuys Date: Fri Apr 17 16:37:44 2020 +0200 Use vectors rather than lists for skylines. https://codereview.appspot.com/583750043/

Re: Add flag to NoteColumn using Axis_group_interface. (issue 555770044 by hanw...@gmail.com)

commit 0b45d764dcbc704713c8a32186561305e58d5659 Author: Han-Wen Nienhuys Date: Mon Apr 27 10:31:56 2020 +0200 Add flag to NoteColumn using Axis_group_interface. https://codereview.appspot.com/555770044/

Re: Transform: add print_smob to aid debugging (issue 561680043 by hanw...@gmail.com)

commit 0a63bd48a02ccdaf7253b1e8edb83a44a6573293 Author: Han-Wen Nienhuys Date: Sat Apr 25 13:09:24 2020 +0200 Transform: add print_smob to aid debugging https://codereview.appspot.com/561680043/

Re: Put system headers after lilypond headers throughout (issue 577840051 by hanw...@gmail.com)

commit b96b6334c00adb398b632aaeefdeaf3a8e6c57c5 Author: Han-Wen Nienhuys Date: Mon Apr 27 10:22:26 2020 +0200 Put system headers after lilypond headers throughou https://codereview.appspot.com/577840051/

Re: Copy alist instead of deep copy on Grob clone (issue 561640045 by hanw...@gmail.com)

commit a456a5946c21cb63c64640a758e7faf829d98fa2 Author: Han-Wen Nienhuys Date: Mon Apr 13 20:57:51 2020 +0200 Copy alist instead of deep copy on Grob clone https://codereview.appspot.com/561640045/

Re: Use Interval for representing skyline X coordinates (issue 571980043 by hanw...@gmail.com)

commit c5b720596fc967baac29cfc4b674b76927377135 Author: Han-Wen Nienhuys Date: Thu Apr 16 22:03:26 2020 +0200 Use Interval for representing skyline X coordinates https://codereview.appspot.com/571980043/

Re: midi: convert data to bigendian encoding directly (issue 565920043 by hanw...@gmail.com)

commit f51b4dbe635670cc08789daa0d9670f60fa47423 Author: Han-Wen Nienhuys Date: Fri Apr 17 14:23:58 2020 +0200 midi: convert data to bigendian encoding directly https://codereview.appspot.com/565920043/

Re: output-distance: create PNG files in batch (issue 567530052 by hanw...@gmail.com)

Reviewers: hahnjo, https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-distance.py#newcode739 scripts/build/output-distance.py:739: '

Re: Convert stencil to skyline directly (issue 555760043 by hanw...@gmail.com)

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode684 lily/stencil-integral.cc:684: if (false) On 2020/05/02 14:50:06, hahnjo wrote: >

(*location*) returning no valid value while parsing embedded scheme on freebsd

I assume this is os specific because the issue makes openlilylib unusable and my understanding was that most of the oll developers were living on the 2.21 branch already before the release and should have run into the problem as well. Right now my understanding is that the separation of input and

output-distance: create PNG files in batch (issue 567530052 by hanw...@gmail.com)

https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/567530052/diff/549980043/scripts/build/output-distance.py#newcode739 scripts/build/output-distance.py:739: ' -sDEVICE=png16m'

Re: Convert stencil to skyline directly (issue 555760043 by hanw...@gmail.com)

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode684 lily/stencil-integral.cc:684: if (false) this looks odd

Sequential_iterator start-up issue

RFC on Case 3 below. Thanks. — Dan \version "2.20.0" upper = f''1 lower = e'1 %% CASE 1: When the music in each simultaneous element begins with a %% note, the upper staff is created first. \score { << \upper \lower >> } %% CASE 2: When there are sets preceding the notes in both

New Japanese PO file for 'lilypond' (version 2.21.1)

Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Japanese team of translators. The file is available at: https://translationproject.org/latest/lilypond/ja.po (We can arrange things so

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

LGTM https://codereview.appspot.com/548030043/diff/548050047/lily/general-scheme.cc File lily/general-scheme.cc (right): https://codereview.appspot.com/548030043/diff/548050047/lily/general-scheme.cc#newcode777 lily/general-scheme.cc:777: for (char *a : passed_args) I'll try to clean this up a

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

https://codereview.appspot.com/548030043/diff/548050047/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/548030043/diff/548050047/lily/main.cc#newcode345 lily/main.cc:345: printf ("%s", (_ ("linked against Ghostscript:").c_str ())); excellent, thanks for bearing with us.

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

On 2020/05/02 10:48:20, hahnjo wrote: > add license information $ lilypond -w GNU LilyPond 2.21.2 Copyright (c) 1996--2020 by Han-Wen Nienhuys Jan Nieuwenhuizen and others. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

I will close this rietveld issue now that you are taking care of it. Whatever discussion needs to take place can happen at the one you have opened. On Sat, May 02, 2020 at 11:54:14AM +0200, Han-Wen Nienhuys wrote: > See http://codereview.appspot.com/545970043 > > note: > 1) Depending on the

Compute SVG skyline based on original data (issue 545970043 by hanw...@gmail.com)

Reviewers: , Message: goes on top of https://codereview.appspot.com/555760043/ Description: Compute SVG skyline based on original data Since stencil data is used as input to formatting decisions, this will make SVG output more similar to PS/PDF output. Please review this at

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

https://codereview.appspot.com/548030043/diff/559960055/lily/general-scheme.cc File lily/general-scheme.cc (right): https://codereview.appspot.com/548030043/diff/559960055/lily/general-scheme.cc#newcode778 lily/general-scheme.cc:778: free (a); On 2020/05/02 10:15:40, hanwenn wrote: > the code

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

On 2020/05/02 10:12:45, hanwenn wrote: > On Sat, May 2, 2020 at 12:09 PM wrote: > > > > This version of LilyPond has been compiled and linked with a version > > > of Ghostscript licensed under the AGPL. > > > > Please re-read point 2 above. Old Ghostscript

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

https://codereview.appspot.com/548030043/diff/559960055/lily/general-scheme.cc File lily/general-scheme.cc (right): https://codereview.appspot.com/548030043/diff/559960055/lily/general-scheme.cc#newcode778 lily/general-scheme.cc:778: free (a); the code mixes setting up the GS instance (memory

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

On Sat, May 2, 2020 at 12:09 PM wrote: > > This version of LilyPond has been compiled and linked with a version > > of Ghostscript licensed under the AGPL. > > Please re-read point 2 above. Old Ghostscript versions are not AGPL and > other implementations may not be either. it's easy to

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

On 2020/05/02 10:04:14, dak wrote: > On 2020/05/02 09:49:44, hahnjo wrote: > > On 2020/05/01 06:28:56, hanwenn wrote: > > > I suggest we make this an option that you have enable explicitly. > > > > done > > > > > If it is enabled, we'd have to change the --license output to say AGPL as > > well.

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

On 2020/05/02 09:49:44, hahnjo wrote: > On 2020/05/01 06:28:56, hanwenn wrote: > > I suggest we make this an option that you have enable explicitly. > > done > > > If it is enabled, we'd have to change the --license output to say AGPL as > well. > > I thought about this and decided against it:

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

See http://codereview.appspot.com/545970043 note: 1) Depending on the renderer, the skylines diverge from the text. Inkscape reproduces exactly, but EOG messes up the text formatting. 2) The lack of regression testing is worrying. We could have a section of regtests that is powered by inkscape

Re: Use GhostScript API instead of forking (issue 548030043 by jonas.hahnf...@gmail.com)

On 2020/05/01 06:28:56, hanwenn wrote: > I suggest we make this an option that you have enable explicitly. done > If it is enabled, we'd have to change the --license output to say AGPL as well. I thought about this and decided against it: 1. LilyPond stays under GPL, even if the whole may be

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

Let me see what I can come up with today On Sat, May 2, 2020 at 10:53 AM Kevin Barry wrote: > > On Sat, May 02, 2020 at 09:59:18AM +0200, Han-Wen Nienhuys wrote: > > Not necessarily, but the refactoring means I'll likely have to > > overwrite the fix wholesale. Because there is no regtest, it

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

On Sat, May 02, 2020 at 09:59:18AM +0200, Han-Wen Nienhuys wrote: > Not necessarily, but the refactoring means I'll likely have to > overwrite the fix wholesale. Because there is no regtest, it willl > depend on my diligence anyway to fix this again. OK, so what should we do? I am happy to take

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

On Sat, May 02, 2020 at 01:16:30AM -0700, beauleetien...@gmail.com wrote: > On 2020/05/02 07:38:58, hanwenn wrote: > > I don't completely understand, though: if we put the "utf-8-string" > directly > > into the SVG output, the SVG browser might make other font choices, > making the > > outline

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

On 2020/05/02 07:38:58, hanwenn wrote: > I don't completely understand, though: if we put the "utf-8-string" directly > into the SVG output, the SVG browser might make other font choices, making the > outline potentially incorrect. Is this a problem in practice? There isn't really an "outline"

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

Not necessarily, but the refactoring means I'll likely have to overwrite the fix wholesale. Because there is no regtest, it willl depend on my diligence anyway to fix this again. On Sat, May 2, 2020 at 9:46 AM wrote: > > On 2020/05/02 07:25:16, hanwenn wrote: > > please don't submit; I'm

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

On 2020/05/02 07:25:16, hanwenn wrote: > please don't submit; I'm rearranging this file completely. Do you really need to hold this up after it went through the full cycle? If it fixes a problem now and doesn't regress somewhere else, I think we should take it now.

Re: Remove if/else for shift/raise (issue 573770043 by hanw...@gmail.com)

LGTM (provided there are no regtest differences) https://codereview.appspot.com/573770043/

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

On 2020/05/02 07:37:31, hanwenn wrote: > On 2020/05/02 07:34:29, barrykp wrote: > > On Sat, May 02, 2020 at 12:25:15AM -0700, mailto:hanw...@gmail.com wrote: > > > please don't submit; I'm rearranging this file completely. > > > > > > Can you add your regression test + instructions on how to

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

On 2020/05/02 07:34:29, barrykp wrote: > On Sat, May 02, 2020 at 12:25:15AM -0700, mailto:hanw...@gmail.com wrote: > > please don't submit; I'm rearranging this file completely. > > > > Can you add your regression test + instructions on how to reproduce the > > problem? > > I did add a

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

On Sat, May 02, 2020 at 12:25:15AM -0700, hanw...@gmail.com wrote: > please don't submit; I'm rearranging this file completely. > > Can you add your regression test + instructions on how to reproduce the > problem? I did add a regression test in the first patch set, but it breaks testing. It

Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

please don't submit; I'm rearranging this file completely. Can you add your regression test + instructions on how to reproduce the problem? https://codereview.appspot.com/582010043/