Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by nine.fierce.ball...@gmail.com)

2015-09-05 Thread Keith OHara
On Sat, 05 Sep 2015 17:49:44 -0700, wrote: I have simply removed the comments warning about filtering ordered arrays. That seems to be correct. Those comments were incorrect. The filter_map* functions do not, in fact, change the order of the array under the meaning of 'ordered_'. Pál's com

Re: Doc: Issue 4059: Document MIDI mapping and MIDI effects (issue 249980043 by tdanielsmu...@googlemail.com)

2015-07-06 Thread Keith OHara
On Mon, 06 Jul 2015 15:19:20 -0700, wrote: Setting midiChannelMapping to 'voice often prevents the context properties from having effect." Doesn't the paragraph under 'voice above explain explicitly what happens? That seems better than the rather vague "often prevents the context properties

Re: Avoid treating x as relative in \relative { \autochange {x} } (issue 250170043 by nine.fierce.ball...@gmail.com)

2015-07-04 Thread Keith OHara
On Sat, 04 Jul 2015 05:45:04 -0700, wrote: Nobody knew \autochange was broken until Thomas found an unused variable, so these test are useful if \autochange is useful. Well, \autochange could have been useful, even to users of \relative if they used their \relative inside the \autochange.

Re: Make music functions callable from Scheme (issue 244840043 by d...@gnu.org)

2015-06-21 Thread Keith OHara
On Sat, 20 Jun 2015 22:28:13 -0700, David Kastrup wrote: "Keith OHara" writes: Some people don't like side-effects in loop-control conditionals while (scm_is_pair (scm_cdr (signature)) // more slots ? && scm_is_pair (scm_cadr (signature

Re: Make music functions callable from Scheme (issue 244840043 by d...@gnu.org)

2015-06-20 Thread Keith OHara
On Mon, 08 Jun 2015 18:04:44 -0700, wrote: No dice. The main problem is dealing with all combinations of running out of signature and running out of available arguments. If you treat the optional argument skipping in an inner loop, you may still run out of signature, and in that case you stil

Re: simple-spacer: inappropriate assert; issue 4448 (issue 249820043 by k-ohara5...@oco.net)

2015-06-20 Thread Keith OHara
On Fri, 19 Jun 2015 23:59:11 -0700, wrote: https://codereview.appspot.com/249820043/diff/1/lily/simple-spacer.cc File lily/simple-spacer.cc (right): https://codereview.appspot.com/249820043/diff/1/lily/simple-spacer.cc#newcode199 lily/simple-spacer.cc:199: programming_error ("misuse of expand

Re: balloon-text: robust with empty stencils; issue 4447 (issue 243610043 by k-ohara5...@oco.net)

2015-06-20 Thread Keith OHara
On Fri, 19 Jun 2015 23:50:50 -0700, wrote: https://codereview.appspot.com/243610043/diff/1/lily/balloon.cc#newcode94 lily/balloon.cc:94: b.widen (padding, padding); Basically we have two options here: not draw a box at all (it would be my guess that this is probably what happened previously wh

Re: Make music functions callable from Scheme (issue 244840043 by d...@gnu.org)

2015-06-08 Thread Keith OHara
On Sun, 07 Jun 2015 23:09:31 -0700, wrote: So your problem appears to be that you understand the code but it does something you did not expect. Cross-check from the user end with the "Extending LilyPond" guide's explanation of optional arguments. It is Extending section 2.2.2. Yuck. A comm

Re: add stencil-whiteout-outline function (issue 236480043 by paulwmor...@gmail.com)

2015-06-01 Thread Keith OHara
On Mon, 01 Jun 2015 19:29:41 -0700, wrote: scripts/auxiliar/update-with-convert-ly.sh I get this: make: *** No rule to make target `python-modules'. Stop. xargs: ./out/bin/convert-ly: No such file or directory xargs: ./out/bin/convert-ly: No such file or directory I'm running LilyDev3 in a v

Re: git-cl upload has stopped working (so has patchy)

2015-05-31 Thread Keith OHara
Trevor Daniels treda.co.uk> writes: > The next step is to decide our preference: do we want to take on the > commitment to maintain Allura ourselves or use the maintained version at > SourceForge. Which would we prefer? (FWIW my preference would be > to run Allura at Savannah as our primary DB,

Re: add stencil-whiteout-outline function (issue 236480043 by paulwmor...@gmail.com)

2015-05-31 Thread Keith OHara
On Sun, 31 May 2015 05:03:05 -0700, Simon Albrecht wrote: (A convert-ly rule may be needed… maybe in any case to change whiteout to whiteout-box? ...or maybe not?) Looking at the existing uses of \whiteout Xxx.whiteout, it does seem best to leave the plain box whiteout in existing scores. Co

Re: Master fails to compile

2015-05-28 Thread Keith OHara
On Thu, 28 May 2015 01:36:54 -0700, David Kastrup wrote: "Keith OHara" writes: I had an old RedHat installation with gcc updated as far as I could to 4.6. In the next few weeks I'll find some reasonably-modern linux. Well, using no longer supported systems with network a

Re: Master fails to compile

2015-05-27 Thread Keith OHara
On Mon, 25 May 2015 23:10:17 -0700, David Kastrup wrote: Keith OHara writes: If I can't get the dependencies worked out I'll be tempted to skip the macro and use scm_call_1() through scm_call_3() in place of each of the three macro expansions. Why? Seriously. 10.04 is not even

Re: Master fails to compile

2015-05-25 Thread Keith OHara
Phil Holmes philholmes.net> writes: > > I've managed to work out how to upgrade Ubuntu 10.04 to gcc 4.8.1 > with the help of StackOverflow, and can now compile again. I'm still working on sorting out dependencies. The troublesome macro asks is used in only three places, creating in each place

Re: PDF is broken for notation{} encoding

2015-05-25 Thread Keith OHara
Phil Holmes philholmes.net> writes: > >> > whenever we use notation{text}, then there is a paragraph break before > >> > the "text". It took a while to figure out the guilty commit, but it is > >> > 9f3c7711bb73baf3aea8502227fb5fd2d2851753: "update texinfo.tex from > >> > upstream". > >> > I

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5a5a oco.net)

2015-05-24 Thread Keith OHara
Wols Lists youngman.org.uk> writes: > On 23/05/15 23:39, Keith OHara wrote: > > googlemail.com> writes: > >> > I'd prefer the syntax and options to parallel those of > >> > \relative. That is, an optional prefix pitch to indicate > >> >

Re: pure/impure?!?!

2015-05-24 Thread Keith OHara
On Sun, 24 May 2015 01:55:30 -0700, David Kastrup wrote: Anyway: how do impure functions reference (and trigger?) line breaks? Non-'pure' functions reference line-breaks very indirectly. Spanners are broken into two or more grobs at line-breaking, so their functions work on the split Grobs

Re: pure/impure?!?!

2015-05-23 Thread Keith OHara
David Kastrup gnu.org> writes: > Ignored or not: those are values indicating breakpoints of the current > system. They should not even be available for functions evaluated > before any line-breaking. Or maybe they are called for one of a set of > tentative not-final line breaks, but in that cas

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5a5a oco.net)

2015-05-23 Thread Keith OHara
Wols Lists youngman.org.uk> writes: > On 21/05/15 07:36, k-ohara5a5a oco.net wrote: > > I'm proposing to push a \fixed c' {} that always takes a reference > > pitch, as in the current patch. > So the behaviour is different from \relative, which doesn't have to > have a reference pitch. Befo

Re: Add French-specific note names (issue 239930043 byv.villenave gmail.com)

2015-05-19 Thread Keith OHara
Trevor Daniels treda.co.uk> writes: > >> BTW dear lilylist: where do you have the 'ñ' on your keyboards? > > > We don't have it anywhere on the English keyboard. > You might have more than you think, or can easily get more. The US-International layout has the accented characters of English, in

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

2015-05-17 Thread Keith OHara
On Sun, 17 May 2015 04:58:22 -0700, wrote: The proper name for this would \absoluteWithFixedOctaveOffset, but that's too long and the acronym is similarly uninspiring. All three of the proposed options appear in this name, so the question is, "Which alludes most memorably to the actual functio

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

2015-05-10 Thread Keith OHara
On Sun, 10 May 2015 00:25:18 -0700, wrote: On 2015/05/09 23:58:22, Keith wrote: It is a bit of an inconvenience that \relative skips over \transpose, and I suspect \relative has this feature so that we do not get rising octaves in \relative c \transpose c c' {c c c c} We could change th

Re: Make \shiftOff an assertive \override, not a \revert (issue 190500043 by k-ohara5...@oco.net)

2015-05-10 Thread Keith OHara
On Sun, 10 May 2015 11:02:21 -0700, wrote: It's not clear why you are now mixing in variants of conversion rules for issue 4372. I noticed that my rule made the same \b mistake as yours, and they are right next to each other, and I thought it was an easy fix, so I tried fixing both at once.

Re: Make \shiftOff an assertive \override, not a \revert (issue 190500043 by k-ohara5...@oco.net)

2015-05-10 Thread Keith OHara
On Sun, 10 May 2015 05:06:24 -0700, wrote: In addition, the following commit commit a1d73a332fc4d1cb99bace19a5ec2c35262429e7 Author: Keith OHara Date: Tue Dec 30 23:30:27 2014 -0800 Update by hand instead of convert-ly The documentation already described the new behavior of

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

2015-05-05 Thread Keith OHara
On Mon, 04 May 2015 23:58:12 -0700, Valentin Villenave wrote: Speaking as someone who regularly gives LilyPond initiation seminars for adults and children, the hardest part is explaining to them why \relative mode is not on by default. What if they didn't have to type all those 's in absolut

Re: \change Voice

2015-04-26 Thread Keith OHara
On Sun, 26 Apr 2015 14:35:33 -0700, Dan Eble wrote: If there existed a command to redirect the sequential iterator’s output to another Voice context without requiring a wrapper context, it could not function in a parallel sequence; the commands would have to be injected into the part sequenc

Re: \change Voice

2015-04-26 Thread Keith OHara
On Sun, 26 Apr 2015 05:37:14 -0700, Dan Eble wrote: I think \context...{} segments make a better implementation of \partcombine than re-routing outlets in the part-combine-iterator.cc I believe that would work, but it looks less tidy than keeping the original part intact and wrapping it in

Re: \change Voice

2015-04-25 Thread Keith OHara
On Fri, 24 Apr 2015 22:04:28 -0700, David Kastrup wrote: Keith OHara writes: The thing you want to change is the "outlet" of the sequential iterator. That's just \context Voice = "xxx". However, it does not take engravers and properties along, as opposed t

Re: \change Voice

2015-04-24 Thread Keith OHara
Dan Eble faithful.be> writes: > > Would it be hard to make \change Voice work as below without relying on > the extra “NoteSequence” context? > > \layout { > \context { > \name "Thread" > \type "Engraver_group" > } > \context { > \Voice > \accepts "Thread" > \defaultch

Re: Avoid floating-point compares on Stem:head_positions; issue 4310 (issue 217720043 by k-ohara5...@oco.net)

2015-03-11 Thread Keith OHara
On Wed, 11 Mar 2015 02:10:29 -0700, wrote: _How_ do we arrive at different versions of 3.0 here, or at GCC considering 3.0 > 3.0 ? Probably we get different numbers that are close to 3.00... or 2.99... The head positions are individually multiplied by staff-space in Grob::get_offset() and t

Re: Lilypond build: version

2015-03-01 Thread Keith OHara
Phil Holmes philholmes.net> writes: > I completed a full GUB build of lilypond yesterday That's very good news. I was beginning to worry. Thanks for taking the time to work through the problems. ___ lilypond-devel mailing list lilypond-devel@gnu.o

Re: Issue 4275: Allow user-defined rest styles. (issue 200860043 by nine.fierce.ball...@gmail.com)

2015-01-31 Thread Keith OHara
On Sat, 31 Jan 2015 14:49:29 -0800, wrote: https://codereview.appspot.com/200860043/diff/20001/lily/rest.cc#newcode166 lily/rest.cc:166: + offset); On 2015/01/31 06:02:50, Keith wrote: I guess that get_position() could possibly trigger a full layout, but I can't tell for sure without booting

Re: Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ball...@gmail.com)

2015-01-28 Thread Keith OHara
On Wed, 28 Jan 2015 17:40:33 -0800, wrote: Yes, the ledgered rest stuff is a big tangle. See https://codereview.appspot.com/200860043/ for the best I've been able to do without changing Rest_collision. Shucks. The similar issue with Accidentals (issue 3646) was not so bad. There we could loo

Re: Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ball...@gmail.com)

2015-01-27 Thread Keith OHara
On Tue, 27 Jan 2015 05:09:58 -0800, wrote: On 2015/01/27 05:21:47, Keith wrote: I discovered this when I tried to use get_property("stencil") from Rest::height while trying to fix issue 4245. It looks like some rests (whole and half rests) have two glyphs, with and without the ledger line,

Re: Reduce size of PDF files when inc. in *TeX docs (issue 194090043 by pkx1...@gmail.com)

2015-01-20 Thread Keith OHara
On Tue, 20 Jan 2015 13:19:26 -0800, wrote: https://codereview.appspot.com/194090043/diff/20001/ps/encodingdefs.ps#newcode8 ps/encodingdefs.ps:8: /LilyNoteHeadEncoding [ On 2015/01/18 06:33:02, Keith wrote: This is a little different from "FetaNoteheadsEncoding" in 'mf/out/feta-noteheads11.enc'

Re: mentorship

2015-01-11 Thread Keith OHara
Kevin Barry gmail.com> writes: > Thank you for responding. I would like to be able to contribute code to the > project but I'm not really a programmer (I'm a music academic). I worked > through some chapters of SICP in the past, so I have a rudimentary > understanding of ... the first few chapter

Re: GUB fail with smob templates

2015-01-03 Thread Keith OHara
Phil Holmes philholmes.net> writes: > >> Phil Holmes philholmes.net> writes: > >>> /home/gub/gub/target/darwin-ppc/src/lilypond-git.sv.gnu.org-- lilypond.git- > >>> release-unstable/lily/include/smobs.tcc:131: error: invalid operands of > >>> types 'scm_unused_struct* (Grob::*)()' and 'scm_unus

Re: Reduce size of *TeX generated pdfs with lilypond snippets

2014-12-28 Thread Keith OHara
On Sun, 28 Dec 2014 21:10:59 -0800, Werner LEMBERG wrote: https://codereview.appspot.com/191360043/ Unfortunately, this doesn't correctly include the new file `encodingdefs.ps' – it is tagged as a `binary'... Oops, forgot to change the settings. There is no existing file to compare to, so t

Re: Reduce size of *TeX generated pdfs with lilypond snippets

2014-12-28 Thread Keith OHara
Knut Petersen t-online.de> writes: > The attached patch (against 2.18.2) changes the way lilypond > uses fonts to draw glyphs. > > It avoids to used glyphshow for all emmentaler glyphs and > adds encoding vectors to the emmentaler fonts before they > are used. It also changes the ghostscript par

Re: crosslinks update

2014-12-28 Thread Keith OHara
Jean-Charles Malahieude orange.fr> writes: > I've locally merged master into translation, and before merging > translation back to staging will correct bad cross-links. > Sorry, I should have changed the rlearning links. > Don't forget that translators use the English node > names with tra

Re: mentorship

2014-12-21 Thread Keith OHara
Kevin Barry gmail.com> writes: > > > It depends on which part of LilyPond you want to help with as to the > > availability of people to help you. Is there a particular skill-set, set > > of issues or area of LilyPond you are particularly interested in? > > Thank you for responding. I would like

Re: GUB and mpfr/mpc

2014-12-21 Thread Keith OHara
Dan Eble faithful.be> writes: > > On Dec 8, 2014, at 08:21 , David Kastrup gnu.org> wrote: > > > > Masamichi HOSODA sea.plala.or.jp> writes: > > > >>> I agree that changing the algorithms is preferred; I didn’t mean to > >> suggest otherwise. But if that’s not going to happen overnight, and

Re: Part combiner: separate split state and voice names

2014-12-01 Thread Keith OHara
Urs Liska openlilylib.org> writes: > Keith wrote: > > I suggest looking over the existing partcombine bugs, and orchestral > > scores, to see what problems generally need solving. > If there's anything I can do to help (without understanding more than > basic Scheme and without any option to h

Re: Part combiner: separate split state and voice names

2014-11-30 Thread Keith OHara
On Sun, 30 Nov 2014 13:46:35 -0800, Dan Eble wrote: I have a question. If the Scheme code produces something like (‘apart “one” “two”) with “one” and “two” being the chosen output voices for the input parts at the moment, would it make sense to write those decisions back to the input parts

Re: Part combiner: separate split state and voice names

2014-11-29 Thread Keith OHara
On Sat, 29 Nov 2014 18:09:34 -0800, Dan Eble wrote: On Nov 29, 2014, at 18:48 , Keith OHara wrote: Oh, so you meant let the Scheme portion dictate to partcombine_iterator which _input_ voice, as it iterates the music expression produced by \partcombine, to use. My reasoning probably

Re: Part combiner: separate split state and voice names

2014-11-29 Thread Keith OHara
On Sat, 29 Nov 2014 14:44:48 -0800, Dan Eble wrote: On Nov 29, 2014, at 16:46 , Keith OHara wrote: Dan Eble faithful.be> writes: I would like the Scheme portion of the part combiner to dictate the names of the voices to use at every moment. Simply letting us specify the Voices _on

Re: Part combiner: separate split state and voice names

2014-11-29 Thread Keith OHara
Dan Eble faithful.be> writes: > I would like to break the rigid link between the split states > (apart, unisilence, etc.) and the names of the > voices into which the Part_combine_iterator routes events. The patch back at http://lists.gnu.org/archive/html/lilypond-devel/2008-09/msg00079.html

Re: Add chord range to make-part-combine-music (issue 144170043 by nine.fierce.ball...@gmail.com)

2014-11-07 Thread Keith OHara
On Fri, 07 Nov 2014 04:37:41 -0800, wrote: On 2014/11/06 05:44:50, Keith wrote: Changing the current global variable 'partcombine-chord-range' will not become the user interface. All I meant for that variable was to avoid repeating the same magic numbers three times. Is there a more idiom

Re: Issue 3286: add single-C time signature style (issue 164830043 by nine.fierce.ballads gmail.com)

2014-11-03 Thread Keith OHara
On Mon, 03 Nov 2014 05:11:02 -0800, Dan Eble wrote: On Nov 3, 2014, at 02:25 , Keith OHara wrote: That kind logic is already at the end of Time_signature::special_time_signature() now, but I don't see any way to use it for anything except 2/2 and 4/4. The logic used for neomen

Re: Issue 3286: add single-C time signature style (issue 164830043 by nine.fierce.ballads gmail.com)

2014-11-02 Thread Keith OHara
On Sun, 02 Nov 2014 18:11:58 -0800, Dan Eble wrote: On Nov 2, 2014, at 14:52 , Keith OHara wrote: The current code has some logic to choose a glyph timesig.C34 if... I followed everything you said except this, maybe because of the sudden mention of 3/4. Are you implying that changing

Re: Issue 3286: add single-C time signature style (issue 164830043 by nine.fierce.ballads gmail.com)

2014-11-02 Thread Keith OHara
Dan Eble faithful.be> writes: > On Nov 1, 2014, at 18:48 , Noeck gmx.de> wrote: > >> > >> * leave the default style alone > >> * add to the C style: 4/2 -> CC, 2/1 -> cut-CC > >> > >> This would end the equivalence of default and C styles. > >> Does that seem like a bad idea to any seasoned

Re: staff-symbol-referencer: ledger logic; issue 4184 (issue 167040043 by k-ohara5...@oco.net)

2014-11-02 Thread Keith OHara
'notehead' noted. On Sat, 01 Nov 2014 23:43:34 -0700, wrote: /* If we are closer to the staff than the notehead, quantize for ledger lines. */ But I wonder whether this is the best description – it's rather about note heads and attached grobs having the same direction, right? Well, if by '

Re: how to make space between time signature and following material squeezable

2014-11-02 Thread Keith OHara
This is https://code.google.com/p/lilypond/issues/detail?id=1785 For four years this space was too compressible, and would not stretch. The behavior did not match the names of the settings and code comments, so I raised issue 1785 to make the space rigid. Another option, semi-fixed-space in pl

Re: Add chord range to make-part-combine-music (issue 144170043 by nine.fierce.ballads gmail.com)

2014-11-01 Thread Keith OHara
gnu.org> writes: > On 2014/10/31 22:50:35, Dan Eble wrote: > > > One thing just occurred to me. If this option is going into the UI, > do you > > think the numbers should be 1-based for easier comprehension by > musicians? > As a UI, numbers instead of intervals (possibly represented only by

Re: Add chord range to make-part-combine-music (issue 144170043 by nine.fierce.ball...@gmail.com)

2014-10-31 Thread Keith OHara
On Fri, 31 Oct 2014 15:50:35 -0700, wrote: One thing just occurred to me. If this option is going into the UI, do you think the numbers should be 1-based for easier comprehension by musicians? For example, use '(1 . 9) to allow chording unisons to ninths, rather than '(0 . 8)? Good to thin

Re: Add chord range to make-part-combine-music (issue 144170043 by nine.fierce.ball...@gmail.com)

2014-10-31 Thread Keith OHara
On Thu, 30 Oct 2014 20:19:01 -0700, wrote: This is the beginning of the function I've actually been using: (define-public (dfe-determine-split-list evl1 evl2 chord-range enable-solo) "@var{evl1} and @var{evl2} should be ascending. @var{chord-range} is a pair (min . max) defining the distanc

Re: Doc: Issue 3324: Add explanation of clashing note columns warning (issue 154640043 by tdanielsmu...@googlemail.com)

2014-10-23 Thread Keith OHara
On Thu, 23 Oct 2014 02:43:56 -0700, wrote: On 2014/10/22 05:58:54, Keith wrote: I have been thinking that when the user gives explicit \voiceOne or \shiftOn to the voices, Lily should set those voices at the shifts requested, even if two voices have the same shift I had forgotten that I a

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-21 Thread Keith OHara
On Tue, 21 Oct 2014 09:33:56 -0700, wrote: I've decided to keep the reverts for the On predefs, since \once does not do what [the name implies] with these overrides. Yuck. The problem seems to be that the override takes effect at the first beat in a bar, after the paper-column for the previ

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-09-08 Thread Keith OHara
On Mon, 08 Sep 2014 16:28:24 -0700, Dan Eble wrote: How about placing the voices inside a VoiceGroup context, moving the Accidental_engraver there, and leaving the NullVoice outside, like in my recent partcombine experiments? Usually, accidentals are reported up the context hierarchy. We c

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-09-07 Thread Keith OHara
On Sun, 07 Sep 2014 01:21:58 -0700, wrote: But messing up the basic grob definition by fetching internals and meddling through them locally: no. Well, you say "messing up the basic grob definition" I say "reading the basic definition, and making a local modified copy" We can do in LilyPond c

Re: Issue 4083: Implement \tagGroup command (issue 137920043 by d...@gnu.org)

2014-09-06 Thread Keith OHara
Patch set 5 will probably be fine. My concern was that someone would be confused that adding to the list of tags to keep \keepWithTag editorial { ... \tag#'editorial \tag#'score \bar'||' } \keepWithTag part.editorial { ... \tag#'editorial \tag#'score \bar'||' } can reduce the things that a

Re: Issue 4078: Doc: Use variables rather than instrument definitions (issue 138950043 by tdanielsmu...@googlemail.com)

2014-08-31 Thread Keith OHara
On Sun, 31 Aug 2014 00:14:11 -0700, wrote: On 2014/08/31 06:58:47, Keith wrote: https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely#newcode2646 \set instrumentCueName = "Flute" This is the *other* use of instrumentSwitch, which I'll probably put back to a <>^\ma

Re: Die, instrumentSwitch. (issue 133390043 by k-ohara5...@oco.net)

2014-08-31 Thread Keith OHara
On Sun, 31 Aug 2014 01:06:46 -0700, wrote: A few minor comments below, but I don't see how we can just remove the instructions for setting up InstrumentSwitch without some replacement. InstrumentSwitch is used by \cueDuring and friends. \cueDuring itself does not use InstrumentSwitch; we were

Re: indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

2014-08-25 Thread Keith OHara
On Mon, 25 Aug 2014 00:28:14 -0700, wrote: Excuse my ignorance, is this going to need any extra documentation or perhaps a changes.tely entry? https://codereview.appspot.com/133840043/ I read through the documentation and saw no changes except mentioning the alternative names for bn, etc

Re: AccidentalCautionary in NullVoice

2014-08-24 Thread Keith OHara
On Sat, 23 Aug 2014 13:16:22 -0700, Dan Eble wrote: On Aug 23, 2014, at 08:03 , Dan Eble wrote: I think I’m really close (again!) to getting modern-voice-cautionary accidentals with combined-part stems by defining a new accidental style that disregards the part combiner’s voices. It looks

Re: AccidentalCautionary in NullVoice

2014-08-17 Thread Keith OHara
On Sat, 16 Aug 2014 11:29:29 -0700, Dan Eble wrote: On Aug 11, 2014, at 02:43 , Keith OHara wrote: I'll still put NullVoice in \score by default, so it doesn't interact with the accidental engraver, or anything else that we haven't noticed yet, and let you \new Staff \

Re: AccidentalCautionary in NullVoice

2014-08-10 Thread Keith OHara
On Sun, 10 Aug 2014 17:15:47 -0700, Dan Eble wrote: On Aug 10, 2014, at 15:40 , Dan Eble wrote: On Aug 10, 2014, at 14:55 , Keith OHara wrote: You could then enter \accepts NullVoice into just those Staffs where you use this technique. (Usually, \partcombine refuses to change the voicing

Re: AccidentalCautionary in NullVoice

2014-08-10 Thread Keith OHara
On Sun, 10 Aug 2014 10:05:04 -0700, Dan Eble wrote: Patch set 3 seems more useful to me than patch set 4. Yep. I'll combine the best of both: 1) NullVoice in Score by default, so that the invisible notes do not affect the setting of accidentals 2) settings enabled so that you can move NullV

Re: Issue 4024: Clarify break-align symbols and space-alist args in IR. (issue 114160044 by markpole...@gmail.com)

2014-07-29 Thread Keith OHara
On Tue, 29 Jul 2014 13:12:47 -0700, wrote: Ah, I see. Here's the confusion: when paired with right-edge, *all* 5 of the spacing-styles actually do something (to be clear, they all do the same thing: they behave like extra-space, with space that doesn't stretch). Anyway, am I correct in conclu

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-07-28 Thread Keith OHara
On Sun, 27 Jul 2014 23:07:58 -0700, wrote: The ugliness is with messing up the whole grob definition of a NoteHead (which is fixed to the degree of being documented in the Internals Reference) inside of a particular context. I thought that was pretty, as well. We override the defaults of grob

Re: Set X-parent of TextScript to NoteColumn instead of PaperColumn (issue 106640043 by janek.lilyp...@gmail.com)

2014-07-27 Thread Keith OHara
On Sun, 27 Jul 2014 09:44:22 -0700, wrote: On 2014/07/26 21:36:12, Keith wrote: On 2014/07/26 06:49:41, janek wrote: > > Setting TextScript.cross-staff property to #f is required to ensure > that there are no collisions between TextScripts and cross-staff notes: The concept of a

Re: AccidentalCautionary in NullVoice

2014-07-06 Thread Keith OHara
Dan Eble faithful.be> writes: > It sounds like you are saying the issue with spurious accidental > cancellations is fixed in 2.19.9 No, NullVoice still has those problems, because it still creates invisible note-heads, and applies various workarounds so that the note-heads don't have any effec

Re: AccidentalCautionary in NullVoice

2014-07-05 Thread Keith OHara
Dan Eble faithful.be> writes: > On Feb 9, 2014, at 21:19 , Dan Eble faithful.be> wrote: > > > Here is a work-around for > > https://code.google.com/p/lilypond/issues/detail?id=3834 NullVoice looks like a long list of workarounds. Now that Janek has independent Lyrics aligned as of version 2.

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-05 Thread Keith OHara
On Fri, 04 Jul 2014 14:38:19 -0700, Janek Warchoł wrote: 2014-07-04 23:26 GMT+02:00 Janek Warchoł : That's actually not what i want to do; I apologize for being unclear. I *want* the columns to behave the same way in case of both accidentals and lyrics (and everything else). The desired beh

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-04 Thread Keith OHara
On Wed, 02 Jul 2014 23:56:20 -0700, wrote: you should try to make the change consistently everywhere ? Yes, that's what i'm aiming for. However, as you remember, some of these changes produce unwanted side-effects I remember you said there were side effects, but you did not until now say w

Re: Doc: NR Pitches.itely - added 2 new snippets (issue 110240044 by pkx1...@gmail.com)

2014-06-30 Thread Keith OHara
On Mon, 30 Jun 2014 14:40:17 -0700, wrote: Is it worth making the Notation Reference longer? What do you suggest? Depending on your opinion about the NR length, maybe leaving these examples in lsr only. https://codereview.appspot.com/110240044/diff/40001/Documentation/notation/pitches.it

Re: Issue 3254: align unassociated lyrics using NoteColumn extent. (issue 108110044 by janek.lilyp...@gmail.com)

2014-06-26 Thread Keith OHara
On Thu, 26 Jun 2014 01:01:11 -0700, wrote: pushed as c73b41b3e7be6d7280c6336cf03610cd7aed3000 - thanks for review! I'll post a follow-up patch later today. https://codereview.appspot.com/108110044/ It seems that after this patch, the old well-tested Devnull context should do everything tha

Re: line-breaking bug in 2.19

2014-02-17 Thread Keith OHara
On Mon, 17 Feb 2014 00:24:22 -0800, Keith OHara wrote: On Sun, 16 Feb 2014 23:50:06 -0800, Keith OHara wrote: On Sun, 16 Feb 2014 17:33:16 -0800, Keith OHara wrote: On Sun, 16 Feb 2014 13:58:01 -0800, Janek Warchoł wrote: 2014-01-17 17:55 GMT+01:00 Keith OHara : Starting with

Re: line-breaking bug in 2.19

2014-02-17 Thread Keith OHara
On Sun, 16 Feb 2014 23:50:06 -0800, Keith OHara wrote: On Sun, 16 Feb 2014 17:33:16 -0800, Keith OHara wrote: On Sun, 16 Feb 2014 13:58:01 -0800, Janek Warchoł wrote: 2014-01-17 17:55 GMT+01:00 Keith OHara : Starting with version 2.19.0, the bassoon part from <h

Re: line-breaking bug in 2.19

2014-02-16 Thread Keith OHara
On Sun, 16 Feb 2014 17:33:16 -0800, Keith OHara wrote: On Sun, 16 Feb 2014 13:58:01 -0800, Janek Warchoł wrote: 2014-01-17 17:55 GMT+01:00 Keith OHara : Starting with version 2.19.0, the bassoon part from <http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1793> gets a shor

Re: line-breaking bug in 2.19

2014-02-16 Thread Keith OHara
On Sun, 16 Feb 2014 13:58:01 -0800, Janek Warchoł wrote: 2014-01-17 17:55 GMT+01:00 Keith OHara : Starting with version 2.19.0, the bassoon part from <http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1793> gets a short line. I have tried to minimize the example, but unfortu

Re: NR: Removed example for alternate repeats (issue 61170044)

2014-02-10 Thread Keith OHara
On Mon, 10 Feb 2014 04:31:25 -0800, wrote: These three examples are more useful as regression tests than as documentation. Are they robust enough? Do they exercise each property properly? They seem good enough, but it is not essential to add them to /input/regressoin/ They won't get lost,

line-breaking bug in 2.19

2014-01-17 Thread Keith OHara
Starting with version 2.19.0, the bassoon part from gets a short line. The first commit where this happens is f8416b for issue 3304 (making horizontal spacing even) but it seems that for any values of the ideal horizontal spacing, th

Re: regtest for new glyphs necessary?

2014-01-02 Thread Keith OHara
Marc Hohl hohlart.de> writes: > I am about to upload a patch for these four glyphs within the next > days, but I wanted to ask whether a new (or enhanced existing) > regtest is necessary for this type of enhancement? They could conceivably be broken accidentally, by a mistaken change to our .mf

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-26 Thread Keith OHara
On Thu, 26 Dec 2013 22:47:41 -0800, Trevor Bača wrote: I suppose it's important to note that all of my scores use proportional notation everywhere. So I imagine that most of the horizontal spacing improvements don't actually impact my scores. (The recent spacing changes optimize Lily's *default

Re: Automatically unfold percent and tremolo repeats in MIDI output. (issue 769) (issue 40720060)

2013-12-22 Thread Keith OHara
On Sun, 22 Dec 2013 11:45:49 -0800, Devon Schudy wrote: Unfolding during iteration doesn't extend well to voltas, because it changes their length. Even if the length is updated, the old length has already been used by the parent iterator to compute moments for subsequent events. So unless this

Re: Automatically unfold percent and tremolo repeats in MIDI output. (issue 769) (issue 40720060)

2013-12-21 Thread Keith OHara
On Sat, 21 Dec 2013 00:23:05 -0800, wrote: Keith comments: The other limitation of \unfoldRepeats is that it fails to see repeats in parallel expressions << {\repeat volta 2 s1 } {c2 d2} >> while this approach using the iterators will see them and be able to expand them when requested. I

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-15 Thread Keith OHara
On Sat, 14 Dec 2013 23:57:20 -0800, Mike Solomon wrote: On Dec 15, 2013, at 12:58 AM, Keith OHara wrote: The most transparent reorganization might be to have all properties that can hold data use the usual callback mechanism: where the callback function is used just once, and the data it

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-14 Thread Keith OHara
On Sat, 14 Dec 2013 14:58:52 -0800, Keith OHara wrote: Several considered line-breaks might have the same 'start' and 'end' around the hairpin, but the upper-level axis-group structure caches results for each start/end pair so just one skyline is generated for each d

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-14 Thread Keith OHara
On Sat, 14 Dec 2013 00:49:43 -0800, Mike Solomon wrote: On Dec 14, 2013, at 9:35 AM, David Kastrup wrote: Most of the contortions seem focused about when or when not and how to pass begin/end columns. It would seem to make sense to turn them into dynamic parameters *begin* *end* that you ca

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-13 Thread Keith OHara
On Fri, 13 Dec 2013 23:05:49 -0800, David Kastrup wrote: That does not make sense. If you want call-once behavior, you can just use a callback. At the moment, the decision on whether to preserve the callback pointer in the grob property, or fill the property with the returned value, depends

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-13 Thread Keith OHara
On Dec 13, 2013, at 9:07 AM, Keith OHara wrote: Open_type_font:: and Pango_font::name_to_index() each call FT_Get_Name_Index(). Inserting print statements to trace those calls I find that FT_Get_Name_Index is called: 7 times for each character in a Tempo The layers of functions that

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-13 Thread Keith OHara
On Fri, 13 Dec 2013 01:38:23 -0800, Werner LEMBERG wrote: I will check whether I can improve that in FreeType. Is there a reason this would have such a significantly different impact in Windows? No. It's exactly the same code on both platforms. However, for lilypond, even a single-element

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-13 Thread Keith OHara
On Thu, 12 Dec 2013 23:07:19 -0800, Keith OHara wrote: I am happy to say that I was wrong here. Open_type_font:: and Pango_font::name_to_index() each call FT_Get_Name_Index(). Inserting print statements to trace those calls I find that FT_Get_Name_Index is called: 7 times for each

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-12 Thread Keith OHara
On Tue, 10 Dec 2013 22:44:18 -0800, Keith OHara wrote: After a brief look at the code, it looked like for each glyph being laid out there is one extra call of Open_type_font:: or Pango_font::name_to_index(), which is the function called by find_by_name() that caused the extra time with

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-10 Thread Keith OHara
On Tue, 10 Dec 2013 17:22:19 -0800, David Kastrup wrote: "Keith OHara" writes: The last time we had a doubling of time required on Windows relative to Linux, issue 1926, it was repeated calls to find_by_name() that go through Pango to the font server. Here the outlines seem to b

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-10 Thread Keith OHara
On Tue, 10 Dec 2013 09:57:20 -0800, Keith OHara wrote: On Tue, 10 Dec 2013 01:59:09 -0800, Phil Holmes wrote: When I benchmarked with and without skylines, I found there was only a noticeable difference with a lot of markup or similar: "normal" music had almost no effect. As a

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-10 Thread Keith OHara
On Tue, 10 Dec 2013 01:59:09 -0800, Phil Holmes wrote: When I benchmarked with and without skylines, I found there was only a noticeable difference with a lot of markup or similar: "normal" music had almost no effect. As a result, I concluded with skylining was the correct default. I agreed

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-10 Thread Keith OHara
On Mon, 25 Nov 2013 00:10:08 -0800, David Kastrup wrote: "Keith OHara" writes: I timed one big score, Movement 1 of <http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=1793> 2.16.2 2.17.95 WinXP 2m 30s 5m 10s Fedora 1m 50s 1m 50s Have you used

Re: Reduce offsets of \super and \sub (issue 35320043)

2013-12-01 Thread Keith OHara
On Sat, 30 Nov 2013 23:56:09 -0800, wrote: I have one request: this patch makes the situation better, and even if the baseline-skip approach is wrong, it was already used that way so it's not making things worse. I suggest to push this patch, and then work on making this smarter (in the spirit

  1   2   3   4   5   6   >