Re: make sure that AmbitusLine is visible for small ambits (issue 4609041)

pushed as 1883fef6da1f91b1985ac296f0eb5bc9aee613ec https://codereview.appspot.com/4609041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allow music with layout instructions in output definitions. (issue 5701049)

Hi, (some archeology...) On 2012/02/29 23:44:20, dak wrote: Janek Warchoł writes: > On Wed, Feb 29, 2012 at 9:22 AM, David Kastrup wrote: >> Janek Warchoł writes: >>> >>> sure, i can do this.  Neverth

Re: parser.yy: allow "scalar" to be a negative literal number (issue 13270048)

On 2013/09/01 16:49:59, dak wrote: https://codereview.appspot.com/13270048/diff/1/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/13270048/diff/1/lily/parser.yy#newcode2328 lily/parser.yy:2328: | SCM_IDENTIFIER On 2013/09/01 16:25:39, Janek Warchol wrote: > just cur

outside-staff-padding: add just one pad; issue 2910 (issue 10329043)

Could you add some information in the commit message explaining why had you changed the default values? https://codereview.appspot.com/10329043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-deve

Re: make sure that AmbitusLine is visible for small ambits (issue 4609041)

Just to let you know: i've tested the patch on a bunch of simple SATB scores and the ambits look way better. https://codereview.appspot.com/4609041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/l

parser.yy: allow "scalar" to be a negative literal number (issue 13270048)

LGTM https://codereview.appspot.com/13270048/diff/1/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/13270048/diff/1/lily/parser.yy#newcode2328 lily/parser.yy:2328: | SCM_IDENTIFIER just curious: this SCM_IDENTIFIER is for things like #LEFT? https://codereview.appspot

Re: make sure that AmbitusLine is visible for small ambits (issue 4609041)

https://codereview.appspot.com/4609041/diff/29002/input/regression/ambitus-gap.ly File input/regression/ambitus-gap.ly (right): https://codereview.appspot.com/4609041/diff/29002/input/regression/ambitus-gap.ly#newcode5 input/regression/ambitus-gap.ly:5: note heads are set by the @code{gap} prope

Re: include lines in breve X-extent (issue 1814) (issue 4931043)

Reviewers: janek, Bertrand Bordage, MikeSol, J_lowe, Ian Hulin (gmail), graham_percival-music.ca, Message: On 2011/09/06 16:26:40, Bertrand Bordage wrote: On 2011/09/06 08:54:40, janek wrote: > I'm not sure what you mean. Are you saying that i should assign (i * (gap + > stemthick), 0) to a

Re: modifying default behaviour of tremolo slashes (issue 4636081)

Regtest added. http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc File lily/stem-tremolo.cc (right): http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc#newcode118 lily/stem-tremolo.cc:118: shape = ly_symbol2scm ("beam-like"); On 2011/08/11 20:05:10, Neil Pu

Re: changing shape of the G clef (issue 4664070)

pushed as e795110331497fbf46a7d61ed6ed73a9da4ae9c5 http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds a glyph for tied lyrics. (issue4808074)

I'd make the tie slightly shorter. I find it awkward that two adjacent ties collide so easily, for example here { \time 3/4 \relative c' { c2 e4 g2 e4 } \addlyrics { gran- de_a- mi- go } \addlyrics { pu- "ro y ho-" nes- to } \addlyrics { pu- ro~y~ho- nes- to } } (example from documentat

Re: Doc: Added \compoundMeter function to NR (issue4837050)

http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1555 Documentation/notation/rhythms.itely:1555: shown durations ar

Re: Adds a glyph for tied lyrics. (issue4808074)

I've created tracker issue: http://code.google.com/p/lilypond/issues/detail?id=1807 Could you upload some pngs showing before/after output? It would be helpful for those who cannot build the patch themselves. http://codereview.appspot.com/4808074/ __

Re: Doc: Added \compoundMeter function to NR (issue4837050)

overall LGTM http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1643 Documentation/notation/rhythms.itely:1643: come

Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072)

Hi Mike, i tried writing a review, but i don't understand what's going on here. Can you add some comments to the code? cheers, Janek http://codereview.appspot.com/4810072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/m

Re: Doc: Added \compoundMeter function to NR (issue4837050)

http://codereview.appspot.com/4837050/diff/9001/Documentation/music-glossary.tely File Documentation/music-glossary.tely (right): http://codereview.appspot.com/4837050/diff/9001/Documentation/music-glossary.tely#newcode2114 Documentation/music-glossary.tely:2114: \compoundMeter #'((3 8) (2 8) (4

Re: print transposed guitar chords on piano sheets (issue4626094)

This patch is obsolete. Current patch is here http://codereview.appspot.com/4800051/ and it is compatible with fixcc. My bad... I should've closed this issue and sent a note. http://codereview.appspot.com/4626094/ ___ lilypond-devel mailing list lilyp

Re: modifying default behaviour of tremolo slashes (issue4636081)

Oh no! I hoped to get it on this countdown. A version compatible with fixcc uploaded. http://codereview.appspot.com/4636081/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue4837050)

I think the \compoundMeter description should be more detailed. http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4837050/diff/1/Documentation/notation/rhythms.itely#newcode1555 Docu

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

New patch set uploaded (adding a regtest). 2011/8/1 Wols Lists : Regression test attached. I've looked at the other regression tests and tried to make it similar. Great! http://codereview.appspot.com/4800051/diff/14003/input/regression/chord-capo.ly File input/regression/chord-capo.ly (rig

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

New patch uploaded. Passes regtests made from scratch. http://codereview.appspot.com/4800051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

New patch from Wol uploaded. http://codereview.appspot.com/4800051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: modifying default behaviour of tremolo slashes (issue4636081)

Reinhold: ok, replaced parallelogram with beam-like http://codereview.appspot.com/4636081/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: modifying default behaviour of tremolo slashes (issue4636081)

New patch set uploaded. Minor style change: slash shape that was named "default" (which was confusing) is now named "parallelogram" (because that's how it looks like). If you don't like parallelograms ;) we can name it beam-like or sth. http://codereview.appspot.com/4636081/ ___

Ends of barlines are hidden in staff lines. (issue4809057)

Reviewers: hanwenn, Message: http://lists.gnu.org/archive/html/lilypond-devel/2011-07/msg01051.html 2011/7/27 Han-Wen Nienhuys : Due to rounding, PDF viewers can err the placement of the barline by a pixel. [so that it looks like sticking out of staff] You can make the problem disappear by

Re: Remove special case in staff-spacing (issue4188051)

Keith, I am so sorry - you've sent me this patch ages ago and i forgot about it! :( I've checked regtests to see how it works and it's great!! However, i cannot write any meaningful review, because i don't understand what's going on here at all :( Could you add some comments for rookies like me

Re: font: change breve vertical lines (issue4748044)

A pdf proof file is attached to tracker issue http://code.google.com/p/lilypond/issues/detail?id=1767 The gap in smallest font sizes was reduced according to Bertrand's suggestion, and the line height was increased just a bit according to my friend's suggestion. I don't feel strong about these ch

Re: changing shape of the G clef (issue4664070)

Going back to replacing the clef only. Old glyph is no longer in the patch, we may discuss it separately. http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

Uploaded Carl's fix, everything works now! I'm making from scratch and will run regtests. http://codereview.appspot.com/4800051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

New patch from Wol uploaded. According to Carl, it addresses previous concerns; we only have a problem with Scheme syntax left. (don't run regtests on this yet) http://codereview.appspot.com/4800051/ ___ lilypond-devel mailing list lilypond-devel@gnu.

Modify chord-name-engraver to call capo-handler (issue4800051)

Reviewers: carl.d.sorensen_gmail.com, Description: Modify chord-name-engraver to call capo-handler Add capo properties to define-context-properties Add capo-handler function for guitar chords Please review this at http://codereview.appspot.com/4800051/ Affected files: M lily/chord-name-en

Re: modifying default behaviour of tremolo slashes (issue4636081)

Joe: redundant lines removed. Interesting thing happens when i compare regtests: i see a difference in part-combine-tuplet-end.ly, which is completely unrelated to tremolos. Even funnier, my branch compiled this test better than master... Perhaps i should've built from scratch. BTW, should i add

Re: Produces better error messages when programmers forget to document a property. (issue4801045)

On 2011/07/20 12:47:56, MikeSol wrote: I've needed something like this for a long time - lemme know what you think! I don't understand how it works, but from what i suppose it's results will be very nice! thanks, Janek http://codereview.appspot.com/4801045/ __

Re: modifying default behaviour of tremolo slashes (issue4636081)

New patch set uploaded. Current Lily default behaviour is kept as default now. http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc File lily/stem-tremolo.cc (right): http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode42 lily/stem-tremolo.cc:42: style

Re: changing shape of the G clef (issue4664070)

I guess this fixes the problem with "old" style for non-G clefs. http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc File lily/clef.cc (right): http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc#newcode51 lily/clef.cc:51: str = str + "_" + clef_style; On 2011/07/17 21:09:45,

Re: CG: describe new C++ formatting (GOP-PROP 3) (issue4760056)

http://codereview.appspot.com/4760056/diff/1/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/4760056/diff/1/Documentation/contributor/programming-work.itexi#newcode334 Documentation/contributor/programm

Re: Creates callback for stem-begin-position. (issue4752048)

My "review" will be a bit non-standard (as i'm still a rookie programmer): i understand what's going on here, so it's probably good :) http://codereview.appspot.com/4752048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/m

font: change breve vertical lines (issue4748044)

Reviewers: , Message: Hi, breve glyphs in Feta font need modification. What is bad now: breves lying between the stafflines form a hard-to-recognize clump, partly because the corners (marked in orange here: http://lilypond.googlecode.com/issues/attachment?aid=1767000&name=breve+dimensions.p

Re: modifying default behaviour of tremolo slashes (issue4636081)

Finally - new patch set uploaded. Now it's possible to easily switch between different tremolo behaviours. 'Style' property is no longer used to choose between rectangular and beam-like slashes - this is now done using 'shape' property. 'Style' property now influences both 'shape' and 'slope' of t

Re: changing shape of the G clef (issue4664070)

New patch set uploaded. \override Staff.Clef #'style = #'old tells Lily to use previous clef glyph instead of my new clef. (dedicated to James) http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://list

Re: Add hihat halfopen glyph to font (issue4714043)

The slash looks too long to me, especially when compared to halfopen (unstopped). I'd change factor to factor := 11/10 * sqrt(1 + 25/16); or maybe even factor := 4/4 * sqrt(1 + 25/16); otherwise LGTM. thanks, Janek http://codereview.appspot.com/4714043/ ___

Re: Move \RemoveEmptyStaves to new file for context modifications (issue #1760) (issue4664076)

The change looks pretty straightforward, but i don't understand why simply moving RemoveEmptyStaff definition changes anything :( cheers, Janek http://codereview.appspot.com/4664076/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists

Re: changing shape of the G clef (issue4664070)

New patch set uploaded - the suggested clef is a bit higher now. Images can be found in tracker issue: http://code.google.com/p/lilypond/issues/detail?id=1752 http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.or

Re: Flag functions instead of defining glyphs directly (issue4625067)

This was just pushed by Mike. I close the issue. thanks, Janek http://codereview.appspot.com/4625067/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: an example of minimal example (issue4636082)

New patch set uploaded. I think that everything works now. cheers, Janek http://codereview.appspot.com/4636082/diff/10003/Documentation/css/lilypond-website.css File Documentation/css/lilypond-website.css (right): http://codereview.appspot.com/4636082/diff/10003/Documentation/css/lilypond-webs

Re: Small pitch bends correct and tested. (issue4654063)

Graham, I'm worried that i don't hear anything from you since 2 weeks! Do you experience any problems with fixing code style issues pointed to by Neil? If you are very busy, i can fix them myself, but i'd prefer that you fix them and send me the collection of all patches, up-to-date (this will mi

Re: Separate flags into their own sub-font. (issue4654084)

Carl, are there any problems? The countdown is over but i don't see it pushed. cheers, Janek http://codereview.appspot.com/4654084/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: an example of minimal example (issue4636082)

New patch set uploaded. http://codereview.appspot.com/4636082/diff/13003/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/13003/Documentation/web/community.itexi#newcode320 Documentation/web/community.itexi:320: or @cod

changing shape of the G clef (issue4664070)

Reviewers: Reinhold, james.lowe_datacore.com, x.scheuer_gmail.com, Message: A tip to speed up work if you try to modify clef shape: use this script to generate a dvi preview of glyphs (no need to run make, and it also shows metafont control points): #!/bin/bash mf '\mode:=proof; input feta20' gf

Re: an example of minimal example (issue4636082)

Reverted sentence about \version. Ready to go? http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi#newcode311 Documentation/web/commun

Re: print transposed guitar chords on piano sheets (issue4626094)

New patch set uploaded. Hmm, Wol, did you use some code formatting tool on a whole file? I see a lot of style changes, and not all of them are for the good. http://codereview.appspot.com/4626094/ ___ lilypond-devel mailing list lilypond-devel@gnu.org h

Re: an example of minimal example (issue4636082)

http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi#newcode311 Documentation/web/community.itexi:311: Specify which release of LilyPond

Re: correcting note about rerunning regtests (issue4675048)

http://codereview.appspot.com/4675048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/4675048/diff/1/Documentation/contributor/regressions.itexi#newcode276 Documentation/contributor/regressions.itexi:276:

Re: print transposed guitar chords on piano sheets (issue4626094)

Some style nitpicks. I also think i found why it didn't work. http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc File lily/chord-name-engraver.cc (right): http://codereview.appspot.com/4626094/diff/1/lily/chord-name-engraver.cc#newcode126 lily/chord-name-engraver.cc:126: {

print transposed guitar chords on piano sheets (issue4626094)

Reviewers: antlists_youngman.org.uk, carl.d.sorensen_gmail.com, Message: Modify chord-name-engraver to print transposed guitar chords on piano sheets Add associated properties capoPitch and capoVertical to define-context-properties Description: print transposed guitar chords on pia Please revie

Re: an example of minimal example (issue4636082)

New patch set uploaded. I have a problem with the box at the bottom: code examples are center-aligned, not left-aligned. I didn't found any example of how it's done in our manuals; i searched texinfo documentation and found @flushleft, but it didn't work... How should i do this? http://coderev

correcting note about rerunning regtests (issue4675048)

Reviewers: , Description: correcting note about rerunning regtests looks like it is necessary to make test-clean if you want to check regtests on a new branch without making test-baseline Please review this at http://codereview.appspot.com/4675048/ Affected files: M Documentation/contributor

Re: an example of minimal example (issue4636082)

New patch set uploaded. 2011/7/4 : I'm glad that you're working on it!  I'm just warning you that there will be many nitpicks. No problem. If they aren't about code style, i can handle them :) http://codereview.appspot.com/4636082/diff/3/Documentation/web/community.itexi File Documentation

Re: Separate flags into their own sub-font. (issue4654084)

I've almost forgotten: i checked that Carl's patch set passes regtests. http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf File mf/feta-scripts.mf (right): http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf#newcode1450 mf/feta-scripts.mf:1450: begingroup; On 2011/07/

Re: an example of minimal example (issue4636082)

On 2011/07/04 20:02:59, Carl wrote: I like this, but I think it should have a little bit more information. I don't think that the changes in the comments affect whether it is minimal or not -- perhaps the comments should be the same in both cases. Imo it's more readable when the comment is

Re: Adds a warning for non-list fingeringOrientations settings. (issue4650070)

On 2011/07/04 13:14:55, Neil Puttock wrote: Context_def::add_context_mod () is where the assignment takes place (and you can see from set_property () how the type-checking is done). Where is set_property defined? cheers, Janek http://codereview.appspot.com/4650070/ __

Re: Separate flags into their own sub-font. (issue4654084)

LGTM! Thank you, Carl! http://codereview.appspot.com/4654084/diff/42/mf/feta-flags-generic.mf File mf/feta-flags-generic.mf (right): http://codereview.appspot.com/4654084/diff/42/mf/feta-flags-generic.mf#newcode4 mf/feta-flags-generic.mf:4: % Copyright (C) 1997--2011 Han-Wen Nienhuys Shouldn'

an example of minimal example (issue4636082)

Reviewers: Graham Percival, james.lowe_datacore.com, Message: In response to http://lists.gnu.org/archive/html/lilypond-user/2011-07/msg00060.html Description: an example of minimal example for some people it's not clear enough how tiny a tiny example should be. So i used a recently discussed e

modifying default behaviour of tremolo slashes (issue4636081)

Reviewers: xratamacue_hotmail.com, reinhold_kainhofer.com, Message: Passes regtests. Description: modifying default behaviour of tremolo slashes It turned out that tremolo slashes should have quite constant slope (definately not depending on beam slope), so i change that. I also changed slash s

Re: Braces redesigned (issue4581060)

Added to google tracker (sorry it's so late...), issue . I understand that this Rietveld issue (4581060) is valid, not the other one (4518052). I like new shapes too, with one exception: the very smallest brace has it's center too far to the left i think. http://codereview.appspot.com/4581060/ _

Re: separating flags from noteheads in font (issue4273119)

This is now abandoned; a new (working) version was created by Carl here: http://codereview.appspot.com/4662055/ (google code issue 1709) cheers, Janek http://codereview.appspot.com/4273119/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https:

Small pitch bends correct and tested. (issue4654063)

Reviewers: gbreed, Message: Graham Breed wrote: I've found and patched two problems with the pitch bend tuning code: 1) The pitch isn't always rounded to the nearest equally tempered value, so the result looks strange in a sequencer, and artifacts caused by the pitch bends are more severe. 2)

Flag functions instead of defining glyphs directly (issue4625067)

Reviewers: carl.d.sorensen_gmail.com, MikeSol, Message: This is an intermediate step that will be needed for shortened flags. Description: Flag functions instead of defining glyphs directly We will need many length variants of every flag. Therefore instead of writing flag code directly in glyph

Re: Add feta-flags to build system (issue4662055)

Carl! Woot! It works! I compiled it twice, and everything looks fine!! I told you you are a genious, didn't i? :D Do i understand correctly that a variable is available to all fonts (fet_beginfont ... fet_endfont) which are in the same mf file - it's so simple? So you solved the problem by callin

Re: ambitus: special handling of small ambits' lines (issue4609041)

http://codereview.appspot.com/4609041/diff/12001/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4609041/diff/12001/scm/define-grobs.scm#newcode141 scm/define-grobs.scm:141: (woot . 1) On 2011/06/17 07:18:49, MikeSol wrote: This seems like 1337 $p34k - I ha

Re: doc: fixing snippet fretted-string-harmonics (issue4624041)

On 2011/06/15 10:27:09, graham_percival-music.ca wrote: thanks, pushed. thanks, issue closed. cheers, Janek http://codereview.appspot.com/4624041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypon

doc: fixing snippet fretted-string-harmonics (issue4624041)

Reviewers: Graham Percival, fedelogy_gmail.com, Message: A fix of fretted-string-harmonics-in-tablature.ly snippet by Federico Bruni. This fixes erroneus notation, for example harmonics at the beginning should be an octave higher than base note, not two octaves higher. Description: doc: fixing s

Re: Bugfix for issue 1630 (issue4490045)

indent indent indent http://codereview.appspot.com/4490045/diff/25003/lily/tie-engraver.cc File lily/tie-engraver.cc (right): http://codereview.appspot.com/4490045/diff/25003/lily/tie-engraver.cc#newcode189 lily/tie-engraver.cc:189: /* On 2011/06/14 23:07:54, Graham Percival wrote: these shoul

Re: describing regression checking more explicitely (issue4621041)

As you wish :) http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode201 Documentation/contributor/r

doc: fixing snippet fretted-string-harmonics (issue4576062)

Reviewers: Graham Percival, fedelogy_gmail.com, Message: I shouldn't have called scripts/auxiliar/makelsr.py? Description: doc: fixing snippet fretted-string-harmonics I probably made it the wrong way - i changed Documentation/snippets/new/ fretted-string-harmonics-in-tablature.ly and called sc

Re: describing regression checking more explicitely (issue4621041)

@Graham: perfect! you caught exactly the subtleties which i was worrying that might be there! http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/4621041/diff/1/Documenta

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011/6/13 Trevor Daniels : Janek Warchoł wrote Monday, June 13, 2011 2:51 PM 2011/6/13  : a) It would be better to honour the value of 'gap if this is set by the user, rather than change a specifically requested gap value. My rationale is that it wouldn't make sense to set a big gap and

Re: Bugfix for issue 1630 (issue4490045)

Thanks to Neil's help, it's done. http://codereview.appspot.com/4490045/diff/30001/lily/tie-engraver.cc File lily/tie-engraver.cc (right): http://codereview.appspot.com/4490045/diff/30001/lily/tie-engraver.cc#newcode157 lily/tie-engraver.cc:157: maybe should check positions too. On 2011/06/14 2

describing regression checking more explicitely (issue4621041)

Reviewers: Graham Percival, james.lowe_datacore.com, Message: A small change to the CG to make things more obvious for the beginners. I hope that what i wrote is true ;) Rewording suggestions are most welcome. http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.i

Re: Bugfix for issue 1630 (issue4490045)

New patch set uploaded, i think all formatting issues are resolved. Should i run the regtests again? http://codereview.appspot.com/4490045/diff/20001/lily/completion-note-heads-engraver.cc File lily/completion-note-heads-engraver.cc (right): http://codereview.appspot.com/4490045/diff/20001/lily

Re: doc: changing example for overriding positions (issue4607043)

Style problems corrected. Thanks for review, Neil! http://codereview.appspot.com/4607043/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/4607043/diff/1/Documentation/learning/tweaks.itely#newcode2801 Documentation/learni

Re: ambitus: special handling of small ambits' lines (issue4609041)

On 2011/06/13 08:01:22, Trevor Daniels wrote: The interpersed comments make it very difficult to read the code. Could you place an abridged summary at the top instead? Done. I write a lot of comments so that rookies like me would be able to understand the code in finite time, if they happen to

ambitus: special handling of small ambits' lines (issue4609041)

Reviewers: Mike, Description: ambitus: special handling of small ambits' lines Until now, it was not possible to have all ambits look good: either the gaps between ambit line and heads were too big for ambits of 4th and 5th, or they were too small for other ambits. This patch introduces automati

doc: changing example for overriding positions (issue4607043)

Reviewers: Graham Percival, Description: doc: changing example for overriding positions example in LM 4.5.2 (fixing beam collision) is outdated because beam collision has been implemented, so there is nothing to fix. Therefore I change the type of collision to beam-tie collision. Please review

Re: separating flags from noteheads in font (issue4273119)

2011/6/11 : Looks good, but untested. I'll test it when I can. Ok. Don't forget to make clean in build/mf - there are still missing dependencies. Thanks! http://codereview.appspot.com/4273119/diff/3001/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): http://codereview.appspot.com/4

Re: separating flags from noteheads in font (issue4273119)

with Carl's help, new patch set was uploaded. Now the flags aren't squished, so it's perhaps ready to go :) http://codereview.appspot.com/4273119/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-de

Re: shortened flags: choosing appropriate flag (issue4410049)

On 2011/06/09 08:12:53, MikeSol wrote: Hey Janek, All the metafont stuff looks good! Last time we touched base, I recall that we had talked about looking into embedding a lot of this info into the font - did that prove to be not doable? Other than that, I have one comment below about t

Re: shortened flags: choosing appropriate flag (issue4410049)

Ian, thanks for review! http://codereview.appspot.com/4410049/diff/16001/input/regression/shortened-flags-cues.ly File input/regression/shortened-flags-cues.ly (right): http://codereview.appspot.com/4410049/diff/16001/input/regression/shortened-flags-cues.ly#newcode6 input/regression/shortened

Re: Bugfix for issue 1630 (issue4490045)

New patch set from Karin uploaded. http://codereview.appspot.com/4490045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Bugfix for issue 1630 (issue4490045)

New patches from Karin uploaded. I've got a warning while applying patch 0003 (about autosplit-remainder) to my repository, but it looks like its not fatal... I don't understand what it means, can anyone more experienced take a look and say whether there is anything to worry about? janek@janek-v

Re: Fattens the 256 first braces. (issue4518052)

LGTM. I like the results! http://codereview.appspot.com/4518052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix calculation of vertical offset when 'staff-padding is set (issue4489042)

Style nitpick. As for the code, i've read it, but unfortunately i'd have to study it a lot more to understand it (my poor programming skills, eh :/) http://codereview.appspot.com/4489042/diff/1/lily/side-position-interface.cc File lily/side-position-interface.cc (right): http://codereview.apps

Bugfix for issue 1630 (issue4490045)

Reviewers: karin_hoethker.de, Graham Percival, lemzwerg, carl.d.sorensen_gmail.com, Message: Finally i'm back in Warsaw and i'm uploading Karin's patch. Sorry for the delay :( Here's an archive with test file and output pdfs from before and after the patch: http://www.sendspace.com/file/gog5zh

Re: shortened flags: choosing appropriate flag (issue4410049)

http://codereview.appspot.com/4410049/diff/1/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4410049/diff/1/lily/stem.cc#newcode619 lily/stem.cc:619: static vector available_flag_lengths[2][5]; On 2011/04/18 03:42:53, hanwenn wrote: You cannot do this. This will screw u

shortened flags: choosing appropriate flag (issue4410049)

Reviewers: , Message: Passes regtests (i see a regression in partcombine-midi.ly, however from Graham's message about midi regtests http://lists.gnu.org/archive/html/lilypond-devel/2011-04/msg00283.html i understand that it's not my fault). If i understand correctly, the default way of calculati

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

New patch set uploaded. After a week of trying, there is probably nothing more that i can do. The code works, but could be easily improved by someone skillful. Any comments and help are welcome. cheers, Janek http://codereview.appspot.com/4312057/ __

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

New patch set uploaded, minor bugfix. http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

Sorry, i clicked "publish" button too fast. New patch set uploaded, 1 TODO partly eliminated. cheers, Janek http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

http://codereview.appspot.com/4312057/diff/10001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4312057/diff/10001/lily/stem.cc#newcode744 lily/stem.cc:744: flag_style = "standard"; Of course this will be properly encoded like other flag variants, as soon as i fint out how

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

New patch set uploaded. Font size is now taken into account when calculating flag variants (one TODO eliminated). cheers, Janek http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/

  1   2   >