Re: Brings beamed rest closer to cross staff beam. (issue 5908043)

2012-04-25 Thread milimetr88
http://codereview.appspot.com/5908043/diff/1/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/5908043/diff/1/lily/beam.cc#newcode1326 lily/beam.cc:1326: || beam-get_property_data (direction) == ly_symbol2scm (calculation-in-progress)) On 2012/04/25 06:29:14, mike7 wrote:

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread milimetr88
http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (left): http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc#oldcode68 lily/ledger-line-spanner.cc:68: while (flip (d) != DOWN); On 2012/04/25 11:47:07, Milimetr88

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-24 Thread milimetr88
Reviewers: Keith, Graham Percival, http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh File flower/include/direction.hh (right): http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh#newcode63 flower/include/direction.hh:63: // huh? On 2012/04/24

Re: Corrected comments and a function check_meshing_chords divided in two. (issue 5975054)

2012-04-15 Thread milimetr88
relatively to the staff. On 2012/04/14 19:12:01, Keith wrote: On 2012/04/14 13:56:18, Milimetr88 wrote: Relative to which element? relative to the staff Most English speakers think of this construction as an adjective, describing 'position', so we use the adjective form 'relative'. We see 'relatively

Re: Corrected style of comments (issue 5862052)

2012-03-31 Thread milimetr88
I'm sorry for that, but the next bunch of corrections are in a separate issue: http://codereview.appspot.com/5975054 It seems that following the procedure from http://lilypond.org/doc/v2.15/Documentation/contributor/commits-and-patches#uploading-a-patch-for-review does not make git-cl ask for

Corrected style of comments (issue 5862052)

2012-03-21 Thread milimetr88
Reviewers: , Message: This is a continuation of Issue: http://codereview.appspot.com/5651069/ Description: Corrected style of comments Please review this at http://codereview.appspot.com/5862052/ Affected files: M .gitignore M flower/include/direction.hh M lily/accidental-placement.cc

Re: some comments and complaints on the code (issue 5651069)

2012-03-21 Thread milimetr88
#newcode211 lily/accidental-placement.cc:211: * @return A vector of Accidental_placement_entrys On 2012/02/13 03:36:27, joeneeman wrote: On 2012/02/11 12:27:31, Milimetr88 wrote: Do you mean @param and @return or the comment to the function? What comment would you propose? I'm complaining

Re: some comments and complaints on the code (issue 5651069)

2012-02-11 Thread milimetr88
http://codereview.appspot.com/5651069/diff/1/lily/accidental-placement.cc File lily/accidental-placement.cc (right): http://codereview.appspot.com/5651069/diff/1/lily/accidental-placement.cc#newcode211 lily/accidental-placement.cc:211: * @return A vector of Accidental_placement_entrys Do you