Re: Add `-dfont-ps-resdir` option to embed fonts to PDFs later (issue 577900043 by truer...@gmail.com)

Please read my suggested changes carefully and amend, as I've no knowledge of the subject matter. https://codereview.appspot.com/577900043/diff/577910043/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/577900043/diff/577910043/Docu

Re: \compressFullBarRests should be renamed (issue 553750044 by v.villen...@gmail.com)

Thanks for picking this up and taking it over the finishing line, Valentin. LGTM apart from a couple of nits. Trevor https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): https://codereview.appspot.com/5537500

Re: Doc: Added documentation for fill-line line-width (issue 583340043 by davidgrant...@gmail.com)

LGTM Trevor https://codereview.appspot.com/583340043/

Re: Documentation: no \layout in markup-nested scores (issue 548590043 by v.villen...@gmail.com)

LGTM Trevor https://codereview.appspot.com/548590043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allow Scheme/identifiers for duration multipliers (issue 346810043 by d...@gnu.org)

The proposed documentation looks fine to me. Trevor https://codereview.appspot.com/346810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Clarify notation for slurs and beams (issue 343060043 by carl.d.soren...@gmail.com)

https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely#newcode495 Documentation/learning/fundamental.itely:495

Re: Clarify notation for slurs and beams (issue 343060043 by carl.d.soren...@gmail.com)

Hi Carl Another minor nit! Otherwise looks fine. Trevor https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.

Re: Clarify notation for slurs and beams (issue 343060043 by carl.d.soren...@gmail.com)

Hi Carl LGTM, with a couple of minor comments. Trevor https://codereview.appspot.com/343060043/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/343060043/diff/1/Documentation/learning/fundamental.itely#newco

Re: Doc: NR - rhythms.itely minor edits to Durations (issue 336030043 by pkx1...@gmail.com)

https://codereview.appspot.com/336030043/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/336030043/diff/1/Documentation/notation/rhythms.itely#newcode93 Documentation/notation/rhythms.itely:93: music sequence will take

Doc: NR - rhythms.itely minor edits to Durations (issue 336030043 by pkx1...@gmail.com)

Apart from a duplicated para this LGTM. Trevor https://codereview.appspot.com/336030043/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/336030043/diff/1/Documentation/notation/rhythms.itely#newcode93 Documentation/no

Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and conver… (issue 323040043 by chazwi...@gmail.com)

Looks OK as far as it goes, but the Docs have been missed. Trevor https://codereview.appspot.com/323040043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

On 2017/05/21 17:12:26, thomasmorley651 wrote: I'd like to mention another point: What to do with pitched rests and rests with user-set staff-position, merge them automatically to the zero-position? If a user has explicitly set the position of a rest this should be honoured by default, I thin

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

LGTM David, you've found an excellent way of squaring the circle! Trevor https://codereview.appspot.com/320820043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: LM - Fundamental - 3.3.2 Creating contexts (issue 312540043 by pkx1...@gmail.com)

LGTM Trevor https://codereview.appspot.com/312540043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

CG: Update info - how to request access to tracker (issue 320180043 by pkx1...@gmail.com)

LGTM, apart from a minor nit. As Phil says - no need to wait for a review cycle. https://codereview.appspot.com/320180043/diff/1/Documentation/contributor/quick-start.itexi File Documentation/contributor/quick-start.itexi (right): https://codereview.appspot.com/320180043/diff/1/Documentation/c

Re: LM: Replace \set Staff.instrumentName (issue 314390043 by pkx1...@gmail.com)

LGTM Trevor https://codereview.appspot.com/314390043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: NR 1.2.1.d: Split note correctly (issue 319940043 by thomasmorle...@gmail.com)

LGTM Trevor https://codereview.appspot.com/319940043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

LGTM, with the trivial suggestions indicated below to the NR, but I'm not competent to check the code sections. The use of "__" has been expunged completely: should we not retain a brief mention perhaps for use when the user has turned auto extenders off? Trevor https://codereview.appspot.co

Re: Doc: Add a section about handling MIDI dynamics with multiple voices (issue 302930043 by ht.lilypond.developm...@gmail.com)

Much improved over the first attempt, thanks. LGTM. Trevor https://codereview.appspot.com/302930043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Don't use @code inside of @example (issue 304810043 by d...@gnu.org)

LGTM Trevor https://codereview.appspot.com/304810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: NR: Mention standalone accidentals in figuremode (issue 299510043 by g...@ursliska.de)

LGTM Trevor https://codereview.appspot.com/299510043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Remove unescaped @funindex entries (issue 295570043 by d...@gnu.org)

Excellent! I've wanted to do this for years, but lacked the scripting skills to do it. Trevor https://codereview.appspot.com/295570043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: CG - replace all references of Google Code (issue 294820044 by pkx1...@gmail.com)

See below. LGTM now. Trevor https://codereview.appspot.com/294820044/diff/1/Documentation/contributor/issues.itexi File Documentation/contributor/issues.itexi (right): https://codereview.appspot.com/294820044/diff/1/Documentation/contributor/issues.itexi#newcode1021 Documentation/contributor

Re: Doc: CG - replace all references of Google Code (issue 294820044 by pkx1...@gmail.com)

New stuff looks OK, but I'm concerned about the deleted section. https://codereview.appspot.com/294820044/diff/1/Documentation/contributor/issues.itexi File Documentation/contributor/issues.itexi (right): https://codereview.appspot.com/294820044/diff/1/Documentation/contributor/issues.itexi#new

Re: Improve beam count handling with subdivided beams (issue 276560043 by g...@ursliska.de)

On 2015/12/22 18:34:43, git wrote: https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly File Documentation/snippets/subdividing-beams.ly (right): https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly#newcode7

Fix documentation of \once \partcombine* (issue 280940043 by d...@gnu.org)

LGTM, apart from a pre-existing typo. https://codereview.appspot.com/280940043/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): https://codereview.appspot.com/280940043/diff/1/Documentation/notation/simultaneous.itely#newcode1030 Documenta

Re: Implement rounded-box whiteout style (issue 274590043 by paulwmor...@gmail.com)

LGTM When this is pushed we ought to raise an issue to document whiteout properly in the NR. https://codereview.appspot.com/274590043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: LM - Document tweaking of StaffSymbol and LedgerLineSpanner (issue 275490043 by pkx1...@gmail.com)

LGTM https://codereview.appspot.com/275490043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: CG - Updated the Meister's section (issue 276980044 by pkx1...@gmail.com)

Much clearer, James. LGTM, apart from a couple of nits. https://codereview.appspot.com/276980044/diff/1/Documentation/contributor/administration.itexi File Documentation/contributor/administration.itexi (right): https://codereview.appspot.com/276980044/diff/1/Documentation/contributor/administ

Re: Ensure one beam is left in subdivided beams (issue 278060043 by lilyli...@googlemail.com)

LGTM https://codereview.appspot.com/278060043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

LGTM, apart from an oversight, although this is based on just eye-balling. https://codereview.appspot.com/270640043/diff/11/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/270640043/diff/11/scm/define-markup-commands.scm#newcod

Doc: NR Clarify repeats w\ partials and barchecks (issue 277940043 by pkx1...@gmail.com)

LGTM https://codereview.appspot.com/277940043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

https://codereview.appspot.com/270640043/diff/60001/scm/define-markup-commands.scm#newcode623 > > scm/define-markup-commands.scm:623: (direction DOWN) > > Should this markup command be called "undertie" or should it rather be "tie", > > with "undertie" explicitly overriding `direction'? > > >

Re: Doc: Usage - Update svg & svg-woff backend text (issue 274260043 by pkx1...@gmail.com)

I can't vouch for the technicalities, but LGTM apart from a few typos. https://codereview.appspot.com/274260043/diff/40001/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/274260043/diff/40001/Documentation/usage/running.itely#newc

Re: Issue 4504/5 update changes.tely (issue 275770043 by paulwmor...@gmail.com)

I raise a couple of questions - maybe I'm not understanding something. https://codereview.appspot.com/275770043/diff/1/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): https://codereview.appspot.com/275770043/diff/1/scm/define-grob-properties.scm#newcode1143 scm/defin

Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by nine.fierce.ball...@gmail.com)

https://codereview.appspot.com/265410043/diff/60001/lily/part-combine-iterator.cc File lily/part-combine-iterator.cc (right): https://codereview.appspot.com/265410043/diff/60001/lily/part-combine-iterator.cc#newcode146 lily/part-combine-iterator.cc:146: // get_event_length(), which reads "length

Re: Create \= command for setting spanner-id (issue 268050045 by d...@gnu.org)

LGTM https://codereview.appspot.com/268050045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Included/compile.itexi - CG 4.2 - Updated notes on reqs for compiling (issue 261430043 by pkx1...@gmail.com)

Not being overly familiar with *nix I can't vouch for the technicalities and syntax, but the general text looks fine (apart from a couple of trivial typos). So LGTM. https://codereview.appspot.com/261430043/diff/1/Documentation/included/compile.itexi File Documentation/included/compile.itexi (

Doc: CG - remove link to R. Kainhofer's doc builds (issue 266960043 by pkx1...@gmail.com)

LGTM https://codereview.appspot.com/266960043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Usage - Updated 'Running LilyPond' intros (issue 261240043 by pkx1...@gmail.com)

You don't appear to have changed the menus in the translations, but I would strongly recommend leaving all the translations to the translators - unless you can translate the modified headings into Czech and Japanese. https://codereview.appspot.com/261240043/diff/20001/Documentation/usage/running

Issue 4595: NR: Describe default fonts as TeX Gyre fonts (issue 268780043 by truer...@gmail.com)

LGTM https://codereview.appspot.com/268780043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Web: Download.itexi - expand on Windows install (issue 258680043 by p...@gnu.org)

LGTM https://codereview.appspot.com/258680043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Authors - Updated authors.itexi (issue 258660043 by p...@gnu.org)

https://codereview.appspot.com/258660043/diff/1/Documentation/included/authors.itexi File Documentation/included/authors.itexi (left): https://codereview.appspot.com/258660043/diff/1/Documentation/included/authors.itexi#oldcode199 Documentation/included/authors.itexi:199: Abraham Lee I think Abr

Re: Improve wording for an NR paragraph (issue 259710043 by simon.albre...@mail.de)

LGTM Trevor https://codereview.appspot.com/259710043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 347: document that ragged-bottom = #t overrides ragged-last-bottom (issue 257280043 by d...@gnu.org)

On 2015/08/11 11:25:23, dak wrote: On 2015/08/11 10:48:24, Trevor Daniels wrote: > https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely > File Documentation/notation/spacing.itely (right): > > https://codereview.appspot.com/257280043/diff/1/Documentation/notat

Re: Issue 347: document that ragged-bottom = #t overrides ragged-last-bottom (issue 257280043 by d...@gnu.org)

https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely#newcode383 Documentation/notation/spacing.itely:383: @code{ragged-last-bott

Issue 347: document that ragged-bottom = #t overrides ragged-last-bottom (issue 257280043 by d...@gnu.org)

https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/257280043/diff/1/Documentation/notation/spacing.itely#newcode383 Documentation/notation/spacing.itely:383: @code{ragged-last-bott

Re: Doc: Usage - Update section on articulate.ly (issue 259130043 by pkx1...@gmail.com)

https://codereview.appspot.com/259130043/diff/20001/Documentation/usage/external.itely File Documentation/usage/external.itely (right): https://codereview.appspot.com/259130043/diff/20001/Documentation/usage/external.itely#newcode780 Documentation/usage/external.itely:780: @rweb{Easier editing}

Doc: Issue 4528/3 Document ssaattbb.ly built-in template (issue 256340043 by tdanielsmu...@googlemail.com)

Reviewers: , https://codereview.appspot.com/256340043/diff/1/input/regression/ssaattbb-template-with-changed-instrument-names.ly File input/regression/ssaattbb-template-with-changed-instrument-names.ly (left): https://codereview.appspot.com/256340043/diff/1/input/regression/ssaattbb-template-wi

Issue 4338: fix revocery description of \octaveCheck (issue 255570043 by d...@gnu.org)

LTGM Trevor https://codereview.appspot.com/255570043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: NR Changing Defaults: document \etc (issue 256990043 by d...@gnu.org)

Apart from nitpicking, doc changes LGTM Trevor https://codereview.appspot.com/256990043/diff/20001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/256990043/diff/20001/Documentation/notation/changing-de

Doc: CG - Tightening up of the Bug Squad intro (issue 254370043 by pkx1...@gmail.com)

LGTM, apart from a trivial typo. Trevor https://codereview.appspot.com/254370043/diff/1/Documentation/contributor/issues.itexi File Documentation/contributor/issues.itexi (right): https://codereview.appspot.com/254370043/diff/1/Documentation/contributor/issues.itexi#newcode22 Documentation/co

Re: Doc: Glossary - add notes for High Bass Clef (issue 256090043 by pkx1...@gmail.com)

LGTM Trevor https://codereview.appspot.com/256090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: NR add @knownissues for Percent Repeats (issue 250530043 by pkx1...@gmail.com)

https://codereview.appspot.com/250530043/diff/1/Documentation/notation/repeats.itely File Documentation/notation/repeats.itely (right): https://codereview.appspot.com/250530043/diff/1/Documentation/notation/repeats.itely#newcode764 Documentation/notation/repeats.itely:764: @knownissues @knowniss

Doc: Usage - OOoLilyPond only works up to v4 (issue 255280043 by pkx1...@gmail.com)

https://codereview.appspot.com/255280043/diff/1/Documentation/usage/external.itely File Documentation/usage/external.itely (right): https://codereview.appspot.com/255280043/diff/1/Documentation/usage/external.itely#newcode726 Documentation/usage/external.itely:726: OpenOffice.org extension that

Re: Issue 4495 Remove unnecessary #{ .. #} constructs (issue 253310043 by tdanielsmu...@googlemail.com)

Thanks David https://codereview.appspot.com/253310043/diff/1/ly/staff-tkit.ly File ly/staff-tkit.ly (right): https://codereview.appspot.com/253310043/diff/1/ly/staff-tkit.ly#newcode60 ly/staff-tkit.ly:60: #(if dynUp On 2015/07/18 22:02:54, dak wrote: elseif cascades are bad to read in Scheme's

Implement partial function calls. (issue 249670043 by d...@gnu.org)

If I understand this correctly it permits a variable definition to be used in some circumstances where a music function definition would previously have been required to achieve the same effect. That seems a worthwhile improvement and simplification. Trevor https://codereview.appspot.com/24967

Re: Doc: Issue 4059: Document MIDI mapping and MIDI effects (issue 249980043 by tdanielsmu...@googlemail.com)

Reviewers: Keith, https://codereview.appspot.com/249980043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/249980043/diff/1/Documentation/notation/input.itely#newcode3279 Documentation/notation/input.itely:3279: @ref{MIDI

Python-ly to indent ../input/regression/a* (issue 249270044 by pkx1...@gmail.com)

On balance the indentation is improved, but there are a few cases which are worse, IMHO. With a follow-up hand-indentation to "uncorrect" the worst cases this would be worth doing, if just to remove the tabs. Trevor https://codereview.appspot.com/249270044/diff/1/input/regression/alignment-ve

Doc: NR Update information for modern-cautionary (issue 252770043 by pkx1...@gmail.com)

LGTM Trevor https://codereview.appspot.com/252770043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: avoid implicit \relative; issue 4371 (issue 237340043 by k-ohara5...@oco.net)

LGTM Thanks Keith https://codereview.appspot.com/237340043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: avoid implicit \relative; issue 4371 (issue 237340043 by k-ohara5...@oco.net)

I'm generally happy with this, but I've made quite a few nit-picking comments. I think it is important that the manuals rigorously show a consistent style, particularly with regard to indentation and the placement of block delimiters. We frequently criticise users presenting examples on the mail

Re: Make music functions callable from Scheme (issue 244840043 by d...@gnu.org)

Just querying a strange sentence. https://codereview.appspot.com/244840043/diff/11/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/244840043/diff/11/Documentation/changes.tely#newcode69 Documentation/changes.tely:69: matching based will

Re: Make music functions callable from Scheme (issue 244840043 by d...@gnu.org)

Well, I can't say LGTM as that would imply I'd understood it and could confirm its correctness, but I can say I'm looking forward to removing lots of the #{ ... #} in the satb.ly template and its supporting cast! Trevor https://codereview.appspot.com/244840043/

Docs: clean up after \relative conversion (issue 239250043 by k-ohara5...@oco.net)

Apart from a really trivial nitpick, LGTM (but I haven't checked if anything has been missed) Trevor https://codereview.appspot.com/239250043/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/239250043/diff/1/Document

Re: Some updates to the ancient music section (issue 240810043 by philehol...@googlemail.com)

LGTM Trevor https://codereview.appspot.com/240810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

On 2015/05/17 21:09:13, dak wrote: At any rate, if we were to retain both \fixed and \absolute, I strongly prefer just two input modes, \relative and \absolute, but as I said right at the beginning: ... I'd prefer the syntax and options [of \absolute] to parallel those of \relative. That

Doc: avoid implicit \relative; issue 4371 (issue 237340043 by k-ohara5...@oco.net)

I'm not opposed to the change to explicit \relative; it avoids having to explain why it was omitted in the examples, and makes the example code more exactly correspond to the code obtained by clicking on the image. But I think if are to make this change it would also be good to say what leaving ou

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

On 2015/05/17 10:44:36, dak wrote: Well, I remain unenthused about the new name. Maybe get a vote on the user list, with options \absolute x'', \fixed x'', \octave x''? I think those were pretty much the terms mentioned significantly more than once. The proper name for this would \absolu

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

On 2015/05/17 07:36:01, Keith wrote: On 2015/05/15 06:12:38, lemzwerg wrote: > Given that we are currently producing development > releases, I suggest that this gets implemented, > then we simply wait a few months so that people can > test it in real life, and then we do a final decision. If w

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

On 2015/05/06 15:57:21, wl_gnu.org wrote: > Probably the best name is \octave, which was used for something > similar > until version 0.1.19 > > \octave c'' {c4 e g c e g c'1} Sounds OK for me. Werner So is this proposing three entry modes: \relative (unchanged) \absolute

Re: Update incipit snippets (issue 235980043 by philehol...@googlemail.com)

I haven't checked incipit.ly, but otherwise it looks fine apart from what appears to be an inadvertent change which needs investigating. https://codereview.appspot.com/235980043/diff/1/Documentation/snippets/conducting-signs,-measure-grouping-signs.ly File Documentation/snippets/conducting-signs

Re: Document incipit command (issue 232180043 by philehol...@googlemail.com)

On 2015/05/05 12:07:32, mail_philholmes.net wrote: I read the CG on *index entries, and experimented a fair amount, but never quite got to understand the difference. Is cindex the Command index only? Should it be @cindex \incipit or @cindex incipit? Or both? And funindex is the main ind

Re: Document incipit command (issue 232180043 by philehol...@googlemail.com)

One suggestion, otherwise LGTM. https://codereview.appspot.com/232180043/diff/1/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/232180043/diff/1/Documentation/notation/ancient.itely#newcode2651 Documentation/notation/ancient

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

On 2015/05/03 20:25:22, dak wrote: Again: I don't think that this was Keith's proposal. And I am pretty sure that none of my suggestions was Keith's proposal either: I just angle for something useful to do with \absolute f. It wasn't Keith's proposal, you're right, I rather ran on ahead.

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

On 2015/05/03 09:02:51, dak wrote: However, I _think_ that your comment would suggest \absolute f'' { f ... to be the same as \absolute { f'' ... Correct whereas I suggested making \absolute f'' { f ... the same as \absolute { bes'' ... Now there _is_ a difference between \relative c an

Re: Partcombiner documentation (Issue 4307) (issue 233110043 by philehol...@googlemail.com)

LGTM. Trevor https://codereview.appspot.com/233110043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Update NR font size section (Issue 3370) (issue 235920043 by philehol...@googlemail.com)

LGTM Trevor https://codereview.appspot.com/235920043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Partcombiner documentation (Issue 4307) (issue 233110043 by philehol...@googlemail.com)

Good point, Phil. Perhaps we should slightly amend the text too to cover this feature, as shown. Trevor https://codereview.appspot.com/233110043/diff/20001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): https://codereview.appspot.com/2331100

Re: absolute pitch entry: accept an offset octave (issue 235010043 by k-ohara5...@oco.net)

I'm in favour of a change like this, but I'd prefer the syntax and options to parallel those of \relative. That is, an optional prefix pitch to indicate the starting octave, and taking the starting octave from the first contained note if the prefix is omitted. That would then become an attractiv

Re: Partcombiner documentation (Issue 4307) (issue 233110043 by philehol...@googlemail.com)

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely#newcode931 Documentation/notation/simultaneous.itely:931: @n

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

Hi James I'm happy with this now. Thanks for being so forbearing and persistent in the face of all the criticism. So, LGTM! Trevor https://codereview.appspot.com/120480043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.o

Re: Doc Issue 4350: \compressFullBarRests needs a warning (issue 227470043 by tdanielsmu...@googlemail.com)

Reviewers: Jean-Charles, https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely#newcode3193 Documentation/learning/fu

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

I can't compile LP at the moment, but LGTM from eye-balling. How pleasing it took just two extra lines! Trevor https://codereview.appspot.com/226700043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/li

Re: Issue 3799: New satb.ly built-in template and template framework (issue 225860043 by tdanielsmu...@googlemail.com)

On 2015/04/21 19:58:34, dak wrote: Is Women/Men the correct nomenclature or would it rather be female/male [voice types]? As an alto I'd prefer the least sexist designation as long as it matches typical usage. "Men" is commonly seen in vocal scores, certainly in Oxford and Novello publica

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

On 2015/04/20 16:31:52, J_lowe wrote: https://codereview.appspot.com/120480043/diff/240001/Documentation/notation/input.itely#newcode2732 Documentation/notation/input.itely:2732: accent, marcato and portato. On 2014/12/28 23:40:29, Trevor Daniels wrote: > We need a proper list here showing clea

Re: Issue 3799: New satb.ly built-in template and template framework (issue 225860043 by tdanielsmu...@googlemail.com)

On 2015/04/18 15:30:06, Trevor Daniels wrote: Fix file names of two more regression tests Sorry for the extra work James. Three out of four regression tests had missing hyphens! Windows, perhaps unfortunately, is quite happy with file names containing spaces, so I saw no errors here. Trevor

Re: Issue 3799: New satb.ly built-in template and template framework (issue 225860043 by tdanielsmu...@googlemail.com)

Patch set 2 contains a number of code improvements as well as four regression tests and a (minimal) change to the documentation. The main changes from patch set 1 are: - There is now a distinction between Women/Men music variables in their own right and WomenDivided/MenDivided variables which ar

Re: Issue 3799: New satb.ly built-in template and template framework (issue 225860043 by tdanielsmu...@googlemail.com)

message: On 2015/04/08 01:54:02, Dan Eble wrote: Thanks for looking, Dan To support TTBB, would you generalize this template further, or would you create something new? My intention is to add an ssaattbb template once this patch has been installed. This would have three staves for each part

Issue 3799: New satb.ly built-in template and template framework (issue 225860043 by tdanielsmu...@googlemail.com)

Reviewers: , Message: This patch is posted for comment and improvement rather than a candidate for immediate inclusion in the code base. Some caveats/issues/questions: \includes are used for testing; later, perhaps after settling on the file names, these may not be necessary. Indenting is prob

Re: Fix TODO with markup padding and fix buggy example in LM (issue 225840043 by philehol...@googlemail.com)

LGTM Trevor https://codereview.appspot.com/225840043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm File scm/define-music-types.scm (right): https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm#newcode343 scm/define-music-types.scm:343: (types . ()) On 2015/04/01 15:16:07, david.nalesnik wrote: Sh

Doc: Issue 4309: Clarify the warning about bare durations (issue 203640043 by tdanielsmu...@googlemail.com)

Reviewers: , Message: Pushed to staging as 67e08daacdeb384724e18a31597d9d828ac40f51 Closing ... Description: Doc: Issue 4309: Clarify the warning about bare durations Please review this at https://codereview.appspot.com/203640043/ Affected files (+4, -4 lines): M Documentation/learning/comm

Docs: Issue 4181: Expose \stemUp and \stemDown predefs less (issue 214870044 by tdanielsmu...@googlemail.com)

Reviewers: , Message: This patch eliminates virtually all mention of the \stemUp and \stemDown predefs from the LM. Most of the uses of these predefs in the NR are sensible, so I have left untouched the ones in ancient, editorial, percussion and staff. Apart from the bald mention in staff, thes

Doc: Internals - dash-fraction when set to 0.0 (issue 198150043 by pkx1...@gmail.com)

This is definitely an improvement, so LGTM. (As David mentioned earlier, there seem to be discrepancies between what one might expect when setting dash-fraction and the actual result, but this at least makes the documentation self-consistent.) https://codereview.appspot.com/198150043/ _

Re: property to set voiced-rest positions; issue 3902 (issue 188580043 by k-ohara5...@oco.net)

LGTM Trevor https://codereview.appspot.com/188580043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc; CG - add more specific note for Guile (issue 193870043 by pkx1...@gmail.com)

On 2015/01/02 00:22:11, J_lowe wrote: On 2015/01/02 00:09:19, Trevor Daniels wrote: > https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi > File Documentation/included/compile.itexi (right): > > https://codereview.appspot.com/193870043/diff/1/Documentation/in

Doc; CG - add more specific note for Guile (issue 193870043 by pkx1...@gmail.com)

https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi File Documentation/included/compile.itexi (right): https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi#newcode78 Documentation/included/compile.itexi:78: (1.8.8 - version 2.x is

Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by pkx1...@gmail.com)

James We've now had so many iterations of this I'd lost track of where we were up to with incremental changes and started over. I think much of it is improved, but some basic information has been lost and/or buried. I've tried to indicate as clearly (starkly might be more accurate) as possible

Re: compare LilyPond Rationals without unnecessary overflow; issue 4180 (issue 194770043 by k-ohara5...@oco.net)

LGTM Trevor https://codereview.appspot.com/194770043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

  1   2   3   4   5   6   >