I gather this is connected to issue 684, so it should probably be marked
closed, Jan.
Thanks,
Colin
http://codereview.appspot.com/1579041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2010/08/30 07:41:55, janneke-list_xs4all.nl wrote:
Thanks!
There seems to be no difference in the metronome-marking-break-align
regression test file, you'll want to amend it so that it shows what
is fixed.
Yes, I found that slightly puzzling, since your patch produced
verifiable changes
Op zondag 29-08-2010 om 23:27 uur [tijdzone +], schreef
n.putt...@gmail.com:
Neil,
I've posted a fix for all these issues here:
http://codereview.appspot.com/2042043/
Thanks!
There seems to be no difference in the metronome-marking-break-align
regression test file, you'll want to amend
http://codereview.appspot.com/1579041/diff/42001/43004
File lily/metronome-engraver.cc (right):
http://codereview.appspot.com/1579041/diff/42001/43004#newcode109
lily/metronome-engraver.cc:109: }
this is out of style with the rest of lilypond code base.
The normal pattern is to use
On Sun, Aug 29, 2010 at 3:54 PM, Jan Nieuwenhuizen
janneke-l...@xs4all.nl wrote:
Op zondag 29-08-2010 om 18:04 uur [tijdzone +], schreef
hanw...@gmail.com:
http://codereview.appspot.com/1579041/diff/42001/43004#newcode109
lily/metronome-engraver.cc:109: }
this is out of style with the
Op zondag 29-08-2010 om 18:04 uur [tijdzone +], schreef
hanw...@gmail.com:
http://codereview.appspot.com/1579041/diff/42001/43004#newcode109
lily/metronome-engraver.cc:109: }
this is out of style with the rest of lilypond code base.
The normal pattern is to use
First, great to see that this feature has finally been implemented and
pushed.
Unfortunately, it seems that it needs some small tweaking, still. The
problem is that the metronome mark is now placed directly above the key
signature, while Gardner Read says that it is aligned over the meter
http://codereview.appspot.com/1579041/diff/42001/43004
File lily/metronome-engraver.cc (right):
http://codereview.appspot.com/1579041/diff/42001/43004#newcode81
lily/metronome-engraver.cc:81: }
is there a reason you are worried about cyclical data structures? I
don't think we check for them
Op zondag 29-08-2010 om 20:09 uur [tijdzone +], schreef
hanw...@gmail.com:
http://codereview.appspot.com/1579041/diff/42001/43004
File lily/metronome-engraver.cc (right):
http://codereview.appspot.com/1579041/diff/42001/43004#newcode81
lily/metronome-engraver.cc:81: }
is there a reason
On Sun, Aug 29, 2010 at 5:21 PM, Jan Nieuwenhuizen
janneke-l...@xs4all.nl wrote:
It's not cyclic, the idea was about not crashing when the data
structure is not a list at all.
I think Neil had a remark about this.
Most of the similar code uses scm_c_memq instead, which skips the
checking.
On 2010/08/29 19:54:28, Reinhold wrote:
First, great to see that this feature has finally been implemented and
pushed.
Unfortunately, it seems that it needs some small tweaking, still. The
problem is
that the metronome mark is now placed directly above the key
signature, while
Gardner Read
On 2010/08/29 22:02:18, Neil Puttock wrote:
On 2010/08/29 19:54:28, Reinhold wrote:
First, great to see that this feature has finally been implemented
and pushed.
Unfortunately, it seems that it needs some small tweaking, still.
The problem
is
that the metronome mark is now placed
Thanks. Applied and set to Fixed.
http://codereview.appspot.com/1579041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Jan,
I've tested the latest patch thoroughly, and it seems fine for the most
part.
The only niggle I've come across is with full-bar rests at the start of
a system:
\relative c' {
c1 \break
\tempo 4 = 60
R1
}
\paper { ragged-right = ##t }
Ideally, the tempo mark would be positioned
On 2010/08/24 13:26:14, jan.nieuwenhuizen wrote:
Obviously, I missed your last set of comments.
I removed metronome-mark from the break-aligned lists and
removed the break-aligned-interface.
The self-alignment-interface was already added in a previous
version of the patch, I think.
From whom?
Obviously, I missed your last set of comments.
I removed metronome-mark from the break-aligned lists and
removed the break-aligned-interface.
The self-alignment-interface was already added in a previous
version of the patch, I think.
OK, so it's unlikely, but a user might use a
On 2010/07/27 14:14:12, janneke-list_xs4all.nl wrote:
I'm waiting for an ack.
From whom?
http://codereview.appspot.com/1579041/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Am Sonntag, 20. Juni 2010, 23:57:20 schrieb n.putt...@gmail.com:
Here are some more comments for you.
What happened to this patch? AFAICS, it has not been pushed to master, right?
I'm just afraid that it might be forgotten, which would be very bad, since I
need this in LilyPond, too...
Op dinsdag 27-07-2010 om 15:45 uur [tijdzone +0200], schreef Reinhold
Kainhofer:
What happened to this patch? AFAICS, it has not been pushed to master, right?
I'm waiting for an ack.
Greetings,
Jan.
--
Jan Nieuwenhuizen jann...@gnu.org | GNU LilyPond http://lilypond.org
Freelance IT
Hi Jan,
On 2010/06/22 19:01:58, jan.nieuwenhuizen wrote:
Alas, it can't. When adding staff-bar to that list, the broken
marks appear next to the bar numbers, right at the start of the
staves.
That's a shame. It would be great if the symbol order in
'break-align-symbols determined the
Op zondag 04-07-2010 om 19:54 uur [tijdzone +], schreef
n.putt...@gmail.com:
Alas, it can't. When adding staff-bar to that list, the broken
marks appear next to the bar numbers, right at the start of the
staves.
That's a shame. It would be great if the symbol order in
On 2010/07/04 20:36:28, janneke-list_xs4all.nl wrote:
It does. The symbol order does determine the priority.
Hmm, this doesn't appear to be the case, since key signatures are
preferred over time signatures for aligning.
Problem is,
at start of a stave the *only* symbol that is present is
http://codereview.appspot.com/1579041/diff/30001/31004
File lily/metronome-engraver.cc (right):
http://codereview.appspot.com/1579041/diff/30001/31004#newcode82
lily/metronome-engraver.cc:82: g-get_property_data
(break-align-symbol)
text_-get_property (break-align-symbol)
OK, so it's
So, how are we doing here? Ready to commit close
http://code.google.com/p/lilypond/issues/detail?id=684
http://codereview.appspot.com/1579041/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Hi Jan,
On 2010/07/01 08:08:36, jan.nieuwenhuizen wrote:
So, how are we doing here? Ready to commit close
I'm testing the latest set at the moment; will report back with more
comments.
Cheers,
Neil
http://codereview.appspot.com/1579041/show
On 2010/06/20 21:57:20, Neil Puttock wrote:
AARGH. Again this web interface eats my email.
Is anyone using this, it is so frustrating. I'm going to
try using plain email response now.
http://codereview.appspot.com/1579041/show
___
lilypond-devel
Hi Neil,
Not sure how to find the email address to bind this
to http://codereview.appspot.com/1579041 ?
http://codereview.appspot.com/1579041/diff/19001/20003#newcode82
lily/metronome-engraver.cc:82: == ly_symbol2scm (staff-bar))
can't this be incorporated into 'break-align-symbols for
Hi Jan,
Here are some more comments for you.
Cheers,
Neil
http://codereview.appspot.com/1579041/diff/19001/20003
File lily/metronome-engraver.cc (right):
http://codereview.appspot.com/1579041/diff/19001/20003#newcode81
lily/metronome-engraver.cc:81: g-get_property_data
(break-align-symbol)
Reviewers: Neil Puttock,
Message:
On 2010/06/08 22:22:43, Neil Puttock wrote:
Comments processed in patch 4 5.
Here are a few thoughts on positioning:
-) A metronome mark at a full-bar rest should be aligned with the
barline
instead of the paper column to the left of the rest.
This is
Hi Jan,
On 2010/06/16 12:08:06, jan.nieuwenhuizen wrote:
On 2010/06/08 22:22:43, Neil Puttock wrote:
-) A metronome mark at a full-bar rest should be aligned with the
barline
instead of the paper column to the left of the rest.
This is not in Read or #684's description...
See
Hi Jan,
I've tested the latest patch, and it looks pretty good so far.
Here are a few thoughts on positioning:
-) A metronome mark at a full-bar rest should be aligned with the
barline instead of the paper column to the left of the rest.
-) If there's a tempo change at a key signature, the
Hi Jan,
Have you checked what happens with full-bar rests?
I haven't tested your patch, but it's similar to the one I posted, which
suffers from invisible tempo marks at full-bar rests.
Cheers,
Neil
http://codereview.appspot.com/1579041/diff/2001/3001
File lily/metronome-engraver.cc (right):
Op maandag 07-06-2010 om 16:59 uur [tijdzone +], schreef
n.putt...@gmail.com:
Hi Neil,
Have you checked what happens with full-bar rests?
Uhuh, I have now ;-)
I haven't tested your patch, but it's similar to the one I posted, which
suffers from invisible tempo marks at full-bar rests.
33 matches
Mail list logo
