Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

LGTM http://codereview.appspot.com/4278058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

LGTM. http://codereview.appspot.com/4278058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

LGTM. http://codereview.appspot.com/4278058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On 2011/03/22 06:28:42, joeneeman wrote: In that case, a better way to avoid too many warnings might be just to add a static bool to check if a warning has already been issued. Done, and removed the original code that had no effect. Given that the old code merely printed warning, the warning te

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On Mon, Mar 21, 2011 at 11:18 PM, Keith OHara wrote: > On Mon, 21 Mar 2011 23:06:12 -0700, Joe Neeman > wrote: > > >> Unfortunately, if I protect the assignment to the property with an if >>> (!pure), I am letting the page-breaking planning rely on the >>> user-requested >>> affinities, and th

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On Mon, 21 Mar 2011 23:06:12 -0700, Joe Neeman wrote: Unfortunately, if I protect the assignment to the property with an if (!pure), I am letting the page-breaking planning rely on the user-requested affinities, and then changing them for the page-layout phase. The boolean 'pure' asks expli

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On Mon, Mar 21, 2011 at 8:11 PM, Keith OHara wrote: > On Sat, 19 Mar 2011 22:46:51 -0700, Joe Neeman > wrote: > >> >> It might cause problems if "pure" is true. When the method is called with >> "pure," it shouldn't cause any side effects. For a concrete example, this >> will mess up if you have

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On Sat, 19 Mar 2011 22:46:51 -0700, Joe Neeman wrote: It might cause problems if "pure" is true. When the method is called with "pure," it shouldn't cause any side effects. For a concrete example, this will mess up if you have Staff Lyrics with affinity down Staff that sometimes disappears Lyr

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On 2011/03/20 07:45:11, Keith wrote: On Sun, 20 Mar 2011 00:17:48 -0700, Joe Neeman wrote: > On Sat, Mar 19, 2011 at 11:58 PM, wrote: > > In that case, is there any need to set after_affinity at all? > I could ask the author of the ori

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On Sun, 20 Mar 2011 00:17:48 -0700, Joe Neeman wrote: On Sat, Mar 19, 2011 at 11:58 PM, wrote: In that case, is there any need to set after_affinity at all? I could ask the author of the original code the same question :) I think yes. As commentary. It assures the reader that LilyPond is p

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On Sat, Mar 19, 2011 at 11:58 PM, wrote: > On 2011/03/20 05:46:51, joeneeman wrote: > >> This can be fixed by adding >> if (!pure) >> > > Thanks very much. > > Just in case anybody wonders, we can safely put the assignment to > after_affinity inside the if (!pure) with no change, because that >

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On 2011/03/20 05:46:51, joeneeman wrote: This can be fixed by adding if (!pure) Thanks very much. Just in case anybody wonders, we can safely put the assignment to after_affinity inside the if (!pure) with no change, because that assignment can't change behavior. If after_affinity > before_

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On Sat, Mar 19, 2011 at 7:03 PM, wrote: > LGTM. > I can't think of a case where updating `after' would cause problems - > this seems like a good solution. It might cause problems if "pure" is true. When the method is called with "pure," it shouldn't cause any side effects. For a concrete exampl

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

LGTM. I can't think of a case where updating `after' would cause problems - this seems like a good solution. http://codereview.appspot.com/4278058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-de

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

Reviewers: Trevor Daniels, Colin Campbell, Message: On 2011/03/19 23:37:50, Colin Campbell wrote: error: expected ';' Oops. I guess you can't teach an old dog to use a new editor. Fixed, and I hope people do try it, because this method of suppressing the repeated warnings changes the output.

Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

On 2011/03/18 11:22:11, Trevor Daniels wrote: LGTM I like this warning text. Much better. Trevor Applying the patch gave the following: /home/colin/lilypond-git/lily/page-layout-problem.cc: In member function 'void Page_layout_problem::solve_rod_spring_problem(bool)': /home/colin/lilypond-g

Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)

LGTM I like this warning text. Much better. Trevor http://codereview.appspot.com/4278058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel