On 7 August 2011 20:48, Reinhold Kainhofer wrote:
> I wouldn't go that lowlevel. I rather thought about a scheme function that
> prints a ly:warning and then returns the new definition (or calls the new
> function).
How would you prevent the deprecation warning from being issued when
the identif
Am Sunday, 7. August 2011, 21:41:42 schrieb Neil Puttock:
> On 7 August 2011 20:21, wrote:
> > http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly
> > File ly/property-init.ly (right):
> >
> > http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly#newcode1
> > 89 ly/proper
On 7 August 2011 20:21, wrote:
> http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly
> File ly/property-init.ly (right):
>
> http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly#newcode189
> ly/property-init.ly:189: fermataMarkup = \fermata
> How about a wrapper to mark
LGTM. I have always wondered why \fermataMarkup was necessary.
http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly
File ly/property-init.ly (right):
http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly#newcode189
ly/property-init.ly:189: fermataMarkup = \fermata
How abo
On 7 August 2011 17:24, wrote:
>
> Reviewers: ,
>
> Message:
> Hi,
>
> I've always been a bit annoyed by this, so I though it would be a nice
> enhancement to allow scripts to work on full-bar rests just like
> ordinary markup.
>
> The syntax constructor already makes a half-hearted attempt to ad
On 7 August 2011 17:01, wrote:
> Nice! LGTM.
Thank you.
> Will need some doc changes too.
Indeed. I'll sort that out later (+ a regression test to exercise the
code properly).
> Should we deprecate \fermataMarkup?
I think so. A convert rule would be reliable since it's just a substitution
Nice! LGTM.
Will need some doc changes too.
Should we deprecate \fermataMarkup?
http://codereview.appspot.com/4672059/diff/1/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (right):
http://codereview.appspot.com/4672059/diff/1/scm/ly-syntax-constructors.scm#newcode157
scm/ly
Reviewers: ,
Message:
Hi,
I've always been a bit annoyed by this, so I though it would be a nice
enhancement to allow scripts to work on full-bar rests just like
ordinary markup.
The syntax constructor already makes a half-hearted attempt to add
scripts, but fails in trying to set the 'text pro
