Re: Make sure to include enclosing context when writing doc examples

2024-12-19 Thread Simon Albrecht
Hi Trevor, I absolutely agree. Seems like these examples need to follow our “tiny examples policy” and not use unnecessary complexity. On 17.12.24 18:00, Trevor Bača wrote: https://lilypond.org/doc/v2.25/Documentation/notation/tweak-and-single […] < \single \easyHeadsOn c' g'

Make sure to include enclosing context when writing doc examples

2024-12-17 Thread Trevor Bača
Hi folks, When writing examples for the NR, make sure to include any "enclosing context" in the user-visible part of each example. For example, notation example 6 in the new NR 5.3.6 "\tweak and \single" section ... https://lilypond.org/doc/v2.25/Documentation/notat

Re: Use new syntax throughout the doc and examples (issue 572640043 by v.villen...@gmail.com)

2019-07-14 Thread pkxgnugitcl
This was stuck as 'please push' for weeks. I have retested the patch today and am pushing it on VV's behalf - seems a shame to waste the work otherwise. Doc: Use new syntax throughout all doc and examples staging author Valentin Villenave Sun, 14 Jul 2019 13:02:02 +01

Re: Use new syntax throughout the doc and examples (issue 572640043 by v.villen...@gmail.com)

2019-07-09 Thread pkxgnugitcl
On 2019/04/25 21:27:39, Valentin Villenave wrote: spaces not tabs… Patch counted down - please push https://codereview.appspot.com/572640043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Use new syntax throughout the doc and examples (issue 572640043 by v.villen...@gmail.com)

2019-06-18 Thread pkxgnugitcl
Patch counted down - please push https://codereview.appspot.com/572640043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Use new syntax throughout the doc and examples (issue 572640043 by v.villen...@gmail.com)

2019-04-25 Thread thomasmorley65
LGTM Some nit below Thanks, Harm https://codereview.appspot.com/572640043/diff/552640043/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/572640043/diff/552640043/scm/define-markup-commands.scm#newcode1310 scm/define-markup-commands.sc

Re: Web: examples page: move more common use cases higher in the list (issue 318560043 by paulwmor...@gmail.com)

2017-02-22 Thread graham
LGTM https://codereview.appspot.com/318560043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Web: examples page: move more common use cases higher in the list (issue 318560043 by paulwmor...@gmail.com)

2017-02-16 Thread paulwmorris
Reviewers: , Message: Finally got around to this. -Paul Description: Web: examples page: move more common use cases higher in the list Makes the order match the list on the home page. Also adds an additional line between the code for each example for better readability. Please review this at

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-10-03 Thread Trevor Bača
On Wed, Sep 14, 2016 at 11:42 PM, Urs Liska wrote: > > > Am 15.09.2016 um 02:51 schrieb paulwmor...@gmail.com: > > Now using the Bach BWV861 example from the essay. Screenshot: > > https://drive.google.com/open?id=0ByNTIEA63_a_ZGZrZzlkSUhJeU0 > > > > I like the cleaner look since this image does

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-14 Thread Urs Liska
Am 15.09.2016 um 02:51 schrieb paulwmor...@gmail.com: > Now using the Bach BWV861 example from the essay. Screenshot: > https://drive.google.com/open?id=0ByNTIEA63_a_ZGZrZzlkSUhJeU0 > > I like the cleaner look since this image doesn't have any title, text, > etc. like the previous one. If you c

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-14 Thread paulwmorris
Now using the Bach BWV861 example from the essay. Screenshot: https://drive.google.com/open?id=0ByNTIEA63_a_ZGZrZzlkSUhJeU0 I like the cleaner look since this image doesn't have any title, text, etc. like the previous one. If you click on the image you can see a larger version. I will upload t

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-13 Thread Phil Holmes
- Original Message - From: "Paul" To: "Phil Holmes" ; ; ; Sent: Tuesday, September 13, 2016 3:11 PM Subject: Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com) On 09/13/2016 09:52 AM, Phil Holmes wrot

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-13 Thread Paul
" that way (which was the point of using the examples mechanisms) but maybe that's not needed on the home page and/or could be a future enhancement. I don't think you can do that. The reason for all the odd stuff with the image files is that the server we host lilypond on does

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-13 Thread Paul
On 09/13/2016 10:02 AM, Phil Holmes wrote: Just thinking about this bit some more - are you running make doc to create the images and make website after that? Yes, at first after reading those docs you linked to, I thought maybe I'd run: make make website make doc (out of order) but then I

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-13 Thread Phil Holmes
- Original Message - From: "Paul" To: "Phil Holmes" ; ; ; Sent: Tuesday, September 13, 2016 2:26 PM Subject: Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com) On 09/13/2016 04:28 AM, Phil H

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-13 Thread Phil Holmes
- Original Message - From: "Paul" To: "Phil Holmes" ; ; ; Sent: Tuesday, September 13, 2016 2:26 PM Subject: Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com) On 09/13/2016 04:28 AM, Phil H

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-13 Thread Paul
/doc/v2.19/Documentation/contributor/website-build any help? Thanks, those are helpful. I'll have to remember that those build system notes are down there. I see now that LilyPond is being run on the new file and the pdf and png files do end up in: build/Documentation/ly-examples/out-www

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-13 Thread Phil Holmes
- Original Message - From: "Paul" To: ; ; ; ; ; ; ; ; Sent: Tuesday, September 13, 2016 1:25 AM Subject: Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com) On 09/08/2016 12:53 PM, carl.d.soren...@gmail.com wr

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-12 Thread Paul
On 09/08/2016 12:53 PM, carl.d.soren...@gmail.com wrote: How about the BWV 861 example from the essay? http://lilypond.org/doc/v2.18/Documentation/essay/engraved-examples-_0028bwv-861_0029 It shows fewer features (e.g. instrument names, score title) but shows a beautiful and complex score

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-08 Thread Carl . D . Sorensen
think is best. One of the existing ones would be simplest of course. How about the BWV 861 example from the essay? http://lilypond.org/doc/v2.18/Documentation/essay/engraved-examples-_0028bwv-861_0029 It shows fewer features (e.g. instrument names, score title) but shows a beautiful and comple

Re: Web: home page: add examples/images, reduce news to headlines(issue 306350043 by paulwmor...@gmail.com)

2016-09-08 Thread Phil Holmes
- Original Message - From: To: ; ; ; ; ; Cc: ; Sent: Thursday, September 08, 2016 4:28 AM Subject: Re: Web: home page: add examples/images, reduce news to headlines(issue 306350043 by paulwmor...@gmail.com) Thanks for the feedback everyone! On 2016/09/06 16:39:22, Carl wrote

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-07 Thread paulwmorris
Thanks for the feedback everyone! On 2016/09/06 16:39:22, Carl wrote: I think the only thing remaining is to get the best possible example for the front page. Any suggestions anyone? I'm fine with the Bach one or whatever people think is best. One of the existing ones would be simplest of

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-06 Thread simon . albrecht
My 2cts. https://codereview.appspot.com/306350043/diff/40001/Documentation/web.texi File Documentation/web.texi (right): https://codereview.appspot.com/306350043/diff/40001/Documentation/web.texi#newcode142 Documentation/web.texi:142: @exampleImage{bach-bwv610} I agree that we should look for t

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-06 Thread Carl . D . Sorensen
On 2016/09/06 15:49:43, pwm wrote: Screenshot: https://drive.google.com/open?id=0ByNTIEA63_a_ZzMtNTFiZHFqN2c I have not built and tested the webpage, but I think this is exactly the way to go. Show an example, and let the user select any other examples they find interesting. I think the

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-06 Thread Urs Liska
Am 06.09.2016 um 17:49 schrieb paulwmor...@gmail.com: > Patch set 3 uploaded, with just one example image on the home page and a > list of links to the other examples on the examples page. I like how > this gets an image of sheet music onto the home page and helps > communicate th

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-06 Thread tisimst
On Tue, Sep 6, 2016 at 9:52 AM, paulwmorris [via Lilypond] < ml-node+s1069038n194266...@n5.nabble.com> wrote: > Patch set 3 uploaded, with just one example image on the home page and a > list of links to the other examples on the examples page. I like how > this gets an image of s

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-09-06 Thread paulwmorris
Patch set 3 uploaded, with just one example image on the home page and a list of links to the other examples on the examples page. I like how this gets an image of sheet music onto the home page and helps communicate the wide range of LilyPond's use cases. Screenshot: https://drive.googl

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-08-31 Thread Urs Liska
ee what I can come up with. > >Maybe just a single example, followed by a list of the other kinds of >examples, to show the range of what LilyPond can do, with a link to the > >full example page. (This is another place where @anchor would come in >handy -- we could link the list item

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-08-31 Thread tisimst
eally long, scrolling, home page. > > Ok, given these concerns that Carl and David raised, let me think some > more and see what I can come up with. > > Maybe just a single example, followed by a list of the other kinds of > examples, to show the range of what LilyPond can do, with

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-08-31 Thread Paul
other kinds of examples, to show the range of what LilyPond can do, with a link to the full example page. (This is another place where @anchor would come in handy -- we could link the list items directly to the examples, "Tablature" to the tablature example etc.) Later, if we wanted

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-08-30 Thread Carl . D . Sorensen
I'm not comfortable with the really long, scrolling, home page. I think we should make the home page so that it is basically a one-screen page on a "typical" computer display, and have the full example page be a link titled "more" or something like that. Carl https://codereview.appspot.com/3063

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-08-30 Thread David Kastrup
> Some time ago I made a quick test of a pure CSS image slider of > lilypond >> examples, but never tried to apply it on texinfo and lilypond source. > > Hmmm, I don't mind the scrolling or use of vertical space, and I like > how the basic page of images fits the simple aest

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-08-30 Thread paulwmorris
On 2016/08/30 15:07:47, fedelogy wrote: Paul, thanks for tackling this issue! Thanks, glad to help. It's been on my wish list for awhile. I'd prefer a slider of images to save vertical space and scrolling. Some time ago I made a quick test of a pure CSS image slider of lilypond

Re: Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-08-30 Thread fedelogy
On 2016/08/29 21:49:41, pwm wrote: The images and other content from the 'Examples' page is moved to the home page, and the 'Examples' page is removed from the 'Introduction' section. Paul, thanks for tackling this issue! I'd prefer a slider of images t

Web: home page: add examples/images, reduce news to headlines (issue 306350043 by paulwmor...@gmail.com)

2016-08-29 Thread paulwmorris
s and other content from the 'Examples' page is moved to the home page, and the 'Examples' page is removed from the 'Introduction' section. The news entries on the home page are reduced to just headline links in the sidebar. They link to the 'Old News' page

Re: Code examples in docs

2016-04-09 Thread Urs Liska
Am 09.04.2016 um 15:27 schrieb Phil Holmes: > - Original Message - From: "Urs Liska" > To: > Sent: Thursday, April 07, 2016 7:11 AM > Subject: Re: Code examples in docs > > >> >> >> Am 07.04.2016 um 07:54 schrieb Urs Liska: >>>

Re: Code examples in docs

2016-04-09 Thread Phil Holmes
- Original Message - From: "Urs Liska" To: Sent: Thursday, April 07, 2016 7:11 AM Subject: Re: Code examples in docs Am 07.04.2016 um 07:54 schrieb Urs Liska: Am 07.04.2016 um 07:50 schrieb Noeck: Hi Urs, a very uneducated guess: Could it be that the html page

Re: Code examples in docs

2016-04-09 Thread Urs Liska
Weitergeleitete Nachricht Betreff:Re: Code examples in docs Datum: Sat, 9 Apr 2016 12:56:12 +0100 Von:James An: Urs Liska Hello Urs On 09/04/16 12:27, Urs Liska wrote: > > Am 9. April 2016 12:56:42 MESZ, schrieb James : >> Urs, >>

Re: Code examples in docs

2016-04-07 Thread Carl Sorensen
On 4/7/16 4:54 PM, "Urs Liska" wrote: > >So it is really strange, I'm completely at a loss to find out where to >start looking further ... Have you worked your way through Phil's notes at http://lilypond.org/doc/v2.19/Documentation/contributor/the-function-of-mak e-doc Carl __

Re: Code examples in docs

2016-04-07 Thread Urs Liska
les are really for lilypond-book and don't have anything to do with the building of LilyPond docs. Which brings us back to the original issue: Where is the code that generates the blockquotes with the LilyPond code snippets and images? Probably David's pointer to texi2html is plausible, but I mus

Re: Code examples in docs

2016-04-07 Thread Urs Liska
Am 07.04.2016 um 12:11 schrieb David Kastrup: > David Kastrup writes: > >> Carl Sorensen writes: >> >>> What about if you delete python/out and redo make doc? >>> >>> Just wondering if there's something wrong with the build script that >>> python/out isn't properly recreated when python/*.py ch

Re: Code examples in docs

2016-04-07 Thread David Kastrup
David Kastrup writes: > Carl Sorensen writes: > >> What about if you delete python/out and redo make doc? >> >> Just wondering if there's something wrong with the build script that >> python/out isn't properly recreated when python/*.py changes. In my >> setup, python/*.py is not executable, bu

Re: Code examples in docs

2016-04-07 Thread David Kastrup
Carl Sorensen writes: > What about if you delete python/out and redo make doc? > > Just wondering if there's something wrong with the build script that > python/out isn't properly recreated when python/*.py changes. In my > setup, python/*.py is not executable, but python/out/*.py is. So make i

Re: Code examples in docs

2016-04-07 Thread Carl Sorensen
On 4/7/16 12:11 AM, "lilypond-devel-bounces+c_sorensen=byu@gnu.org on behalf of Urs Liska" wrote: > > >However, when *deleting* the .py and .pyc files an error was triggered, >when lilypond-book tries to import book_html. > >Looking further into it I realized: >- book_base keeps an array with

Re: Code examples in docs

2016-04-06 Thread Urs Liska
Am 07.04.2016 um 08:03 schrieb David Kastrup: > Urs Liska writes: > >> Hm, I'm puzzled. >> >> I must say that this file and particularly >> BookHTMLOutputFormat.snippet_output() looks like it's exactly the code >> I'm looking for. What I need is the code that wraps the source code of >> any Lily

Re: Code examples in docs

2016-04-06 Thread Urs Liska
Am 07.04.2016 um 07:54 schrieb Urs Liska: > > Am 07.04.2016 um 07:50 schrieb Noeck: >> Hi Urs, >> >> a very uneducated guess: Could it be that the html pages are only >> generated if the input has changed and as you change the generating code >> and not the doc-input, the generation is skipped? I

Re: Code examples in docs

2016-04-06 Thread David Kastrup
Urs Liska writes: > Hm, I'm puzzled. > > I must say that this file and particularly > BookHTMLOutputFormat.snippet_output() looks like it's exactly the code > I'm looking for. What I need is the code that wraps the source code of > any LilyPond snippet in the docs in > ...image > > However, m

Re: Code examples in docs

2016-04-06 Thread Urs Liska
Am 07.04.2016 um 07:50 schrieb Noeck: > Hi Urs, > > a very uneducated guess: Could it be that the html pages are only > generated if the input has changed and as you change the generating code > and not the doc-input, the generation is skipped? It is still strange > that it works if you empty the

Re: Code examples in docs

2016-04-06 Thread Noeck
Hi Urs, a very uneducated guess: Could it be that the html pages are only generated if the input has changed and as you change the generating code and not the doc-input, the generation is skipped? It is still strange that it works if you empty the file. Cheers, Joram

Re: Code examples in docs

2016-04-06 Thread Urs Liska
>>> Hi, >>> >>> can someone tell me where I should look for code that generates code >>> examples in the HTML docs? >> I assume you mean the texi/latex code that takes the snippet and puts it >> into the document as a code fragment? >> >> I thi

Re: Code examples in docs

2016-04-06 Thread Urs Liska
Hi Carl, Am 06.04.2016 um 02:09 schrieb Carl Sorensen: > On 4/5/16 5:09 PM, "lilypond-devel-bounces+c_sorensen=byu@gnu.org on > behalf of Urs Liska" behalf of u...@openlilylib.org> wrote: > >> Hi, >> >> can someone tell me where I should look for cod

Re: Code examples in docs

2016-04-05 Thread Carl Sorensen
On 4/5/16 5:09 PM, "lilypond-devel-bounces+c_sorensen=byu@gnu.org on behalf of Urs Liska" wrote: >Hi, > >can someone tell me where I should look for code that generates code >examples in the HTML docs? I assume you mean the texi/latex code that takes the snippe

Re: Code examples in docs

2016-04-05 Thread Simon Albrecht
On 06.04.2016 01:09, Urs Liska wrote: Hi, can someone tell me where I should look for code that generates code examples in the HTML docs? There are links on the pictures, aren’t they? Best, Simon ___ lilypond-devel mailing list lilypond-devel

Code examples in docs

2016-04-05 Thread Urs Liska
Hi, can someone tell me where I should look for code that generates code examples in the HTML docs? Thanks Urs -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet. ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: doc: nice music examples removed?

2016-01-28 Thread Bob Bib
On 28/01/16 11:58, Federico Bruni wrote: Il giorno gio 28 gen 2016 alle 2:07, Bob Bib ha scritto: ... An upper-level directory was removed in 2009: http://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=11a53dff1e2552e5b9b3ea5629a86f19086098fc The directory is named "input/mutopia"... meanw

Re: doc: nice music examples removed?

2016-01-28 Thread Federico Bruni
Il giorno gio 28 gen 2016 alle 2:07, Bob Bib ha scritto: Wed, 27 Jan 2016 from Federico Bruni: > Actually, the source code is available here: > http://git.savannah.gnu.org/cgit/lilypond.git/tree/Documentation/ly-examples Thanks for the link! An upper-level directory was removed i

Re: doc: nice music examples removed?

2016-01-27 Thread Bob Bib
Wed, 27 Jan 2016 from Federico Bruni: > Actually, the source code is available here: > http://git.savannah.gnu.org/cgit/lilypond.git/tree/Documentation/ly-examples Thanks for the link! An upper-level directory was removed in 2009: http://git.savannah.gnu.org/cgit/lilypond.git/comm

Re: doc: nice music examples removed?

2016-01-26 Thread Federico Bruni
Actually, the source code is available here: http://git.savannah.gnu.org/cgit/lilypond.git/tree/Documentation/ly-examples It's been discussed in the past how to make this source code clearly visible in the website. You can find some discussion in the tracker as well. Il giorno mer 2

Re: doc: nice music examples removed?

2016-01-26 Thread tisimst
Bob, Not sure why they've been removed, but it appears that there's a new page that shows some new examples as well as some of those found in the site you mentioned (source code not included): http://lilypond.org/examples.html HTH, Abraham On Tuesday, January 26, 2016, Bob Bib [vi

doc: nice music examples removed?

2016-01-26 Thread Bob Bib
Hi developers, in the past versions, some really nice pieces of music were included in the docs (e. g., J. S. Bach, E. Satie, F. Schubert): http://lilypond.org/doc/v2.12/examples In the current version (2.18), I can't find them. Have those music pieces been removed from the manuals (an

Re: Issue 3958: Give examples of \applyContext usage. (issue 110060045 by markpole...@gmail.com)

2014-07-04 Thread janek . lilypond
LGTM, thanks! https://codereview.appspot.com/110060045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3958: Give examples of \applyContext usage. (issue 110060045 by markpole...@gmail.com)

2014-07-04 Thread markpolesky
Reviewers: janek, Keith, dak, Message: I've rewritten the \applyContext description, and this new patch is about 40% shorter than the previous one. Please review. Thanks, Mark Description: The documentation on \applyContext is pretty slim. I'm just mentioning some new tricks I recently learne

Re: Issue 3958: Give examples of \applyContext usage. (issue 110060045 by markpole...@gmail.com)

2014-06-24 Thread dak
https://codereview.appspot.com/110060045/diff/1/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://codereview.appspot.com/110060045/diff/1/Documentation/extending/programming-interface.itely#newcode1339 Documentation/exte

Re: Issue 3958: Give examples of \applyContext usage. (issue 110060045 by markpole...@gmail.com)

2014-06-23 Thread k-ohara5a5a
Looks fine as-is. You might look at it again, and see if you like the idea of shortening it so more people read it. https://codereview.appspot.com/110060045/diff/1/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://coder

Issue 3958: Give examples of \applyContext usage. (issue 110060045 by markpole...@gmail.com)

2014-06-23 Thread janek . lilypond
LGTM - this is helpful, thanks! https://codereview.appspot.com/110060045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR add \chord to examples in A2 (issue 40640045)

2013-12-28 Thread fedelogy
If you keep .3 for the second column width, you avoid the stretching of the text inside the column. I would reduce the narrowest columns, something like: -@multitable @columnfractions .2 .3 .2 .2 +@multitable @columnfractions .15 .3 .15 .15 .2 https://codereview.appspot.com/40640045/ _

Doc: NR add \chord to examples in A2 (issue 40640045)

2013-12-28 Thread tdanielsmusic
LGTM, but why not use @* to split the lines for the first item in every line? This column could then be made a little narrower. Trevor https://codereview.appspot.com/40640045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.

Re: Doc: NR Appendix A10.3 \path examples (issue 45380043)

2013-12-25 Thread pkx166h
Reviewers: Trevor Daniels, Message: On 2013/12/24 21:04:42, Trevor Daniels wrote: LGTM, although I haven't tried compiling the new examples. I have now attached a screen shot to the tracker for completeness http://code.google.com/p/lilypond/issues/detail?id=3587#c3 Description: Do

Doc: NR Appendix A10.3 \path examples (issue 45380043)

2013-12-24 Thread tdanielsmusic
LGTM, although I haven't tried compiling the new examples. https://codereview.appspot.com/45380043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Stop Documentation/ly-examples/orchestra.ly from redefining markup commands (issue 10431047)

2013-06-24 Thread graham
LGTM. FWIW, this piece was composed and typeset by one of our blind users. It's amazing that he creates tweaks, but without being able to see their effects it's not surprising that some of those tweaks turn out to be unnecessary. https://codereview.appspot.com/10431047/

Stop Documentation/ly-examples/orchestra.ly from redefining markup commands (issue 10431047)

2013-06-22 Thread k-ohara5a5a
Removing the warnings is possible by removing the Axis_group_engraver from the MarkLine context definition, but this messes up the positions of the tempo marks. You could keep the positioning and remove the warnings with \override MetronomeMark #'Y-offset = #'() The default has the tempo ma

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-28 Thread graham
LGTM https://codereview.appspot.com/7013043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread PhilEHolmes
LGTM https://codereview.appspot.com/7013043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread Phil Holmes
- Original Message - From: "James" To: ; ; ; ; ; Sent: Wednesday, December 26, 2012 1:15 PM Subject: Re: Doc: CG Clarifying about Examples with overrides (issue 7013043) Hello, On 26 December 2012 12:52, wrote: https://codereview.appspot.com/7013043/diff/3003/Doc

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread thomasmorley65
On 2012/12/26 13:15:05, J_lowe wrote: Is there any case where a snippet would not have the docs tag? James Some statistic from the last LSR-update: The 2.12.3-LSR contained 645 snippets. 291 were tagged docs. There are many LSR-snippets showing nice code/features, but not all of them are w

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread James
Hello, On 26 December 2012 12:52, wrote: > > https://codereview.appspot.com/7013043/diff/3003/Documentation/contributor/doc-work.itexi > File Documentation/contributor/doc-work.itexi (right): > > https://codereview.appspot.com/7013043/diff/3003/Documentation/contributor/doc-work.itexi#newcode158

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread PhilEHolmes
https://codereview.appspot.com/7013043/diff/3003/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): https://codereview.appspot.com/7013043/diff/3003/Documentation/contributor/doc-work.itexi#newcode158 Documentation/contributor/doc-work.itexi:158: @ref

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread David Kastrup
James writes: > On 26 December 2012 11:00, wrote: >> Documentation/contributor/doc-work.itexi:155: The correct way to add >> [changes like this] to the documentation is to >>> > Why the [] ? >> >> >>> This is a standard way to to clarify the antecedent. >> Another frequent use is to make exp

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread pkx166h
: @contributions that contain examples using overrides or tweaks On 2012/12/26 10:27:39, Trevor Daniels wrote: Not sure what you intended here. Does the @ mean there is an omitted texinfo command? Maybe this line should just be deleted. No that's a typo. :( It should be @subheading contribu

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread James
hello, On 26 December 2012 11:00, wrote: > > https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi > File Documentation/contributor/doc-work.itexi (right): > > https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi#newcode155 > Doc

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread dak
https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi#newcode155 Documentation/contributor/doc-work.itexi:155: The correc

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-26 Thread tdanielsmusic
-work.itexi:149: @contributions that contain examples using overrides or tweaks Not sure what you intended here. Does the @ mean there is an omitted texinfo command? Maybe this line should just be deleted. https://codereview.appspot.com/7013043/ ___

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-25 Thread pkx166h
2012/12/25 11:01:33, PhilEHolmes wrote: This is Phil - as was the BealingsPlayford comment earlier. Should the closing ) be a } ? Done. Description: Doc: CG Clarifying about Examples with overrides Issue 3051 Paraphrased an email response sent by Trevor Daniels. Please review this at https://co

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-25 Thread PhilEHolmes
https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi#newcode161 Documentation/contributor/doc-work.itexi:161: it as a @e

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-25 Thread tdanielsmusic
Other than my suggestion below, LGTM https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi#newcode161 Documentation/cont

Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-25 Thread bealingsplayfordnews
https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): https://codereview.appspot.com/7013043/diff/1/Documentation/contributor/doc-work.itexi#newcode155 Documentation/contributor/doc-work.itexi:155: The correc

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-06-14 Thread graham
On 2012/06/13 19:21:48, janek wrote: On 2012/06/13 18:47:57, Keith wrote: > I've added the three line-breaks. I don't see them. I don't think it's worth re-uploading a new patch just for this. Please push to staging. http://codereview.appspot.com/6197068/ _

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-06-13 Thread janek . lilypond
http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/keyboards.itely File Documentation/notation/keyboards.itely (right): http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/keyboards.itely#newcode210 Documentation/notation/keyboards.itely:210: e''2\p\< d''

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-06-13 Thread k-ohara5a5a
http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/changing-defaults.itely#newcode749 Documentation/notation/changing-

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-06-12 Thread graham
ok. http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/keyboards.itely File Documentation/notation/keyboards.itely (right): http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/keyboards.itely#newcode210 Documentation/notation/keyboards.itely:210: e''2\p\

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-06-01 Thread k-ohara5a5a
http://codereview.appspot.com/6197068/diff/10002/Documentation/snippets/new/multi-measure-rest-markup.ly File Documentation/snippets/new/multi-measure-rest-markup.ly (left): http://codereview.appspot.com/6197068/diff/10002/Documentation/snippets/new/multi-measure-rest-markup.ly#oldcode82 Documen

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-14 Thread dak
http://codereview.appspot.com/6197068/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/staff.itely#newcode1361 Documentation/notation/staff.itely:1361: \new CueVoice { \set "instrumentCu

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-13 Thread k-ohara5a5a
Absorbed suggestions. Added snippets. http://codereview.appspot.com/6197068/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/changing-defaults.itely#newcode749

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-13 Thread dak
http://codereview.appspot.com/6197068/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/changing-defaults.itely#newcode749 Documentation/notation/changing-defaults

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-11 Thread Keith OHara
On Fri, 11 May 2012 00:55:48 -0700, wrote: The decresc can be terminated with a note or rest of any duration,but <>\! can only be used if it happens to fall on a bar line. ..or if the you finish the bar in some other way { c2 <>\! r2 } { c2 <>\! s2 } The <> specifies when to end the hairp

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-11 Thread janek . lilypond
LGTM http://codereview.appspot.com/6197068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-11 Thread tdanielsmusic
http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely#newcode89 Documentation/notation/simultaneous.itely:89: r4 e8( g <

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-11 Thread dak
On 2012/05/11 07:55:48, Trevor Daniels wrote: Houston, we have a problem. http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simul

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-11 Thread tdanielsmusic
Houston, we have a problem. http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely#newcode89 Documentation/notation/simu

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-10 Thread k-ohara5a5a
http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely#newcode89 Documentation/notation/simultaneous.itely:89: r4 e8( g <

  1   2   3   >