Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-29 Thread dak
On 2017/04/29 00:36:36, david.nalesnik wrote: On 2017/04/28 22:49:25, thomasmorley651 wrote: > So I'd vote for keeping extra-offset as in your last patch-set. > Although I'm aware David K's point is important, I think a user doing manual > positioning, is responsible to deal with possible

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
On 2017/04/28 22:49:25, thomasmorley651 wrote: On 2017/04/28 22:27:12, david.nalesnik wrote: > On 2017/04/28 22:24:57, david.nalesnik wrote: > > On 2017/04/28 16:15:42, david.nalesnik wrote: > > > On 2017/04/28 15:50:52, dak wrote: > > > > Does an extra-offset in X direction even make sense when

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread thomasmorley65
On 2017/04/28 22:27:12, david.nalesnik wrote: On 2017/04/28 22:24:57, david.nalesnik wrote: > On 2017/04/28 16:15:42, david.nalesnik wrote: > > On 2017/04/28 15:50:52, dak wrote: > > > Does an extra-offset in X direction even make sense when the systems are > > spaced > > > according to their

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
On 2017/04/28 22:24:57, david.nalesnik wrote: On 2017/04/28 16:15:42, david.nalesnik wrote: > On 2017/04/28 15:50:52, dak wrote: > > Does an extra-offset in X direction even make sense when the systems are > spaced > > according to their skylines _before_ the extra-offset is applied? > > Well,

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
On 2017/04/28 16:15:42, david.nalesnik wrote: On 2017/04/28 15:50:52, dak wrote: > Does an extra-offset in X direction even make sense when the systems are spaced > according to their skylines _before_ the extra-offset is applied? Well, X-offset of line-break-system-details is applied in

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
On 2017/04/28 15:50:52, dak wrote: Does an extra-offset in X direction even make sense when the systems are spaced according to their skylines _before_ the extra-offset is applied? Well, X-offset of line-break-system-details is applied in make-page-stencil, too.

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread dak
Does an extra-offset in X direction even make sense when the systems are spaced according to their skylines _before_ the extra-offset is applied? https://codereview.appspot.com/324810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
Also added a "Changes" entry. Thanks! https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly File input/regression/page-layout-extra-offset.ly (right): https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly#newcode7

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread thomasmorley65
Some nits, otherwise LGTM Worth an entry in changes? https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly File input/regression/page-layout-extra-offset.ly (right):

Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-27 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Implement extra-offset for system positioning Add the property 'extra-offset to 'line-break-system-details. It is possible to position systems absolutely using the properties 'X-offset and 'Y-offset of 'line-break-system-details.