I will close this rietveld issue now that you are taking care of it.
Whatever discussion needs to take place can happen at the one you have
opened.
On Sat, May 02, 2020 at 11:54:14AM +0200, Han-Wen Nienhuys wrote:
> See http://codereview.appspot.com/545970043
>
> note:
> 1) Depending on the
See http://codereview.appspot.com/545970043
note:
1) Depending on the renderer, the skylines diverge from the text.
Inkscape reproduces exactly, but EOG messes up the text formatting.
2) The lack of regression testing is worrying. We could have a section
of regtests that is powered by
inkscape
Let me see what I can come up with today
On Sat, May 2, 2020 at 10:53 AM Kevin Barry wrote:
>
> On Sat, May 02, 2020 at 09:59:18AM +0200, Han-Wen Nienhuys wrote:
> > Not necessarily, but the refactoring means I'll likely have to
> > overwrite the fix wholesale. Because there is no regtest, it
On Sat, May 02, 2020 at 09:59:18AM +0200, Han-Wen Nienhuys wrote:
> Not necessarily, but the refactoring means I'll likely have to
> overwrite the fix wholesale. Because there is no regtest, it willl
> depend on my diligence anyway to fix this again.
OK, so what should we do? I am happy to take
On Sat, May 02, 2020 at 01:16:30AM -0700, beauleetien...@gmail.com wrote:
> On 2020/05/02 07:38:58, hanwenn wrote:
> > I don't completely understand, though: if we put the "utf-8-string"
> directly
> > into the SVG output, the SVG browser might make other font choices,
> making the
> > outline
On 2020/05/02 07:38:58, hanwenn wrote:
> I don't completely understand, though: if we put the "utf-8-string"
directly
> into the SVG output, the SVG browser might make other font choices,
making the
> outline potentially incorrect. Is this a problem in practice?
There isn't really an "outline"
Not necessarily, but the refactoring means I'll likely have to
overwrite the fix wholesale. Because there is no regtest, it willl
depend on my diligence anyway to fix this again.
On Sat, May 2, 2020 at 9:46 AM wrote:
>
> On 2020/05/02 07:25:16, hanwenn wrote:
> > please don't submit; I'm
On 2020/05/02 07:25:16, hanwenn wrote:
> please don't submit; I'm rearranging this file completely.
Do you really need to hold this up after it went through the full cycle?
If it fixes a problem now and doesn't regress somewhere else, I think we
should take it now.
On 2020/05/02 07:37:31, hanwenn wrote:
> On 2020/05/02 07:34:29, barrykp wrote:
> > On Sat, May 02, 2020 at 12:25:15AM -0700, mailto:hanw...@gmail.com
wrote:
> > > please don't submit; I'm rearranging this file completely.
> > >
> > > Can you add your regression test + instructions on how to
On 2020/05/02 07:34:29, barrykp wrote:
> On Sat, May 02, 2020 at 12:25:15AM -0700, mailto:hanw...@gmail.com
wrote:
> > please don't submit; I'm rearranging this file completely.
> >
> > Can you add your regression test + instructions on how to reproduce
the
> > problem?
>
> I did add a
On Sat, May 02, 2020 at 12:25:15AM -0700, hanw...@gmail.com wrote:
> please don't submit; I'm rearranging this file completely.
>
> Can you add your regression test + instructions on how to reproduce the
> problem?
I did add a regression test in the first patch set, but it breaks
testing. It
please don't submit; I'm rearranging this file completely.
Can you add your regression test + instructions on how to reproduce the
problem?
https://codereview.appspot.com/582010043/
LGTM
https://codereview.appspot.com/582010043/
13 matches
Mail list logo
