Re: mensural notation improvements (issue3797046)

2011-01-24 Thread Carl Sorensen
On 1/24/11 3:31 PM, "Benkő Pál" wrote: >>> please advise me about regression tests: can I modify ligatures within >>> mensural-ligatures.ly?  if not, can I add new ones to the same file? >> >> Ancient music has been abandoned by developers for a number of years. >> IMO, you may do whatever you t

Re: mensural notation improvements (issue3797046)

2011-01-24 Thread Carl . D . Sorensen
On 2011/01/24 21:27:35, benko.pal wrote: new patchset up. please advise me about regression tests: can I modify ligatures within mensural-ligatures.ly? if not, can I add new ones to the same file? Ancient music has been abandoned by developers for a number of years. IMO, you may do whatever

Re: mensural notation improvements (issue3797046)

2011-01-24 Thread Benkő Pál
>> please advise me about regression tests: can I modify ligatures within >> mensural-ligatures.ly?  if not, can I add new ones to the same file? > > Ancient music has been abandoned by developers for a number of years. > IMO, you may do whatever you think makes the most sense as you try to > bring

Re: mensural notation improvements (issue3797046)

2011-01-24 Thread benko . pal
new patchset up. please advise me about regression tests: can I modify ligatures within mensural-ligatures.ly? if not, can I add new ones to the same file? http://codereview.appspot.com/3797046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: mensural notation improvements (issue3797046)

2011-01-24 Thread Benkő Pál
now I see I forgot to answer a question: > http://codereview.appspot.com/3797046/diff/1/lily/mensural-ligature-engraver.cc#newcode380 > lily/mensural-ligature-engraver.cc:380: { > Why put the {} in this case? because variables defined there should not be seen in the default case. p

Re: mensural notation improvements (issue3797046)

2011-01-24 Thread Benkő Pál
hi Carl, thanks for reviewing! > Let me start by saying I know *nothing* about mensural notation. > > The code looks good to me. > > I found only one real issue: > > LilyPond coding standards for C++ say that if there is only one > statement in an if clause, we omit {} around that clause. that's

Re: mensural notation improvements (issue3797046)

2011-01-23 Thread Carl . D . Sorensen
Let me start by saying I know *nothing* about mensural notation. The code looks good to me. I found only one real issue: LilyPond coding standards for C++ say that if there is only one statement in an if clause, we omit {} around that clause. I also had a question (and it probably doesn't matt

Re: mensural notation improvements (issue3797046)

2011-01-07 Thread Robert Memering
Am 07.01.2011 10:17, schrieb Benkő Pál: >> Sometimes I have been confused by a punctus divisionis placed in the >> middle above a ligature, but of course that's something different. > > wow, I have never seen such a thing! could you give an example? The only one I could find quickly is from Apel

Re: mensural notation improvements (issue3797046)

2011-01-07 Thread Benkő Pál
> if it helps to confirm that you are right, I might add my own experience > with mensural sources. Composers/writers seem to literally avoid dotted > notes in ligatures except (a) at the end of the ligature, or (b) on top > of the first note of an obliqua, or (c) both.  (a) and (b) are frequent, >

Re: mensural notation improvements (issue3797046)

2011-01-06 Thread Robert Memering
Am 06.01.2011 10:56, schrieb Lukas Pietsch: > On Thu, 2011-01-06 at 10:49 +0100, Benkő Pál wrote: > >>> According to Apel (1962: 99), the general rule would seem to be that the dot >>> should be on the right if it applies to the final note of the whole >>> ligature, but on top if it is anywhere el

Re: mensural notation improvements (issue3797046)

2011-01-06 Thread Lukas Pietsch
On Thu, 2011-01-06 at 10:49 +0100, Benkő Pál wrote: > > According to Apel (1962: 99), the general rule would seem to be that the dot > > should be on the right if it applies to the final note of the whole > > ligature, but on top if it is anywhere else (flexa or no flexa). He has one > > example o

Re: mensural notation improvements (issue3797046)

2011-01-06 Thread Benkő Pál
> > One thing I forgot to mention: I've also rewritten dot handling within > > ligatures. The old code > > - didn't avoid staff lines > > - didn't conform actual usage: dotting notes above is not a practice, > > only if they are first within a flexa, see examples in > > http://anaigeon.free.fr/mes

Re: mensural notation improvements (issue3797046)

2011-01-06 Thread Lukas Pietsch
On Thu, 2011-01-06 at 08:44 +, benko@gmail.com wrote: > One thing I forgot to mention: I've also rewritten dot handling within > ligatures. The old code > - didn't avoid staff lines > - didn't conform actual usage: dotting notes above is not a practice, > only if they are first within a f

Re: mensural notation improvements (issue3797046)

2011-01-06 Thread benko . pal
One thing I forgot to mention: I've also rewritten dot handling within ligatures. The old code - didn't avoid staff lines - didn't conform actual usage: dotting notes above is not a practice, only if they are first within a flexa, see examples in http://anaigeon.free.fr/mes_facs/fsbarb.jpg http:/

Re: mensural notation

2005-05-09 Thread Juergen Reuter
Applied (in CVS). Greetings, Juergen On Mon, 9 May 2005, Pal Benko wrote: What about the remaining durations (maxima, ...) for petrucci style? I guess, they should be the same as for mensural style? Yes. These as well are quite close but not identical to those found in Petrucci prints; they will d

Re: mensural notation

2005-05-09 Thread Pal Benko
What about the remaining durations (maxima, ...) for petrucci style? I guess, they should be the same as for mensural style? Yes. These as well are quite close but not identical to those found in Petrucci prints; they will do. p ___ lilypond-devel mailin

Re: mensural notation

2005-05-09 Thread Pal Benko
Hi Jürgen, What I do not understand, if you want neo-mensural noteheads, why not just doing "\override Voice.NoteHead #'style = #'neomensural"? As far as I can see, the main difference between neomensural and mensural notehead are (besides the different parameters) that mensural noteheads have diam

Re: mensural notation

2005-05-09 Thread Juergen Reuter
Ok, then I will apply your noteheads as "petrucci" style (hopefully, I will be able to spend some time this evening). What about the remaining durations (maxima, ...) for petrucci style? I guess, they should be the same as for mensural style? Anyway, this can easily be changed in the find-not

Re: mensural notation

2005-05-09 Thread Juergen Reuter
On Wed, 4 May 2005, Pal Benko wrote: Hi Jürgen, What I do not understand, if you want neo-mensural noteheads, why not just doing "\override Voice.NoteHead #'style = #'neomensural"? As far as I can see, the main difference between neomensural and mensural notehead are (besides the different paramete

Re: mensural notation

2005-05-05 Thread Pal Benko
Hi Jürgen, What I do not understand, if you want neo-mensural noteheads, why not just doing "\override Voice.NoteHead #'style = #'neomensural"? As far as I can see, the main difference between neomensural and mensural notehead are (besides the different parameters) that mensural noteheads have diam

Re: mensural notation

2005-04-28 Thread Juergen Reuter
Hi, Pal! On Wed, 20 Apr 2005, Pal Benko wrote: Hi all, attached is a patch with changed mensural noteheads. ... fet_beginchar("Mensural open head","s0mensural") - draw_diamond_head (staff_space#, 0.15, 0.30, 30, true); +% draw_diamond_head (1.8 staff_space#, 0.15, 0.40, 30, true); +

Re: mensural notation: patch, question, plan

2005-04-28 Thread Juergen Reuter
Hi, Benko! I have finally (sorry for the extremely long delay!) applied your patch, slightly modified, for using a constant thickness of horizontal lines in flexa shapes (rather than using the thickness property). I still feel somewhat uncomfortable with this solution, as the property thickness

Re: mensural notation

2005-04-24 Thread Han-Wen Nienhuys
Op wo, 20-04-2005 te 22:02 +0200, schreef Pal Benko: > 2. I'd like to make punctus divisionis work as a new bar symbol, > \bar ".". But for correct positioning I need in > Bar_line::compound_barline the previous and the next note - how > can I get them (if I can at all)? Unfortunately, this info

Re: mensural notation: patch, question, plan

2005-03-15 Thread Pal Benko
Hi Jürgen, Currently, the thickness property of the flexa shape aplies to all segments of the outline. IIUC, you are suggesting to apply the thickness property only to the left and right outline segment of the flexa shape, while hard-wiring the upper and lower segment wrt to the proportions in the

Re: mensural notation: patch, question, plan

2005-03-14 Thread Juergen Reuter
On Sun, 27 Feb 2005, Benkõ Pál wrote: 2005-02-27 Pal Benko <[EMAIL PROTECTED]> * lily/mensural-ligature.cc (brew_flexa): make flexa parts of ligatures look more similar to square parts Hi, Pál! Currently, the thickness property of the flexa shape aplies to all segments of the out

Re: mensural notation: patch, question, plan

2005-03-07 Thread Juergen Reuter
Hi, Pál! I am sorry for responding so late: last week not only I was in bad health, but also my (quite old) linux installation, which finally broke down, such that I had to install a new distribution. I am still working on getting things running again, but I am quite confident that I will be ab

Re: mensural notation: patch, question, plan

2005-02-28 Thread Benk� P
Hi, I was wondering, could you provide some description for the NEWS file of what you have changed in the ancient notation in your previous patch? White mensural ligatures now conform more closely to renaissance usage (on the input side maximae are allowed; the output has changed completely). Ba

Re: Mensural notation - some questions and a patch

2005-02-20 Thread Juergen Reuter
On Tue, 15 Feb 2005, Benkõ Pál wrote: > ChangeLog: > 2005-02-15 Pal Benko <[EMAIL PROTECTED]> > > * lily/mensural-ligature-engraver.cc: > * lily/mensural-ligature.cc: > * lily/include/mensural-ligature.hh: new algorithm implemented > > * scm/define-grob-properties.scm

Re: Mensural notation - some questions and a patch

2005-02-17 Thread Benko Pal
Hi Jürgen, > > 1. punctus divisionis > > Hmmh, I haven't thought about this much by now. Maybe, we want to > introduce a new type of breath mark; my main source[1] says, that punctus > divisionis can be thought of something similar like a bar glyph. ([1] is my main source as well.) The main

Re: Mensural notation - some questions and a patch

2005-02-17 Thread Juergen Reuter
On Tue, 15 Feb 2005, Benkõ Pál wrote: > ChangeLog: > 2005-02-15 Pal Benko <[EMAIL PROTECTED]> > > * lily/mensural-ligature-engraver.cc: > * lily/mensural-ligature.cc: > * lily/include/mensural-ligature.hh: new algorithm implemented > > * scm/define-grob-properties.scm