Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

Sure. On Tue, Apr 14, 2020 at 8:57 AM wrote: > > On 2020/04/12 11:05:14, hanwenn wrote: > > this should probably not be merged, given the inability to demonstrate > speed > > savings. But I'm uploading the latest version to not leave bugs in > the public > > record. > > Shall we put the patch

Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

On 2020/04/12 11:05:14, hanwenn wrote: > this should probably not be merged, given the inability to demonstrate speed > savings. But I'm uploading the latest version to not leave bugs in the public > record. Shall we put the patch on Needs_work to avoid progressing in the usual process?

Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

this should probably not be merged, given the inability to demonstrate speed savings. But I'm uploading the latest version to not leave bugs in the public record. https://codereview.appspot.com/559790043/

Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

On 2020/04/11 11:36:16, hanwenn wrote: > On Sat, Apr 11, 2020 at 1:05 PM wrote: > > > > On 2020/04/11 05:37:39, hanwenn wrote: > > > > In addition, I don't think that it is used to a degree where it > > would > > > significantly affect LilyPond's performance. > >

Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

On Sat, Apr 11, 2020 at 1:05 PM wrote: > > On 2020/04/11 05:37:39, hanwenn wrote: > > > In addition, I don't think that it is used to a degree where it > would > > significantly affect LilyPond's performance. > > > > It is not yet. > > > > My plan is to plugin this into Grob and Prob and see if

Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

On 2020/04/11 05:37:39, hanwenn wrote: > > In addition, I don't think that it is used to a degree where it would > significantly affect LilyPond's performance. > > It is not yet. > > My plan is to plugin this into Grob and Prob and see if there is a measurable > speed improvement. You cannot

Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

On 2020/04/11 05:37:39, hanwenn wrote: > > In addition, I don't think that it is used to a degree where it would > significantly affect LilyPond's performance. > > It is not yet. > > My plan is to plugin this into Grob and Prob and see if there is a measurable > speed improvement. If there is

Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

Reviewers: dak, Message: > In addition, I don't think that it is used to a degree where it would significantly affect LilyPond's performance. It is not yet. My plan is to plugin this into Grob and Prob and see if there is a measurable speed improvement. If there is none, it's likely that your

Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

I don't see the point in reinventing the wheel. This functionality is provided both by Guile (where an improved implementation could be submitted) and C++'s STL. In addition, I don't think that it is used to a degree where it would significantly affect LilyPond's performance. Reworking this to