commit 7688936a4e598bc9919e8a9adceb3ba1c9b2c23c
Author: Han-Wen Nienhuys
Date: Sat Apr 11 17:49:38 2020 +0200
Remove ly:grob-properties
https://codereview.appspot.com/549840044/
On 2020/04/11 17:44:11, hanwenn wrote:
> On 2020/04/11 17:19:19, dak wrote:
> > > I thought of removing the other function too, and I agree in
principle, but
> it
> > > can only break more user files. As long as we're not considering
> reorganizing
> > > the immutable lists, I think it can stay.
>
On 2020/04/11 17:19:19, dak wrote:
> > I thought of removing the other function too, and I agree in
principle, but it
> > can only break more user files. As long as we're not considering
reorganizing
> > the immutable lists, I think it can stay.
>
> Note that there is no necessity of returning a
On 2020/04/11 16:38:28, hanwenn wrote:
> On 2020/04/11 16:02:31, dak wrote:
> > The description says "[ly:grob-properties] will not return the
properties that
> > were \overridden."
> >
> > Aren't you confusing this with ly:grob-basic-properties ? I think
> > ly:grob-properties will actually
> Fixes
> Documentation/snippets/overriding-articulations-of-destinct-type,
> which should be mirrored back into LSR.
Fixed in LSR
https://codereview.appspot.com/549840044/
Reviewers: dak, thomasmorley651,
Message:
On 2020/04/11 16:02:31, dak wrote:
> The description says "[ly:grob-properties] will not return the
properties that
> were \overridden."
>
> Aren't you confusing this with ly:grob-basic-properties ? I think
> ly:grob-properties will actually _only_
On 2020/04/11 16:32:58, thomasmorley651 wrote:
> On 2020/04/11 16:31:48, thomasmorley651 wrote:
>
> > Btw, it's used in
> > input/regression/multi-measure-rest-reminder.ly
> > input/regression/scheme-text-spanner.ly
> > as well.
>
> No, that's ly:grob-properties?
> Bad grepping ...
Also icky
On 2020/04/11 16:31:48, thomasmorley651 wrote:
> Btw, it's used in
> input/regression/multi-measure-rest-reminder.ly
> input/regression/scheme-text-spanner.ly
> as well.
No, that's ly:grob-properties?
Bad grepping ...
https://codereview.appspot.com/549840044/
The change in the snippet is ofcourse nice.
Though, please don't delete ly:grob-properties or
ly:grob-basic-properties.
I use them every day.
They are tools to get insights at the grob at hand.
Don't judge from our code base and the few occurencies there.
Btw, it's used in
The description says "[ly:grob-properties] will not return the
properties that were \overridden."
Aren't you confusing this with ly:grob-basic-properties ? I think
ly:grob-properties will actually _only_ return the properties that were
overriden.
https://codereview.appspot.com/549840044/
https://codereview.appspot.com/549840044/diff/567430043/lily/grob-scheme.cc
File lily/grob-scheme.cc (left):
https://codereview.appspot.com/549840044/diff/567430043/lily/grob-scheme.cc#oldcode327
lily/grob-scheme.cc:327: LY_DEFINE (ly_grob_basic_properties,
"ly:grob-basic-properties",
There is
11 matches
Mail list logo
