Re: Sketch for fix of issue 307 (issue4813048)

2011-08-09 Thread bordage . bertrand
This needs an update to be applied. Cheers, Bertrand http://codereview.appspot.com/4813048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Sketch for fix of issue 307 (issue4813048)

2011-07-26 Thread mtsolo
On 2011/07/26 06:14:47, mike_apollinemike.com wrote: On Jul 26, 2011, at 5:01 AM, mailto:hanw...@gmail.com wrote: > regtest missing. > > > http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc > File lily/slur-scoring.cc (right): > > http://codereview.appspot.com/4813048/diff/

Re: Sketch for fix of issue 307 (issue4813048)

2011-07-25 Thread m...@apollinemike.com
On Jul 26, 2011, at 5:01 AM, hanw...@gmail.com wrote: > regtest missing. > > > http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc > File lily/slur-scoring.cc (right): > > http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286 > lily/slur-scoring.cc:286

Re: Sketch for fix of issue 307 (issue4813048)

2011-07-25 Thread hanwenn
regtest missing. http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc File lily/slur-scoring.cc (right): http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286 lily/slur-scoring.cc:286: end_ys[d] += additional_ys + 0.5; // 0.5 = m4g1c padding over extra

Re: Sketch for fix of issue 307 (issue4813048)

2011-07-25 Thread mtsolo
On 2011/07/24 14:43:16, MikeSol wrote: Please don't run regtests yet on this patch - it is up to see if people are OK with this approach. It is a brute-force approach that will slow down lilypond for slurs that have extra-object-collisions, but I think it'll cover the grand majority of cas

Sketch for fix of issue 307 (issue4813048)

2011-07-24 Thread mtsolo
Reviewers: , Message: Please don't run regtests yet on this patch - it is up to see if people are OK with this approach. It is a brute-force approach that will slow down lilypond for slurs that have extra-object-collisions, but I think it'll cover the grand majority of cases. Description: Sketc