https://codereview.appspot.com/7310075/diff/67001/lily/skyline.cc
File lily/skyline.cc (right):
https://codereview.appspot.com/7310075/diff/67001/lily/skyline.cc#newcode370
lily/skyline.cc:370: if (x1 = last_end)
Oops. This controls whether to put an empty, -inf height, building in
the gap.
On 12 avr. 2013, at 22:29, k-ohara5...@oco.net wrote:
https://codereview.appspot.com/7310075/diff/67001/lily/skyline.cc
File lily/skyline.cc (right):
https://codereview.appspot.com/7310075/diff/67001/lily/skyline.cc#newcode370
lily/skyline.cc:370: if (x1 = last_end)
Oops. This controls
On 12 mars 2013, at 23:44, janek.lilyp...@gmail.com wrote:
Hi Mike,
i've read changes in code and i don't quite get what this change is for.
What makes it possible that we can now accept boxes that are narrower
than epsilon? What can we achieve with that and why?
I'm sorry for asking
m...@mikesolomon.org m...@mikesolomon.org writes:
The concern before was a comment about numerical inaccuracy, but after
having tested the patch, this seems not to be an issue.
Like Keith pointed out, it could become one if more than one operation
is done before storing the result, and/or
Just sent this to developer list only, so here a copy for the record:
m...@mikesolomon.org m...@mikesolomon.org writes:
The concern before was a comment about numerical inaccuracy, but after
having tested the patch, this seems not to be an issue.
Like Keith pointed out, it could become one
On Wed, 13 Mar 2013 02:44:33 -0700, d...@gnu.org wrote:
If left and right have equal values to start with, C++ is still not
required to have left and right receive the same value after
left = left*factor + offset;
right = right*factor + offset;
The C standard requires the variables to be
Keith OHara k-ohara5...@oco.net writes:
On Wed, 13 Mar 2013 02:44:33 -0700, d...@gnu.org wrote:
If left and right have equal values to start with, C++ is still not
required to have left and right receive the same value after
left = left*factor + offset;
right = right*factor + offset;
The
Hi,
On Wed, Mar 13, 2013 at 10:44 AM, d...@gnu.org wrote:
m...@mikesolomon.org m...@mikesolomon.org writes:
The concern before was a comment about numerical inaccuracy, but after
having tested the patch, this seems not to be an issue.
Like Keith pointed out, it could become one if more
On 2013/03/13 20:40:36, dak wrote:
Keith OHara mailto:k-ohara5...@oco.net writes:
The C standard requires the variables to be equal after assignment.
C99 5.4.2.2: Except for assignment and cast (which remove all extra
range and precision), the values of operations with floating
operands
Hi Mike,
i've read changes in code and i don't quite get what this change is for.
What makes it possible that we can now accept boxes that are narrower
than epsilon? What can we achieve with that and why?
I'm sorry for asking such boring questions, but this is one of your
smallest patches and
https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly
File input/regression/skyline-point-extent.ly (right):
https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly#newcode5
input/regression/skyline-point-extent.ly:5: even
Thanks for the review!
https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly
File input/regression/skyline-point-extent.ly (right):
https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly#newcode5
On 27 févr. 2013, at 07:03, k-ohara5...@oco.net wrote:
Just needs cleanup of some leftover unneeded complications.
https://codereview.appspot.com/7310075/diff/38001/lily/skyline.cc
File lily/skyline.cc (right):
Just needs cleanup of some leftover unneeded complications.
https://codereview.appspot.com/7310075/diff/38001/lily/skyline.cc
File lily/skyline.cc (right):
https://codereview.appspot.com/7310075/diff/38001/lily/skyline.cc#newcode488
lily/skyline.cc:488: will be ignored.
What do you mean by
On 2013/02/18 02:59:58, Keith wrote:
On Sun, 17 Feb 2013 02:07:19 -0800, mailto:m...@mikesolomon.org
mailto:m...@mikesolomon.org
wrote:
The classic error with floating point is to do math on the pair,
something like (left . right) + shift/3.0 , where left==right, and
then ask is_empty().
On 16 févr. 2013, at 21:20, k-ohara5...@oco.net wrote:
Best, of course, would be to find and repair the code that cannot handle
zero-widths. We do not yet have the choice between a bit better and
best, merely a bit better or nothing.
One solution is to just allow 0-width buildings and then
On Sun, 17 Feb 2013 02:07:19 -0800, m...@mikesolomon.org m...@mikesolomon.org
wrote:
On 16 févr. 2013, at 21:20, k-ohara5...@oco.net wrote:
Best, of course, would be to find and repair the code that cannot handle
zero-widths. We do not yet have the choice between a bit better and
best,
https://codereview.appspot.com/7310075/diff/12001/lily/separation-item.cc
File lily/separation-item.cc (right):
https://codereview.appspot.com/7310075/diff/12001/lily/separation-item.cc#newcode156
lily/separation-item.cc:156: // If these two uses of inf combine, leave
the empty extent.
The
Joe disallowed buildings of zero width in his skylines for reasons given
only as avoiding numerical inaccuracies. Could be something like
depending on the +/- sign of 0.0, or depending on advancement through
loops when we increment by a building width.
It seems a bit better, for consistency, to
On Sat, 09 Feb 2013 23:24:41 -0800, mts...@gmail.com wrote:
https://codereview.appspot.com/7310075/diff/10/lily/grob.cc#newcode488
lily/grob.cc:488: Interval iv = robust_scm2interval (iv_scm, Interval
());
On 2013/02/10 03:08:04, Keith wrote:
I assume you will apply this change and the change
https://codereview.appspot.com/7310075/diff/10/input/regression/skyline-point-extent.ly
File input/regression/skyline-point-extent.ly (right):
https://codereview.appspot.com/7310075/diff/10/input/regression/skyline-point-extent.ly#newcode7
input/regression/skyline-point-extent.ly:7: }
... The
New patch set coming after I finish running the regtests.
https://codereview.appspot.com/7310075/diff/10/input/regression/skyline-point-extent.ly
File input/regression/skyline-point-extent.ly (right):
22 matches
Mail list logo
