Re: Uploading a patch to Rietveld

2011-05-02 Thread Phil Holmes
Latest sit-rep of my attempts. I now have a bin directory under my home phil directory. It contains a singe file - looks like it's a link to git-cl at /home/phil/git-cl/git-cl. If I do git cl upload origin/master I get: git: 'cl' is not a git command I'm guessing a) my bin directory is not

RE: Uploading a patch to Rietveld

2011-05-02 Thread James Lowe
a patch to Rietveld ) )Latest sit-rep of my attempts. ) )I now have a bin directory under my home phil directory. It contains a )singe file - looks like it's a link to git-cl at /home/phil/git-cl/git-cl. ) )If I do git cl upload origin/master I get: )git: 'cl' is not a git command can you use

Re: Uploading a patch to Rietveld

2011-05-02 Thread Phil Holmes
- Original Message - From: James Lowe james.l...@datacore.com To: Phil Holmes m...@philholmes.net; Graham Percival gra...@percival-music.ca Cc: lilypond-devel@gnu.org Sent: Monday, May 02, 2011 10:52 AM Subject: RE: Uploading a patch to Rietveld Phil, )-Original Message

RE: Uploading a patch to Rietveld

2011-05-02 Thread James Lowe
Phil, )-Original Message- )From: Phil Holmes [mailto:m...@philholmes.net] )Sent: 02 May 2011 11:39 )To: James Lowe; Graham Percival )Cc: lilypond-devel@gnu.org )Subject: Re: Uploading a patch to Rietveld ) ) )- Original Message - )From: James Lowe james.l...@datacore.com )To: Phil

Re: Uploading a patch to Rietveld

2011-05-02 Thread David Kastrup
Phil Holmes m...@philholmes.net writes: phil@phil-lilydev:~/lilypond-git$ git-cl upload origin/master bash: /bin/git-cl: No such file or directory That sounds like a symbolic link from /bin/git-cl pointing nowhere. There is little reason for bash to single out /bin/git-cl otherwise. -- David

Re: Uploading a patch to Rietveld

2011-05-02 Thread Graham Percival
On Mon, May 02, 2011 at 10:22:26AM +0100, Phil Holmes wrote: I'm guessing a) my bin directory is not in my PATH yet? Sounds like it. - have you rebooted? IIRC the ubuntu startup scripts automatically add ~/bin/ to your PATH if it exists. - if no, then add this to your ~/.profile # set PATH

Re: Uploading a patch to Rietveld

2011-05-02 Thread Phil Holmes
- Original Message - From: Graham Percival gra...@percival-music.ca To: Phil Holmes m...@philholmes.net Cc: lilypond-devel@gnu.org Sent: Monday, May 02, 2011 12:41 PM Subject: Re: Uploading a patch to Rietveld On Mon, May 02, 2011 at 10:22:26AM +0100, Phil Holmes wrote: I'm guessing

Re: Uploading a patch to Rietveld

2011-05-02 Thread Graham Percival
On Mon, May 02, 2011 at 01:41:50PM +0100, Phil Holmes wrote: - Original Message - From: Graham Percival - have you rebooted? IIRC the ubuntu startup scripts No. I have now, and git cl now works :-) Except I get a failure like this: phil@phil-lilydev:~/lilypond-git$ git cl upload

Re: Uploading a patch to Rietveld

2011-05-02 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: On Mon, May 02, 2011 at 01:41:50PM +0100, Phil Holmes wrote: - Original Message - From: Graham Percival - have you rebooted? IIRC the ubuntu startup scripts No. I have now, and git cl now works :-) Except I get a failure like this:

Re: Uploading a patch to Rietveld

2011-05-02 Thread Phil Holmes
- Original Message - From: Graham Percival gra...@percival-music.ca To: Phil Holmes m...@philholmes.net Cc: lilypond-devel@gnu.org Sent: Monday, May 02, 2011 2:08 PM Subject: Re: Uploading a patch to Rietveld On Mon, May 02, 2011 at 01:41:50PM +0100, Phil Holmes wrote: - Original

Re: Uploading a patch to Rietveld

2011-05-02 Thread Phil Holmes
- Original Message - From: Phil Holmes m...@philholmes.net To: Graham Percival gra...@percival-music.ca In the end, I nuked the git directory (having copied my changes elsewhere) and started from scratch. It's at http://codereview.appspot.com/4428077/ but hopefully this should be

RE: Uploading a patch to Rietveld

2011-05-02 Thread James Lowe
Hello, )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of Phil Holmes )Sent: 02 May 2011 17:16 )To: Graham Percival )Cc: lilypond-devel@gnu.org )Subject: Re: Uploading a patch

Re: Uploading a patch to Rietveld

2011-05-02 Thread Phil Holmes
- Original Message - From: James Lowe james.l...@datacore.com To: Phil Holmes m...@philholmes.net; Graham Percival gra...@percival-music.ca Cc: lilypond-devel@gnu.org Sent: Monday, May 02, 2011 5:28 PM Subject: RE: Uploading a patch to Rietveld Hello, )-Original Message

Re: Uploading a patch to Rietveld

2011-05-02 Thread Graham Percival
On Mon, May 02, 2011 at 05:36:59PM +0100, Phil Holmes wrote: - Original Message - From: James Lowe )BTW - it might be worth mentioning in the CG that git cl upload )origin/master at one point fires you into vi. For windows users, that's a )bit of an issue - took me a couple of

Uploading a patch to Rietveld

2011-05-01 Thread Phil Holmes
I've created a patch that gets rid of the warning messages in make website, and want to upload it for comments. I use the LilyPond Ubuntu build in a VM, and use lily-git.tcl. I've created the patch, and am trying to follow the instructions at

Re: Uploading a patch to Rietveld

2011-05-01 Thread Phil Holmes
- Original Message - From: Graham Percival gra...@percival-music.ca To: Phil Holmes m...@philholmes.net Cc: lilypond-devel@gnu.org Sent: Sunday, May 01, 2011 5:59 PM Subject: Re: Uploading a patch to Rietveld On Sun, May 01, 2011 at 05:36:45PM +0100, Phil Holmes wrote: When I type

Re: Uploading a patch to Rietveld

2011-05-01 Thread Graham Percival
On Sun, May 01, 2011 at 06:44:41PM +0100, Phil Holmes wrote: - Original Message - From: Graham Percival Are you certain that you have the latest version? IIRC we added git-cl in lilydev-1.1. It was certainly one of the last things that was added. We certainly don't expect new

Re: Uploading a patch to Rietveld

2011-05-01 Thread Phil Holmes
- Original Message - From: Graham Percival gra...@percival-music.ca To: Phil Holmes m...@philholmes.net Cc: lilypond-devel@gnu.org Sent: Sunday, May 01, 2011 7:16 PM Subject: Re: Uploading a patch to Rietveld On Sun, May 01, 2011 at 06:44:41PM +0100, Phil Holmes wrote: - Original

Re: Uploading a patch to Rietveld

2011-05-01 Thread Graham Percival
On Sun, May 01, 2011 at 08:35:15PM +0100, Phil Holmes wrote: - Original Message - From: Graham Percival On Sun, May 01, 2011 at 06:44:41PM +0100, Phil Holmes wrote: the iso from lilynet is named ubuntu-lilydev-remix-1.1.iso so if yours is called something else, I'd be suspicious.

Re: Uploading a patch to Rietveld

2011-05-01 Thread Phil Holmes
- Original Message - From: Graham Percival gra...@percival-music.ca To: Phil Holmes m...@philholmes.net Cc: lilypond-devel@gnu.org Sent: Sunday, May 01, 2011 9:02 PM Subject: Re: Uploading a patch to Rietveld On Sun, May 01, 2011 at 08:35:15PM +0100, Phil Holmes wrote: - Original

Re: Uploading a patch to Rietveld

2011-05-01 Thread David Kastrup
Graham Percival gra...@percival-music.ca writes: Both methods will work, but one of them feels a bit off. and then try: git-cl you should get a git cl help message at this point. Yup :-). Is the CG in error - it says git cl, not git-cl? It should be fine either way. Why? AFAICS, git

Re: Uploading a patch to Rietveld

2011-05-01 Thread Reinhold Kainhofer
Am Sonntag, 1. Mai 2011, um 23:36:16 schrieb David Kastrup: Graham Percival gra...@percival-music.ca writes: Both methods will work, but one of them feels a bit off. and then try: git-cl you should get a git cl help message at this point. Yup :-). Is the CG in error - it says

Re: Uploading a patch to Rietveld

2011-05-01 Thread Graham Percival
On Sun, May 01, 2011 at 11:54:43PM +0200, Reinhold Kainhofer wrote: Am Sonntag, 1. Mai 2011, um 23:36:16 schrieb David Kastrup: If you did not place the git-cl binary there, you can't use git cl instead. If you did place it there, you can't use git-cl as it won't be in the path. Clearly