On Tue, Jun 26, 2012 at 11:51 PM, Robert Lee rob@linaro.org wrote:
Add imx anatop peripheral thermal driver and use it for imx6q builds.
This driver hooks into the linux thermal framework which provides a
sysfs interface for temperature readings and other information and
a mechanism to
On Wed, Jun 27, 2012 at 8:48 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Tue, Jun 26, 2012 at 11:51:55PM -0500, Robert Lee wrote:
+static inline int anatop_get_temp(int *temp, struct thermal_zone_device
*tzdev)
+{
+ unsigned int n_meas;
+ unsigned int reg;
+ struct
Hey Amit,
I was just re-organizing the imx thermal driver that uses this cpu
cooling interface and noticed a couple of small issues here. If
these suggestions are agreed upon and if it's too late for these
issues be changed with this patchset, I can submit them separately
unless you'd prefer
On Wed, Jun 20, 2012 at 9:15 AM, Rob Lee rob@linaro.org wrote:
Hello Sascha,
On Wed, Jun 20, 2012 at 5:30 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
Hi Robert,
On Mon, May 21, 2012 at 05:50:23PM -0500, Robert Lee wrote:
Cleanup up imx5 idle code and enable imx5 low powe idle
On Wed, Jun 20, 2012 at 2:06 AM, Robert Lee rob@linaro.org wrote:
Add imx6q cpu thermal management driver using the new cpu cooling
interface which limits system performance via cpufreq to reduce
the cpu temperature. Temperature readings are taken using
the imx6q temperature sensor and
Sascha, thanks for the review.
On Wed, Jun 20, 2012 at 5:11 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Wed, Jun 20, 2012 at 02:06:04AM -0500, Robert Lee wrote:
Add imx6q cpu thermal management driver using the new cpu cooling
interface which limits system performance via cpufreq to
Hello Sascha,
On Wed, Jun 20, 2012 at 5:30 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
Hi Robert,
On Mon, May 21, 2012 at 05:50:23PM -0500, Robert Lee wrote:
Cleanup up imx5 idle code and enable imx5 low powe idle for imx53.
Add common imx cpuidle initialization functionality and add a
On Wed, Jun 20, 2012 at 9:20 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Wed, Jun 20, 2012 at 09:12:51AM -0500, Rob Lee wrote:
Sascha, thanks for the review.
+
+static struct imx6q_thermal_zone *th_zone;
+static void __iomem *ocotp_base;
This is a driver
Hey Daniel,
Sorry for the late review/response but perhaps this will still be
useful as your cpuidle work is ongoing.
Most of the caller are in the boot-up code, in device_init or module_init.
The other ones are doing some specific initialization on the cpuidle_device
(cpuinit, like acpi) and
On Wed, May 16, 2012 at 12:38 PM, Sascha Hauer s.ha...@pengutronix.de wrote:
Hi Robert,
Overall this looks ok now, some comments inline.
Sascha
On Tue, May 15, 2012 at 09:33:32PM -0500, Robert Lee wrote:
The imx5 idle code that existed in mm-imx5.c is moved to pm-imx5.c.
The imx5_pm_init
On Wed, May 16, 2012 at 12:47 PM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Tue, May 15, 2012 at 09:33:33PM -0500, Robert Lee wrote:
Add various functionality needed to enable a imx53 low power idle
state. This includes adding the imx53 gpc_dvfs clock and making a
common imx5_late_init
On Wed, May 16, 2012 at 12:55 PM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Tue, May 15, 2012 at 09:33:34PM -0500, Robert Lee wrote:
Add common cpuidle init functionality that can be used by various
imx platforms.
Signed-off-by: Robert Lee rob@linaro.org
---
+
+#ifdef
Hello Uwe and Sascha,
On Wed, May 9, 2012 at 7:24 PM, Robert Lee rob@linaro.org wrote:
A change is needed in the IMX_IO_P2V macro to allow all imx5 platforms
to use common definitions when accessing registers of peripherals on
the AIPS2 bus.
This change was tested for mapping conflicts
Sascha,
On Wed, May 9, 2012 at 3:02 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Mon, May 07, 2012 at 04:16:46PM -0500, Robert Lee wrote:
Add imx5 cpuidle driver.
Signed-off-by: Robert Lee rob@linaro.org
---
arch/arm/mach-imx/mm-imx5.c | 42
On Tue, May 1, 2012 at 10:23 PM, Shawn Guo shawn@linaro.org wrote:
On Tue, May 01, 2012 at 09:12:40PM -0500, Robert Lee wrote:
Add basic imx6q cpuidle driver. For now, only basic WFI state is
supported. Deeper idle states will be added in the future.
Signed-off-by: Robert Lee
Shawn,
On Tue, May 1, 2012 at 10:13 PM, Shawn Guo shawn@linaro.org wrote:
On Tue, May 01, 2012 at 09:12:38PM -0500, Robert Lee wrote:
Add common cpuidle init functionality that can be used by various
imx platforms.
Signed-off-by: Robert Lee rob@linaro.org
---
On Wed, May 2, 2012 at 9:07 AM, Shawn Guo shawn@linaro.org wrote:
On 2 May 2012 21:59, Rob Lee rob@linaro.org wrote:
+ ret = cpuidle_register_device(dev);
+ if (ret) {
+ pr_err(%s: Failed to register cpu %u\n
Sascha,
On Wed, May 2, 2012 at 2:27 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Tue, May 01, 2012 at 09:12:38PM -0500, Robert Lee wrote:
Add common cpuidle init functionality that can be used by various
imx platforms.
Signed-off-by: Robert Lee rob@linaro.org
---
+
+int __init
Sascha,
On Wed, May 2, 2012 at 2:33 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Tue, May 01, 2012 at 09:12:39PM -0500, Robert Lee wrote:
Add imx5 cpuidle driver.
Signed-off-by: Robert Lee rob@linaro.org
---
arch/arm/mach-imx/mm-imx5.c | 42
On Wed, Apr 25, 2012 at 9:44 AM, Daniel Lezcano
daniel.lezc...@linaro.org wrote:
On 04/25/2012 02:11 PM, Amit Daniel Kachhap wrote:
This patch enables core cpuidle timekeeping and irq enabling and
remove those redundant parts from the exynos cpuidle drivers
CC: Daniel
On Tue, Apr 24, 2012 at 3:36 AM, Shawn Guo shawn@linaro.org wrote:
On Tue, Apr 24, 2012 at 08:54:26AM +0100, Russell King - ARM Linux wrote:
On Tue, Apr 24, 2012 at 09:38:43AM +0800, Shawn Guo wrote:
On Mon, Apr 23, 2012 at 10:45:02AM -0500, Rob Lee wrote:
Let me try last time. What
Let me try last time. What about having a late_initcall hook in
machine_desc?
Also fine with me.
Shall I add Shawn's patch to my imx cpuidle patchset or should the
arch/arm/kernel/setup.c and arch.h changes be submitted separately?
If separately, Shawn, did you want to submit this patch or
If I called imx_cpuidle_init directly from imx5 or imx6q init
routines, it would be getting called before the coreinit_call of core
cpuidle causing a failure. There were various other directions to
take and all seemed less desirable than this one.
One alternative would be to add a function
On Tue, Apr 17, 2012 at 2:43 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Mon, Apr 16, 2012 at 06:50:12PM -0500, Robert Lee wrote:
Add common cpuidle init functionality that can be used by various
imx platforms.
Signed-off-by: Robert Lee rob@linaro.org
---
diff --git
On Tue, Apr 17, 2012 at 3:10 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Mon, Apr 16, 2012 at 06:37:48PM -0500, Robert Lee wrote:
The imx5_idle() check of the tzic_eanble_wake() return value uses
incorrect (inverted) logic causing all attempt to idle to fail.
Does this have influence
On Tue, Apr 17, 2012 at 9:13 AM, Christian Robottom Reis
k...@linaro.org wrote:
On Tue, Apr 17, 2012 at 08:54:03AM -0500, Rob Lee wrote:
+void __init imx_cpuidle_set_driver(struct cpuidle_driver *p)
+{
+ drv = p;
+}
You like it complicated, eh? Why do you introduce a function
+void __init imx_cpuidle_set_driver(struct cpuidle_driver *p)
+{
+ drv = p;
+}
You like it complicated, eh? Why do you introduce a function which sets
a variable...
This complication is used to deal with the timing of various levels of
init calls. More explanation below.
On Thu, Apr 5, 2012 at 12:52 AM, Amit Daniel Kachhap
amit.kach...@linaro.org wrote:
Hi Durgadoss,
Instead of making all the trip-points of a thermal zone writeable we should
only allow non-critical trip points to be writeable.
Thanks,
Amit Daniel
Agree, or even better, could the writeable
Sorry, I just read Durgadoss last comment. Please ignore mine.
On Fri, Apr 6, 2012 at 8:01 AM, Rob Lee rob@linaro.org wrote:
On Thu, Apr 5, 2012 at 12:52 AM, Amit Daniel Kachhap
amit.kach...@linaro.org wrote:
Hi Durgadoss,
Instead of making all the trip-points of a thermal zone
On Tue, Mar 20, 2012 at 7:10 PM, Kevin Hilman khil...@ti.com wrote:
Hi Rob,
Robert Lee rob@linaro.org writes:
This patch series moves various functionality duplicated in platform
cpuidle drivers to the core cpuidle driver. Also, the platform irq
disabling was removed as it appears that
On Wed, Mar 21, 2012 at 9:28 AM, Rob Lee rob@linaro.org wrote:
Sekhar tested this patch on Davinci last night and found a problem. I
looked at the code again and found a mindless omission on my part (see
below). Fix is trivial. I've check all other platforms and confirmed
this problem
Sekhar tested this patch on Davinci last night and found a problem. I
looked at the code again and found a mindless omission on my part (see
below). Fix is trivial. I've check all other platforms and confirmed
this problem does not exist for those. Will resend a v9 of the
patchset shortly.
On
or information on my part.
Thanks,
Rob
On Fri, Mar 9, 2012 at 12:40 AM, Stephen Rothwell s...@canb.auug.org.au wrote:
Hi Rob,
On Thu, 8 Mar 2012 19:58:23 -0600 Rob Lee rob@linaro.org wrote:
git://git.linaro.org/people/rob_lee/linux.git cpuidle_consol_pull
These changes move various
Hello Stephen,
The following changes since commit 192cfd58774b4d17b2fe8bdc77d89c2ef4e0591d:
Linux 3.3-rc6 (2012-03-03 17:08:09 -0800)
are available in the git repository at:
git://git.linaro.org/people/rob_lee/linux.git cpuidle_consol_pull
Robert Lee (8):
cpuidle: Add common time
On Wed, Feb 29, 2012 at 6:42 PM, Robert Lee rob@linaro.org wrote:
This patch series moves various functionality duplicated in platform
cpuidle drivers to the core cpuidle driver. Also, the platform irq
disabling was removed as it appears that all calls into
cpuidle_call_idle will have
On Wed, Feb 29, 2012 at 2:36 AM, Jean Pihet jean.pi...@newoldbits.com wrote:
Rob,
On Wed, Feb 29, 2012 at 4:11 AM, Robert Lee rob@linaro.org wrote:
Enable core cpuidle timekeeping and irq enabling and remove that
handling from this code.
Signed-off-by: Robert Lee rob@linaro.org
---
Hello Deepthi,
On Wed, Feb 29, 2012 at 5:13 AM, Deepthi Dharwar
deep...@linux.vnet.ibm.com wrote:
Hi Rob,
On 02/29/2012 08:41 AM, Robert Lee wrote:
Make necessary changes to implement time keeping and irq enabling
in the core cpuidle code. This will allow the removal of these
On Wed, Feb 29, 2012 at 2:30 AM, Jean Pihet jean.pi...@newoldbits.com wrote:
Hi Rob,
On Wed, Feb 29, 2012 at 4:11 AM, Robert Lee rob@linaro.org wrote:
Make necessary changes to implement time keeping and irq enabling
in the core cpuidle code. This will allow the removal of these
On Wed, Feb 29, 2012 at 12:43 PM, Kevin Hilman khil...@ti.com wrote:
Robert Lee rob@linaro.org writes:
Make necessary changes to implement time keeping and irq enabling
in the core cpuidle code. This will allow the removal of these
functionalities from various platform cpuidle
Hey Mike,
On Mon, Feb 27, 2012 at 6:06 PM, Turquette, Mike mturque...@ti.com wrote:
On Sun, Feb 26, 2012 at 8:47 PM, Robert Lee rob@linaro.org wrote:
+/**
+ * cpuidle_enter_wrap - performing timekeeping and irq around enter function
+ * @dev: pointer to a valid cpuidle_device object
+ *
On Mon, Feb 27, 2012 at 6:49 PM, Turquette, Mike mturque...@ti.com wrote:
On Sun, Feb 26, 2012 at 8:47 PM, Robert Lee rob@linaro.org wrote:
+/**
+ * cpuidle_enter_wrap - performing timekeeping and irq around enter function
+ * @dev: pointer to a valid cpuidle_device object
+ * @drv:
Any reason that this code is in the header? Why not in cpuidle.c?
Not a strong reason. I thought making it an inline would introduce
slightly less new execution when adding this code (realizing that
there are function calls immediately after, so the only benefit is the
reduce popping and
I brought this topic up internally and Jon suggested that the 'usage'
statistics that are reported in sysfs should also reflect failed
versus successful C-state transitions, which is a great idea. This
could simply be achieved by renaming the current 'usage' count to
something like
Sounds reasonable. In some cases it may be helpful to track state
demotion as well. Since I'm still a noob and wearing my submission
training wheels, I'm trying to minimize things that fall outside of
this basic consolidation effort for this patch series. But I added
Jon's suggestion to
Adding sh mailing list and sh contributors I missed on the original
submission. SH folks, full patchset submission can be found here:
http://www.spinics.net/lists/arm-kernel/msg161596.html
Best Regards,
Rob
On Sun, Feb 26, 2012 at 10:47 PM, Robert Lee rob@linaro.org wrote:
Enable core
On Mon, Feb 27, 2012 at 10:19 AM, Jean Pihet jean.pi...@newoldbits.com wrote:
Robert,
On Mon, Feb 27, 2012 at 5:47 AM, Robert Lee rob@linaro.org wrote:
Add functionality that is commonly duplicated by various platforms.
Signed-off-by: Robert Lee rob@linaro.org
---
On Mon, Feb 27, 2012 at 10:26 AM, Jean Pihet jean.pi...@newoldbits.com wrote:
On Mon, Feb 27, 2012 at 5:47 AM, Robert Lee rob@linaro.org wrote:
Use core cpuidle timekeeping and irqen wrapper and remove that
handling from this code.
Signed-off-by: Robert Lee rob@linaro.org
---
On Wed, Feb 22, 2012 at 2:52 PM, Colin Cross ccr...@google.com wrote:
On Fri, Feb 10, 2012 at 11:32 AM, Rob Lee rob@linaro.org wrote:
Maintainers for drivers/cpuidle, do you have any comments/opinions
about this patch?
Intel cpuidle and acpi cpuidle maintainers, do you have any
comments
Maintainers for drivers/cpuidle, do you have any comments/opinions
about this patch?
Intel cpuidle and acpi cpuidle maintainers, do you have any
comments/opinions about this patch and the changes to your code?
Any other review and comments welcome.
Summary of positive and negatives as I
On Sat, Feb 4, 2012 at 4:06 PM, Turquette, Mike mturque...@ti.com wrote:
On Sat, Feb 4, 2012 at 11:02 AM, Colin Cross ccr...@google.com wrote:
On Tue, Jan 31, 2012 at 7:00 PM, Robert Lee rob@linaro.org wrote:
Make necessary changes to add implement time keepign and irq enabling
keeping
in
Hello Colin, thanks for the review.
On Sat, Feb 4, 2012 at 1:02 PM, Colin Cross ccr...@google.com wrote:
On Tue, Jan 31, 2012 at 7:00 PM, Robert Lee rob@linaro.org wrote:
Make necessary changes to add implement time keepign and irq enabling
keeping
in the core cpuidle code. This will
On Thu, Feb 2, 2012 at 10:21 AM, Jean Pihet jean.pi...@newoldbits.com wrote:
Rob,
On Wed, Feb 1, 2012 at 4:00 AM, Robert Lee rob@linaro.org wrote:
Now that the core cpuidle driver keeps time and handles irq enabling,
remove this functionality. Also, remove irq disabling as all paths to
Hey Amit, I was able to use your code on an i.MX6Q thermal
implementation and it seemed to work pretty well. Thanks for adding
this. A couple of comments below.
On Tue, Dec 13, 2011 at 9:13 AM, Amit Daniel Kachhap
amit.kach...@linaro.org wrote:
This patch adds support for generic cpu thermal
Hey Amit/Vincent,
It appears that with this implementation the STATE_ACTIVE trip number
used will also be the index of the cool_freq_tab used. If that is
true, then perhaps a common structure would be beneficial that links
each STATE_ACTIVE trip point with its corresponding cooling data.
BR,
Hey Paul,
I'm already working on upstreaming a thermal driver for i.MX6. I'm
currently on hold paused to upstream cpufreq for i.MX6 and do some
cpuidle work but I predict that I'll be ready to submit a first
version sometime next week.
For all things power management related on i.MX(cpufreq,
(Re-send from my Linaro email address this time)
Requesting to add the commits in the attached patch to the October
Linaro release. These commits add a common imx cpuidle driver, some
common cpuidle mach-mx5 code, and the init call for i.MX51 SoCs.
Requesting to add the commits in the attached patch to the October
Linaro release. These commits add a common imx cpuidle driver, some
common cpuidle mach-mx5 code, and the init call for i.MX51 SoCs.
git://git.linaro.org/people/rob_lee/imx_cpuidle.git imx_mx5_mx51
A patch series containing this
57 matches
Mail list logo
