On Wed, Jun 20, 2012 at 02:06:04AM -0500, Robert Lee wrote:
Add imx6q cpu thermal management driver using the new cpu cooling
interface which limits system performance via cpufreq to reduce
the cpu temperature. Temperature readings are taken using
the imx6q temperature sensor and this
Hi Robert,
On Mon, May 21, 2012 at 05:50:23PM -0500, Robert Lee wrote:
Cleanup up imx5 idle code and enable imx5 low powe idle for imx53.
Add common imx cpuidle initialization functionality and add a i.MX5 and i.MX6Q
platform cpuidle implementation.
I rebased this to 3.5-rc1 here:
On Wed, Jun 20, 2012 at 09:12:51AM -0500, Rob Lee wrote:
Sascha, thanks for the review.
+
+static struct imx6q_thermal_zone *th_zone;
+static void __iomem *ocotp_base;
This is a driver and drivers should generally be multi instance safe.
I don't understand
Hi Robert,
On Mon, May 21, 2012 at 05:50:23PM -0500, Robert Lee wrote:
Cleanup up imx5 idle code and enable imx5 low powe idle for imx53.
Add common imx cpuidle initialization functionality and add a i.MX5 and i.MX6Q
platform cpuidle implementation.
The series looks good now. We can take
On Thu, May 17, 2012 at 09:46:21AM -0500, Rob Lee wrote:
On Wed, May 16, 2012 at 12:47 PM, Sascha Hauer s.ha...@pengutronix.de wrote:
+void __init imx5_init_late(void)
+{
+ imx5_pm_init();
+}
+
void __init imx51_init_late(void)
{
mx51_neon_fixup
On Thu, May 17, 2012 at 09:34:26AM -0500, Rob Lee wrote:
On Wed, May 16, 2012 at 12:38 PM, Sascha Hauer s.ha...@pengutronix.de wrote:
Hi Robert,
Overall this looks ok now, some comments inline.
+ return ret;
+
+ if (cpu_is_mx51())
+ suspend_set_ops
Hi Robert,
Overall this looks ok now, some comments inline.
Sascha
On Tue, May 15, 2012 at 09:33:32PM -0500, Robert Lee wrote:
The imx5 idle code that existed in mm-imx5.c is moved to pm-imx5.c.
The imx5_pm_init call is now exported and called during the
MACHINE_START late_init in supported
On Tue, May 15, 2012 at 09:33:33PM -0500, Robert Lee wrote:
Add various functionality needed to enable a imx53 low power idle
state. This includes adding the imx53 gpc_dvfs clock and making a
common imx5_late_init function and initializing all imx53
MACHINE_STATE late_init calls to
On Tue, May 15, 2012 at 09:33:34PM -0500, Robert Lee wrote:
Add common cpuidle init functionality that can be used by various
imx platforms.
Signed-off-by: Robert Lee rob@linaro.org
---
+
+#ifdef CONFIG_CPU_IDLE
+extern int imx_cpuidle_init(struct cpuidle_driver *drv);
+#else
On Mon, May 07, 2012 at 04:16:46PM -0500, Robert Lee wrote:
Add imx5 cpuidle driver.
Signed-off-by: Robert Lee rob@linaro.org
---
arch/arm/mach-imx/mm-imx5.c | 42 +++---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git
tries to change the
parent rate even if it is not allowed to. This can be added in a later
patch, so
Acked-by: Sascha Hauer s.ha...@pengutronix.de
Sascha
---
drivers/clk/clk.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
On Fri, May 04, 2012 at 04:24:17PM +, Arnd Bergmann wrote:
On Thursday 03 May 2012, Sascha Hauer wrote:
I don't think that enforcing DT only in multiplatform kernels will speed
up porting to DT. As a platform maintainer I am interested in building
multiplatform Kernels, but our
On Wed, May 02, 2012 at 03:11:35PM -0500, Rob Lee wrote:
Sascha,
mxc_iomux_v3_init(MX51_IO_ADDRESS(MX51_IOMUXC_BASE_ADDR));
mxc_arch_reset_init(MX51_IO_ADDRESS(MX51_WDOG1_BASE_ADDR));
- arm_pm_idle = imx5_idle;
+ arm_pm_idle = (void *)imx5_idle;
I don't like
On Tue, May 01, 2012 at 09:12:38PM -0500, Robert Lee wrote:
Add common cpuidle init functionality that can be used by various
imx platforms.
Signed-off-by: Robert Lee rob@linaro.org
---
+
+int __init imx_cpuidle_init(struct cpuidle_driver *drv)
+{
+ struct cpuidle_device *dev;
+
On Tue, May 01, 2012 at 09:12:39PM -0500, Robert Lee wrote:
Add imx5 cpuidle driver.
Signed-off-by: Robert Lee rob@linaro.org
---
arch/arm/mach-imx/mm-imx5.c | 42 +++---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git
On Wed, May 02, 2012 at 02:16:36PM -0500, Rob Lee wrote:
Sascha,
+int __init imx_cpuidle_init(struct cpuidle_driver *drv)
+{
+ struct cpuidle_device *dev;
+ int cpu_id, ret;
+
+ if (!drv || drv-state_count CPUIDLE_STATE_MAX) {
Please don't check for !drv here. When
On Mon, Apr 23, 2012 at 01:18:21PM +0800, Shawn Guo wrote:
On Sun, Apr 22, 2012 at 11:44:39PM -0500, Rob Lee wrote:
I don't think we need a cpu_is_imx6q(), but having some i.MX6 specific
hook at device_initcall time can't be too wrong. Shawn?
Yep, it works for me.
Sascha, Shawn,
On Mon, Apr 23, 2012 at 02:53:01PM +0800, Shawn Guo wrote:
On Mon, Apr 23, 2012 at 08:27:39AM +0200, Sascha Hauer wrote:
On Mon, Apr 23, 2012 at 01:18:21PM +0800, Shawn Guo wrote:
On Sun, Apr 22, 2012 at 11:44:39PM -0500, Rob Lee wrote:
I don't think we need a cpu_is_imx6q(), but having
On Mon, Apr 23, 2012 at 03:10:15PM +0800, Shawn Guo wrote:
On Mon, Apr 23, 2012 at 08:56:23AM +0200, Sascha Hauer wrote:
On Mon, Apr 23, 2012 at 02:53:01PM +0800, Shawn Guo wrote:
On Mon, Apr 23, 2012 at 08:27:39AM +0200, Sascha Hauer wrote:
On Mon, Apr 23, 2012 at 01:18:21PM +0800
On Wed, Apr 18, 2012 at 11:18:55PM -0500, Rob Lee wrote:
If I called imx_cpuidle_init directly from imx5 or imx6q init
routines, it would be getting called before the coreinit_call of core
cpuidle causing a failure. There were various other directions to
take and all seemed less desirable
On Tue, Apr 17, 2012 at 09:11:32AM -0500, Rob Lee wrote:
On Tue, Apr 17, 2012 at 3:10 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Mon, Apr 16, 2012 at 06:37:48PM -0500, Robert Lee wrote:
The imx5_idle() check of the tzic_eanble_wake() return value uses
incorrect (inverted) logic
On Mon, Apr 16, 2012 at 06:50:12PM -0500, Robert Lee wrote:
Add common cpuidle init functionality that can be used by various
imx platforms.
Signed-off-by: Robert Lee rob@linaro.org
---
diff --git a/arch/arm/plat-mxc/Makefile b/arch/arm/plat-mxc/Makefile
index e81290c..7c9e05f 100644
On Mon, Apr 16, 2012 at 06:37:48PM -0500, Robert Lee wrote:
The imx5_idle() check of the tzic_eanble_wake() return value uses
incorrect (inverted) logic causing all attempt to idle to fail.
Does this have influence on current kernels or does this only trigger
with your cpuidle patches?
On Tue, Apr 17, 2012 at 08:54:03AM -0500, Rob Lee wrote:
On Tue, Apr 17, 2012 at 2:43 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Mon, Apr 16, 2012 at 06:50:12PM -0500, Robert Lee wrote:
Add common cpuidle init functionality that can be used by various
imx platforms.
Signed-off
King li...@arm.linux.org.uk
Cc: Sascha Hauer s.ha...@pengutronix.de
Cc: Shawn Guo shawn@freescale.com
Cc: Richard Zhao richard.z...@linaro.org
Cc: Saravana Kannan skan...@codeaurora.org
Cc: Mark Brown broo...@opensource.wolfsonmicro.com
Cc: Andrew Lunn and...@lunn.ch
Cc: Rajendra Nayak rna
On Wed, Apr 11, 2012 at 06:02:51PM -0700, Mike Turquette wrote:
This patch is the basic clk version of 'clk: core: copy parent_names
return error codes'.
The registration functions are changed to allow the core code to copy
the array of strings and allow platforms to declare those arrays as
putting SoC support onto it.
Except the last patch:
Acked-by: Sascha Hauer s.ha...@pengutronix.de
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim
On Wed, Mar 21, 2012 at 01:44:01AM -0600, Paul Walmsley wrote:
Hello Saravana,
Certainly a Kconfig help text change seems trivial enough. But even the
resistance to CONFIG_EXPERIMENTAL has been quite surprising to me, given
that every single defconfig in arch/arm/defconfig sets it:
$
On Mon, Mar 19, 2012 at 03:01:17PM +0800, Shawn Guo wrote:
On Fri, Mar 09, 2012 at 10:25:00AM -0800, Turquette, Mike wrote:
...
However if you have the ability to use the clk_foo_register functions
please do use them in place of static initialization. The static init
stuff is only for
On Mon, Mar 19, 2012 at 04:52:05PM +0530, Rajendra Nayak wrote:
Hi Mike,
+/*
+ * calculate the new rates returning the topmost clock that has to be
+ * changed.
+ */
+static struct clk *clk_calc_new_rates(struct clk *clk, unsigned long rate)
+{
+struct clk *top = clk;
+unsigned
On Sat, Mar 17, 2012 at 11:02:11AM -0700, Turquette, Mike wrote:
On Sat, Mar 17, 2012 at 2:05 AM, Arnd Bergmann a...@arndb.de wrote:
On Friday 16 March 2012, Turquette, Mike wrote:
On Fri, Mar 16, 2012 at 3:21 PM, Paul Walmsley p...@pwsan.com wrote:
From: Paul Walmsley p...@pwsan.com
carried over the *-by's from v6; I hope everyone is
OK with that.
Nice work, thanks again Mike. I gave it a test on various i.MX SoCs and
I can give you my:
Tested-by: Sascha Hauer s.ha...@pengutronix.de
Acked-by: Sascha Hauer s.ha...@pengutronix.de
Sascha
--
Pengutronix e.K
Hi Paul,
On Fri, Mar 16, 2012 at 04:21:17PM -0600, Paul Walmsley wrote:
Hi
On Fri, 16 Mar 2012, Arnd Bergmann wrote:
If the common clock code is to go upstream now, it should be marked as
experimental.
No, please don't do this. This effectively marks the architectures using
the
On Wed, Mar 14, 2012 at 05:51:48PM -0700, Turquette, Mike wrote:
On Tue, Mar 13, 2012 at 5:05 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Mon, Mar 12, 2012 at 08:16:36PM -0700, Turquette, Mike wrote:
On Mon, Mar 12, 2012 at 4:51 AM, Sascha Hauer s.ha...@pengutronix.de
wrote:
I
On Tue, Mar 13, 2012 at 04:43:57PM -0700, Turquette, Mike wrote:
On Tue, Mar 13, 2012 at 4:24 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Sat, Mar 03, 2012 at 12:29:00AM -0800, Mike Turquette wrote:
The common clock framework defines a common struct clk useful across
most platforms
characteristics.
Based on original work by Jeremy Kerr and contribution by Jamie Iles.
Dividers and multiplexor clocks originally contributed by Richard Zhao
Sascha Hauer.
Signed-off-by: Mike Turquette mturque...@linaro.org
Signed-off-by: Mike Turquette mturque...@ti.com
Cc: Russell King li
On Mon, Mar 12, 2012 at 10:50:09PM -0500, Matt Sealey wrote:
Hi Mike,
Can I suggest/we discuss that we support fractional (i.e. represented
by fixed point value with integer and fractional part) dividers in the
common divider clock case, simplistically just adding a divider
fractional width
On Sat, Mar 03, 2012 at 12:29:00AM -0800, Mike Turquette wrote:
The common clock framework defines a common struct clk useful across
most platforms as well as an implementation of the clk api that drivers
can use safely for managing clocks.
The net result is consolidation of many different
Hi Mike,
On Mon, Mar 12, 2012 at 08:16:36PM -0700, Turquette, Mike wrote:
On Mon, Mar 12, 2012 at 4:51 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Sun, Mar 11, 2012 at 02:24:46PM -0700, Turquette, Mike wrote:
On Sun, Mar 11, 2012 at 4:34 AM, Sascha Hauer s.ha...@pengutronix.de
wrote
On Sun, Mar 11, 2012 at 02:24:46PM -0700, Turquette, Mike wrote:
On Sun, Mar 11, 2012 at 4:34 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
Hi Mike,
I was about to give my tested-by when I decided to test the set_rate
function. Unfortunately this is broken for several reasons. I'll try
Hi Mike,
I was about to give my tested-by when I decided to test the set_rate
function. Unfortunately this is broken for several reasons. I'll try
to come up with a fixup series later the day.
On Fri, Mar 09, 2012 at 11:54:23PM -0800, Mike Turquette wrote:
+
+/**
+ * DOC: Using the
are compile
tested only.
A typical clock file will then look like this, here the i.MX27
implementation:
8---
ARM i.MX27: implement clocks using common clock framework
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
---
arch/arm/mach-imx
On Thu, Mar 08, 2012 at 07:27:39AM +0100, Andrew Lunn wrote:
Assuming that some day OMAP code can be refactored to allow for lazy
(or at least initcall-based) registration of clocks then perhaps your
suggestion can take root. Which leads me to this question: are there
any other platforms
-by: Sascha Hauer s.ha...@pengutronix.de
---
drivers/clk/clk-divider.c| 34 +++---
drivers/clk/clk-gate.c | 33 ++---
include/linux/clk-provider.h |2 ++
3 files changed, 31 insertions(+), 38 deletions(-)
diff --git a/drivers/clk
On Mon, Mar 05, 2012 at 12:03:15PM -0800, Turquette, Mike wrote:
On Sun, Mar 4, 2012 at 11:38 PM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Sun, Mar 04, 2012 at 04:12:21PM -0800, Turquette, Mike wrote:
I believe this patch already does what you suggest, but I might be
missing your
On Mon, Mar 05, 2012 at 09:48:23AM +0100, Andrew Lunn wrote:
On Sun, Mar 04, 2012 at 04:30:08PM -0800, Turquette, Mike wrote:
On Sun, Mar 4, 2012 at 9:42 AM, Andrew Lunn and...@lunn.ch wrote:
On Sat, Mar 03, 2012 at 12:29:01AM -0800, Mike Turquette wrote:
Many platforms support simple
On Sun, Mar 04, 2012 at 04:12:21PM -0800, Turquette, Mike wrote:
I believe this patch already does what you suggest, but I might be
missing your point.
In include/linux/clk-private.h you expose struct clk outside the core.
This has to be done to make static initializers possible. There
On Sat, Mar 03, 2012 at 09:14:43AM -0800, Turquette, Mike wrote:
On Sat, Mar 3, 2012 at 5:31 AM, Sascha Hauer s.ha...@pengutronix.de wrote:
On Sat, Mar 03, 2012 at 12:29:00AM -0800, Mike Turquette wrote:
The common clock framework defines a common struct clk useful across
most platforms
On Sat, Mar 03, 2012 at 12:29:00AM -0800, Mike Turquette wrote:
The common clock framework defines a common struct clk useful across
most platforms as well as an implementation of the clk api that drivers
can use safely for managing clocks.
The net result is consolidation of many different
On Mon, Oct 17, 2011 at 06:53:03PM +0800, Richard Zhao wrote:
On Mon, Oct 17, 2011 at 10:20:28AM +0100, Mark Brown wrote:
On Mon, Oct 17, 2011 at 04:48:52PM +0800, Richard Zhao wrote:
For example, devices that possible access to on-chip RAM, depend on OCRAM
clock.
On imx53, VPU
On Fri, Oct 14, 2011 at 06:32:33PM +0800, Richard Zhao wrote:
On Fri, Oct 14, 2011 at 11:05:04AM +0100, Mark Brown wrote:
On Fri, Oct 14, 2011 at 04:10:26PM +0800, Richard Zhao wrote:
On Thu, Sep 22, 2011 at 03:26:56PM -0700, Mike Turquette wrote:
snip essentially Mike's entire mail -
On Wed, Oct 12, 2011 at 07:59:19AM -0700, Turquette, Mike wrote:
On Tue, Oct 11, 2011 at 11:46 PM, Richard Zhao
richard.z...@freescale.com wrote:
On Thu, Sep 22, 2011 at 03:26:59PM -0700, Mike Turquette wrote:
From: Jeremy Kerr jeremy.k...@canonical.com
Signed-off-by: Jeremy Kerr
On Thu, Aug 25, 2011 at 12:12:59PM +0200, Linus Walleij wrote:
On Wed, Aug 24, 2011 at 8:29 PM, Stephen Warren swar...@nvidia.com wrote:
Linus Walleij wrote at Friday, August 19, 2011 3:54 AM:
This creates a subsystem for handling of pin control devices.
These are devices that control
On Thu, Aug 25, 2011 at 01:58:12PM +0200, Linus Walleij wrote:
On Thu, Aug 25, 2011 at 1:04 PM, Sascha Hauer s.ha...@pengutronix.de wrote:
Not really. UART2_CTS can't be routed to arbitrary pads, but it can be
routed to more than one pad:
#define _MX51_PAD_EIM_D16__UART2_CTS
On Thu, Feb 17, 2011 at 09:18:11AM +0100, Yong Shen wrote:
+ return 0;
+}
+
+late_initcall(imx_cpuidle_init);
We have a late_initcall here which needs to be protected from other
cpus. On the other hand we depend on board code calling
imx_cpuidle_board_params() before
On Fri, Feb 11, 2011 at 10:36:12AM +0100, yong.s...@linaro.org wrote:
From: Yong Shen yong.s...@freescale.com
implement cpuidle driver for iMX5 SOCs, leave cpuidle params to board
related code.
Signed-off-by: Yong Shen yong.s...@freescale.com
---
arch/arm/mach-mx5/Makefile |1 +
On Fri, Feb 11, 2011 at 10:36:12AM +0100, yong.s...@linaro.org wrote:
From: Yong Shen yong.s...@freescale.com
implement cpuidle driver for iMX5 SOCs, leave cpuidle params to board
related code.
Signed-off-by: Yong Shen yong.s...@freescale.com
---
arch/arm/mach-mx5/Makefile |1 +
Hi Yong,
On Wed, Dec 01, 2010 at 03:15:55PM +0800, Yong Shen wrote:
Hi there,
This is the v2 with some changes according to comments from v1. There
will be few patches coming out after this one, for mc13892 regulator
to share some code with mc13783.
Still, cause the firewall problem, I
On Tue, Oct 19, 2010 at 05:28:51PM +0800, Yong Shen wrote:
+#include linux/kernel.h
+
+static struct cpu_op mx51_cpu_op[] = {
+ {
+ .cpu_rate = 16000,},
+ {
+ .cpu_rate = 8,},
+};
Why did you remove the values between 800MHz and 160MHz?
Hi Yong,
On Mon, Oct 18, 2010 at 01:43:43PM +0800, Yong Shen wrote:
Hi Sascha,
Thanks for your thorough review. I have two feedbacks to your commends.
Sorry for delayed response, cause I had a hard time due to my computer crash
and data loss.
diff --git a/arch/arm/mach-mx5/cpu.c
On Mon, Oct 18, 2010 at 04:21:45PM +0800, yong.s...@linaro.org wrote:
From: Yong Shen yong.s...@linaro.org
the operating points are tested on babbage 3.0
Signed-off-by: Yong Shen yong.s...@linaro.org
---
arch/arm/Kconfig |6 +
arch/arm/mach-mx5/Kconfig
On Mon, Oct 18, 2010 at 05:08:14PM +0800, Yong Shen wrote:
Hi Sascha,
On Mon, Oct 18, 2010 at 4:31 PM, Sascha Hauer s.ha...@pengutronix.dewrote:
Hi Yong,
On Mon, Oct 18, 2010 at 01:43:43PM +0800, Yong Shen wrote:
Hi Sascha,
Thanks for your thorough review. I have two
On Thu, Oct 07, 2010 at 10:40:44AM +0300, Amit Kucheria wrote:
On 10 Oct 07, Yong Shen wrote:
+static struct cpufreq_frequency_table imx_freq_table[4];
Three frequencies should be enough for everyone, right? This should be
dynamically allocated like in other cpufreq drivers.
On Thu, Oct 07, 2010 at 11:36:07AM +0800, Yong Shen wrote:
Hi Sascha,
Thanks for your thorough comments.
I have already received comments from Arnd before yours arrived. So some of
the commends you two provided are common.
I acknowledge most of your opinions, except for two, I have some
64 matches
Mail list logo
