Re: [PATCH v2 7/7] [RFC] nvme: Fix a race condition

2016-10-11 Thread Bart Van Assche
On 10/11/16 09:46, Christoph Hellwig wrote: On Wed, Sep 28, 2016 at 05:01:45PM -0700, Bart Van Assche wrote: Avoid that nvme_queue_rq() is still running when nvme_stop_queues() returns. Untested. Signed-off-by: Bart Van Assche Cc: Keith Busch

Re: [PATCHv3 13/41] truncate: make sure invalidate_mapping_pages() can discard huge pages

2016-10-11 Thread Kirill A. Shutemov
On Tue, Oct 11, 2016 at 05:58:15PM +0200, Jan Kara wrote: > On Thu 15-09-16 14:54:55, Kirill A. Shutemov wrote: > > invalidate_inode_page() has expectation about page_count() of the page > > -- if it's not 2 (one to caller, one to radix-tree), it will not be > > dropped. That condition almost

Re: [PATCHv3 14/41] filemap: allocate huge page in page_cache_read(), if allowed

2016-10-11 Thread Kirill A. Shutemov
On Tue, Oct 11, 2016 at 06:15:45PM +0200, Jan Kara wrote: > On Thu 15-09-16 14:54:56, Kirill A. Shutemov wrote: > > This patch adds basic functionality to put huge page into page cache. > > > > At the moment we only put huge pages into radix-tree if the range covered > > by the huge page is

Re: [PATCHv3 12/41] thp: handle write-protection faults for file THP

2016-10-11 Thread Kirill A. Shutemov
On Tue, Oct 11, 2016 at 05:47:50PM +0200, Jan Kara wrote: > On Thu 15-09-16 14:54:54, Kirill A. Shutemov wrote: > > For filesystems that wants to be write-notified (has mkwrite), we will > > encount write-protection faults for huge PMDs in shared mappings. > > > > The easiest way to handle them

Re: [PATCHv3 11/41] thp: try to free page's buffers before attempt split

2016-10-11 Thread Kirill A. Shutemov
On Tue, Oct 11, 2016 at 05:40:31PM +0200, Jan Kara wrote: > On Thu 15-09-16 14:54:53, Kirill A. Shutemov wrote: > > We want page to be isolated from the rest of the system before spliting > > it. We rely on page count to be 2 for file pages to make sure nobody > > uses the page: one pin to caller,

[PATCH v3 0/2] Enabling ATA Command Priorities

2016-10-11 Thread Adam Manzanares
This patch builds ATA commands with high priority if the iocontext of a process is set to real time. The goal of the patch is to improve tail latencies of workloads that use higher queue depths. This patch has been tested with an Ultrastar HE8 HDD and cuts the the p99.99 tail latency of

[PATCH v3 2/2] ata: Enabling ATA Command Priorities

2016-10-11 Thread Adam Manzanares
This patch checks to see if an ATA device supports NCQ command priorities. If so and the user has specified an iocontext that indicates IO_PRIO_CLASS_RT and also enables request priorities in the block queue then we build a tf with a high priority command. This patch depends on patch

[PATCH v3 1/2] block: Add iocontext priority to request

2016-10-11 Thread Adam Manzanares
Patch adds an association between iocontext ioprio and the ioprio of a request. This feature is only enabled if a queue flag is set to indicate that requests should have ioprio associated with them. The queue flag is exposed as the req_prio queue sysfs entry. Signed-off-by: Adam Mananzanares

Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors

2016-10-11 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Switch the ipr driver to use pci_alloc_irq_vectors. We need Christoph> to two calls to pci_alloc_irq_vectors as ipr only supports Christoph> multiple MSI-X vectors, but not multiple MSI vectors. Christoph> Otherwise this

Re: [PATCH 1/6] arcmsr: use pci_alloc_irq_vectors

2016-10-11 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Switch the arcmsr driver to use pci_alloc_irq_vectors. We Christoph> need to two calls to pci_alloc_irq_vectors as arcmsr only Christoph> supports multiple MSI-X vectors, but not multiple MSI Christoph> vectors. Christoph>

Re: [PATCHv3 13/41] truncate: make sure invalidate_mapping_pages() can discard huge pages

2016-10-11 Thread Jan Kara
On Thu 15-09-16 14:54:55, Kirill A. Shutemov wrote: > invalidate_inode_page() has expectation about page_count() of the page > -- if it's not 2 (one to caller, one to radix-tree), it will not be > dropped. That condition almost never met for THPs -- tail pages are > pinned to the pagevec. > >

Re: [PATCHv3 11/41] thp: try to free page's buffers before attempt split

2016-10-11 Thread Jan Kara
On Thu 15-09-16 14:54:53, Kirill A. Shutemov wrote: > We want page to be isolated from the rest of the system before spliting > it. We rely on page count to be 2 for file pages to make sure nobody > uses the page: one pin to caller, one to radix-tree. > > Filesystems with backing storage can have

Re: [PATCHv3 12/41] thp: handle write-protection faults for file THP

2016-10-11 Thread Jan Kara
On Thu 15-09-16 14:54:54, Kirill A. Shutemov wrote: > For filesystems that wants to be write-notified (has mkwrite), we will > encount write-protection faults for huge PMDs in shared mappings. > > The easiest way to handle them is to clear the PMD and let it refault as > wriable. > >

Re: [PATCHv3 14/41] filemap: allocate huge page in page_cache_read(), if allowed

2016-10-11 Thread Jan Kara
On Thu 15-09-16 14:54:56, Kirill A. Shutemov wrote: > This patch adds basic functionality to put huge page into page cache. > > At the moment we only put huge pages into radix-tree if the range covered > by the huge page is empty. > > We ignore shadow entires for now, just remove them from the

Re: [PATCH v2 6/7] SRP transport: Port srp_wait_for_queuecommand() to scsi-mq

2016-10-11 Thread Christoph Hellwig
On Wed, Oct 05, 2016 at 02:51:50PM -0700, Bart Van Assche wrote: > There are multiple direct blk_*() calls in other SCSI transport drivers. So > my proposal is to wait with moving this code into scsi_lib.c until there is > a second user of this code. I still don't think these low-level

Re: [PATCH v2 1/7] blk-mq: Introduce blk_mq_queue_stopped()

2016-10-11 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/9] Introduce blk_quiesce_queue() and blk_resume_queue()

2016-10-11 Thread Laurence Oberman
- Original Message - > From: "Bart Van Assche" > To: "Jens Axboe" > Cc: "Christoph Hellwig" , "James Bottomley" > , "Martin K. Petersen" > , "Mike Snitzer" ,

[PATCH 35/44] block: add reference counting for struct bsg_job

2016-10-11 Thread Johannes Thumshirn
Add reference counting to 'struct bsg_job' so we can implement a reuqest timeout handler for bsg_jobs, which is needed for Fibre Channel. Signed-off-by: Johannes Thumshirn --- block/bsg-lib.c | 7 +-- include/linux/bsg-lib.h | 2 ++ 2 files changed, 7

[PATCH 42/44] block: add bsg_job_put() and bsg_job_get()

2016-10-11 Thread Johannes Thumshirn
Add bsg_job_put() and bsg_job_get() so don't need to export bsg_destroy_job() any more. Signed-off-by: Johannes Thumshirn --- block/bsg-lib.c | 17 ++--- drivers/scsi/scsi_transport_fc.c | 2 +- include/linux/bsg-lib.h | 3 ++- 3 files

[PATCH 37/44] block: export bsg_destroy_job

2016-10-11 Thread Johannes Thumshirn
Export bsg_destroy_job so we can use it from clients of bsg-lib. Signed-off-by: Johannes Thumshirn --- block/bsg-lib.c | 3 ++- include/linux/bsg-lib.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/block/bsg-lib.c b/block/bsg-lib.c index

[PATCH 44/44] block: unexport bsg_softirq_done() again

2016-10-11 Thread Johannes Thumshirn
Unexport bsg_softirq_done() again, we don't need it outside of bsg-lib.c anymore now that scsi_transport_fc is a pure bsg-lib client. Signed-off-by: Johannes Thumshirn --- block/bsg-lib.c | 3 +-- include/linux/bsg-lib.h | 1 - 2 files changed, 1 insertion(+), 3

Re: [PATCH][V3] nbd: add multi-connection support

2016-10-11 Thread Sagi Grimberg
NBD can become contended on its single connection. We have to serialize all writes and we can only process one read response at a time. Fix this by allowing userspace to provide multiple connections to a single nbd device. This coupled with block-mq drastically increases performance in

Re: [PATCH] softirq: Display IRQ_POLL for irq-poll statistics

2016-10-11 Thread Johannes Thumshirn
On Mon, Oct 10, 2016 at 03:10:51PM +0300, Sagi Grimberg wrote: > This library was moved to the generic area and was > renamed to irq-poll. Hence, update proc/softirqs output accordingly. > > Signed-off-by: Sagi Grimberg > --- Looks good, Reviewed-by: Johannes Thumshirn