Re: [PATCH v2] mm, swap: disallow swapon() on zoned block devices

2019-10-15 Thread Andrew Morton
On Tue, 15 Oct 2019 02:06:41 -0700 Christoph Hellwig wrote: > > + /* > > +* Zoned block device contains zones that have > > +* sequential write only restriction. For the restriction, > > +* zoned block devices are not suitable for a swap device. > > +

Re: [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two)

2019-09-24 Thread Andrew Morton
On Tue, 24 Sep 2019 20:52:52 + (UTC) c...@linux.com wrote: > On Mon, 23 Sep 2019, David Sterba wrote: > > > As a user of the allocator interface in filesystem, I'd like to see a > > more generic way to address the alignment guarantees so we don't have to > > apply workarounds like 3acd48507dc

Re: [PATCH 2/4] bdi: Add bdi->id

2019-08-07 Thread Andrew Morton
On Wed, 7 Aug 2019 11:31:51 -0700 Tejun Heo wrote: > Hello, > > On Tue, Aug 06, 2019 at 04:01:02PM -0700, Andrew Morton wrote: > > On Sat, 3 Aug 2019 07:01:53 -0700 Tejun Heo wrote: > > > There currently is no way to universally identify and lookup a bdi > > >

Re: [PATCH 4/4] writeback, memcg: Implement foreign dirty flushing

2019-08-06 Thread Andrew Morton
On Sat, 3 Aug 2019 07:01:55 -0700 Tejun Heo wrote: > There's an inherent mismatch between memcg and writeback. The former > trackes ownership per-page while the latter per-inode. This was a > deliberate design decision because honoring per-page ownership in the > writeback path is complicated,

Re: [PATCH 2/4] bdi: Add bdi->id

2019-08-06 Thread Andrew Morton
On Sat, 3 Aug 2019 07:01:53 -0700 Tejun Heo wrote: > There currently is no way to universally identify and lookup a bdi > without holding a reference and pointer to it. This patch adds an > non-recycling bdi->id and implements bdi_get_by_id() which looks up > bdis by their ids. This will be us

Re: [PATCH] psi: annotate refault stalls from IO submission

2019-07-22 Thread Andrew Morton
On Mon, 22 Jul 2019 16:13:37 -0400 Johannes Weiner wrote: > psi tracks the time tasks wait for refaulting pages to become > uptodate, but it does not track the time spent submitting the IO. The > submission part can be significant if backing storage is contended or > when cgroup throttling (io.la

Re: [PATCH] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-23 Thread Andrew Morton
On Fri, 23 Nov 2018 15:24:16 +0530 Anshuman Khandual wrote: > At present there are multiple places where invalid node number is encoded > as -1. Even though implicitly understood it is always better to have macros > in there. Replace these open encodings for an invalid node number with the > glo

Re: [PATCH v4 1/3] lib: add crc64 calculation routines

2018-07-25 Thread Andrew Morton
On Wed, 25 Jul 2018 10:37:23 +0800 Coly Li wrote: > > IIUC this series in Andrew's quilt. So, it's still possible to replace > > it with better one, I suppose. Ask Andrew (at least I remember recent > > case where he just replaced series by fixed one). > > Hi Andrew, > > It seems there should b

Re: [PATCH 0/10 v12] No wait AIO

2017-06-15 Thread Andrew Morton
On Thu, 15 Jun 2017 16:51:41 -0500 Goldwyn Rodrigues wrote: > > I have only minor quibbles - I'll grab the patch series for some -next > > testing (at least). > > > > I agree to the quibbles you have on patch 02/10. Should I send the > entire fixed series, just the 02/10 patch, or would you pre

Re: [PATCH 0/10 v12] No wait AIO

2017-06-15 Thread Andrew Morton
On Thu, 15 Jun 2017 10:59:52 -0500 Goldwyn Rodrigues wrote: > This series adds nonblocking feature to asynchronous I/O writes. > io_submit() can be delayed because of a number of reason: > - Block allocation for files > - Data writebacks for direct I/O > - Sleeping because of waiting to acquir

Re: [PATCH 02/10] fs: Introduce filemap_range_has_page()

2017-06-15 Thread Andrew Morton
On Thu, 15 Jun 2017 10:59:54 -0500 Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > filemap_range_has_page() return true if the file's mapping has > a page within the range mentioned. This function will be used > to check if a write() call will cause a writeback of previous > writes. > >

Re: [PATCH v5 00/17] fs: introduce new writeback error reporting and convert ext2 and ext4 to use it

2017-05-31 Thread Andrew Morton
On Wed, 31 May 2017 17:31:49 -0400 Jeff Layton wrote: > On Wed, 2017-05-31 at 13:27 -0700, Andrew Morton wrote: > > On Wed, 31 May 2017 08:45:23 -0400 Jeff Layton wrote: > > > > > This is v5 of the patchset to improve how we're tracking and reporting > > &

Re: [PATCH v5 00/17] fs: introduce new writeback error reporting and convert ext2 and ext4 to use it

2017-05-31 Thread Andrew Morton
On Wed, 31 May 2017 08:45:23 -0400 Jeff Layton wrote: > This is v5 of the patchset to improve how we're tracking and reporting > errors that occur during pagecache writeback. I'm curious to know how you've been testing this? Is that testing strong enough for us to be confident that all nature o

Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses

2017-03-06 Thread Andrew Morton
On Mon, 6 Mar 2017 08:21:11 -0700 Jens Axboe wrote: > On 03/06/2017 03:23 AM, Johannes Thumshirn wrote: > > zram can handle at most SECTORS_PER_PAGE sectors in a bio's bvec. When using > > the NVMe over Fabrics loopback target which potentially sends a huge bulk of > > pages attached to the bio's

Re: [RFC 00/10] implement alternative and much simpler id allocator

2016-12-09 Thread Andrew Morton
On Thu, 8 Dec 2016 02:22:55 +0100 Rasmus Villemoes wrote: > TL;DR: these patches save 250 KB of memory, with more low-hanging > fruit ready to pick. > > While browsing through the lib/idr.c code, I noticed that the code at > the end of ida_get_new_above() probably doesn't work as intended: Mos