On 10/23/2019 02:11 AM, Michal Hocko wrote:
> On Wed 23-10-19 07:43:44, Dave Chinner wrote:
>> On Tue, Oct 22, 2019 at 06:33:10PM +0200, Michal Hocko wrote:
>
> Thanks for more clarifiation regarding PF_LESS_THROTTLE.
>
> [...]
>>> PF_IO_FLUSHER would mean that the user
>>> context is a part of t
On 10/22/2019 06:24 AM, Michal Hocko wrote:
> On Mon 21-10-19 16:41:37, Mike Christie wrote:
>> There are several storage drivers like dm-multipath, iscsi, tcmu-runner,
>> amd nbd that have userspace components that can run in the IO path. For
>> example, iscsi and nbd's
On 10/21/2019 05:52 PM, Dave Chinner wrote:
> On Mon, Oct 21, 2019 at 04:41:37PM -0500, Mike Christie wrote:
>> There are several storage drivers like dm-multipath, iscsi, tcmu-runner,
>> amd nbd that have userspace components that can run in the IO path. For
>> example, iscs
ere we race
> with the timeout handler and the reply handler. Thanks,
>
Patches look ok and tested ok for me.
Reviewed-by: Mike Christie
device we are trying to allocate for.
This patch allows the userspace deamon to set the PF_MEMALLOC* flags
with prctl during their initialization so later allocations cannot
calling back into them.
Signed-off-by: Mike Christie
---
V2:
- Use prctl instead of procfs.
- Add support for NOF
connection/reconnection to make sure the
socket being passed in supports the needed callout.
Reported-by: syzbot+24c12fa8d218ed260...@syzkaller.appspotmail.com
Fixes: e9e006f5fcf2 ("nbd: fix max number of supported devs")
Signed-off-by: Mike Christie
---
drivers/block/
On 10/17/2019 11:49 AM, Richard W.M. Jones wrote:
> On Thu, Oct 17, 2019 at 09:36:34AM -0700, Eric Biggers wrote:
>> On Thu, Oct 17, 2019 at 05:28:29PM +0100, Richard W.M. Jones wrote:
>>> On Thu, Oct 17, 2019 at 10:47:59AM -0500, Mike Christie wrote:
>>>> On 10
Josef and Jens,
I am nacking my patch.
It looks like nbd only supported sockets that supported the shutdown
method, so I will fix the test and do a patch for nbd to warn when
unsupported sockets are passed in.
On 10/14/2019 01:36 AM, Mike Christie wrote:
> This fixes a regression added w
On 10/17/2019 09:03 AM, Richard W.M. Jones wrote:
> On Tue, Oct 01, 2019 at 04:19:25PM -0500, Mike Christie wrote:
>> Hey Josef and nbd list,
>>
>> I had a question about if there are any socket family restrictions for nbd?
>
> In normal circumstances, in userspace, the
This fixes a regression added with:
commit e9e006f5fcf2bab59149cb38a48a4817c1b538b4
Author: Mike Christie
Date: Sun Aug 4 14:10:06 2019 -0500
nbd: fix max number of supported devs
Before the patch, if we got a signal in the NBD_DO_IT ioctl, we would
call sock_shutdown then return
011a
> compiler: gcc (GCC) 9.0.0 20181231 (experimental)
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12abc2a360
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11712c0560
>
> The bug was bisected to:
>
> commit e9e006f5fcf2bab59149cb38a48a481
abc2a360
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11712c0560
>
> The bug was bisected to:
>
> commit e9e006f5fcf2bab59149cb38a48a4817c1b538b4
> Author: Mike Christie
> Date: Sun Aug 4 19:10:06 2019 +
>
> nbd: fix max number of supported devs
&g
On 09/17/2019 01:40 PM, Josef Bacik wrote:
>>> + nbd->destroy_complete = &destroy_complete;
>>
>> Also, without the mutex part of the v3 patch, we could race and
>> nbd_dev_remove could have passed the destroy_complete check already, so
>> below we will wait forever.
>>
>
> Oh hmm you're
On 09/17/2019 01:40 PM, Josef Bacik wrote:
> On Tue, Sep 17, 2019 at 01:31:05PM -0500, Mike Christie wrote:
>> On 09/17/2019 06:56 AM, xiu...@redhat.com wrote:
>>> From: Xiubo Li
>>>
>>> When the NBD_CFLAG_DESTROY_ON_DISCONNECT flag is set and at the same
>&
On 09/17/2019 06:56 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> When the NBD_CFLAG_DESTROY_ON_DISCONNECT flag is set and at the same
> time when the socket is closed due to the server daemon is restarted,
> just before the last DISCONNET is totally done if we start a new connection
> by usi
On 09/12/2019 11:22 AM, Mike Christie wrote:
> On 09/11/2019 02:21 PM, Martin Raiber wrote:
>> On 11.09.2019 18:56 Mike Christie wrote:
>>> On 09/11/2019 03:40 AM, Martin Raiber wrote:
>>>> On 10.09.2019 10:35 Damien Le Moal wrote:
>>>>> Mike,
>>
On 09/11/2019 02:21 PM, Martin Raiber wrote:
> On 11.09.2019 18:56 Mike Christie wrote:
>> On 09/11/2019 03:40 AM, Martin Raiber wrote:
>>> On 10.09.2019 10:35 Damien Le Moal wrote:
>>>> Mike,
>>>>
>>>> On 2019/09/09 19:26, Mike Christie wr
On 09/11/2019 03:40 AM, Martin Raiber wrote:
> On 10.09.2019 10:35 Damien Le Moal wrote:
>> Mike,
>>
>> On 2019/09/09 19:26, Mike Christie wrote:
>>> Forgot to cc linux-mm.
>>>
>>> On 09/09/2019 11:28 AM, Mike Christie wrote:
>>>> There a
On 09/11/2019 05:07 AM, Tetsuo Handa wrote:
> On 2019/09/11 12:13, Hillf Danton wrote:
>>
>> On Tue, 10 Sep 2019 11:06:03 -0500 From: Mike Christie
>>>
>>>> Really? Without any privilege check? So any random user can tap into
>>>> __GFP_NOIO alloc
On 09/10/2019 05:12 PM, Tetsuo Handa wrote:
> On 2019/09/10 3:26, Mike Christie wrote:
>> Forgot to cc linux-mm.
>>
>> On 09/09/2019 11:28 AM, Mike Christie wrote:
>>> There are several storage drivers like dm-multipath, iscsi, and nbd that
>>> have userspace
On 09/10/2019 05:00 AM, Kirill A. Shutemov wrote:
> On Mon, Sep 09, 2019 at 11:28:04AM -0500, Mike Christie wrote:
>> There are several storage drivers like dm-multipath, iscsi, and nbd that
>> have userspace components that can run in the IO path. For example,
>> iscsi and nb
On 09/10/2019 01:36 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> The followed code will do the same check, and this part is redandant.
>
> Signed-off-by: Xiubo Li
> ---
> drivers/block/nbd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/block/nbd.c b/drivers/block/nb
Forgot to cc linux-mm.
On 09/09/2019 11:28 AM, Mike Christie wrote:
> There are several storage drivers like dm-multipath, iscsi, and nbd that
> have userspace components that can run in the IO path. For example,
> iscsi and nbd's userspace deamons may need to recreate a socket an
e
per flag or just do a memalloc_noio file.
Signed-off-by: Mike Christie
---
Documentation/filesystems/proc.txt | 6
fs/proc/base.c | 53 ++
2 files changed, 59 insertions(+)
diff --git a/Documentation/filesystems/proc.txt
b/Documentation/f
On 08/29/2019 07:58 PM, Xiubo Li wrote:
> On 2019/8/30 7:49, Mike Christie wrote:
>> On 08/22/2019 02:59 AM, xiu...@redhat.com wrote:
>>> From: Xiubo Li
>>>
>>> When the NBD_CFLAG_DESTROY_ON_DISCONNECT flag is set and at the same
>>> time when the
On 08/22/2019 02:59 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> When the NBD_CFLAG_DESTROY_ON_DISCONNECT flag is set and at the same
> time when the socket is closed due to the server daemon is restarted,
> just before the last DISCONNET is totally done if we start a new connection
> by usi
On 08/21/2019 06:57 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> When the NBD_CFLAG_DESTROY_ON_DISCONNECT flag is set and at the same
> time when the socket is closed due to the server daemon is restarted,
> just before the last DISCONNET is totally done if we start a new connection
> by usi
Josef had ackd my patch for the same thing here:
https://www.spinics.net/lists/linux-block/msg43800.html
so maybe Jens will pick that up with the rest of the set Josef had acked:
https://www.spinics.net/lists/linux-block/msg43809.html
to make it easier.
On 08/14/2019 08:27 PM, sunke (E) wrote:
Add a helper to set the cmd timeout. It does not really do a lot now,
but will be more useful in the next patches.
Reviewed-by: Josef Bacik
Signed-off-by: Mike Christie
---
drivers/block/nbd.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a
The following patches fix bugs related to the nbd cmd timeout feature.
The patches were made over Linus's current tree and also apply over
this nbd patch:
https://marc.info/?l=linux-block&m=156494582914495&w=2
V2:
- Fix patch4 so it allows resetting of the nbd cmd timeout to 0 as well
initializi
This adds a helper function to convert a block req op to a nbd cmd type.
It will be used in the last patch to log the type in the timeout
handler.
Reviewed-by: Josef Bacik
Signed-off-by: Mike Christie
---
drivers/block/nbd.c | 33 ++---
1 file changed, 18 insertions
layer timeout
framework, but if zero is set, nbd just logs a message and then resets
the timer when it expires.
Reviewed-by: Josef Bacik
Signed-off-by: Mike Christie
---
V2 - We used to allow apps to reset the timeout to 0. The first version
of the patch only allowed it to be initialized to 0, so
we will leave a config reference
and cannot free the config later.
Reviewed-by: Josef Bacik
Signed-off-by: Mike Christie
---
drivers/block/nbd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index c6ff8f922fd7..ebc98cf76365
On 08/13/2019 10:54 AM, Mike Christie wrote:
> I was debating about sending a patch for not allowing
>
> blk_queue_rq_timeout(q, 9)
I meant zero
blk_queue_rq_timeout(q, 0)
>
> in a separate patchset, but I was not sure if people use that for
> testing fast timeouts.
>
On 08/13/2019 10:45 AM, Mike Christie wrote:
> On 08/13/2019 08:13 AM, Josef Bacik wrote:
>> On Fri, Aug 09, 2019 at 04:26:10PM -0500, Mike Christie wrote:
>>> This fixes a regression added in 4.9 with commit:
>>>
>>> commit 0eadf37afc2500e1162c9040ec26
On 08/13/2019 08:13 AM, Josef Bacik wrote:
> On Fri, Aug 09, 2019 at 04:26:10PM -0500, Mike Christie wrote:
>> This fixes a regression added in 4.9 with commit:
>>
>> commit 0eadf37afc2500e1162c9040ec26a705b9af8d47
>> Author: Josef Bacik
>> Date: Thu Sep 8
> if (config->num_connections > 1) {
> dev_err_ratelimited(nbd_to_dev(nbd),
>
I just sent the same patch
https://www.spinics.net/lists/linux-block/msg43718.html
here
https://www.spinics.net/lists/linux-block/msg43715.html
so it looks good to me.
Reviewed-by: Mike Christie
On 08/09/2019 04:26 PM, Mike Christie wrote:
>
> +static void nbd_set_cmd_timeout(struct nbd_device *nbd, u64 timeout)
> +{
> + nbd->tag_set.timeout = timeout * HZ;
> + blk_queue_rq_timeout(nbd->disk->queue, timeout * HZ);
> +}
> +
> /* Must be called w
The following patches fix bugs related to the nbd cmd timeout feature.
The patches were made over Linus's current tree and also apply over
this nbd patch:
https://marc.info/?l=linux-block&m=156494582914495&w=2
Add a helper to set the cmd timeout. It does not really do a lot now,
but will be more useful in the next patches.
Signed-off-by: Mike Christie
---
drivers/block/nbd.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/block/nbd.c b
This adds a helper function to convert a block req op to a nbd cmd type.
It will be used in the last patch to log the type in the timeout
handler.
Signed-off-by: Mike Christie
---
drivers/block/nbd.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff
we will leave a config reference
and cannot free the config later.
Signed-off-by: Mike Christie
---
drivers/block/nbd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 131b541d07c3..93294000ce55 100644
--- a/drivers/block
anywhere cleanly with older ones
like 4.9, so I was not sure how we wanted to handle it.
Signed-off-by: Mike Christie
---
drivers/block/nbd.c | 26 ++
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 93294000ce55
device, so we can block in the work.
Cc: sta...@vger.kernel.org
Signed-off-by: Mike Christie
---
drivers/block/nbd.c | 39 +--
1 file changed, 25 insertions(+), 14 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 9bcde2325893..cc4b2ae57
On 06/13/2019 12:01 PM, Josef Bacik wrote:
> On Wed, May 29, 2019 at 03:16:06PM -0500, Mike Christie wrote:
>> If the device is setup with ioctl we can resize the device after the
>> initial setup, but if the device is setup with netlink we cannot use the
>> resize related i
This is just Xiubo's zero blksize patch from here:
https://marc.info/?l=linux-kernel&m=155893597828674&w=2
and my resize patch.
Xiubo's zero blksize patch and my resize patch conflicted, so
I fixed the issue mentioned in the link so his patch does "goto out"
instead of returning while holding re
From: Xiubo Li
This will allow the blksize to be set zero and then use 1024 as
default.
Signed-off-by: Xiubo Li
[fix to use goto out instead of return in genl_connect]
Signed-off-by: Mike Christie
---
V2:
- Fix error handling in genl_connect.
drivers/block/nbd.c | 23
interface.
Signed-off-by: Mike Christie
---
V3;
- If the device size or block size has not changed do not call
nbd_size_set.
V2:
- Merge reconfig and connect resize related code to helper and avoid
multiple nbd_size_set calls.
drivers/block/nbd.c | 48
On 05/27/2019 12:44 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> This will allow the blksize to be set zero and then use 1024 as
> default.
>
> Signed-off-by: Xiubo Li
> ---
> drivers/block/nbd.c | 21 ++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --gi
On 05/27/2019 01:23 PM, Yao Liu wrote:
> On Fri, May 24, 2019 at 09:08:58AM -0400, Josef Bacik wrote:
>> On Fri, May 24, 2019 at 05:43:55PM +0800, Yao Liu wrote:
>>> Some nbd client implementations have a userland's daemon, so we should
>>> inform client daemon to clean up and exit.
>>>
>>> Signed-
On 05/26/2019 04:49 PM, Mike Christie wrote:
> If the device is setup with ioctl we can resize the device after the
> initial setup, but if the device is setup with netlink we cannot use the
> resize related ioctls and there is no netlink reconfigure size ATTR
> handling code.
>
&g
interface.
Signed-off-by: Mike Christie
---
V2:
- Merge reconfig and connect resize related code to helper and avoid
multiple nbd_size_set calls.
drivers/block/nbd.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers
Ignore this patch. I had copied nbd_genl_connect, but there is no need
to do 2 nbd_size_set calls if both attrs are set. I am going to resubmit
a new patch.
On 05/15/2019 07:38 PM, Mike Christie wrote:
> If the device is setup with ioctl we can resize the device after the
> initial setup,
interface.
Signed-off-by: Mike Christie
---
drivers/block/nbd.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 053958a8a2ba..68b9d4b2d1be 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1939,6 +1939,15 @@ static int
On 04/10/2017 11:07 AM, Christoph Hellwig wrote:
> Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the
> kernel there is very little use left for REQ_OP_WRITE_SAME. We only
> have two callers left, and both just export optional protocol features
> to remote systems: DRBD and the
t, dev_t);
> extern void make_bad_inode(struct inode *);
> extern bool is_bad_inode(struct inode *);
>
> +#ifdef CONFIG_BLOCK
> static inline bool op_is_write(unsigned int op)
> {
> return op == REQ_OP_READ ? false : true;
> }
>
> -#ifdef CONFIG_BLOCK
> -
&g
-20160804]
>>> [cannot apply to v4.7]
>>> [if your patch is applied to the wrong git tree, please drop us a note to
>>> help improve the system]
>>>
>>> url:
>>> https://github.com/0day-ci/linux/commits/Mike-Christie/mm-block-convert-rw_page
On 08/04/2016 03:15 PM, Jens Axboe wrote:
> On 08/04/2016 01:59 PM, Mike Christie wrote:
>> On 08/04/2016 02:27 PM, Jens Axboe wrote:
>>> On 08/04/2016 11:50 AM, kbuild test robot wrote:
>>>> Hi Mike,
>>>>
>>>> [auto build test ERROR on linu
e wrong git tree, please drop us a note
>> to help improve the system]
>>
>> url:
>> https://github.com/0day-ci/linux/commits/Mike-Christie/mm-block-convert-rw_page-users-to-bio-op-use/20160805-012041
>>
>> config: i386-tinyconfig (attached as .config)
>> co
On 08/04/2016 01:46 PM, Ross Zwisler wrote:
> On Thu, Aug 04, 2016 at 12:17:36PM -0500, Mike Christie wrote:
>> This fixes a regression from
>> 4e1b2d52a80d79296a5d899d73249748dea71a53
>> block, fs, drivers: remove REQ_OP compat defs and related code
>>
>> The rw
.
Signed-off-by: Mike Christie
---
drivers/block/brd.c | 17 +++--
drivers/block/zram/zram_drv.c | 28 +++-
drivers/nvdimm/btt.c | 18 +-
drivers/nvdimm/pmem.c | 12 ++--
fs/block_dev.c| 8 +---
fs
On 08/03/2016 07:30 PM, Shaun Tancheff wrote:
> On Wed, Aug 3, 2016 at 6:47 PM, Mike Christie wrote:
>> On 08/03/2016 05:33 PM, Ross Zwisler wrote:
>>> On Sun, Jun 5, 2016 at 1:32 PM, wrote:
>>>> From: Mike Christie
>>>>
>>>> The r
On 08/03/2016 05:33 PM, Ross Zwisler wrote:
> On Sun, Jun 5, 2016 at 1:32 PM, wrote:
>> From: Mike Christie
>>
>> The req operation REQ_OP is separated from the rq_flag_bits
>> definition. This converts the block layer drivers to
>> use req_op to get the op from
On 08/03/2016 11:25 AM, Ross Zwisler wrote:
> run fstests generic/008 at 2016-08-03 09:54:56
> page:ea0017af04c0 count:3 mapcount:0 mapping:8805eb059200 index:0x0
> flags: 0x3fff802828(uptodate|lru|private|writeback)
> page dumped because: VM_BUG_ON_PAGE(!PageLocked(page))
> page->mem_
64 matches
Mail list logo
