Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On Wed, May 03, 2017 at 10:00:04AM -0700, Omar Sandoval wrote: > On Thu, May 04, 2017 at 12:55:30AM +0800, Ming Lei wrote: > > On Wed, May 03, 2017 at 09:29:36AM -0700, Omar Sandoval wrote: > > > On Fri, Apr 28, 2017 at 11:15:38PM +0800, Ming Lei wrote: > > > > When tag space of one device is big

Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On Thu, May 04, 2017 at 12:55:30AM +0800, Ming Lei wrote: > On Wed, May 03, 2017 at 09:29:36AM -0700, Omar Sandoval wrote: > > On Fri, Apr 28, 2017 at 11:15:38PM +0800, Ming Lei wrote: > > > When tag space of one device is big enough, we use hw tag > > > directly for I/O scheduling. > > > > > >

Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On Wed, May 03, 2017 at 09:29:36AM -0700, Omar Sandoval wrote: > On Fri, Apr 28, 2017 at 11:15:38PM +0800, Ming Lei wrote: > > When tag space of one device is big enough, we use hw tag > > directly for I/O scheduling. > > > > Now the decision is made if hw queue depth is not less than > >

Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On Fri, Apr 28, 2017 at 11:15:38PM +0800, Ming Lei wrote: > When tag space of one device is big enough, we use hw tag > directly for I/O scheduling. > > Now the decision is made if hw queue depth is not less than > q->nr_requests and the tag set isn't shared. > > Signed-off-by: Ming Lei

Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On Mon, May 01, 2017 at 03:06:16PM +, Bart Van Assche wrote: > On Sat, 2017-04-29 at 18:35 +0800, Ming Lei wrote: > > On Fri, Apr 28, 2017 at 06:09:40PM +, Bart Van Assche wrote: > > > On Fri, 2017-04-28 at 23:15 +0800, Ming Lei wrote: > > > > +static inline bool

Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On Mon, May 01, 2017 at 03:06:16PM +, Bart Van Assche wrote: > On Sat, 2017-04-29 at 18:35 +0800, Ming Lei wrote: > > On Fri, Apr 28, 2017 at 06:09:40PM +, Bart Van Assche wrote: > > > On Fri, 2017-04-28 at 23:15 +0800, Ming Lei wrote: > > > > +static inline bool

Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On Sat, 2017-04-29 at 18:35 +0800, Ming Lei wrote: > On Fri, Apr 28, 2017 at 06:09:40PM +, Bart Van Assche wrote: > > On Fri, 2017-04-28 at 23:15 +0800, Ming Lei wrote: > > > +static inline bool blk_mq_sched_may_use_hw_tag(struct request_queue *q) > > > +{ > > > + if (q->tag_set->flags &

Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On Fri, Apr 28, 2017 at 06:09:40PM +, Bart Van Assche wrote: > On Fri, 2017-04-28 at 23:15 +0800, Ming Lei wrote: > > +static inline bool blk_mq_sched_may_use_hw_tag(struct request_queue *q) > > +{ > > + if (q->tag_set->flags & BLK_MQ_F_TAG_SHARED) > > + return false; > > + > > +

Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On Fri, 2017-04-28 at 12:22 -0600, Jens Axboe wrote: > On 04/28/2017 09:15 AM, Ming Lei wrote: > > +/* > > + * If this queue has enough hardware tags and doesn't share tags with > > + * other queues, just use hw tag directly for scheduling. > > + */ > > +static inline bool

Re: [PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

On 04/28/2017 09:15 AM, Ming Lei wrote: > +/* > + * If this queue has enough hardware tags and doesn't share tags with > + * other queues, just use hw tag directly for scheduling. > + */ > +static inline bool blk_mq_sched_may_use_hw_tag(struct request_queue *q) > +{ > + if (q->tag_set->flags

[PATCH 3/4] blk-mq: use hw tag for scheduling if hw tag space is big enough

When tag space of one device is big enough, we use hw tag directly for I/O scheduling. Now the decision is made if hw queue depth is not less than q->nr_requests and the tag set isn't shared. Signed-off-by: Ming Lei --- block/blk-mq-sched.c | 8