Re: [PATCH 2/2] Btrfs: Fix setting umask when POSIX ACLs are not enabled

2009-09-16 Thread Alex Dedul
Hi Chris! On Thu, Sep 17, 2009 at 8:42 AM, Chris Ball wrote: > We currently set sb->s_flags |= MS_POSIXACL unconditionally, which is > incorrect -- it tells the VFS that it shouldn't set umask because we > will, yet we don't set it ourselves if we aren't using POSIX ACLs, so > the umask ends up i

Re: btrfs csum failed on git .pack file

2009-09-16 Thread Jens Axboe
On Thu, Sep 17 2009, Markus Trippelsdorf wrote: > On Tue, Sep 08, 2009 at 10:00:42PM +0200, Jens Axboe wrote: > > On Mon, Sep 07 2009, Markus Trippelsdorf wrote: > > > Just got this error today in my dmesg: > > > btrfs csum failed ino 1483065 off 158482432 csum 4283543305 private > > > 43905798 >

[PATCH 2/2] Btrfs: Fix setting umask when POSIX ACLs are not enabled

2009-09-16 Thread Chris Ball
We currently set sb->s_flags |= MS_POSIXACL unconditionally, which is incorrect -- it tells the VFS that it shouldn't set umask because we will, yet we don't set it ourselves if we aren't using POSIX ACLs, so the umask ends up ignored. Signed-off-by: Chris Ball --- fs/btrfs/super.c |2 ++ 1

[PATCH 1/2] Btrfs: Use CONFIG_BTRFS_POSIX_ACL to enable ACL code

2009-09-16 Thread Chris Ball
We've already defined CONFIG_BTRFS_POSIX_ACL in Kconfig, but we're currently not using it and are testing CONFIG_FS_POSIX_ACL instead. CONFIG_FS_POSIX_ACL states "Never use this symbol for ifdefs". Signed-off-by: Chris Ball --- fs/btrfs/acl.c |6 +++--- fs/btrfs/ctree.h |2 +- fs/btrfs

Re: btrfs csum failed on git .pack file

2009-09-16 Thread Markus Trippelsdorf
On Tue, Sep 08, 2009 at 10:00:42PM +0200, Jens Axboe wrote: > On Mon, Sep 07 2009, Markus Trippelsdorf wrote: > > Just got this error today in my dmesg: > > btrfs csum failed ino 1483065 off 158482432 csum 4283543305 private 43905798 > > > > linux % find . -inum 1483065 > > ./.git/objects/pack/pac

Re: Updated performance results

2009-09-16 Thread Steven Pratt
from? mount -t btrfs /dev/ffsbdev1 /mnt/ffsb1' [20090916-11:47:37.738883526] PROCESSING COMMAND : 'run random_writes__threads_0001 ffsb http://hks.austin.ibm.com/users/corry/btrfs/ffsb/profiles/btrfs2/random_writes.ffsb num_threads=1' So , this is single disk machine, r

Re: Updated performance results

2009-09-16 Thread Chris Mason
On Wed, Sep 16, 2009 at 01:16:56PM -0500, Steven Pratt wrote: > Chris Mason wrote: > >On Wed, Sep 16, 2009 at 12:57:22PM -0500, Steven Pratt wrote: > >>Steven Pratt wrote: > >>>Chris Mason wrote: > On Mon, Sep 14, 2009 at 04:41:48PM -0500, Steven Pratt wrote: > >Only bit of bad news is I di

Re: Updated performance results

2009-09-16 Thread Chris Mason
On Wed, Sep 16, 2009 at 01:15:12PM -0500, Steven Pratt wrote: > Chris Mason wrote: > >On Wed, Sep 16, 2009 at 12:57:22PM -0500, Steven Pratt wrote: > >>Steven Pratt wrote: > >>>Chris Mason wrote: > On Mon, Sep 14, 2009 at 04:41:48PM -0500, Steven Pratt wrote: > >Only bit of bad news is I di

Re: Updated performance results

2009-09-16 Thread Steven Pratt
Chris Mason wrote: On Wed, Sep 16, 2009 at 12:57:22PM -0500, Steven Pratt wrote: Steven Pratt wrote: Chris Mason wrote: On Mon, Sep 14, 2009 at 04:41:48PM -0500, Steven Pratt wrote: Only bit of bad news is I did get one error that crashed the system on single threaded

Re: Updated performance results

2009-09-16 Thread Steven Pratt
Chris Mason wrote: On Wed, Sep 16, 2009 at 12:57:22PM -0500, Steven Pratt wrote: Steven Pratt wrote: Chris Mason wrote: On Mon, Sep 14, 2009 at 04:41:48PM -0500, Steven Pratt wrote: Only bit of bad news is I did get one error that crashed the system on single threaded

Re: Updated performance results

2009-09-16 Thread Chris Mason
On Wed, Sep 16, 2009 at 12:57:22PM -0500, Steven Pratt wrote: > Steven Pratt wrote: > >Chris Mason wrote: > >>On Mon, Sep 14, 2009 at 04:41:48PM -0500, Steven Pratt wrote: > >>>Only bit of bad news is I did get one error that crashed the system > >>>on single threaded nocow run. So that data point

Re: Updated performance results

2009-09-16 Thread Steven Pratt
Steven Pratt wrote: Chris Mason wrote: On Mon, Sep 14, 2009 at 04:41:48PM -0500, Steven Pratt wrote: Only bit of bad news is I did get one error that crashed the system on single threaded nocow run. So that data point is missing. Output below: I hope I've got this fixed. If you pull f

Re: Updated performance results

2009-09-16 Thread Steven Pratt
Chris Mason wrote: On Mon, Sep 14, 2009 at 04:41:48PM -0500, Steven Pratt wrote: Only bit of bad news is I did get one error that crashed the system on single threaded nocow run. So that data point is missing. Output below: I hope I've got this fixed. If you pull from the master branc