Re: btrfs/git question.

2011-11-29 Thread Fajar A. Nugraha
On Tue, Nov 29, 2011 at 10:22 PM, Chris Mason wrote: > On Tue, Nov 29, 2011 at 09:33:37AM +0700, Fajar A. Nugraha wrote: >> On Tue, Nov 29, 2011 at 8:58 AM, Phillip Susi wrote: >> > On 11/28/2011 12:53 PM, Ken D'Ambrosio wrote: >> >> Seems I've picked up a wireless regression, and randomly drop m

Re: [PATCH 2/2] Btrfs: set the i_nlink to 2 for an initial dir inode

2011-11-29 Thread Jeff Liu
On 11/29/2011 11:48 PM, Chris Mason wrote: > On Tue, Nov 29, 2011 at 02:04:37PM +0800, Jeff Liu wrote: >> Please ignore this patch for now, it can cause the file system corrupted >> and failed to mount again, sorry for the noise! > > Directories always have a link count of 1 in btrfs. This tells

[RFC][PATCH] Sector Size check during Mount

2011-11-29 Thread Keith Mannthey
Gracefully fail when trying to mount a BTRFS file system that has a sectorsize smaller than PAGE_SIZE. On PPC it is possible to build a FS while using a 4k PAGE_SIZE kernel then boot into a 64K PAGE_SIZE kernel. Presently open_ctree fails in an endless loop and hangs the machine in this situati

Re: [PATCH] Btrfs: fix submit_worker congestion

2011-11-29 Thread Chris Mason
On Tue, Nov 29, 2011 at 09:40:56PM +0100, Arne Jansen wrote: > Write bios are submitted from the submit_worker. The worker pumps down > bios into the block layer until it signals a congestion. At least this > is the theory. In pratice submit_bio just blocks before any signalling > happens. As the b

Re: [PATCH 02/20] Btrfs: initialize new bitmaps' list

2011-11-29 Thread Christian Brunner
2011/11/28 Alexandre Oliva : > We're failing to create clusters with bitmaps because > setup_cluster_no_bitmap checks that the list is empty before inserting > the bitmap entry in the list for setup_cluster_bitmap, but the list > field is only initialized when it is restored from the on-disk free >

[PATCH] Btrfs: fix submit_worker congestion

2011-11-29 Thread Arne Jansen
Write bios are submitted from the submit_worker. The worker pumps down bios into the block layer until it signals a congestion. At least this is the theory. In pratice submit_bio just blocks before any signalling happens. As the bios are queued per device, this can lead to a situation where only on

Re: kernel BUG at /build/buildd/linux-3.2.0/fs/btrfs/extent-tree.c:4816!

2011-11-29 Thread Chris Mason
On Tue, Nov 29, 2011 at 05:47:46PM +0100, David Sterba wrote: > On Tue, Nov 29, 2011 at 10:49:13AM -0500, Chris Mason wrote: > > The good news about this one is that it is very clear cut. The hard > > part is figuring out where these bogus link counts came from. > > > > I'd suggest that you spend

[PATCH] btrfs: simplify move_pages and copy_pages

2011-11-29 Thread David Sterba
After commit a65917156e34594 ("Btrfs: stop using highmem for extent_buffers") we don't need to kmap_atomic anymore and can simplify both functions. Signed-off-by: David Sterba --- fs/btrfs/extent_io.c | 19 --- 1 files changed, 4 insertions(+), 15 deletions(-) diff --git a/fs/

Re: kernel BUG at /build/buildd/linux-3.2.0/fs/btrfs/extent-tree.c:4816!

2011-11-29 Thread David Sterba
On Tue, Nov 29, 2011 at 10:49:13AM -0500, Chris Mason wrote: > The good news about this one is that it is very clear cut. The hard > part is figuring out where these bogus link counts came from. > > I'd suggest that you spend some time running memtest on the machine. Just to add some evidence fr

Re: [PATCH 0/5] fix bugs of sub transid -- WARNING: at fs/btrfs/ctree.c:432

2011-11-29 Thread David Sterba
On Tue, Nov 29, 2011 at 09:18:35AM +0800, Liu Bo wrote: > a) For the first one (last_snapshot bug), > > The test involves three processes (derived from Chris): > > mkfs.btrfs /dev/xxx > mount /dev/xxx /mnt > > 1) run compilebench -i 30 --makej -D /mnt > > Let compilebench run until it starts th

Re: [PATCH 2/2] Btrfs: set the i_nlink to 2 for an initial dir inode

2011-11-29 Thread Jan Schmidt
On 29.11.2011 16:48, Chris Mason wrote: > On Tue, Nov 29, 2011 at 02:04:37PM +0800, Jeff Liu wrote: >> Please ignore this patch for now, it can cause the file system corrupted >> and failed to mount again, sorry for the noise! > > Directories always have a link count of 1 in btrfs. This tells fin

Re: [PATCH] fs: push file_update_time into ->page_mkwrite

2011-11-29 Thread Josef Bacik
On Tue, Nov 29, 2011 at 04:50:20PM +0100, Jan Kara wrote: > On Tue 29-11-11 10:40:59, Josef Bacik wrote: > > The fault code has been calling file_update_time after ->page_mkwrite after > > it > > drops the page lock, but this is annoying because this calls > > mark_inode_dirty > > which can fail

Re: kernel BUG at /build/buildd/linux-3.2.0/fs/btrfs/extent-tree.c:4816!

2011-11-29 Thread Chris Mason
On Tue, Nov 29, 2011 at 04:29:54PM +0100, Karl Mardoff Kittilsen wrote: > Den 29. nov. 2011 16:12, skrev Chris Mason: > >On Tue, Nov 29, 2011 at 02:39:26AM +0100, Karl Mardoff Kittilsen wrote: > >>Hi! > >> > >>Sending a mail on this issue, as advised on IRC. > >> > >>My /home file system fails to m

Re: [PATCH] fs: push file_update_time into ->page_mkwrite

2011-11-29 Thread Jan Kara
On Tue 29-11-11 10:40:59, Josef Bacik wrote: > The fault code has been calling file_update_time after ->page_mkwrite after it > drops the page lock, but this is annoying because this calls mark_inode_dirty > which can fail in Btrfs, so we want to be able to do these updates in > ->page_mkwrite so w

Re: [PATCH 2/2] Btrfs: set the i_nlink to 2 for an initial dir inode

2011-11-29 Thread Chris Mason
On Tue, Nov 29, 2011 at 02:04:37PM +0800, Jeff Liu wrote: > Please ignore this patch for now, it can cause the file system corrupted > and failed to mount again, sorry for the noise! Directories always have a link count of 1 in btrfs. This tells find not to use the link count as the count of subd

[PATCH] fs: push file_update_time into ->page_mkwrite

2011-11-29 Thread Josef Bacik
The fault code has been calling file_update_time after ->page_mkwrite after it drops the page lock, but this is annoying because this calls mark_inode_dirty which can fail in Btrfs, so we want to be able to do these updates in ->page_mkwrite so we can get an error back to the user. So get rid of t

Re: kernel BUG at /build/buildd/linux-3.2.0/fs/btrfs/extent-tree.c:4816!

2011-11-29 Thread Karl Mardoff Kittilsen
Den 29. nov. 2011 16:12, skrev Chris Mason: On Tue, Nov 29, 2011 at 02:39:26AM +0100, Karl Mardoff Kittilsen wrote: Hi! Sending a mail on this issue, as advised on IRC. My /home file system fails to mount and the kernel seem to freeze and I need to do the Alt+SysRq RSNEIUB routine to boot it s

Re: btrfs/git question.

2011-11-29 Thread Chris Mason
On Tue, Nov 29, 2011 at 09:33:37AM +0700, Fajar A. Nugraha wrote: > On Tue, Nov 29, 2011 at 8:58 AM, Phillip Susi wrote: > > On 11/28/2011 12:53 PM, Ken D'Ambrosio wrote: > >> Seems I've picked up a wireless regression, and randomly drop my WiFi > >> connection with more recent kernels.  While I'd

Re: kernel BUG at /build/buildd/linux-3.2.0/fs/btrfs/extent-tree.c:4816!

2011-11-29 Thread Chris Mason
On Tue, Nov 29, 2011 at 02:39:26AM +0100, Karl Mardoff Kittilsen wrote: > Hi! > > Sending a mail on this issue, as advised on IRC. > > My /home file system fails to mount and the kernel seem to freeze > and I need to do the Alt+SysRq RSNEIUB routine to boot it safely. > The corruption happened on