[patch] Btrfs: silence a compiler warning

2012-02-21 Thread Dan Carpenter
Gcc warns that "ret" can be used uninitialized. It can't actually be used uninitialized because btrfs_num_copies() always returns 1 or more. Signed-off-by: Dan Carpenter diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index 064b29b..c053e90 100644 --- a/fs/btrfs/check-integ

Re: [PATCH] Btrfs: avoid setting ->d_op twice

2012-02-21 Thread Li Zefan
David Sterba wrote: > Hi, > > thanks for the patch! > > On Tue, Feb 21, 2012 at 05:04:28PM +0800, Li Zefan wrote: >> Follow those instructions, and you'll trigger a warning in the >> beginning of d_set_d_op(): >> >> # mkfs.btrfs /dev/loop3 >> # mount /dev/loop3 /mnt >> # btrfs sub create /m

Re: Hot data Tracking

2012-02-21 Thread David Sterba
On Sat, Feb 11, 2012 at 05:49:41AM +0100, Timo Witte wrote: > What happened to the hot data tracking feature in btrfs? There are a lot > of old patches from aug 2010, but it looks like the feature has been > completly removed from the current version of btrfs. Is this feature > still on the roadmap

Re: [PATCH] Btrfs: avoid setting ->d_op twice

2012-02-21 Thread David Sterba
Hi, thanks for the patch! On Tue, Feb 21, 2012 at 05:04:28PM +0800, Li Zefan wrote: > Follow those instructions, and you'll trigger a warning in the > beginning of d_set_d_op(): > > # mkfs.btrfs /dev/loop3 > # mount /dev/loop3 /mnt > # btrfs sub create /mnt/sub > # btrfs sub snap /mnt /m

Re: subvolume info in /proc/mounts

2012-02-21 Thread David Sterba
On Thu, Feb 09, 2012 at 02:44:03PM +0100, David Sterba wrote: > --- a/fs/btrfs/super.c > +++ b/fs/btrfs/super.c > @@ -766,6 +766,9 @@ static int btrfs_show_options(struct seq_file *seq, > struct vfsmount *vfs) > seq_puts(seq, ",inode_cache"); > if (btrfs_test_opt(root, SKIP

Is there any data recovery tool?

2012-02-21 Thread qasdfgtyuiop
Hi, I'm using GNU/linux with btrfs root. My filesystem is created with command "mkfs.btrfs /dev/sda" . Today I'm trying to install Microsoft Windows 7 on /dev/sdb , a 16GB esata ssd. After the installation, I found that Windows create a "hidden" NTFS partition called "System Reserved" on the firs

Re: Problems Implementing Snappy Patches

2012-02-21 Thread David Sterba
On Wed, Feb 15, 2012 at 04:46:00PM -0600, Mitch Harder wrote: > I've been trying to test the snappy compression patches, but I'm > getting corruptions when trying to use snappy as built on my system. I went through the original C++ implementation (svn release r52) and compared it to the C implemen

[PATCH] Btrfs: avoid setting ->d_op twice

2012-02-21 Thread Li Zefan
Follow those instructions, and you'll trigger a warning in the beginning of d_set_d_op(): # mkfs.btrfs /dev/loop3 # mount /dev/loop3 /mnt # btrfs sub create /mnt/sub # btrfs sub snap /mnt /mnt/snap # touch /mnt/snap/sub touch: cannot touch `tmp': Permission denied __d_alloc() set d_op

Re: Deadlock while mounting with current for-linus

2012-02-21 Thread Miao Xie
Hi, Jan Schmidt On tue, 21 Feb 2012 08:56:29 +0100, Jan Schmidt wrote: > the current for-linus head as of today (d98456fc) gets stuck > in a deadlock when executing xfstest 083. This is the > corresponding output, preceeded by a related lockdep warning: > > Feb 21 08:30:52 oglaroon kernel: [56906