Re: [RFC v2 05/10] vfs: introduce one hash table

2012-09-27 Thread Zhi Yong Wu
On Thu, Sep 27, 2012 at 11:43 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:30PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Adds a hash table structure which contains a lot of hash list and is used to efficiently look up the

Re: [RFC v2 06/10] vfs: enable hot data tracking

2012-09-27 Thread Zhi Yong Wu
On Thu, Sep 27, 2012 at 11:54 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:31PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Miscellaneous features that implement hot data tracking and generally make the hot data functions a bit

Re: [RFC v2 07/10] vfs: fork one kthread to update data temperature

2012-09-27 Thread Zhi Yong Wu
On Thu, Sep 27, 2012 at 12:03 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:32PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Fork and run one kernel kthread to calculate that temperature based on some metrics kept in custom

Re: [RFC v2 05/10] vfs: introduce one hash table

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 02:23:16PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 11:43 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:30PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Adds a hash table structure which

Re: [RFC v2 06/10] vfs: enable hot data tracking

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 02:28:12PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 11:54 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:31PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Miscellaneous features that implement

Re: [RFC v2 07/10] vfs: fork one kthread to update data temperature

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 02:54:22PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 12:03 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:32PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Fork and run one kernel kthread to

Re: [RFC v2 03/10] vfs: add one new mount option '-o hottrack'

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 01:25:34PM +0800, Zhi Yong Wu wrote: On Tue, Sep 25, 2012 at 5:28 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:28PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Introduce one new mount option '-o

Re: [RFC v2 05/10] vfs: introduce one hash table

2012-09-27 Thread Zhi Yong Wu
On Thu, Sep 27, 2012 at 2:57 PM, Dave Chinner da...@fromorbit.com wrote: On Thu, Sep 27, 2012 at 02:23:16PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 11:43 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:30PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong

Re: [RFC v2 06/10] vfs: enable hot data tracking

2012-09-27 Thread Zhi Yong Wu
On Thu, Sep 27, 2012 at 2:59 PM, Dave Chinner da...@fromorbit.com wrote: On Thu, Sep 27, 2012 at 02:28:12PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 11:54 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:31PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong

Re: [RFC v2 07/10] vfs: fork one kthread to update data temperature

2012-09-27 Thread Zhi Yong Wu
On Thu, Sep 27, 2012 at 3:01 PM, Dave Chinner da...@fromorbit.com wrote: On Thu, Sep 27, 2012 at 02:54:22PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 12:03 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:32PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong

Re: [RFC v2 03/10] vfs: add one new mount option '-o hottrack'

2012-09-27 Thread Zhi Yong Wu
On Thu, Sep 27, 2012 at 3:05 PM, Dave Chinner da...@fromorbit.com wrote: On Thu, Sep 27, 2012 at 01:25:34PM +0800, Zhi Yong Wu wrote: On Tue, Sep 25, 2012 at 5:28 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:28PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong

Re: typo in inode.c

2012-09-27 Thread David Sterba
On Thu, Sep 27, 2012 at 05:04:02AM +0800, ching wrote: On 09/26/2012 11:23 PM, David Sterba wrote: On Wed, Sep 26, 2012 at 07:48:47PM +0800, ching wrote: There is a typo (?) in inode.c (git) What's the top commit and what git tree? This has been fixed in 3.6-rc4 via

Re: [PATCH v4 0/4] btrfs: extended inode refs

2012-09-27 Thread David Sterba
On Tue, Sep 25, 2012 at 04:04:46PM -0400, Chris Mason wrote: @@ -889,16 +899,23 @@ static inline int __add_inode_ref(struct btrfs_trans_handle *trans, while (cur_offset item_size) { extref = (struct btrfs_inode_extref *)base + cur_offset; -

[PATCH] Btrfs: improve the noflush reservation

2012-09-27 Thread Miao Xie
In some places(such as: evicting inode), we just can not flush the reserved space of delalloc, flushing the delayed directory index and delayed inode is OK, but we don't try to flush those things and just go back when there is no enough space to be reserved. This patch fixes this problem. We

Re: [PATCH 1/2] btrfs-progs: limit the max value of leafsize and nodesize

2012-09-27 Thread David Sterba
On Wed, Sep 26, 2012 at 03:52:07PM +0800, Robin Dong wrote: Using mkfs.btrfs like: mkfs.btrfs -l 131072 /dev/sda will return no error, but after mount it, the dmesg will report: BTRFS: couldn't mount because metadata blocksize (131072) was too large The user tools should use

[PATCH] Btrfs: fix wrong calculation of the available space when reserving the space

2012-09-27 Thread Miao Xie
According to the comment, we can overcommit the space up to 1/2 of the total disk space, or we just can overcommit up to 1/8. But the code was written reversedly. Fix it. Signed-off-by: Miao Xie mi...@cn.fujitsu.com --- This is based on btrfs-next tree. --- fs/btrfs/extent-tree.c |4 ++-- 1

Re: [PATCH] Btrfs: improve the noflush reservation

2012-09-27 Thread Miao Xie
On thu, 27 Sep 2012 16:45:51 +0800, Miao Xie wrote: In some places(such as: evicting inode), we just can not flush the reserved space of delalloc, flushing the delayed directory index and delayed inode is OK, but we don't try to flush those things and just go back when there is no enough space

BTRF - Storage Usage

2012-09-27 Thread Sébastien Maury
Hi, I've installed a new server using btrfs for my root partition (/). It uses snapper for snapshots management and all seems to work pretty fine. My problem is to be able to know the remaining REAL free space in my partition. Using different commands, i have different results, and i don't

[PATCH V4 1/2] Btrfs: cleanup duplicated division functions

2012-09-27 Thread Miao Xie
div_factor{_fine} has been implemented for two times, and these two functions are very similar, so cleanup the reduplicate implement and drop the original div_factor(), and then rename div_factor_fine() to div_factor(). So the factor of the new div_factor() is 100, not 10. And I move div_factor

Re: [PATCH V3 1/2] Btrfs: cleanup duplicated division functions

2012-09-27 Thread Miao Xie
Sorry to reply late. On Mon, 24 Sep 2012 18:47:42 +0200, David Sterba wrote: This is the most straightforward transformation I can think of. It doesn't result in an unnecessary BUG_ON, keeps churn to a minimum and agree with you. doesn't change the style of the balance ioctl. (If I were

Re: BTRF - Storage Usage

2012-09-27 Thread Hugo Mills
On Thu, Sep 27, 2012 at 12:44:27PM +0200, Sébastien Maury wrote: I've installed a new server using btrfs for my root partition (/). It uses snapper for snapshots management and all seems to work pretty fine. My problem is to be able to know the remaining REAL free space in my partition.

Re: BTRF - Storage Usage

2012-09-27 Thread Sébastien Maury
Hi, Thanks for the quick reply, this clarify me lots of things. I've had read the articles you mentioned, but i must admit that your explanations based on my examples makes things even more clearer. Also, if i understand things properly, snaphots size aren't included in the btrfs

Re: [PATCH] Btrfs: improve the noflush reservation

2012-09-27 Thread Miao Xie
Please ignore this patch, my btrfs-next tree is old, and this patch will conflict with Josef's patch [PATCH] Btrfs: run delayed refs first when out of space I will modify this patch as soon as possible. Thanks Miao On thu, 27 Sep 2012 16:45:51 +0800, Miao Xie wrote: In some places(such as:

Re: BTRF - Storage Usage

2012-09-27 Thread Hugo Mills
On Thu, Sep 27, 2012 at 01:25:58PM +0200, Sébastien Maury wrote: Hi, Thanks for the quick reply, this clarify me lots of things. I've had read the articles you mentioned, but i must admit that your explanations based on my examples makes things even more clearer. Also, if i understand

Re: BTRF - Storage Usage

2012-09-27 Thread Sébastien Maury
Hi, Thanks a lot for your time and answers. Things look pretty clear now for me. I'm monitoring my systems using nagios, and i was annoyed about the disk usage monitoring. Thanks to your answers, i should be able to developp a rather accurate script. Or so i hope :) Regards, Sebastien.

Re: [PATCH] Btrfs: fix wrong calculation of the available space when reserving the space

2012-09-27 Thread Miao Xie
Please ignore this patch, it is not based on the new btrfs-next tree. I'll send the right one as soon as possible. Thanks Miao On thu, 27 Sep 2012 17:09:15 +0800, Miao Xie wrote: According to the comment, we can overcommit the space up to 1/2 of the total disk space, or we just can overcommit

Re: [PATCH] Btrfs: fix wrong calculation of the available space when reserving the space

2012-09-27 Thread Josef Bacik
On Thu, Sep 27, 2012 at 03:09:15AM -0600, Miao Xie wrote: According to the comment, we can overcommit the space up to 1/2 of the total disk space, or we just can overcommit up to 1/8. But the code was written reversedly. Fix it. Sorry the comment is wrong, I was actually just looking at this

Re: [PATCH V4 1/2] Btrfs: cleanup duplicated division functions

2012-09-27 Thread Ilya Dryomov
Hi Miao, You haven't addressed any of my concerns with v3. On Thu, Sep 27, 2012 at 06:19:58PM +0800, Miao Xie wrote: (snipped) the parameters are right. So besides the code cleanup, this patch also add a check for the usage of the space balance, it is the only place that we need add check

Re: btrfs send/receive review by vfs folks

2012-09-27 Thread Alex Lyakas
Hi Jan, I hope to get my proposal working soon, then expect for some code from me to look at. Thanks! Alex. On Mon, Sep 24, 2012 at 11:27 AM, Jan Schmidt list.bt...@jan-o-sch.net wrote: Hi Alex, On Mon, September 24, 2012 at 11:13 (+0200), Alex Lyakas wrote: Hi, write_buf: Used to write

Re: [PATCH v4 0/4] btrfs: extended inode refs

2012-09-27 Thread Mark Fasheh
On Tue, Sep 25, 2012 at 04:04:46PM -0400, Chris Mason wrote: On Mon, Aug 20, 2012 at 02:29:17PM -0600, Mark Fasheh wrote: Testing wise, the basic namespace operations work well (link, unlink, etc). The rest has gotten less debugging (and I really don't have a great way of testing the

[RFC] btrfs fi df output [Was Re: BTRF - Storage Usage]

2012-09-27 Thread Goffredo Baroncelli
On 09/27/2012 12:44 PM, Sébastien Maury wrote: Hi, I've installed a new server using btrfs for my root partition (/). It uses snapper for snapshots management and all seems to work pretty fine. My problem is to be able to know the remaining REAL free space in my partition. Using different

[PATCH] Btrfs: cache extent state when writing out dirty metadata pages

2012-09-27 Thread Josef Bacik
Everytime we write out dirty pages we search for an offset in the tree, convert the bits in the state, and then when we wait we search for the offset again and clear the bits. So for every dirty range in the io tree we are doing 4 rb searches, which is suboptimal. With this patch we are only

[PATCH] btrfs-convert: show progress

2012-09-27 Thread Alfredo Esteban
Hello, I'm sending a patch to show progress of btrfs-convert command. I put a progress bar in the only heavy process: the btrfs metadata creation (due to CRC calculation): ./btrfs-convert /dev/loop1 Creating btrfs metadata [] 100% Creating ext2fs

Re: [PATCH] btrfs-convert: show progress

2012-09-27 Thread cwillu
On Thu, Sep 27, 2012 at 6:02 PM, Alfredo Esteban aedelato...@gmail.com wrote: Hello, I'm sending a patch to show progress of btrfs-convert command. I put a progress bar in the only heavy process: the btrfs metadata creation (due to CRC calculation): Please include patches inline in the

[PATCH V5 1/2] Btrfs: cleanup duplicated division functions

2012-09-27 Thread Miao Xie
div_factor{_fine} has been implemented for two times, and these two functions are very similar, so cleanup the reduplicate implement and drop the original div_factor(), and then rename div_factor_fine() to div_factor(). So the factor of the new div_factor() is 100, not 10. And I move div_factor

Re: [PATCH V4 1/2] Btrfs: cleanup duplicated division functions

2012-09-27 Thread Miao Xie
On thu, 27 Sep 2012 19:56:24 +0300, Ilya Dryomov wrote: the parameters are right. So besides the code cleanup, this patch also add a check for the usage of the space balance, it is the only place that we need add check to make sure the parameters of div_factor are right till now. Besides that,

[PATCH v2 1/2] btrfs-progs: limit the max value of leafsize and nodesize

2012-09-27 Thread Robin Dong
From: Robin Dong san...@taobao.com Using mkfs.btrfs like: mkfs.btrfs -l 131072 /dev/sda will return no error, but after mount it, the dmesg will report: BTRFS: couldn't mount because metadata blocksize (131072) was too large The leafsize and nodesize are equal at present, so

[PATCH v2 2/2] btrfs-progs: limit the min value of total_bytes

2012-09-27 Thread Robin Dong
From: Robin Dong san...@taobao.com Using mkfs.btrfs like: mkfs.btrfs -b 1048576 /dev/sda will report error: mkfs.btrfs: volumes.c:796: btrfs_alloc_chunk: Assertion `!(ret)' failed. Aborted because the length of dev_extent is 4MB. But if we use mkfs.btrfs with 8MB

Re: [RFC] btrfs fi df output [Was Re: BTRF - Storage Usage]

2012-09-27 Thread Roman Mamedov
On Thu, 27 Sep 2012 23:02:35 +0200 Goffredo Baroncelli kreij...@libero.it wrote: Sorry for the space error: Below a more correct example $ btrfs filesystem disk-free / Summary: Total:135.00GB Allocated: 10.51GB Unallocated: