Re: [PATCH] btrfs: fix reversed warning condition in btrfs_delayed_inode_reserve_metadata

2014-04-02 Thread Liu Bo
On Wed, Apr 02, 2014 at 07:13:00PM +0200, David Sterba wrote: > Commit fae7f21cece9a4c181 ("btrfs: Use WARN_ON()'s return value in place of > WARN_ON(1)") cleaned up WARN_ON usage and in one place reversed the condition > that led to loads of warnings that were not supposed to occur. > > WARN_ON w

Re: [PATCH] btrfs: fix reversed warning condition in btrfs_delayed_inode_reserve_metadata

2014-04-02 Thread Liu Bo
On Wed, Apr 02, 2014 at 07:13:00PM +0200, David Sterba wrote: > Commit fae7f21cece9a4c181 ("btrfs: Use WARN_ON()'s return value in place of > WARN_ON(1)") cleaned up WARN_ON usage and in one place reversed the condition > that led to loads of warnings that were not supposed to occur. > > WARN_ON w

Re: Btrfs lockdep with 3.15 merge window v3.14-751-g683b6c6f82a6

2014-04-02 Thread Chris Mason
On 04/02/2014 12:47 PM, David Sterba wrote: On Tue, Apr 01, 2014 at 06:23:11PM -0400, Josh Boyer wrote: Below is a lockdep spew I have on a local VM running Linus' tree as of this afternoon. The specific git commit is v3.14-751-g683b6c6f82a6. [ 295.349016]CPU0CPU

Re: Btrfs lockdep with 3.15 merge window v3.14-751-g683b6c6f82a6

2014-04-02 Thread Josh Boyer
On Wed, Apr 2, 2014 at 12:56 PM, Josh Boyer wrote: > On Wed, Apr 2, 2014 at 12:47 PM, David Sterba wrote: >> On Tue, Apr 01, 2014 at 06:23:11PM -0400, Josh Boyer wrote: >>> Below is a lockdep spew I have on a local VM running Linus' tree as of >>> this afternoon. The specific git commit is v3.14

Re: Space cache degradation

2014-04-02 Thread Chris Mason
On 04/02/2014 01:54 PM, Justin Maggard wrote: I've found that, after using some btrfs filesystems for some time, that the first large write after a reboot takes a very long time. So I went to work trying out different test cases to simplify reproduction of the issue, and I've got it down to ju

Space cache degradation

2014-04-02 Thread Justin Maggard
I've found that, after using some btrfs filesystems for some time, that the first large write after a reboot takes a very long time. So I went to work trying out different test cases to simplify reproduction of the issue, and I've got it down to just these steps: 1) mkfs.btrfs on a large-ish devi

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-04-02 Thread David Sterba
On Wed, Apr 02, 2014 at 04:29:11PM +0800, Qu Wenruo wrote: > Convert the old btrfs man pages to new asciidoc and split the huge > btrfs man page into subcommand man page. Excellent! > The asciidoc style and Makefile things are mostly simplified from git > Documentation, which only supports man pa

[PATCH] btrfs: fix reversed warning condition in btrfs_delayed_inode_reserve_metadata

2014-04-02 Thread David Sterba
Commit fae7f21cece9a4c181 ("btrfs: Use WARN_ON()'s return value in place of WARN_ON(1)") cleaned up WARN_ON usage and in one place reversed the condition that led to loads of warnings that were not supposed to occur. WARN_ON will trigger because it sees 'ret' though in the previous code did not re

Re: [PATCH] Btrfs: avoid warning bomb of btrfs_delayed_inode_reserve_metadata

2014-04-02 Thread David Sterba
On Wed, Apr 02, 2014 at 05:41:10PM +0800, Liu Bo wrote: > When we nearly run out of global_block_rsv's reserved space, this WARNING will > be hit for thousands of times, which is not good because the kernel log has > nothing else. > > ret = btrfs_block_rsv_migrate(src_rsv, dst_rsv, n

Re: Btrfs lockdep with 3.15 merge window v3.14-751-g683b6c6f82a6

2014-04-02 Thread Josh Boyer
On Wed, Apr 2, 2014 at 12:47 PM, David Sterba wrote: > On Tue, Apr 01, 2014 at 06:23:11PM -0400, Josh Boyer wrote: >> Below is a lockdep spew I have on a local VM running Linus' tree as of >> this afternoon. The specific git commit is v3.14-751-g683b6c6f82a6. > >> [ 295.349016]CPU0

Re: Btrfs lockdep with 3.15 merge window v3.14-751-g683b6c6f82a6

2014-04-02 Thread David Sterba
On Tue, Apr 01, 2014 at 06:23:11PM -0400, Josh Boyer wrote: > Below is a lockdep spew I have on a local VM running Linus' tree as of > this afternoon. The specific git commit is v3.14-751-g683b6c6f82a6. > [ 295.349016]CPU0CPU1 > [ 295.349016]

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-04-02 Thread Marc MERLIN
On Wed, Apr 02, 2014 at 09:24:10AM -0400, Chris Mason wrote: > On 04/02/2014 04:29 AM, Qu Wenruo wrote: > >Convert the old btrfs man pages to new asciidoc and split the huge > >btrfs man page into subcommand man page. > > > >The asciidoc style and Makefile things are mostly simplified from git > >D

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-04-02 Thread Chris Mason
On 04/02/2014 04:29 AM, Qu Wenruo wrote: Convert the old btrfs man pages to new asciidoc and split the huge btrfs man page into subcommand man page. The asciidoc style and Makefile things are mostly simplified from git Documentation, which only supports man page output and remove html output, si

[PATCH] Btrfs: fix unlock in __start_delalloc_inodes()

2014-04-02 Thread Wang Shilong
This patch fix a regression caused by the following patch: Btrfs: don't flush all delalloc inodes when we doesn't get s_umount lock break while loop will make us call @spin_unlock() without calling @spin_lock() before, fix it. Signed-off-by: Wang Shilong --- fs/btrfs/inode.c | 5 +++-- 1 file c

[PATCH v2 4/9] Btrfs: use bitfield instead of integer data type for the some variants in btrfs_root

2014-04-02 Thread Wang Shilong
From: Miao Xie Signed-off-by: Miao Xie Signed-off-by: Wang Shilong --- v1->v2: fix wrong test where we should test @force_cow while we test @root_refs(Thanks to Josef) --- fs/btrfs/ctree.c | 25 ++--- fs/btrfs/ctree.h | 39 +--

[PATCH] Btrfs: use helpers for last_trans_log_full_commit instead of opencode

2014-04-02 Thread Wang Shilong
From: Miao Xie Signed-off-by: Miao Xie Signed-off-by: Wang Shilong --- fs/btrfs/extent-tree.c | 5 ++--- fs/btrfs/inode.c | 2 +- fs/btrfs/tree-log.c| 40 +--- fs/btrfs/tree-log.h| 16 4 files changed, 36 insertions(+), 27 de

[PATCH RFC v2] Btrfs: device_list_add() should not update list when mounted

2014-04-02 Thread Anand Jain
Device list add shouldn't update the list when FS is mounted, unless the whole loop w.r.t to bringing back the missing disk is completed. (That is making it to be part of the group profile and the code for this isn't there yet). As as of now (without this patch) when device is scanned with missing

[PATCH RFC] Btrfs: device_list_add() should not update list when mounted

2014-04-02 Thread Anand Jain
Device list add shouldn't update the list when FS is mounted, unless the whole loop w.r.t to bringing back the missing disk is completed. (That is making it to be part of the group profile and the code for this isn't there yet). As as of now (without this patch) when device is scanned with missing

[PATCH] Btrfs: avoid warning bomb of btrfs_delayed_inode_reserve_metadata

2014-04-02 Thread Liu Bo
When we nearly run out of global_block_rsv's reserved space, this WARNING will be hit for thousands of times, which is not good because the kernel log has nothing else. Signed-off-by: Liu Bo --- fs/btrfs/delayed-inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs

[PATCH v3] lib: add size unit t/p/e to memparse

2014-04-02 Thread Gui Hecheng
For modern filesystems such as btrfs, t/p/e size level operations are common. add size unit t/p/e parsing to memparse Signed-off-by: Gui Hecheng --- changelog v1->v2: replace kilobyte with kibibyte, and others v2->v3: add missing unit "bytes" in comment --- lib/cmdline.c | 25 +++

[PATCH 10/27] btrfs-progs: Convert man page for btrfs-send.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-send. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-send.txt | 60 2 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-send.txt diff --git a/Docu

[PATCH 15/27] btrfs-progs: Convert man page for btrfs-dedup.

2014-04-02 Thread Qu Wenruo
Although the btrfs-dedup function is not available in mainline kernel, add the man page any way and add a warning into it. Signed-off-by: Qu Wenruo --- Documentation/Makefile| 2 +- Documentation/btrfs-dedup.txt | 51 +++ 2 files changed, 52 inser

[PATCH 04/27] btrfs-progs: Convert man page for btrfs-balance.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-balance. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-balance.txt | 77 + 2 files changed, 78 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-balance.txt diff --g

[PATCH 03/27] btrfs-progs: Convert man page for filesystem subcommand.

2014-04-02 Thread Qu Wenruo
Convert man page for filesystem subcommand. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-filesystem.txt | 163 + 2 files changed, 164 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-filesyst

[PATCH 13/27] btrfs-progs: Convert and enhance the man page of btrfs-qgroup.

2014-04-02 Thread Qu Wenruo
Convert and enhance the man page of btrfs-qgroup. The original man page for btrfs-qgroup subcommand is almost useless for new user(like me), so adds more information on it. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 1 + Documentation/btrfs-qgroup.txt | 110

[PATCH 06/27] btrfs-progs: Convert man page for btrfs-scrub

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-scrub. Signed-off-by: Qu Wenruo --- Documentation/Makefile| 2 +- Documentation/btrfs-scrub.txt | 98 +++ 2 files changed, 99 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-scrub.txt diff --git a/D

[PATCH 12/27] btrfs-progs: Convert man page for btrfs-quota.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-quota. Signed-off-by: Qu Wenruo --- Documentation/Makefile| 2 +- Documentation/btrfs-quota.txt | 59 +++ 2 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-quota.txt diff --git a/D

[PATCH 11/27] btrfs-progs: Convert man page for btrfs-receive.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-receive. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-receive.txt | 58 + 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-receive.txt diff --g

[PATCH 09/27] btrfs-progs: Convert man page for btrfs-inspect-internal

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-inspect-internal. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-inspect-internal.txt | 69 2 files changed, 70 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-ins

[PATCH 08/27] btrfs-progs: Convert man page for btrfs-rescue

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-rescue. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-rescue.txt | 60 ++ 2 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-rescue.txt diff --git

[PATCH 18/27] btrfs-progs: Convert man page for btrfs-debug-tree.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-debug-tree. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-debug-tree.txt | 50 ++ 2 files changed, 51 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-debug-tree.txt

[PATCH 17/27] btrfs-progs: Convert man page for btrfs-convert.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-convert. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-convert.txt | 49 + 2 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-convert.txt diff --g

[PATCH 19/27] btrfs-progs: Convert man page for btrfs-find-root.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-find-root. Signed-off-by: Qu Wenruo --- Documentation/Makefile| 2 +- Documentation/btrfs-find-root.txt | 45 +++ 2 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-find-root.txt di

[PATCH 20/27] btrfs-progs: Convert man page for btrfs-image.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-image. Signed-off-by: Qu Wenruo --- Documentation/Makefile| 2 +- Documentation/btrfs-image.txt | 70 +++ 2 files changed, 71 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-image.txt diff --git a/D

[PATCH 14/27] btrfs-progs: Convert man page for btrfs-replace.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-replace. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-replace.txt | 76 + 2 files changed, 77 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-replace.txt diff --g

[PATCH 07/27] btrfs-progs: Convert man page for btrfs-check.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-check. Signed-off-by: Qu Wenruo --- Documentation/Makefile| 2 +- Documentation/btrfs-check.txt | 45 +++ 2 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-check.txt diff --git a/D

[PATCH 27/27] btrfs-progs: Switch to the new asciidoc Documentation.

2014-04-02 Thread Qu Wenruo
Since all man page are converted to the new asciidoc, the old man page can be removed. Signed-off-by: Qu Wenruo --- Makefile | 4 +- man/Makefile | 31 -- man/btrfs-convert.8.in | 33 -- man/btrfs-debug-tree.8.in | 35 -- man/btrfs-find-root.8.in | 30

[PATCH 25/27] btrfs-progs: Convert man page for fsck.btrfs.

2014-04-02 Thread Qu Wenruo
Convert man page for fsck.btrfs. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/fsck.btrfs.txt | 51 2 files changed, 52 insertions(+), 1 deletion(-) create mode 100644 Documentation/fsck.btrfs.txt diff --git a/Docu

[PATCH 24/27] btrfs-progs: Convert man page for btrfs-zero-log

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-zero-log Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-zero-log.txt | 39 +++ 2 files changed, 40 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-zero-log.txt diff --

[PATCH 26/27] btrfs-progs: Convert man page for mkfs.btrfs.

2014-04-02 Thread Qu Wenruo
Convert man page for mkfs.btrfs. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/mkfs.btrfs.txt | 133 +++ 2 files changed, 134 insertions(+), 1 deletion(-) create mode 100644 Documentation/mkfs.btrfs.txt diff --git a/Do

[PATCH 22/27] btrfs-progs: Convert man page for btrfs-show-super.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-show-super. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-show-super.txt | 53 ++ 2 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-show-super.txt

[PATCH 16/27] btrfs-progs: Convert man page for btrfsck

2014-04-02 Thread Qu Wenruo
Convert man page for btrfsck. Signed-off-by: Qu Wenruo --- Documentation/Makefile| 2 +- Documentation/btrfsck.txt | 55 +++ 2 files changed, 56 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfsck.txt diff --git a/Documentation

[PATCH 21/27] btrfs-progs: Convert man page for btrfs-map-logical.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-map-logical. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-map-logical.txt | 49 + 2 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-map-logical.t

[PATCH 23/27] btrfs-progs: Convert man page for btrfstune.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfstune. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfstune.txt | 47 + 2 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfstune.txt diff --git a/Documen

[PATCH 05/27] btrfs-progs: Convert man page for btrfs-device subcommand.

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-device subcommand. Signed-off-by: Qu Wenruo --- Documentation/Makefile | 2 +- Documentation/btrfs-device.txt | 75 ++ 2 files changed, 76 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-device.txt

[PATCH 01/27] btrfs-progs: Introduce asciidoc based man page and btrfs man page.

2014-04-02 Thread Qu Wenruo
The old man page of btrfs will grow larger with new functions adding to btrfs-progs and harder to maintain because the reader-unfriendly roff grammar and one LARGE btrfs.in. This patch will introduce the simplified Documentation directory mainly 'stolen' from git and include the first man page for

[PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-04-02 Thread Qu Wenruo
Convert the old btrfs man pages to new asciidoc and split the huge btrfs man page into subcommand man page. The asciidoc style and Makefile things are mostly simplified from git Documentation, which only supports man page output and remove html output, since html output is somewhat overkilled for

[PATCH 02/27] btrfs-progs: Convert man page for btrfs-subvolume

2014-04-02 Thread Qu Wenruo
Convert man page for btrfs-subvolume. Signed-off-by: Qu Wenruo --- Documentation/Makefile| 2 +- Documentation/btrfs-subvolume.txt | 172 ++ 2 files changed, 173 insertions(+), 1 deletion(-) create mode 100644 Documentation/btrfs-subvolume.txt