Re: fallocate fail on btrfs

2014-08-26 Thread Duncan
G. Richard Bellamy posted on Tue, 26 Aug 2014 22:05:01 -0700 as excerpted: > When I try to run fallocate with "--keep-size" on my btrfs partitions, > it's failing, and I'm at a loss as to why. This was working in prior > versions. > > Any suggestions on how to attack this problem? I'm betting I'm

fallocate fail on btrfs

2014-08-26 Thread G. Richard Bellamy
When I try to run fallocate with "--keep-size" on my btrfs partitions, it's failing, and I'm at a loss as to why. This was working in prior versions. Any suggestions on how to attack this problem? I'm betting I'm missing something simple here, and have just gone down the rabbit hole... BTW, I've

ext4 vs btrfs performance on SSD array

2014-08-26 Thread Nikolai Grigoriev
Hi, This is not exactly a problem - I am trying to understand why BTRFS demonstrates significantly higher throughput in my environment. I am observing something that I cannot explain. I am trying to come up with a good filesystem configuration using HP P420i controller and SSDs (Intel S3500). Out

Re: [PATCH 0/3] btrfs-progs: remove full /dev scanning

2014-08-26 Thread Anand Jain
On 26/08/2014 22:53, Chris Mason wrote: On 08/26/2014 10:51 AM, Eric Sandeen wrote: On 8/26/14, 5:55 AM, David Sterba wrote: On Thu, Aug 21, 2014 at 08:08:57PM +0200, Goffredo Baroncelli wrote: Of course I (we) don't care cdrom and/or floppy, but this raises the question: are there other blo

[GIT PULL] Btrfs for rc3

2014-08-26 Thread Chris Mason
Hi Linus, Please pull our fixes from my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus The biggest of these comes from Liu Bo, who tracked down a hang we've been hitting since moving to kernel workqueues (it's a btrfs bug, not in the generic code)

Re: [PATCH RFC] Btrfs: fix warning of insert_state() when doing lseek

2014-08-26 Thread Chris Mason
On 08/26/2014 11:15 AM, Liu Bo wrote: > An user reported this, it is because that lseek's SEEK_SET/SEEK_CUR/SEEK_END > allow a negative value for @offset, but btrfs's SEEK_DATA/SEEK_HOLE don't > prepare for that and convert the negative @offset into unsigned type, > so we get (end < start) warnin

[PATCH RFC] Btrfs: fix warning of insert_state() when doing lseek

2014-08-26 Thread Liu Bo
An user reported this, it is because that lseek's SEEK_SET/SEEK_CUR/SEEK_END allow a negative value for @offset, but btrfs's SEEK_DATA/SEEK_HOLE don't prepare for that and convert the negative @offset into unsigned type, so we get (end < start) warning. [ 1269.835374] [ cut here ]-

Re: [PATCH 0/3] btrfs-progs: remove full /dev scanning

2014-08-26 Thread Chris Mason
On 08/26/2014 10:51 AM, Eric Sandeen wrote: > On 8/26/14, 5:55 AM, David Sterba wrote: >> On Thu, Aug 21, 2014 at 08:08:57PM +0200, Goffredo Baroncelli wrote: >>> Of course I (we) don't care cdrom and/or floppy, but this raises >>> the question: are there other block devices which aren't showed in

Re: [PATCH 0/3] btrfs-progs: remove full /dev scanning

2014-08-26 Thread Eric Sandeen
On 8/26/14, 5:55 AM, David Sterba wrote: > On Thu, Aug 21, 2014 at 08:08:57PM +0200, Goffredo Baroncelli wrote: >> Of course I (we) don't care cdrom and/or floppy, but this raises >> the question: are there other block devices which aren't showed in >> proc/partitions ? > > cdrom appears as /de

Btrfs-progs releases

2014-08-26 Thread Chris Mason
Hi everyone, I've just tagged btrfs-progs v3.16. Like the last few releases, this one was prepared by Dave Sterba, who has been wrangling btrfs-progs patches for some time now. Dave has asked to officially take over the btrfs-progs maintenance, and I said yes before he could change his mind. Ev

Re: [PATCH v3] Btrfs: fix task hang under heavy compressed write

2014-08-26 Thread Martin Steigerwald
Am Dienstag, 26. August 2014, 09:02:23 schrieb Chris Mason: > On 08/26/2014 06:20 AM, Martin Steigerwald wrote: > > Am Montag, 25. August 2014, 10:58:13 schrieb Chris Mason: > >> On 08/15/2014 11:36 AM, Liu Bo wrote: > >>> This has been reported and discussed for a long time, and this hang > >>> oc

Re: [PATCH v3] Btrfs: fix task hang under heavy compressed write

2014-08-26 Thread Chris Mason
On 08/26/2014 06:20 AM, Martin Steigerwald wrote: > Am Montag, 25. August 2014, 10:58:13 schrieb Chris Mason: >> On 08/15/2014 11:36 AM, Liu Bo wrote: >>> This has been reported and discussed for a long time, and this hang occurs >>> in both 3.15 and 3.16. >> >> [ great description ] >> >> I ran

Re: [PATCH v3] Btrfs: fix task hang under heavy compressed write

2014-08-26 Thread Martin Steigerwald
Am Dienstag, 26. August 2014, 18:38:03 schrieb Liu Bo: > On Tue, Aug 26, 2014 at 12:20:28PM +0200, Martin Steigerwald wrote: > > Am Montag, 25. August 2014, 10:58:13 schrieb Chris Mason: > > > On 08/15/2014 11:36 AM, Liu Bo wrote: > > > > This has been reported and discussed for a long time, and th

Re: Most recent stable enough btrfs-tools?

2014-08-26 Thread Martin Steigerwald
Am Montag, 25. August 2014, 14:45:39 schrieb Chris Murphy: > On Aug 25, 2014, at 6:00 AM, Martin Steigerwald wrote: > > What is the latest stuff that stills supposed to work okay? > > I'm new to git so take this with a grain of salt, but this returns no > differences: > > git diff mason/master s

Re: fuzz testing a 32 bit x86 user mode linux guest brought a BUG in

2014-08-26 Thread Liu Bo
On Tue, Aug 26, 2014 at 04:11:53PM +0800, Liu Bo wrote: > On Mon, Aug 25, 2014 at 06:14:41PM +0200, Toralf Förster wrote: > > On 08/25/2014 06:12 AM, Liu Bo wrote: > > > Could you please elaborate what options of trinity you're using? > > > > > > thanks, > > > -liubo > > > > $> nice trinity.sh -t

Re: [PATCH 0/3] btrfs-progs: remove full /dev scanning

2014-08-26 Thread David Sterba
On Thu, Aug 21, 2014 at 09:29:56AM -0500, Eric Sandeen wrote: > On 8/21/14, 3:44 AM, Anand Jain wrote: > > > > > > A long time back there was an attempt to remove it but > > this avoided it. Pls ref to the link in this discussion. > > > > https://www.mail-archive.com/linux-btrfs@vger.kernel.o

Re: [PATCH] Btrfs: shrink further sizeof(struct extent_buffer)

2014-08-26 Thread David Sterba
On Thu, Aug 14, 2014 at 12:25:14PM +0100, Filipe Manana wrote: > The map_start and map_len fields aren't used anywhere, so just remove > them. On a x86_64 system, this reduced sizeof(struct extent_buffer) > from 296 bytes to 280 bytes, and therefore 14 extent_buffer structs can > now fit into a pag

Re: [PATCH 0/3] btrfs-progs: remove full /dev scanning

2014-08-26 Thread David Sterba
On Thu, Aug 21, 2014 at 08:08:57PM +0200, Goffredo Baroncelli wrote: > Of course I (we) don't care cdrom and/or floppy, but this raises > the question: are there other block devices which aren't showed in > proc/partitions ? cdrom appears as /dev/sr0, floppy is /dev/fd0 if the respective module

Re: [PATCH v3] Btrfs: fix task hang under heavy compressed write

2014-08-26 Thread Liu Bo
On Tue, Aug 26, 2014 at 12:20:28PM +0200, Martin Steigerwald wrote: > Am Montag, 25. August 2014, 10:58:13 schrieb Chris Mason: > > On 08/15/2014 11:36 AM, Liu Bo wrote: > > > This has been reported and discussed for a long time, and this hang occurs > > > in both 3.15 and 3.16. > > > > [ great de

Re: [PATCH v3] Btrfs: fix task hang under heavy compressed write

2014-08-26 Thread Martin Steigerwald
Am Montag, 25. August 2014, 10:58:13 schrieb Chris Mason: > On 08/15/2014 11:36 AM, Liu Bo wrote: > > This has been reported and discussed for a long time, and this hang occurs > > in both 3.15 and 3.16. > > [ great description ] > > I ran this through tests last week, and an overnight test over

Re: [PATCH 0/3] btrfs-progs: remove full /dev scanning

2014-08-26 Thread Anand Jain
Apparently we don't need -d option at all. The libblkid does cover both udev and /proc/partitions. EVALUATE= Defines LABEL and UUID evaluation method(s). Currently, the libblkid library supports "udev" and "scan" methods. More than one methods may be specified in a comma separated

Re: [PATCH] Btrfs: fix corruption after write/fsync failure + fsync + log recovery

2014-08-26 Thread Liu Bo
On Tue, Aug 26, 2014 at 08:56:18AM +0100, Filipe David Manana wrote: > On Tue, Aug 26, 2014 at 4:32 AM, Liu Bo wrote: > > On Mon, Aug 25, 2014 at 10:43:00AM +0100, Filipe Manana wrote: > >> While writing to a file, in inode.c:cow_file_range() (and same applies to > >> submit_compressed_extents()),

Re: [PATCH 3/3] btrfs-progs: remove BTRFS_SCAN_DEV and btrfs_scan_one_dir

2014-08-26 Thread Anand Jain
:-( to see the entire btrfs_scan_one_dir() going away. Reviewed-by: Anand Jain On 21/08/2014 06:24, Eric Sandeen wrote: After the previous 2 patches, nothing uses whole-dev-tree scanning, so remove the code which implemented that functionality. Signed-off-by: Eric Sandeen --- diff --git

Re: [PATCH 2/3] btrfs-progs: don't fall back to recursive /dev scan

2014-08-26 Thread Anand Jain
Reviewed-by: Anand Jain On 21/08/2014 06:23, Eric Sandeen wrote: If we didn't find what we are looking for in /proc/partitions, we're not going to find it by scanning every node under /dev, either. But that's just what btrfs_scan_for_fsid() does. Remove that fallback; at that point btrfs_sc

Re: [PATCH 1/3] btrfs-progs: scan /proc/partitions not all of /dev with "-d"

2014-08-26 Thread Anand Jain
Reviewed-by: Anand Jain On 21/08/2014 06:22, Eric Sandeen wrote: We can scan for btrfs devices in a few ways. By default libblkid is used for "device scan" and "filesystem show"; with the -m option only mounted filesystems are scanned, and with -d we physically read every system device. But

Re: [PATCH 0/3] btrfs-progs: remove full /dev scanning

2014-08-26 Thread Anand Jain
On 21/08/2014 22:29, Eric Sandeen wrote: On 8/21/14, 3:44 AM, Anand Jain wrote: A long time back there was an attempt to remove it but this avoided it. Pls ref to the link in this discussion. https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg27272.html Hm, I guess I don't

Re: fuzz testing a 32 bit x86 user mode linux guest brought a BUG in

2014-08-26 Thread Liu Bo
On Mon, Aug 25, 2014 at 06:14:41PM +0200, Toralf Förster wrote: > On 08/25/2014 06:12 AM, Liu Bo wrote: > > Could you please elaborate what options of trinity you're using? > > > > thanks, > > -liubo > > $> nice trinity.sh -t "-C 2 -N 10 -x mremap -x munmap -x madvise -q" -v > /mnt/btrfs >

Re: [PATCH] Btrfs: fix corruption after write/fsync failure + fsync + log recovery

2014-08-26 Thread Filipe David Manana
On Tue, Aug 26, 2014 at 4:32 AM, Liu Bo wrote: > On Mon, Aug 25, 2014 at 10:43:00AM +0100, Filipe Manana wrote: >> While writing to a file, in inode.c:cow_file_range() (and same applies to >> submit_compressed_extents()), after reserving an extent for the file data, >> we create a new extent map f