Re: How btrfs-find-root knows that the block is actually a root?

2014-12-23 Thread Alex Lyakas
Hi Qu, On Tue, Dec 23, 2014 at 7:27 AM, Qu Wenruo quwen...@cn.fujitsu.com wrote: Original Message Subject: How btrfs-find-root knows that the block is actually a root? From: Alex Lyakas alex.bt...@zadarastorage.com To: linux-btrfs linux-btrfs@vger.kernel.org Date:

Re: [RFC PATCH 06/17] btrfs: make use of immutable biovecs

2014-12-23 Thread Christoph Hellwig
This seems like it could be applied without the rest of the series, right? Might be worth to get it into the btrfs tree ASAP? -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [RFC PATCH 06/17] btrfs: make use of immutable biovecs

2014-12-23 Thread Dongsu Park
On 23.12.2014 02:35, Christoph Hellwig wrote: This seems like it could be applied without the rest of the series, right? Might be worth to get it into the btrfs tree ASAP? Ah, you're right. While patch #5 must be in this series, patch #6 does not necessarily have to be included. This

Re: Standards Problems [Was: [PATCH v2 1/3] Btrfs: get more accurate output in df command.]

2014-12-23 Thread Dongsheng Yang
On 12/18/2014 12:07 PM, Robert White wrote: I don't disagree with the _ideal_ of your patch. I just think that it's impossible to implement it without lying to the user or making things just as bad in a different way. I would _like_ you to be right. But my thing is finding and quantifying

Re: Can BTRFS handle XATTRs larger than 4K?

2014-12-23 Thread Austin S Hemmelgarn
On 2014-12-22 19:08, Robert White wrote: On 12/22/2014 02:55 PM, Richard Sharpe wrote: On Mon, Dec 22, 2014 at 2:52 PM, Robert White rwh...@pobox.com wrote: So skipping the full ADS, what's the current demand/payoff for large XATTR space? Windows Security Descriptors (sometimes incorrectly

Re: [RFC PATCH 05/17] btrfs: remove bio splitting and merge_bvec_fn() calls

2014-12-23 Thread Chris Mason
On Mon, Dec 22, 2014 at 6:48 AM, Dongsu Park dongsu.p...@profitbricks.com wrote: From: Kent Overstreet k...@daterainc.com Btrfs has been doing bio splitting from btrfs_map_bio(), by checking device limits as well as calling -merge_bvec_fn() etc. That is not necessary any more, because

Re: [PATCH] btrfs-progs: rebuild missing block group during chunk recovery if possible

2014-12-23 Thread Alex Lyakas
Hi Qu, On Thu, Oct 30, 2014 at 4:54 AM, Qu Wenruo quwen...@cn.fujitsu.com wrote: Before the patch, chunk will be considered bad if the corresponding block group is missing, even the only uncertain data is the 'used' member of the block group. This patch will try to recalculate the 'used'

[PATCH] btrfs-progs: Fix btrfs fi show by uuid and label

2014-12-23 Thread Justin Maggard
Commit 8be2fff (btrfs-progs: apply realpath for btrfs fi show when mount point is given) changed the behavior of btrfs fi show to return an error if the call to realpath() failed. This broke the ability to specify a filesystem by uuid or label. So let's not consider a failed call to realpath()

Re: Quota limit question

2014-12-23 Thread Christian Robottom Reis
On Tue, Dec 16, 2014 at 11:15:37PM -0200, Christian Robottom Reis wrote: # btrfs qgroup limit 2000m 0/261 . touch x touch: cannot touch ‘x’: Disk quota exceeded The strange thing is that it doesn't seem to be actually out of space: # btrfs qgroup show -p -r -e /var | grep 261

Re: [PATCH] btrfs: add regression test for remount with thread_pool resized

2014-12-23 Thread Dave Chinner
On Tue, Dec 23, 2014 at 03:07:32PM +0800, Qu Wenruo wrote: Original Message Subject: Re: [PATCH] btrfs: add regression test for remount with thread_pool resized From: gux.fnst gux.f...@cn.fujitsu.com To: fste...@vger.kernel.org Date: 2014年09月17日 18:02 Hi, Could

Re: [PATCH v2] btrfs: add regression test for remount with thread_pool resized

2014-12-23 Thread Dave Chinner
On Tue, Dec 23, 2014 at 03:23:10PM +0800, Eryu Guan wrote: On Tue, Dec 23, 2014 at 01:41:02PM +0800, Xing Gu wrote: Regression test for a btrfs issue of resizing 'thread_pool' when remount the fs. Signed-off-by: Xing Gu gux.f...@cn.fujitsu.com --- tests/btrfs/017 | 64

Re: Uncorrectable errors on RAID-1?

2014-12-23 Thread Zygo Blaxell
On Sun, Dec 21, 2014 at 05:25:47PM -0700, Chris Murphy wrote: For the kernel to automatically fix bad sectors by overwriting them, the drive needs to explicitly report read errors. If the SCSI command timer value is shorter than the drive's error recovery, the SATA link might get reset before

Re: btrfs is using 25% more disk than it should

2014-12-23 Thread Zygo Blaxell
On Sat, Dec 20, 2014 at 06:28:22AM -0500, Josef Bacik wrote: We now have two extents with the same bytenr but with different lengths. [...] Then there is the problem of actually returning the free space. Now if we drop all of the refs for an extent we know the space is free and we return

Re: Uncorrectable errors on RAID-1?

2014-12-23 Thread Chris Murphy
On Tue, Dec 23, 2014 at 2:16 PM, Zygo Blaxell zblax...@furryterror.org wrote: On Sun, Dec 21, 2014 at 05:25:47PM -0700, Chris Murphy wrote: For the kernel to automatically fix bad sectors by overwriting them, the drive needs to explicitly report read errors. If the SCSI command timer value is

Re: Uncorrectable errors on RAID-1?

2014-12-23 Thread Chris Murphy
The other thing to note, is that the scsi command timer timeout is a maximum. So at 30 seconds if a command to the drive hasn't completed, then consider the drive hung up and do a link reset. And whatever error recovery is in the drive, is also a maximum. If the sector is really immediately bad,

Re: [PATCH 1/2] btrfs-progs: Add support for btrfs-image + corrupt script fsck test case.

2014-12-23 Thread Dave Chinner
[ Sorry to take some time to get to this, it got caught by a spam filter and I only just noticed. ] On Tue, Dec 16, 2014 at 02:08:53PM +, Filipe David Manana wrote: On Tue, Dec 16, 2014 at 1:35 AM, Qu Wenruo quwen...@cn.fujitsu.com wrote: Original Message Subject:

Re: How btrfs-find-root knows that the block is actually a root?

2014-12-23 Thread Qu Wenruo
Original Message Subject: Re: How btrfs-find-root knows that the block is actually a root? From: Alex Lyakas alex.bt...@zadarastorage.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年12月23日 18:08 Hi Qu, On Tue, Dec 23, 2014 at 7:27 AM, Qu Wenruo quwen...@cn.fujitsu.com

Debian/Jessie 3.16.7-ckt2-1 kernel error

2014-12-23 Thread Russell Coker
I've attached the kernel message log that I get after booting kernel 3.16.7 from Debian/Unstable. This is the kernel branch that will go into Debian/Jessie so it's important to get it fixed. Below has the start of the errors, the attached file has everything from boot. I've got similar

Re: [PATCH] btrfs-progs: rebuild missing block group during chunk recovery if possible

2014-12-23 Thread Qu Wenruo
Original Message Subject: Re: [PATCH] btrfs-progs: rebuild missing block group during chunk recovery if possible From: Alex Lyakas alex.bt...@zadarastorage.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年12月24日 00:49 Hi Qu, On Thu, Oct 30, 2014 at 4:54 AM, Qu Wenruo

Re: [PATCH] btrfs-progs: Fix btrfs fi show by uuid and label

2014-12-23 Thread Gui Hecheng
On Tue, 2014-12-23 at 11:34 -0800, Justin Maggard wrote: Commit 8be2fff (btrfs-progs: apply realpath for btrfs fi show when mount point is given) changed the behavior of btrfs fi show to return an error if the call to realpath() failed. This broke the ability to specify a filesystem by uuid

[PATCH v2 2/2] btrfs: Enhance btrfs chunk allocation algorithm to reduce ENOSPC caused by unbalanced data/metadata allocation.

2014-12-23 Thread Qu Wenruo
When btrfs allocate a chunk, it will try to alloc up to 1G for data and 256M for metadata, or 10% of all the writeable space if there is enough space for the stripe on device. However, when we run out of space, this allocation may cause unbalanced chunk allocation. For example, there are only 1G

[PATCH 1/2] btrfs: Make the chunk size limit on on-disk/logical more clean.

2014-12-23 Thread Qu Wenruo
Original __btrfs_alloc_chunk() use max_chunk_size to limit chunk size, however it mixed the on-disk space with logical space. When comes to 10% of writable space, max_chunk_size is used with on-disk size, but it is also used as logical space size limit, so it is very confusing and causing

Re: [PATCH 1/2] btrfs-progs: Add support for btrfs-image + corrupt script fsck test case.

2014-12-23 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 1/2] btrfs-progs: Add support for btrfs-image + corrupt script fsck test case. From: Dave Chinner da...@fromorbit.com To: Filipe David Manana fdman...@gmail.com Date: 2014年12月24日 08:03 [ Sorry to take some time to get to this, it got

Re: [PATCH][BTRFS-PROGS][CLEANUP] Remove gotos

2014-12-23 Thread Satoru Takeuchi
Hi Goffredo, On 2014/12/23 4:07, Goffredo Baroncelli wrote: On 12/22/2014 12:34 PM, Satoru Takeuchi wrote: On 2014/12/22 3:07, Goffredo Baroncelli wrote: Change a spagetti-style code (there are some interlaced gotos) to a more modern style... This patch removes also some #define from

Re: [PATCH 1/2] btrfs-progs: Add support for btrfs-image + corrupt script fsck test case.

2014-12-23 Thread Dave Chinner
On Wed, Dec 24, 2014 at 10:56:04AM +0800, Qu Wenruo wrote: Original Message Subject: Re: [PATCH 1/2] btrfs-progs: Add support for btrfs-image + corrupt script fsck test case. From: Dave Chinner da...@fromorbit.com To: Filipe David Manana fdman...@gmail.com Date:

Re: Quota limit question

2014-12-23 Thread Duncan
Christian Robottom Reis posted on Tue, 23 Dec 2014 18:36:02 -0200 as excerpted: On Tue, Dec 16, 2014 at 11:15:37PM -0200, Christian Robottom Reis wrote: # btrfs qgroup limit 2000m 0/261 . touch x touch: cannot touch ‘x’: Disk quota exceeded The strange thing is that it doesn't seem

Re: [PATCH 1/2] Remove unnecessary placeholder in btrfs_err_code

2014-12-23 Thread Satoru Takeuchi
Hi Gui, On 2014/12/23 10:59, Gui Hecheng wrote: On Mon, 2014-12-22 at 19:39 +0900, Satoru Takeuchi wrote: Sorry, I forgot to add Signed-off-by line. --- From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com notused is not necessary. Set 1 to the first entry is enough. Hi Satoru, Actually,

[PATCH] Btrfs: Remove unnecessary placeholder in btrfs_err_code

2014-12-23 Thread Satoru Takeuchi
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com notused is not necessary. Set 1 to the first entry is enough. Signed-off-by: Takeuchi Satoru takeuchi_sat...@jp.fujitsu.com Cc: Gui Hecheng guihc.f...@cn.fujitsu.com --- I once submit the similar patch to btrfs-progs. Then Gui Hecheng tell me

[PATCH] Btrfs: call inode_dec_link_count() on mkdir error path

2014-12-23 Thread Wang Shilong
From: Wang Shilong wangshilong1...@gmail.com In btrfs_mkdir(), if it fails to create dir, we should clean up existed items, setting inode's link properly to make sure it could be cleaned up properly. Signed-off-by: Wang Shilong wangshilong1...@gmail.com --- fs/btrfs/inode.c | 4 +++- 1 file

[PATCH] btrfs-progs: doc: fix incorrect format of 'l' option in mkfs.btrfs

2014-12-23 Thread Tsutomu Itoh
The format of 'l' option in mkfs.btrfs.txt is wrong. And, when the head of the character string is 65536, the following warning is displayed. $ make Making all in Documentation [ASCII] mkfs.btrfs.xml asciidoc: WARNING: mkfs.btrfs.xml.tmp1: line 67: list item index: expected