btrfs_alloc_tree_block() returns an extent buffer on which a blocked lock has
been taken. Hence assign the appropriate value to path->locks[level].
Signed-off-by: Chandan Rajendra
---
fs/btrfs/ctree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs
在 2015年01月14日 23:48, David Sterba 写道:
On Fri, Jan 09, 2015 at 04:11:41PM +0800, Fan Chengniang wrote:
Before with -S option, setting positive value on seeding-enabled btrfs
filesystem will cause error. So I add -i option which can ignore it.
Why can't we use the existing --force/-f option for
On Wed, 2015-01-14 at 16:22 +0100, David Sterba wrote:
> On Wed, Jan 14, 2015 at 04:18:54PM +0800, Gui Hecheng wrote:
> > Move the branch that is unrelated to the result of io_ctl_init() before
> > the function call, so we can save a kmalloc() & kfree() pair in that
> > branch.
> >
> > Signed-off-
在 2015年01月14日 23:46, David Sterba 写道:
On Tue, Jan 13, 2015 at 01:53:39PM +0800, Fan Chengniang wrote:
make btrfs qgroups show human readable sizes
using --human-readable option, example:
That's too long to type and the idea was to add all the long options
that force the specific unit base, ie.
Original Message
Subject: Re: [PATCH v2 RESEND] btrfs-progs: make btrfs qgroups show
human readable sizes
From: David Sterba
To: Fan Chengniang
Date: 2015年01月14日 23:46
On Tue, Jan 13, 2015 at 01:53:39PM +0800, Fan Chengniang wrote:
make btrfs qgroups show human readable si
Original Message
Subject: Re: [PATCH 2/4] btrfs-progs: Enhance btrfs-find-root.
From: David Sterba
To: Qu Wenruo
Date: 2015年01月15日 01:58
On Wed, Nov 12, 2014 at 01:52:12PM +0800, Qu Wenruo wrote:
Enhance btrfs-find-root in the following way:
1. Use existing or lightly modifi
Original Message
Subject: [PATCH 1/2] btrfs-progs: tests, add support for running
commands under root
From: David Sterba
To:
Date: 2015年01月15日 01:25
Most of the checks run fine without root, but some of them may need to
do a mount test or access the data. Add the support to
On Wed, Jan 14, 2015 at 3:44 PM, Marc MERLIN wrote:
> On Mon, Jan 12, 2015 at 05:02:00PM +0100, Patrik Lundquist wrote:
>> Hi,
>>
>> I've been looking at recommended cryptsetup options for Btrfs and I
>> have one question:
>>
>> Marc uses "cryptsetup luksFormat --align-payload=1024" directly on a
Currently this test fails on 2 situations:
1) The scratch device supports trim/discard. In this case any modern
version of mkfs.btrfs outputs a message (to stderr) informing that
a trim is performed, which the golden output doesn't expect:
btrfs/017 - output mismatch (see
/git/xfste
On Mon, Jan 12, 2015 at 05:02:00PM +0100, Patrik Lundquist wrote:
> Hi,
>
> I've been looking at recommended cryptsetup options for Btrfs and I
> have one question:
>
> Marc uses "cryptsetup luksFormat --align-payload=1024" directly on a
> disk partition and not on e.g. a striped mdraid. Is there
On Wed, Jan 14, 2015 at 04:06:02PM -0500, Sandy McArthur Jr wrote:
> Sometimes btrfs scrub status reports that is not running when it still is.
>
> I think this a cosmetic bug. And I believe this is related to the
> scrub completing on some drives before others in a multi-drive btrfs
> filesystem
Okay, different output when the scrub is actually complete:
completed status:
scrub status for 94b3345e-2589-423c-a228-d569bf94ab58
scrub started at Tue Jan 13 01:18:22 2015 and finished after 139459 seconds
total bytes scrubbed: 23.30TiB with 513 errors
error details: verify=19 csum=494
correcte
Am Wed, 14 Jan 2015 16:06:02 -0500
schrieb Sandy McArthur Jr :
> Sometimes btrfs scrub status reports that is not running when it still is.
[...]
FWIW, I (and one other person) reported this in the thread titled 'btrfs scrub
status misreports as "interrupted"' (starting on 22.11.2014).
> # uname
Sometimes btrfs scrub status reports that is not running when it still is.
I think this a cosmetic bug. And I believe this is related to the
scrub completing on some drives before others in a multi-drive btrfs
filesystem that is not well balanced.
Based on `iostat 1` activity the last drive in th
Currently there's a 4B hole in the structure between refs and state and there
are only 16 bits used so we can make it unsigned. This will get a better
packing and may save some stack space for local variables.
The size of extent_state gets reduced by 8B and there are usually a lot
of slab objects.
If the found_key is NULL, then btrfs_find_item becomes a verbose wrapper
for simple btrfs_search_slot.
After we've removed all such callers, passing a NULL key is not valid
anymore.
Signed-off-by: David Sterba
---
fs/btrfs/ctree.c | 3 ++-
fs/btrfs/disk-io.c | 8 ++--
fs/btrfs/inode.c
We can search and add the orphan item in one go,
btrfs_insert_orphan_item will find out if the item already exists.
Signed-off-by: David Sterba
---
fs/btrfs/tree-log.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
A simple wrapper around btrfs_find_item.
Signed-off-by: David Sterba
---
fs/btrfs/backref.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index 66554b3f7748..e715c16e9d07 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btr
If btrfs_find_item is called with NULL path it allocates one locally but
does not free it. Affected paths are inserting an orphan item for a file
and for a subvol root.
Move the path allocation to the callers.
CC: # 3.14+
Fixes: 3f870c289900 ("btrfs: expand btrfs_find_item() to include
find_orp
It's only a simple wrapper around btrfs_find_item, the locally defined
key is not used.
Signed-off-by: David Sterba
---
fs/btrfs/backref.c | 11 ---
fs/btrfs/backref.h | 3 ---
fs/btrfs/scrub.c | 6 +-
3 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/fs/btrfs/backr
Coverity for btrfs-progs spotted a variable leak in btrfs_find_item though the
same error is not reported in the kernel project and the code is the same. The
leak is very rare though and does not need to go to stable immediatelly. The
rest of patches are cleanups in the related codepaths.
You can
On Wed, 14 Jan 2015 16:46:33 +0100
David Sterba wrote:
> On Tue, Jan 13, 2015 at 01:53:39PM +0800, Fan Chengniang wrote:
> > make btrfs qgroups show human readable sizes
> > using --human-readable option, example:
>
> That's too long to type and the idea was to add all the long options
> that fo
On Wed, Nov 12, 2014 at 01:52:12PM +0800, Qu Wenruo wrote:
> Enhance btrfs-find-root in the following way:
> 1. Use existing or lightly modified btrfs infrastructure
>Don't use btrfs-find-root local defined open_ctree or csum check.
>Slightly modify open_ctree() and csum_tree_block() to pro
On Thu, Dec 25, 2014 at 09:32:10AM +0800, Qu Wenruo wrote:
> This patchset introduce the new btrfsck test framework.
Thanks, merged to the 3.18.x branch, with the two patches and one
cosmetic adjustment to the output. The file layout seems flexible enough
to do what we may need in the future.
--
T
Most of the checks run fine without root, but some of them may need to
do a mount test or access the data. Add the support to selectively run
commands under root, hardcoded to sudo for now.
Signed-off-by: David Sterba
---
tests/common | 15 +++
1 file changed, 15 insertions(+)
diff
We need it to mount/umount, to traverse lost+found and stat the results.
Signed-off-by: David Sterba
---
tests/fsck-tests/012-leaf-corruption/test.sh | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/tests/fsck-tests/012-leaf-corruption/test.sh
b/tests/fsck-te
On Fri, Jan 09, 2015 at 04:11:41PM +0800, Fan Chengniang wrote:
> Before with -S option, setting positive value on seeding-enabled btrfs
> filesystem will cause error. So I add -i option which can ignore it.
Why can't we use the existing --force/-f option for that?
--
To unsubscribe from this list
On Tue, Jan 13, 2015 at 01:53:39PM +0800, Fan Chengniang wrote:
> make btrfs qgroups show human readable sizes
> using --human-readable option, example:
That's too long to type and the idea was to add all the long options
that force the specific unit base, ie. --kbytes/--mbytes/..., --raw,
--si an
On Wed, Jan 14, 2015 at 04:18:54PM +0800, Gui Hecheng wrote:
> Move the branch that is unrelated to the result of io_ctl_init() before
> the function call, so we can save a kmalloc() & kfree() pair in that
> branch.
>
> Signed-off-by: Gui Hecheng
> ---
> fs/btrfs/free-space-cache.c | 17
Hi David, Josef,
Please find attached a patch that restores backtrace functionality when
using glibc. Note that "#include " is included in this
patch, but this is not necessary. That is, on glibc systems, stdlib.h
and other headers also include this header (And only on glibc systems we
care about
Move the branch that is unrelated to the result of io_ctl_init() before
the function call, so we can save a kmalloc() & kfree() pair in that
branch.
Signed-off-by: Gui Hecheng
---
fs/btrfs/free-space-cache.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/fs
31 matches
Mail list logo
