On Thu, Mar 17, 2016 at 03:56:38PM -0700, Liu Bo wrote:
> This is to test if COW enabled btrfs can end up with single 4k extents
> when doing subpagesize buffered writes.
What happens if btrfs is mounted with "nodatacow" option? Does it need
to _notrun if cow is disabled?
>
> The patch to fix th
On Mon, Mar 21, 2016 at 07:23:38PM +, fdman...@kernel.org wrote:
> From: Filipe Manana
>
> While writing a test case for overlayfs I noticed that _check_dmesg()
> did not detect general protection fault traces like the following:
>
> [15277.026108] run fstests overlay/002 at 2016-03-21 18:42
On Mon, Mar 21, 2016 at 05:50:25PM +, fdman...@kernel.org wrote:
> From: Filipe Manana
>
> Test that calling fsync against a file using the merged directory does
> not result in a crash nor fails unexpectedly.
>
> This is motivated by a change in overlayfs that resulted in a crash
> (invalid
Hi Wang,
[auto build test ERROR on btrfs/next]
[also build test ERROR on next-20160321]
[cannot apply to v4.5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Qu-Wenruo/Btrfs-Add-inband-write
On Mon, Mar 21, 2016 at 7:24 PM, Chris Mason wrote:
>
> Hmmm, rereading my answer I realized I didn't actually answer. I really
> think this is fixed. I left the warning only because I originally
> expected something much more exotic.
Ok. It's more that you said the top commit fixes a problem,
Hi Wang,
[auto build test ERROR on btrfs/next]
[also build test ERROR on next-20160321]
[cannot apply to v4.5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Qu-Wenruo/Btrfs-Add-inband-write
On Mon, Mar 21, 2016 at 10:15:33PM -0400, Chris Mason wrote:
> On Mon, Mar 21, 2016 at 06:16:54PM -0700, Linus Torvalds wrote:
> > On Mon, Mar 21, 2016 at 5:24 PM, Chris Mason wrote:
> > >
> > > I waited an extra day to send this one out because I hit a crash late
> > > last week with CONFIG_DEBUG
On Mon, Mar 21, 2016 at 06:16:54PM -0700, Linus Torvalds wrote:
> On Mon, Mar 21, 2016 at 5:24 PM, Chris Mason wrote:
> >
> > I waited an extra day to send this one out because I hit a crash late
> > last week with CONFIG_DEBUG_PAGEALLOC enabled (fixed in the top commit).
>
> Hmm. If that commit
Core implement for inband de-duplication.
It reuse the async_cow_start() facility to do the calculate dedupe hash.
And use dedupe hash to do inband de-duplication at extent level.
The work flow is as below:
1) Run delalloc range for an inode
2) Calculate hash for the delalloc range at the unit of
Now on-disk backend can delete hash now.
Signed-off-by: Wang Xiaoguang
Signed-off-by: Qu Wenruo
---
fs/btrfs/dedupe.c | 100 ++
1 file changed, 100 insertions(+)
diff --git a/fs/btrfs/dedupe.c b/fs/btrfs/dedupe.c
index f73a4c7..c38137e 100644
This patchset can be fetched from github:
https://github.com/adam900710/linux.git wang_dedupe_20160322
This updated version of inband de-duplication has the following features:
1) ONE unified dedup framework.
Most of its code is hidden quietly in dedup.c and export the minimal
interfaces fo
From: Wang Xiaoguang
The basic idea is also calculate hash before compression, and add needed
members for dedupe to record compressed file extent.
Since dedupe support dedupe_bs larger than 128K, which is the up limit
of compression file extent, in that case we will skip dedupe and prefer
compre
Now on-disk backend should be able to search hash now.
Signed-off-by: Wang Xiaoguang
Signed-off-by: Qu Wenruo
---
fs/btrfs/dedupe.c | 133 +++---
fs/btrfs/dedupe.h | 1 +
2 files changed, 118 insertions(+), 16 deletions(-)
diff --git a/fs/btrfs
Now on-disk backend can add hash now.
Signed-off-by: Wang Xiaoguang
Signed-off-by: Qu Wenruo
---
fs/btrfs/dedupe.c | 83 +++
1 file changed, 83 insertions(+)
diff --git a/fs/btrfs/dedupe.c b/fs/btrfs/dedupe.c
index c38137e..6a80afc 100644
---
From: Wang Xiaoguang
Introduce BTRFS_INODE_NODEDUP flag, then we can explicitly disable
online data dedupelication for specified files.
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/ctree.h | 1 +
fs/btrfs/ioctl.c | 6 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/
Introduce a new tree, dedupe tree to record on-disk dedupe hash.
As a persist hash storage instead of in-memeory only implement.
Unlike Liu Bo's implement, in this version we won't do hack for
bytenr -> hash search, but add a new type, DEDUP_BYTENR_ITEM for such
search case, just like in-memory ba
A missing branch in btrfs_get_fs_root() is making dedupe_root read from
disk, and REF_COWS bit set.
This makes btrfs balance treating dedupe_root as fs root, and reusing the
old dedupe root bytenr to drop tree ref, causing the following kernel
warning after metadata balancing:
BTRFS error (device
Since the introduce of btrfs dedupe tree, it's possible that balance can
race with dedupe disabling.
When this happens, dedupe_enabled will make btrfs_get_fs_root() return
PTR_ERR(-ENOENT).
But due to a bug in error handling branch, when this happens
backref_cache->nr_nodes is increased but the no
We allocate a dedupe hash into async_extent, but forget to free it.
Fix it by freeing the hash before freeing async_extent.
Reported-by: Wang Xiaoguang
Signed-off-by: Qu Wenruo
---
fs/btrfs/inode.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index
From: Wang Xiaoguang
Add ioctl interface for inband dedupelication, which includes:
1) enable
2) disable
3) status
We will later add ioctl to disable inband dedupe for given file/dir.
Signed-off-by: Qu Wenruo
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/dedupe.c | 48 +
Since we will introduce a new on-disk based dedupe method, introduce new
interfaces to resume previous dedupe setup.
And since we introduce a new tree for status, also add disable handler
for it.
Signed-off-by: Wang Xiaoguang
Signed-off-by: Qu Wenruo
---
fs/btrfs/dedupe.c | 269 ++
From: Wang Xiaoguang
Add ordered-extent support for dedupe.
Note, current ordered-extent support only supports non-compressed source
extent.
Support for compressed source extent will be added later.
Signed-off-by: Qu Wenruo
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/ordered-data.c | 44 +
From: Wang Xiaoguang
When running inband dedupe with balance, it's possible that inband dedupe
still increase ref on extents which are in RO chunk.
This may cause either find_data_references() gives warning, or make
run_delayed_refs() return -EIO and cause trans abort.
The cause is, normal dedu
From: Wang Xiaoguang
Introduce static function inmem_search() to handle the job for in-memory
hash tree.
The trick is, we must ensure the delayed ref head is not being run at
the time we search the for the hash.
With inmem_search(), we can implement the btrfs_dedupe_search()
interface.
Signed-
From: Wang Xiaoguang
Add generic function to initialize dedupe info.
Signed-off-by: Qu Wenruo
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/Makefile | 2 +-
fs/btrfs/dedupe.c | 97 +++
fs/btrfs/dedupe.h | 16 +++--
3 files changed, 112 ins
For dedupe to work with compression, new members recording compression
algorithm and on-disk extent length are needed.
Add them for later compress-dedupe co-work.
Signed-off-by: Qu Wenruo
---
fs/btrfs/ctree.h| 11 -
fs/btrfs/dedupe.c | 64 ++
From: Wang Xiaoguang
Introduce static function inmem_del() to remove hash from in-memory
dedupe tree.
And implement btrfs_dedupe_del() and btrfs_dedup_destroy() interfaces.
Signed-off-by: Qu Wenruo
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/dedupe.c | 105 +
Dedupe has a bug that underflow block_group_cache->delalloc_bytes, makes
it unable to return to 0.
This will cause free space cache for that block group never written to
disk.
And cause the following kernel message at umount:
BTRFS info (device vdc): The free space cache file (1485570048) is
inval
From: Wang Xiaoguang
Unlike in-memory or on-disk dedupe method, only SHA256 hash method is
supported yet, so implement btrfs_dedupe_calc_hash() interface using
SHA256.
Signed-off-by: Qu Wenruo
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/dedupe.c | 49 +++
From: Wang Xiaoguang
Introduce the header for btrfs online(write time) de-duplication
framework and needed header.
The new de-duplication framework is going to support 2 different dedupe
methods and 1 dedupe hash.
Signed-off-by: Qu Wenruo
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/ctree.h
From: Wang Xiaoguang
Introduce inode_need_dedupe() to implement per-file online dedupe control.
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/inode.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 13ae366..979811c 1006
From: Wang Xiaoguang
Introduce static function inmem_add() to add hash into in-memory tree.
And now we can implement the btrfs_dedupe_add() interface.
Signed-off-by: Qu Wenruo
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/dedupe.c | 162 ++
1 f
For in-band dedupe, btrfs needs to increase data ref with delayed_ref
locked, so add a new function btrfs_add_delayed_data_ref_lock() to
increase extent ref with delayed_refs already locked.
Signed-off-by: Qu Wenruo
---
fs/btrfs/delayed-ref.c | 30 +++---
fs/btrfs/delayed
From: Wang Xiaoguang
In btrfs_delalloc_reserve_metadata(), the number of metadata bytes we try
to reserve is calculated by the difference between outstanding_extents and
reserved_extents.
When reserve_metadata_bytes() fails to reserve desited metadata space,
it has already done some reclaim work
From: Wang Xiaoguang
We use btrfs extended attribute "btrfs.dedupe" to record per-file online
dedupe status, so add a dedupe property handler.
Signed-off-by: Wang Xiaoguang
---
fs/btrfs/props.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/fs/bt
From: Wang Xiaoguang
Before this patch, even for duplicated extent, it will still go through
page write, meaning we didn't skip IO for them.
Although such write will be skipped by block level, as block level will
only select the last submitted write request to the same bytenr.
This patch will m
On Mon, Mar 21, 2016 at 5:24 PM, Chris Mason wrote:
>
> I waited an extra day to send this one out because I hit a crash late
> last week with CONFIG_DEBUG_PAGEALLOC enabled (fixed in the top commit).
Hmm. If that commit helps, it will spit out a warning.
So is it actually fixed, or just hacked
Hi Linus,
I waited an extra day to send this one out because I hit a crash late
last week with CONFIG_DEBUG_PAGEALLOC enabled (fixed in the top commit).
Please pull my my for-linus-4.6 branch:
git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git
for-linus-4.6
We have a good siz
Hi Dan,
On Fri, Mar 18, 2016 at 08:37:13AM +0300, Dan Carpenter wrote:
> Hello Liu Bo,
>
> The patch 64c043de466d: "Btrfs: fix up read_tree_block to return
> proper error" from May 25, 2015, leads to the following static
> checker warning:
>
> fs/btrfs/relocation.c:1858 replace_path()
>
On Mon, Mar 21, 2016 at 1:49 PM, David Sterba wrote:
>
> On Thu, Jan 28, 2016 at 10:52:28AM -0500, Dan Fuhry wrote:
> > Add support for the RENAME_WHITEOUT and RENAME_EXCHANGE flags in
> > renameat2(). This brings us pretty close to having btrfs ready to be
> > an upper layer for overlayfs. (The l
Dan Carpenter's static checker has found this error, it's introduced by
commit 64c043de466d
("Btrfs: fix up read_tree_block to return proper error")
It's really supposed to 'break' the loop on error like others.
Cc: Dan Carpenter
Reported-by: Dan Carpenter
Signed-off-by: Liu Bo
---
fs/btrfs/
Hi,
On Fri, Mar 18, 2016 at 05:44:03PM +0500, Roman Mamedov wrote:
> On Thu, 17 Mar 2016 15:16:15 -0700
> Liu Bo wrote:
>
> > For nocow/prealloc files, we try our best to not allocate space, however,
> > this ends up a huge performance regression since it's expensive to check
> > if data is shar
FOR YOUR INFORMATION DEAR BENEFICIARY,
Your Over-due ATM Card payment of $1.5MUSD by the UN Office have
deposited to the ATM MASTER CARD OFFICE. All you have to do now is to
contact the Office Manager Dr. peter Akupa Boni at:
(peterakupa...@gmail.com) and Phone number: +229 61 31 07 78 , he
will
Hi,
a few low-risk patches that appeared after I sent my main pull for 4.6. I think
they still apply to 4.6, the freezer patches help the livepatch to clean up the
mis-use of the freezer API, the rest makes sure we don't miss an error during
writing checksums.
I've removed Liu Bo's patch fixing t
On Thu, Mar 10, 2016 at 11:10 AM, Alex Lyakas wrote:
> csum_dirty_buffer was issuing a warning in case the extent buffer
> did not look alright, but was still returning success.
> Let's return error in this case, and also add an additional sanity
> check on the extent buffer header.
> The caller u
On Thu, Mar 10, 2016 at 11:09 AM, Alex Lyakas wrote:
> Signed-off-by: Alex Lyakas
Reviewed-by: Filipe Manana
> ---
> fs/btrfs/disk-io.c | 13 +
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 4545e2e..4420ab2 100644
On Mon, Mar 21, 2016 at 02:08:00PM -0400, Chris Mason wrote:
> On Mon, Mar 21, 2016 at 06:58:08PM +0100, David Sterba wrote:
> > On Mon, Mar 21, 2016 at 01:51:07PM -0400, Chris Mason wrote:
> > > On Mon, Mar 21, 2016 at 05:38:44PM +, fdman...@kernel.org wrote:
> > > > From: Filipe Manana
> > >
From: Filipe Manana
While writing a test case for overlayfs I noticed that _check_dmesg()
did not detect general protection fault traces like the following:
[15277.026108] run fstests overlay/002 at 2016-03-21 18:42:27
[15277.933179] general protection fault: [#11] PREEMPT SMP DEBUG_PAGEALL
On Mon, Mar 21, 2016 at 06:58:08PM +0100, David Sterba wrote:
> On Mon, Mar 21, 2016 at 01:51:07PM -0400, Chris Mason wrote:
> > On Mon, Mar 21, 2016 at 05:38:44PM +, fdman...@kernel.org wrote:
> > > From: Filipe Manana
> > >
> > > If the lower or upper directory of an overlayfs mount belong
On Mon, Mar 21, 2016 at 01:51:07PM -0400, Chris Mason wrote:
> On Mon, Mar 21, 2016 at 05:38:44PM +, fdman...@kernel.org wrote:
> > From: Filipe Manana
> >
> > If the lower or upper directory of an overlayfs mount belong to a btrfs
> > file system and we fsync the file through the overlayfs'
On 2016-03-21 13:40, David Sterba wrote:
On Mon, Mar 21, 2016 at 08:23:11AM -0400, Austin S. Hemmelgarn wrote:
Currently, btrfs fi du uses open_file_or_dir(), which tries to open
it's argument with o_RDWR. Because of POSIX semantics, this fails for
non-root users when the file is read-only or i
From: Filipe Manana
Test that calling fsync against a file using the merged directory does
not result in a crash nor fails unexpectedly.
This is motivated by a change in overlayfs that resulted in a crash
(invalid memory access) when the lower or upper directory belonged to
a btrfs file system.
On Mon, Mar 21, 2016 at 5:51 PM, Chris Mason wrote:
> On Mon, Mar 21, 2016 at 05:38:44PM +, fdman...@kernel.org wrote:
>> From: Filipe Manana
>>
>> If the lower or upper directory of an overlayfs mount belong to a btrfs
>> file system and we fsync the file through the overlayfs' merged direct
On 2016-03-21 13:29, Tycho Andersen wrote:
On Mon, Mar 21, 2016 at 11:22:06AM -0600, Chris Murphy wrote:
On Mon, Mar 21, 2016 at 9:21 AM, Tycho Andersen
wrote:
Hi all,
I'm seeing some strange behavior when bind mounting files from a btrfs
subvolume. Consider the output below:
root@criu2:/tmp
On Mon, Mar 21, 2016 at 05:38:44PM +, fdman...@kernel.org wrote:
> From: Filipe Manana
>
> If the lower or upper directory of an overlayfs mount belong to a btrfs
> file system and we fsync the file through the overlayfs' merged directory
> we ended up accessing an inode that didn't belong to
From: Filipe Manana
Test that calling fsync against a file using the merged directory does
not result in a crash nor fails unexpectedly.
This is motivated by a change in overlayfs that resulted in a crash
(invalid memory access) when the lower or upper directory belonged to
a btrfs file system.
On Thu, Jan 28, 2016 at 10:52:28AM -0500, Dan Fuhry wrote:
> Add support for the RENAME_WHITEOUT and RENAME_EXCHANGE flags in
> renameat2(). This brings us pretty close to having btrfs ready to be
> an upper layer for overlayfs. (The last remaining issue is in
> btrfs_sync_file, which I'm looking a
On Mon, Mar 21, 2016 at 08:23:11AM -0400, Austin S. Hemmelgarn wrote:
> Currently, btrfs fi du uses open_file_or_dir(), which tries to open
> it's argument with o_RDWR. Because of POSIX semantics, this fails for
> non-root users when the file is read-only or is an executable that
> is being run cu
From: Filipe Manana
If the lower or upper directory of an overlayfs mount belong to a btrfs
file system and we fsync the file through the overlayfs' merged directory
we ended up accessing an inode that didn't belong to btrfs as if it were
a btrfs inode at btrfs_sync_file() resulting in a crash li
On Fri, Mar 11, 2016 at 12:49:45PM +0100, Alexander Fougner wrote:
> Signed-off-by: Alexander Fougner
Both applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.or
On Mon, Mar 21, 2016 at 11:22:06AM -0600, Chris Murphy wrote:
> On Mon, Mar 21, 2016 at 9:21 AM, Tycho Andersen
> wrote:
> > Hi all,
> >
> > I'm seeing some strange behavior when bind mounting files from a btrfs
> > subvolume. Consider the output below:
> >
> > root@criu2:/tmp# mount -o loop /tmp/
On Mon, Mar 21, 2016 at 9:21 AM, Tycho Andersen
wrote:
> Hi all,
>
> I'm seeing some strange behavior when bind mounting files from a btrfs
> subvolume. Consider the output below:
>
> root@criu2:/tmp# mount -o loop /tmp/tester.btrfs /tmp/dir1
> root@criu2:/tmp# touch dir1/file
> root@criu2:/tmp# s
On Mon, Mar 21, 2016 at 5:22 AM, Austin S. Hemmelgarn
wrote:
> On 2016-03-21 05:55, Duncan wrote:
>>
>> Chris Murphy posted on Sun, 20 Mar 2016 21:43:52 -0600 as excerpted:
>>
>>> Hi folks,
>>>
>>> So I just ran into this:
>>> https://raid.wiki.kernel.org/index.php/
>>
>> Recovering_a_failed_softw
On Monday 21 Mar 2016 11:00:14 Chris Mason wrote:
> Hi everyone,
>
> I realized last week that CONFIG_DEBUG_PAGEALLOC had dropped out of my
> config, and hit a crash inside __btrfs_lookup_bio_sums once I enabled it
> again. It's hard for this bug to cause problems because Chandan's inner
> loop i
The following scenario can occur when running btrfs/066,
Task ATask B Task C
run_test()
- Execute _btrfs_stress_subvolume()
in a background shell.
_btrfs_stress_subvolme()
Hi all,
I'm seeing some strange behavior when bind mounting files from a btrfs
subvolume. Consider the output below:
root@criu2:/tmp# mount -o loop /tmp/tester.btrfs /tmp/dir1
root@criu2:/tmp# touch dir1/file
root@criu2:/tmp# sudo mount --bind dir1/file dir2/file
root@criu2:/tmp# grep "/tmp/dir"
Works for me, thanks.
Martin Volf
On Mon, Mar 21, 2016 at 1:23 PM, Austin S. Hemmelgarn
wrote:
> Currently, btrfs fi du uses open_file_or_dir(), which tries to open
> it's argument with o_RDWR. Because of POSIX semantics, this fails for
> non-root users when the file is read-only or is an execu
Hi everyone,
I realized last week that CONFIG_DEBUG_PAGEALLOC had dropped out of my
config, and hit a crash inside __btrfs_lookup_bio_sums once I enabled it
again. It's hard for this bug to cause problems because Chandan's inner
loop is always done at the same time the outer loop is done. Withou
commit b5e7979 "btrfs-progs: build: extend per-binary objects" allows
the standalone utilities to link against object files shared with the
main binary. However, the btrfs-*.static targets need to be adjusted
to build against the static versions of the common files.
Signed-off-by: Noah Massey
---
On Monday 21 Mar 2016 20:07:06 Eryu Guan wrote:
> > diff --git a/common/rc b/common/rc
> > index 16f5a43..7d971ea 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -3280,9 +3280,10 @@ _btrfs_stress_subvolume()
> >
> > local btrfs_mnt=$2
> > local subvol_name=$3
> > local subvol_mnt
On 2016-03-21 02:37, Martin Volf wrote:
Hello,
I have just tried the new "btrfs fi du" command from btrfs-progs 4.5
on 4.4.6 linux kernel, and it gave me:
# btrfs fi du /bin
Total Exclusive Set shared Filename
(many lines of output for individual files, probably OK)
...
ERROR: cannot
Currently, btrfs fi du uses open_file_or_dir(), which tries to open
it's argument with o_RDWR. Because of POSIX semantics, this fails for
non-root users when the file is read-only or is an executable that
is being run currently, or for all users (including root) when the
filesystem is read-only.
On Mon, Mar 21, 2016 at 01:09:52PM +0530, Chandan Rajendra wrote:
> The following scenario can occur when running btrfs/066,
>
> Task ATask B Task C
>
> run_test()
> - Execute _btrfs_stress_subvolume()
> in a background shell.
>
On 2016-03-21 05:55, Duncan wrote:
Chris Murphy posted on Sun, 20 Mar 2016 21:43:52 -0600 as excerpted:
Hi folks,
So I just ran into this:
https://raid.wiki.kernel.org/index.php/
Recovering_a_failed_software_RAID#Making_the_harddisks_read-
only_using_an_overlay_file
[That's a single link, wr
On 2016-03-21 02:37, Martin Volf wrote:
Hello,
I have just tried the new "btrfs fi du" command from btrfs-progs 4.5
on 4.4.6 linux kernel, and it gave me:
# btrfs fi du /bin
Total Exclusive Set shared Filename
(many lines of output for individual files, probably OK)
...
ERROR: cannot
Chris Murphy posted on Sun, 20 Mar 2016 21:43:52 -0600 as excerpted:
> Hi folks,
>
> So I just ran into this:
> https://raid.wiki.kernel.org/index.php/
Recovering_a_failed_software_RAID#Making_the_harddisks_read-
only_using_an_overlay_file
[That's a single link, wrapped by my client.]
> This i
Qu Wenruo posted on Mon, 21 Mar 2016 10:15:55 +0800 as excerpted:
> The point that I didn't want to keep the current behavior is, the old
> one is just OK or OOM, no one would know if it will OOM until it
> happens.
>
> But the new one would be much flex than current behavior.
> As it fully uses
Hi Flex,
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 366b335..5c16f04 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2325,7 +2325,10 @@ int btrfs_init_new_device(struct btrfs_root *root, char
*device_path)
if (seeding_dev) {
sb->s_flags &=
The following scenario can occur when running btrfs/066,
Task ATask B Task C
run_test()
- Execute _btrfs_stress_subvolume()
in a background shell.
_btrfs_stress_subvolme()
On 03/18/2016 09:31 PM, David Sterba wrote:
On Fri, Mar 18, 2016 at 04:54:24PM +0800, Anand Jain wrote:
On 03/17/2016 10:19 PM, David Sterba wrote:
On Wed, Mar 16, 2016 at 10:14:33PM +0800, Anand Jain wrote:
Makes few subvol related functions usable outside of subvol
command set.
This is
btrfs failed to mount small fs on ppc64 host with error ENOSPC, even
creating such small fs succeeded, then generic/027 consumed all free
space on root fs not on SCRATCH_DEV and test harness cannot create tmp
files and continue other tests.
Though I think it's a btrfs bug, it's still worth prevent
get_subvol_info() is useful as we are adding more features around
subvolume. This function was inline with the function
cmd_subvol_show().
Signed-off-by: Anand Jain
---
cmds-subvolume.c | 80 ++--
utils.c | 73 +
Signed-off-by: Anand Jain
---
cmds-send.c | 11 ---
utils.c | 12
utils.h | 1 +
3 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/cmds-send.c b/cmds-send.c
index 3e34d75bb834..7605ed94cd64 100644
--- a/cmds-send.c
+++ b/cmds-send.c
@@ -335,17 +335,6 @
The function test_issubvolume() provides the same check, and
has better logic.
Signed-off-by: Anand Jain
---
utils.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/utils.c b/utils.c
index 046ddf8eef19..110a4badb764 100644
--- a/utils.c
+++ b/utils.c
@@
We need subvolume helper functions easily accessible for features
around subvolume. This patch set is just a cleanup of subvolume
functions.
This is tested fine with fstests group subvol and subvol hand tests.
v3: Separate changes into 6 commits,
Drops the idea of creating subvolume.c, instea
Signed-off-by: Anand Jain
---
cmds-send.c | 4 ++--
utils.c | 4 ++--
utils.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cmds-send.c b/cmds-send.c
index 7605ed94cd64..339475927837 100644
--- a/cmds-send.c
+++ b/cmds-send.c
@@ -455,7 +455,7 @@ int cmd_send(int a
Signed-off-by: Anand Jain
---
utils.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/utils.c b/utils.c
index c0c564e2f69b..fb549ee923c7 100644
--- a/utils.c
+++ b/utils.c
@@ -2784,17 +2784,6 @@ int test_minimum_size(const char *file, u32 nodesize)
Signed-off-by: Anand Jain
---
cmds-subvolume.c | 27 ---
utils.c | 27 +++
utils.h | 1 +
3 files changed, 28 insertions(+), 27 deletions(-)
diff --git a/cmds-subvolume.c b/cmds-subvolume.c
index 3953d7c060a2..f62ab9584ce7 100644
88 matches
Mail list logo
