Re: [PATCH] btrfs-progs: add verbose option to btrfs device scan

2019-07-15 Thread Nikolay Borisov
On 16.07.19 г. 4:26 ч., Qu Wenruo wrote: > > > On 2019/7/15 下午11:09, Nikolay Borisov wrote: >> >> >> On 15.07.19 г. 17:42 ч., Anand Jain wrote: >>> To help debug device scan issues, add verbose option to btrfs device scan. >>> >>> Signed-off-by: Anand Jain >> >> I fail to see what this patch

Re: Best Practices (or stuff to avoid) with Raid5/6 ?

2019-07-15 Thread Chris Murphy
On Mon, Jul 15, 2019 at 8:09 PM Qu Wenruo wrote: > > > > On 2019/7/15 下午11:02, Robert Krig wrote: > > That being said, are there any recommended best practices when > > deploying btrfs with raid5? > > If there is any possibility of powerloss, kernel panic, or even unstable > cable connection, the

[PATCH v2] btrfs-progs: add verbose option to btrfs device scan

2019-07-15 Thread Anand Jain
To help debug device scan issues, add verbose option to btrfs device scan. Signed-off-by: Anand Jain --- v2: Use bool instead of int as a btrfs_scan_device() argument. cmds/device.c| 8 ++-- cmds/filesystem.c| 2 +- common/device-scan.c | 4 +++- common/device-scan.h | 3 ++- co

Re: [PATCH] btrfs-progs: add verbose option to btrfs device scan

2019-07-15 Thread Anand Jain
> On 16 Jul 2019, at 9:26 AM, Qu Wenruo wrote: > > > > On 2019/7/15 下午11:09, Nikolay Borisov wrote: >> >> >> On 15.07.19 г. 17:42 ч., Anand Jain wrote: >>> To help debug device scan issues, add verbose option to btrfs device scan. >>> >>> Signed-off-by: Anand Jain >> >> I fail to see wh

Re: Best Practices (or stuff to avoid) with Raid5/6 ?

2019-07-15 Thread Qu Wenruo
On 2019/7/15 下午11:02, Robert Krig wrote: > Hi guys. > I was wondering, are there any recommended best practices when using > Raid5/6 on BTRFS? > > I intend to build a 4 Disk BTRFS Raid5 array, but that's just going to > be as a backup for my main ZFS Server. So the data on it is not > important

Re: [PATCH] btrfs-progs: add verbose option to btrfs device scan

2019-07-15 Thread Qu Wenruo
On 2019/7/15 下午11:09, Nikolay Borisov wrote: > > > On 15.07.19 г. 17:42 ч., Anand Jain wrote: >> To help debug device scan issues, add verbose option to btrfs device scan. >> >> Signed-off-by: Anand Jain > > I fail to see what this patch helps for. We get the path in case of > errors, in case o

Re: [RFC] a standard user-friendly way to find a snapshot in nested subvolumes [was: find subvolume directories]

2019-07-15 Thread Ulli Horlacher
On Mon 2019-07-15 (19:58), Nicholas D Steeves wrote: > > I need a list of all subvolumes DIRECTORIES, to be accessible with > > standard UNIX commands like cd and ls or btrfs subvolume show > > > > "a list of all subvolumes DIRECTORIES" doesn't make sense... It > sounds like you want to list al

Re: [PATCH] btrfs-progs: add verbose option to btrfs device scan

2019-07-15 Thread Anand Jain
> On 15 Jul 2019, at 11:09 PM, Nikolay Borisov wrote: > > > > On 15.07.19 г. 17:42 ч., Anand Jain wrote: >> To help debug device scan issues, add verbose option to btrfs device scan. >> >> Signed-off-by: Anand Jain > > I fail to see what this patch helps for. > To know what are the devi

Re: [RFC] a standard user-friendly way to find a snapshot in nested subvolumes [was: find subvolume directories]

2019-07-15 Thread Nicholas D Steeves
Hi Ulli, On Tue, Jul 16, 2019 at 12:40:51AM +0200, Ulli Horlacher wrote: > On Mon 2019-07-15 (15:22), Piotr Szymaniak wrote: > > > > I want a list of all subvolumes directories (which I can access with UNIX > > > tools like cd and ls or btrfs subvolume ...). > > > > what about btrfs sub list [op

Re: find subvolume directories

2019-07-15 Thread Ulli Horlacher
On Mon 2019-07-15 (15:22), Piotr Szymaniak wrote: > > I want a list of all subvolumes directories (which I can access with UNIX > > tools like cd and ls or btrfs subvolume ...). > > what about btrfs sub list [options]? (see man btrfs-subvolume) > > You can make ie.: > root@ed:~# btrfs sub list -

Best Practices (or stuff to avoid) with Raid5/6 ?

2019-07-15 Thread Robert Krig
Hi guys. I was wondering, are there any recommended best practices when using Raid5/6 on BTRFS? I intend to build a 4 Disk BTRFS Raid5 array, but that's just going to be as a backup for my main ZFS Server. So the data on it is not important. I just want to see how RAID5 will behave over time. Th

Re: [PATCH] btrfs-progs: add verbose option to btrfs device scan

2019-07-15 Thread Nikolay Borisov
On 15.07.19 г. 17:42 ч., Anand Jain wrote: > To help debug device scan issues, add verbose option to btrfs device scan. > > Signed-off-by: Anand Jain I fail to see what this patch helps for. We get the path in case of errors, in case of success what good could the path be ? > --- > cmds/de

[PATCH] btrfs-progs: add verbose option to btrfs device scan

2019-07-15 Thread Anand Jain
To help debug device scan issues, add verbose option to btrfs device scan. Signed-off-by: Anand Jain --- cmds/device.c| 8 ++-- cmds/filesystem.c| 2 +- common/device-scan.c | 4 +++- common/device-scan.h | 2 +- common/utils.c | 2 +- disk-io.c| 2 +- 6 files c

Re: find subvolume directories

2019-07-15 Thread Piotr Szymaniak
On Sat, Jul 13, 2019 at 01:28:32PM +0200, Ulli Horlacher wrote: > On Sat 2019-07-13 (14:10), Andrei Borzenkov wrote: > > > >> It is entirely up to the user who creates it how subvolumes are named and > > >> structured. You can well have /foo, /bar, /baz mounted as /, /var and > > >> /home. > > >

Re: [PATCH] btrfs: don't leak extent_map in btrfs_get_io_geometry()

2019-07-15 Thread Nikolay Borisov
On 15.07.19 г. 16:16 ч., Johannes Thumshirn wrote: > btrfs_get_io_geometry() calls btrfs_get_chunk_map() to acquire a reference > on a extent_map, but on normal operation it does not drop this reference > anymore. > > This leads to excessive kmemleak reports. > > Always call free_extent_map(),

[PATCH] btrfs: don't leak extent_map in btrfs_get_io_geometry()

2019-07-15 Thread Johannes Thumshirn
btrfs_get_io_geometry() calls btrfs_get_chunk_map() to acquire a reference on a extent_map, but on normal operation it does not drop this reference anymore. This leads to excessive kmemleak reports. Always call free_extent_map(), not just in the error case. Fixes: 5f1411265e16 ("btrfs: Introduce

Re: find subvolume directories

2019-07-15 Thread Ulli Horlacher
On Sat 2019-07-13 (14:10), Andrei Borzenkov wrote: > I am not sure what problem you are trying to solve, but you can use list > of current mounts to build path to each subvolume (as long as it is > either below one of mounted subvolumes or explicitly mounted). I have tried it this way (many hours

Re: find subvolume directories

2019-07-15 Thread Ulli Horlacher
On Sat 2019-07-13 (01:17), Ulli Horlacher wrote: > I need to find (all) subvolume directories. > I know, btrfs subvolumes root directories have inode #256, but a > "find / -inum 256" is horrible slow! At least, I want to exclude non-btrfs filesystems to speed up the find run, but find cannot detec

Kindly Respond

2019-07-15 Thread Donald Douglas
Hello, I am Barr Fredrick Mbogo a business consultant i have a lucrative business to discuss with you from the Eastern part of Africa Uganda to be precise aimed at agreed percentage upon your acceptance of my hand in business and friendship. Kindly respond to me if you are interested to partner wit

[GIT PULL] Btrfs updates for 5.3

2019-07-15 Thread David Sterba
Hi, there's majority of cleanups and refactoring, no big new features made it to the final branch, the rest are fixes. No merge conflicts. Please pull, thanks. Hilights: - chunks that have been trimmed and unchanged since last mount are tracked and skipped on repeated trims - use hw assissed

Re: High write iops

2019-07-15 Thread Nikolay Borisov
On 15.07.19 г. 10:19 ч., Игорь Наумов wrote: > > Hello, > > using Ubuntu server 18.04.2 btrfs on / > > 10 absolutely identical servers (Dell M630), with the same configuration, > updated 2/10 and encountered this problem on both. > After upgrading kernel from version 4.15.0-36-generic # 39

High write iops

2019-07-15 Thread Игорь Наумов
Hello, using Ubuntu server 18.04.2 btrfs on / 10 absolutely identical servers (Dell M630), with the same configuration, updated 2/10 and encountered this problem on both. After upgrading kernel from version 4.15.0-36-generic # 39-Ubuntu SMP observing at the same software configuration an incr