Re: [PATCH] Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items

2014-10-28 Thread Petr Janecek
Hello, [...] > This patch seems to fix https://bugzilla.kernel.org/show_bug.cgi?id=64961 > for me: I've been testing it together with > [PATCH] Btrfs: fix invalid leaf slot access in btrfs_lookup_extent() > on top of 3.18-rc2 since yesterday, and so far no crashes during balance > or device remo

Re: [PATCH] Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items

2014-10-28 Thread Petr Janecek
Hello, >On Mon, 27 Oct 2014 13:44:22 +, Filipe David Manana wrote: >> On Mon, Oct 27, 2014 at 12:11 PM, Filipe David Manana >> wrote: >>> On Mon, Oct 27, 2014 at 11:08 AM, Miao Xie wrote: On Mon, 27 Oct 2014 09:19:52 +, Filipe Manana wrote: > We have a race that can lead us to m

Re: [PATCH] Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items

2014-10-27 Thread Miao Xie
On Mon, 27 Oct 2014 13:44:22 +, Filipe David Manana wrote: > On Mon, Oct 27, 2014 at 12:11 PM, Filipe David Manana > wrote: >> On Mon, Oct 27, 2014 at 11:08 AM, Miao Xie wrote: >>> On Mon, 27 Oct 2014 09:19:52 +, Filipe Manana wrote: We have a race that can lead us to miss skinny ext

Re: [PATCH] Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items

2014-10-27 Thread Filipe David Manana
On Mon, Oct 27, 2014 at 12:11 PM, Filipe David Manana wrote: > On Mon, Oct 27, 2014 at 11:08 AM, Miao Xie wrote: >> On Mon, 27 Oct 2014 09:19:52 +, Filipe Manana wrote: >>> We have a race that can lead us to miss skinny extent items in the function >>> btrfs_lookup_extent_info() when the skin

Re: [PATCH] Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items

2014-10-27 Thread Filipe David Manana
On Mon, Oct 27, 2014 at 11:08 AM, Miao Xie wrote: > On Mon, 27 Oct 2014 09:19:52 +, Filipe Manana wrote: >> We have a race that can lead us to miss skinny extent items in the function >> btrfs_lookup_extent_info() when the skinny metadata feature is enabled. >> So basically the sequence of ste

Re: [PATCH] Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items

2014-10-27 Thread Miao Xie
On Mon, 27 Oct 2014 09:19:52 +, Filipe Manana wrote: > We have a race that can lead us to miss skinny extent items in the function > btrfs_lookup_extent_info() when the skinny metadata feature is enabled. > So basically the sequence of steps is: > > 1) We search in the extent tree for the skin

[PATCH] Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items

2014-10-27 Thread Filipe Manana
We have a race that can lead us to miss skinny extent items in the function btrfs_lookup_extent_info() when the skinny metadata feature is enabled. So basically the sequence of steps is: 1) We search in the extent tree for the skinny extent, which returns > 0 (not found); 2) We check the previ