Re: [PATCH] btrfs: copy fsid to super_block s_uuid

2017-08-16 Thread David Sterba
On Tue, Aug 01, 2017 at 06:35:08PM +0800, Anand Jain wrote: > We didn't copy fsid to struct super_block.s_uuid so Overlay disables > index feature with btrfs as the lower FS. > > kernel: overlayfs: fs on '/lower' does not support file handles, falling back > to index=off. > > Fix this by

Re: [PATCH] btrfs: copy fsid to super_block s_uuid

2017-08-02 Thread Darrick J. Wong
On Wed, Aug 02, 2017 at 02:02:11PM +0800, Anand Jain wrote: > > Hi Darrick, > > Thanks for commenting.. > > >>+ memcpy(>s_uuid, fs_info->fsid, BTRFS_FSID_SIZE); > > > >uuid_copy()? > > It requires a larger migration to use uuid_t, IMO it can be done all > together, in a separate patch ?

Re: [PATCH] btrfs: copy fsid to super_block s_uuid

2017-08-01 Thread Anand Jain
Hi Darrick, Thanks for commenting.. + memcpy(>s_uuid, fs_info->fsid, BTRFS_FSID_SIZE); uuid_copy()? It requires a larger migration to use uuid_t, IMO it can be done all together, in a separate patch ? Just for experiment, starting with struct btrfs_fs_info.fsid and to

Re: [PATCH] btrfs: copy fsid to super_block s_uuid

2017-08-01 Thread Darrick J. Wong
On Tue, Aug 01, 2017 at 06:35:08PM +0800, Anand Jain wrote: > We didn't copy fsid to struct super_block.s_uuid so Overlay disables > index feature with btrfs as the lower FS. > > kernel: overlayfs: fs on '/lower' does not support file handles, falling back > to index=off. > > Fix this by

[PATCH] btrfs: copy fsid to super_block s_uuid

2017-08-01 Thread Anand Jain
We didn't copy fsid to struct super_block.s_uuid so Overlay disables index feature with btrfs as the lower FS. kernel: overlayfs: fs on '/lower' does not support file handles, falling back to index=off. Fix this by publishing the fsid through struct super_block.s_uuid. Signed-off-by: Anand