Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-23 Thread David Sterba
On Tue, Jul 22, 2014 at 09:05:32PM +0200, David Sterba wrote: On Thu, Jul 10, 2014 at 12:00:55PM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: What interfaces would be needed for this to work precisely so we don't have to play this game ever again?

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-23 Thread Josef Bacik
On 07/23/2014 08:30 AM, David Sterba wrote: On Tue, Jul 22, 2014 at 09:05:32PM +0200, David Sterba wrote: On Thu, Jul 10, 2014 at 12:00:55PM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: What interfaces would be needed for this to work precisely so we

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-22 Thread David Sterba
On Wed, Jul 09, 2014 at 03:41:50PM -0700, Mark Fasheh wrote: +$BTRFS_UTIL_PROG fi sy $SCRATCH_MNT +$BTRFS_UTIL_PROG su sna $SCRATCH_MNT $SCRATCH_MNT/snap1 +$BTRFS_UTIL_PROG qu en $SCRATCH_MNT +$BTRFS_UTIL_PROG su de $SCRATCH_MNT/snap1 Please spell the full names of the subcommands. -- To

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-22 Thread David Sterba
On Thu, Jul 10, 2014 at 12:00:55PM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote: On Wed, Jul 09, 2014 at 03:41:50PM -0700,

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-22 Thread David Sterba
On Thu, Jul 10, 2014 at 12:00:55PM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: What interfaces would be needed for this to work precisely so we don't have to play this game ever again? Well there's also the 'sleep 45' below because we need to be

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Mark Fasheh
Hey Dave, thanks for the patch review! Pretty much all of what you wrote sounds good to me, there's just one or two items I wanted to clarify - those comments are inline. Thanks again, On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote: On Wed, Jul 09, 2014 at 03:41:50PM -0700, Mark

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Zach Brown
On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote: On Wed, Jul 09, 2014 at 03:41:50PM -0700, Mark Fasheh wrote: + +# Enable qgroups now that we have our filesystem prepared. This +# will kick off a scan which we

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Mark Fasheh
On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote: On Wed, Jul 09, 2014 at 03:41:50PM -0700, Mark Fasheh wrote: + +# Enable qgroups now that we have our

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Zach Brown
On Thu, Jul 10, 2014 at 12:00:55PM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave Chinner wrote: On Wed, Jul 09, 2014 at 03:41:50PM -0700,

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Mark Fasheh
On Thu, Jul 10, 2014 at 12:05:05PM -0700, Zach Brown wrote: On Thu, Jul 10, 2014 at 12:00:55PM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 11:32:28AM -0700, Zach Brown wrote: On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Dave Chinner
On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: Hey Dave, thanks for the patch review! Pretty much all of what you wrote sounds good to me, there's just one or two items I wanted to clarify - those comments are inline. Thanks again, On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Duncan
Mark Fasheh posted on Thu, 10 Jul 2014 12:00:55 -0700 as excerpted: Given something like that, you'd just replace the calls to sleep with 'btrfs fi synctheworldandwait' and know that on return, the actions you just queued up completed. I'll admit to not really knowing what I'm talking about

[PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-09 Thread Mark Fasheh
Test btrfs quota group consistency operations during snapshot delete. Btrfs has had long standing issues with drop snapshot failing to properly account for quota groups. This test crafts a snapshot tree with shared and exclusive elements. The tree is removed and then quota group consistency is

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-09 Thread Dave Chinner
On Wed, Jul 09, 2014 at 03:41:50PM -0700, Mark Fasheh wrote: Test btrfs quota group consistency operations during snapshot delete. Btrfs has had long standing issues with drop snapshot failing to properly account for quota groups. This test crafts a snapshot tree with shared and exclusive