Re: [PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-26 Thread David Sterba
On Thu, Nov 26, 2015 at 08:38:23AM +0800, Qu Wenruo wrote: > > As far as the conversion support stays, it's not a problem of course. I > > don't have a complete picture of all the actual merging conflicts, but > > the idea is to provide the callback abstraction v2 to allow ext2 and > > reiser plus

Re: [PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-26 Thread Qu Wenruo
On 11/26/2015 05:30 PM, David Sterba wrote: On Thu, Nov 26, 2015 at 08:38:23AM +0800, Qu Wenruo wrote: As far as the conversion support stays, it's not a problem of course. I don't have a complete picture of all the actual merging conflicts, but the idea is to provide the callback abstraction

Re: [PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-26 Thread David Sterba
On Thu, Nov 26, 2015 at 06:12:57PM +0800, Qu Wenruo wrote: > But I'm a little concerned about the unstable headers, unlike ext2 its > headers is almost stable but reiserfs seems not. Well, reiserfs is not developped nowadays and I think Jeff implemented the bits required for btrfs-convert. The

Re: [PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-26 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 11/26/15 5:12 AM, Qu Wenruo wrote: > > > On 11/26/2015 05:30 PM, David Sterba wrote: >> On Thu, Nov 26, 2015 at 08:38:23AM +0800, Qu Wenruo wrote: As far as the conversion support stays, it's not a problem of course. I don't have a

Re: [PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-25 Thread Qu Wenruo
David Sterba wrote on 2015/11/25 13:42 +0100: On Tue, Nov 24, 2015 at 04:50:00PM +0800, Qu Wenruo wrote: It seems the conflict is quite huge, your reiserfs support is based on the old behavior, just like what old ext2 one do: custom extent allocation. I'm afraid the rebase will take a lot

Re: [PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-25 Thread David Sterba
On Tue, Nov 24, 2015 at 04:50:00PM +0800, Qu Wenruo wrote: > It seems the conflict is quite huge, your reiserfs support is based on > the old behavior, just like what old ext2 one do: custom extent allocation. > I'm afraid the rebase will take a lot of time since I'm completely a > newbie about

Re: [PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-24 Thread Qu Wenruo
David Sterba wrote on 2015/11/23 18:33 +0100: On Fri, Nov 20, 2015 at 11:24:04AM +0800, Qu Wenruo wrote: Here comes the 1st version of btrfs-convert rework. Any test is welcomed, and it can already pass the convert test from btrfs-progs. (Since the test doesn't test rollback function) I

Re: [PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-23 Thread Qu Wenruo
David Sterba wrote on 2015/11/23 18:33 +0100: On Fri, Nov 20, 2015 at 11:24:04AM +0800, Qu Wenruo wrote: Here comes the 1st version of btrfs-convert rework. Any test is welcomed, and it can already pass the convert test from btrfs-progs. (Since the test doesn't test rollback function) I

Re: [PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-23 Thread David Sterba
On Fri, Nov 20, 2015 at 11:24:04AM +0800, Qu Wenruo wrote: > Here comes the 1st version of btrfs-convert rework. > Any test is welcomed, and it can already pass the convert test from > btrfs-progs. (Since the test doesn't test rollback function) I went through the patches, looks mostly ok akin to

[PATCH 00/25] Btrfs-convert rework to support native separate

2015-11-19 Thread Qu Wenruo
Here comes the 1st version of btrfs-convert rework. Any test is welcomed, and it can already pass the convert test from btrfs-progs. (Since the test doesn't test rollback function) I also did some tests like create ext4 and fill it with fsstress to test convert, at least no bug spotted yet. The