Re: [PATCH 1/3] btrfs: iterate over unused chunk space in FITRIM

2015-06-05 Thread Holger Hoffstätte
On Fri, 05 Jun 2015 09:08:37 -0400, Jeff Mahoney wrote: >> which conflicts with Filipe's patch on Tuesday called "Btrfs: check >> pending chunks when shrinking fs to avoid corruption": >> >> +if (contains_pending_extent(trans, device, &start, len)) { >> >> since trans (returned from

Re: [PATCH 1/3] btrfs: iterate over unused chunk space in FITRIM

2015-06-05 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 6/4/15 7:15 AM, Holger Hoffstätte wrote: > On Wed, 03 Jun 2015 10:47:52 -0400, jeffm wrote: > >> This patch iterates over the unused chunk space and discards any >> regions that are unallocated, regardless of whether they were >> ever used. This i

Re: [PATCH 1/3] btrfs: iterate over unused chunk space in FITRIM

2015-06-04 Thread Holger Hoffstätte
On Wed, 03 Jun 2015 10:47:52 -0400, jeffm wrote: > This patch iterates over the unused chunk space and discards any regions > that are unallocated, regardless of whether they were ever used. This is > a change for btrfs but is consistent with other file systems. > .. [snip] This just gave me: f

[PATCH 1/3] btrfs: iterate over unused chunk space in FITRIM

2015-06-03 Thread jeffm
From: Jeff Mahoney Since we now clean up block groups automatically as they become empty, iterating over block groups is no longer sufficient to discard unused space. This patch iterates over the unused chunk space and discards any regions that are unallocated, regardless of whether they were ev