Re: [PATCH 2/2 V2] btrfs-progs: mark static & remove unused from non-kernel code

2013-08-09 Thread David Sterba
On Fri, Aug 09, 2013 at 06:16:30PM -0500, Eric Sandeen wrote: > Ok, fair enough - so preferred is > > function(some args . . , > . . . more args . . ., > . . . last args) Yeah something like that, bonus points if variable type and name

Re: [PATCH 2/2 V2] btrfs-progs: mark static & remove unused from non-kernel code

2013-08-09 Thread Eric Sandeen
On 8/9/13 5:48 PM, David Sterba wrote: > On Fri, Aug 09, 2013 at 03:20:47PM -0500, Eric Sandeen wrote: >> Mark many functions as static, and remove any resulting dead code. > > Thanks. > >> -struct btrfs_root *link_subvol(struct btrfs_root *root, const char *base, >> - u

Re: [PATCH 2/2 V2] btrfs-progs: mark static & remove unused from non-kernel code

2013-08-09 Thread David Sterba
On Fri, Aug 09, 2013 at 03:20:47PM -0500, Eric Sandeen wrote: > Mark many functions as static, and remove any resulting dead code. Thanks. > -struct btrfs_root *link_subvol(struct btrfs_root *root, const char *base, > -u64 root_objectid) > +static struct btrfs_root * >

[PATCH 2/2 V2] btrfs-progs: mark static & remove unused from non-kernel code

2013-08-09 Thread Eric Sandeen
Mark many functions as static, and remove any resulting dead code. Signed-off-by: Eric Sandeen --- V2: Keep the "special" subvol_uuid_search_add()-which-only-frees-pointers because I'm picking my battles :) btrfs-convert.c |8 btrfs-find-root.c |2 +- btrfs-list.c