Re: [PATCH 2/3] btrfs: update some code documentation

2017-11-21 Thread Nikolay Borisov
On 22.11.2017 00:20, Edmund Nadolski wrote: > > > On 11/21/2017 12:59 AM, Nikolay Borisov wrote: >> >> >> On 20.11.2017 22:24, Edmund Nadolski wrote: >>> Improve code documentation by adding/expanding comments in >>> several places. >>> >>> Signed-off-by: Edmund Nadolski

Re: [PATCH 2/3] btrfs: update some code documentation

2017-11-21 Thread Edmund Nadolski
On 11/21/2017 12:59 AM, Nikolay Borisov wrote: > > > On 20.11.2017 22:24, Edmund Nadolski wrote: >> Improve code documentation by adding/expanding comments in >> several places. >> >> Signed-off-by: Edmund Nadolski >> --- >> fs/btrfs/ctree.c| 31

Re: [PATCH 2/3] btrfs: update some code documentation

2017-11-21 Thread David Sterba
On Mon, Nov 20, 2017 at 01:24:48PM -0700, Edmund Nadolski wrote: > +/* > + * Reserve some special-case values for the extent_map .start, .block_start, > + *: and .orig_start fields. I'm used to write the structure members as type::member, which resembles the C++ syntax. There are already a few

Re: [PATCH 2/3] btrfs: update some code documentation

2017-11-21 Thread Nikolay Borisov
On 20.11.2017 22:24, Edmund Nadolski wrote: > Improve code documentation by adding/expanding comments in > several places. > > Signed-off-by: Edmund Nadolski > --- > fs/btrfs/ctree.c| 31 +++--- > fs/btrfs/ctree.h| 28

[PATCH 2/3] btrfs: update some code documentation

2017-11-20 Thread Edmund Nadolski
Improve code documentation by adding/expanding comments in several places. Signed-off-by: Edmund Nadolski --- fs/btrfs/ctree.c| 31 +++--- fs/btrfs/ctree.h| 28 +++- fs/btrfs/extent_map.h | 58