Re: [PATCH 2/5] btrfs: qgroup: account shared subtrees during snapshot delete

2014-08-12 Thread Mark Fasheh
On Tue, Aug 12, 2014 at 02:22:31PM -0400, Chris Mason wrote: On 07/17/2014 03:39 PM, Mark Fasheh wrote: During its tree walk, btrfs_drop_snapshot() will skip any shared subtrees it encounters. This is incorrect when we have qgroups turned on as those subtrees need to have their contents

Re: [PATCH 2/5] btrfs: qgroup: account shared subtrees during snapshot delete

2014-08-12 Thread Chris Mason
On 07/17/2014 03:39 PM, Mark Fasheh wrote: During its tree walk, btrfs_drop_snapshot() will skip any shared subtrees it encounters. This is incorrect when we have qgroups turned on as those subtrees need to have their contents accounted. In particular, the case we're concerned with is when

Re: [PATCH 2/5] btrfs: qgroup: account shared subtrees during snapshot delete

2014-08-12 Thread Mark Fasheh
On Tue, Aug 12, 2014 at 02:36:17PM -0400, Chris Mason wrote: On 08/12/2014 02:32 PM, Mark Fasheh wrote: On Tue, Aug 12, 2014 at 02:22:31PM -0400, Chris Mason wrote: On 07/17/2014 03:39 PM, Mark Fasheh wrote: During its tree walk, btrfs_drop_snapshot() will skip any shared subtrees

Re: [PATCH 2/5] btrfs: qgroup: account shared subtrees during snapshot delete

2014-08-12 Thread Chris Mason
On 08/12/2014 03:01 PM, Mark Fasheh wrote: On Tue, Aug 12, 2014 at 02:36:17PM -0400, Chris Mason wrote: On 08/12/2014 02:32 PM, Mark Fasheh wrote: On Tue, Aug 12, 2014 at 02:22:31PM -0400, Chris Mason wrote: On 07/17/2014 03:39 PM, Mark Fasheh wrote: During its tree walk,

[PATCH 2/5] btrfs: qgroup: account shared subtrees during snapshot delete

2014-07-17 Thread Mark Fasheh
During its tree walk, btrfs_drop_snapshot() will skip any shared subtrees it encounters. This is incorrect when we have qgroups turned on as those subtrees need to have their contents accounted. In particular, the case we're concerned with is when removing our snapshot root leaves the subtree with