Re: [PATCH 2/6] Btrfs: build up error handling for merge_reloc_roots

2013-03-28 Thread David Sterba
On Tue, Mar 19, 2013 at 08:16:41PM +0800, Liu Bo wrote: On Mon, Mar 18, 2013 at 03:16:12PM +0100, David Sterba wrote: I've noticed that return value from merge_reloc_roots is never checked in the callers. Did you verify that this is ok? Yeah, it's fine. Then it's ok to change return value

Re: [PATCH 2/6] Btrfs: build up error handling for merge_reloc_roots

2013-03-19 Thread Liu Bo
On Mon, Mar 18, 2013 at 03:16:12PM +0100, David Sterba wrote: On Tue, Mar 05, 2013 at 12:25:37AM +0800, Liu Bo wrote: We first use btrfs_std_error hook to replace with BUG_ON, and we also need to cleanup what is left, including reloc roots rbtree and reloc roots list. Here we use a helper

Re: [PATCH 2/6] Btrfs: build up error handling for merge_reloc_roots

2013-03-18 Thread David Sterba
On Tue, Mar 05, 2013 at 12:25:37AM +0800, Liu Bo wrote: We first use btrfs_std_error hook to replace with BUG_ON, and we also need to cleanup what is left, including reloc roots rbtree and reloc roots list. Here we use a helper function to cleanup both rbtree and list, and since this function

[PATCH 2/6] Btrfs: build up error handling for merge_reloc_roots

2013-03-04 Thread Liu Bo
We first use btrfs_std_error hook to replace with BUG_ON, and we also need to cleanup what is left, including reloc roots rbtree and reloc roots list. Here we use a helper function to cleanup both rbtree and list, and since this function can also be used in the balance recover path, we also make