Re: [PATCH 3/3] btrfs: document extent mapping assumptions in checksum

2018-11-28 Thread Johannes Thumshirn
On 27/11/2018 17:36, Nikolay Borisov wrote: > > > On 27.11.18 г. 18:00 ч., Johannes Thumshirn wrote: >> Document why map_private_extent_buffer() cannot return '1' (i.e. the map >> spans two pages) for the csum_tree_block() case. >> >> The current algorithm for detecting a page boundary crossing

Re: [PATCH 3/3] btrfs: document extent mapping assumptions in checksum

2018-11-27 Thread Noah Massey
On Tue, Nov 27, 2018 at 2:32 PM Nikolay Borisov wrote: > > On 27.11.18 г. 21:08 ч., Noah Massey wrote: > > On Tue, Nov 27, 2018 at 11:43 AM Nikolay Borisov wrote: > >> > >> On 27.11.18 г. 18:00 ч., Johannes Thumshirn wrote: > >>> Document why map_private_extent_buffer() cannot return '1' (i.e.

Re: [PATCH 3/3] btrfs: document extent mapping assumptions in checksum

2018-11-27 Thread Nikolay Borisov
On 27.11.18 г. 21:08 ч., Noah Massey wrote: > On Tue, Nov 27, 2018 at 11:43 AM Nikolay Borisov wrote: >> >> On 27.11.18 г. 18:00 ч., Johannes Thumshirn wrote: >>> Document why map_private_extent_buffer() cannot return '1' (i.e. the map >>> spans two pages) for the csum_tree_block() case. >>>

Re: [PATCH 3/3] btrfs: document extent mapping assumptions in checksum

2018-11-27 Thread Noah Massey
On Tue, Nov 27, 2018 at 11:43 AM Nikolay Borisov wrote: > > On 27.11.18 г. 18:00 ч., Johannes Thumshirn wrote: > > Document why map_private_extent_buffer() cannot return '1' (i.e. the map > > spans two pages) for the csum_tree_block() case. > > > > The current algorithm for detecting a page

Re: [PATCH 3/3] btrfs: document extent mapping assumptions in checksum

2018-11-27 Thread Nikolay Borisov
On 27.11.18 г. 18:00 ч., Johannes Thumshirn wrote: > Document why map_private_extent_buffer() cannot return '1' (i.e. the map > spans two pages) for the csum_tree_block() case. > > The current algorithm for detecting a page boundary crossing in > map_private_extent_buffer() will return a '1'

[PATCH 3/3] btrfs: document extent mapping assumptions in checksum

2018-11-27 Thread Johannes Thumshirn
Document why map_private_extent_buffer() cannot return '1' (i.e. the map spans two pages) for the csum_tree_block() case. The current algorithm for detecting a page boundary crossing in map_private_extent_buffer() will return a '1' *IFF* the product of the extent buffer's offset in the page + the