Re: [PATCH 3/3] fstests: btrfs: Add test case to check v1 space cache corruption

2018-03-06 Thread Filipe Manana
On Tue, Mar 6, 2018 at 12:07 PM, Qu Wenruo wrote: > > > On 2018年03月06日 18:12, Filipe Manana wrote: >> On Tue, Mar 6, 2018 at 8:15 AM, Qu Wenruo wrote: >>> There are some btrfs corruption report in mail list for a while, >> >> There have been for years

Re: [PATCH 3/3] fstests: btrfs: Add test case to check v1 space cache corruption

2018-03-06 Thread Filipe Manana
On Tue, Mar 6, 2018 at 10:53 AM, Qu Wenruo wrote: > > > On 2018年03月06日 18:12, Filipe Manana wrote: >> On Tue, Mar 6, 2018 at 8:15 AM, Qu Wenruo wrote: >>> There are some btrfs corruption report in mail list for a while, >> >> There have been for years

Re: [PATCH 3/3] fstests: btrfs: Add test case to check v1 space cache corruption

2018-03-06 Thread Qu Wenruo
On 2018年03月06日 18:12, Filipe Manana wrote: > On Tue, Mar 6, 2018 at 8:15 AM, Qu Wenruo wrote: >> There are some btrfs corruption report in mail list for a while, > > There have been for years (well, since ever) many reports of different > types of corruptions. > Which kind of

Re: [PATCH 3/3] fstests: btrfs: Add test case to check v1 space cache corruption

2018-03-06 Thread Nikolay Borisov
On 6.03.2018 12:53, Qu Wenruo wrote: > > [snip] > It breaks the rule that we shouldn't have the hole in file extents. > > IIRC Nikolay is trying to use inode_lock_shared() to solve this race. > Unfortunately the inode_lock_shared approach is a no go since Filipe objected to it quite

Re: [PATCH 3/3] fstests: btrfs: Add test case to check v1 space cache corruption

2018-03-06 Thread Qu Wenruo
On 2018年03月06日 18:12, Filipe Manana wrote: > On Tue, Mar 6, 2018 at 8:15 AM, Qu Wenruo wrote: >> There are some btrfs corruption report in mail list for a while, > > There have been for years (well, since ever) many reports of different > types of corruptions. > Which kind of

Re: [PATCH 3/3] fstests: btrfs: Add test case to check v1 space cache corruption

2018-03-06 Thread Filipe Manana
On Tue, Mar 6, 2018 at 8:15 AM, Qu Wenruo wrote: > There are some btrfs corruption report in mail list for a while, There have been for years (well, since ever) many reports of different types of corruptions. Which kind of corruption are you referring to? > although such

Re: [PATCH 3/3] fstests: btrfs: Add test case to check v1 space cache corruption

2018-03-06 Thread Qu Wenruo
On 2018年03月06日 17:03, Amir Goldstein wrote: > On Tue, Mar 6, 2018 at 10:15 AM, Qu Wenruo wrote: >> There are some btrfs corruption report in mail list for a while, >> although such corruption is pretty rare and almost impossible to >> reproduce, with dm-log-writes we found it's

Re: [PATCH 3/3] fstests: btrfs: Add test case to check v1 space cache corruption

2018-03-06 Thread Amir Goldstein
On Tue, Mar 6, 2018 at 10:15 AM, Qu Wenruo wrote: > There are some btrfs corruption report in mail list for a while, > although such corruption is pretty rare and almost impossible to > reproduce, with dm-log-writes we found it's highly related to v1 space > cache. > > Unlike

[PATCH 3/3] fstests: btrfs: Add test case to check v1 space cache corruption

2018-03-06 Thread Qu Wenruo
There are some btrfs corruption report in mail list for a while, although such corruption is pretty rare and almost impossible to reproduce, with dm-log-writes we found it's highly related to v1 space cache. Unlike journal based filesystems, btrfs completely rely on metadata CoW to protect itself